Bubble bar pointer arrow was being drawn outside of BubbleBarView
bounds.
This caused issues when alpha was applied to the BubbleBarView. With
alpha, BubbleBarView draw was clipped to its bounds and arrow was no
longer visible. This led to the arrow flickering during move animations.
Move animation updates alpha.
Move the pointer arrow inside the bounds of the bar view. Update the bar
height to include the arrow.
Update callers who rely on bubble bar content height to take into
account extra height for the arrow.
Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: move bubble bar left and right, observe arrow is visible
Change-Id: I05866b5c944361b2f10437c3641527ed3c594047
When it is not the initial bubble data, animate bubble bar location
change.
Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual, move expanded view from one side to the other, observe the
location change animates
Change-Id: I52117a31d02e7160ca1d3dc3e724bda2e38f6cbf
Adds bubble bar location to the update object that is sent by shell.
Allows repositioning the bubble bar if the location changes.
Bug: 313661121
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manually sending the update to reposition, dragging coming soon
Change-Id: Id430a98116d860a7badcf607edc166c751e12cf8
This change disables saving App Pair from recents
into launcher workspace when any of the app in pair
belongs to Private Space.
Private Space are still allowed in Split Mode
Bug: 322892793
Test: Manual on device
Flag: ACONFIG com.android.launcher3.private_space_restrict_accessibility_drag TRUNKFOOD
Change-Id: I204b721ce3a2bf4ebfd7419c25d72a77fd8174ac
* changes:
[Predictive Back] Recover taskbar all apps scale to 1f with animation if user swipe back within search [3/n]
[Predictive Back] Dismiss taskbar all apps's scroll bar during swipe gesture [2/n]
[Predictive Back] Fix predictive back swipe on task bar all apps [1/n]
For taskbar all apps, the background scrim is child view of AbstractSlideInView, thus scaling AbstracSlideInView during PB swipe will scale down background scrim. There is no need to re-apply scale effect on background scrim separately.
Bug: 327490078
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Test: manual
Change-Id: I125670d14bc788664a1371008589e4106496ae2e
The time in between each gesture's finish page and the start of the next
gesture tutorial was too short. We increased the time we spend on the
finish page by 1000 ms based on this feedback.
Fix: 293967263
Test: Run through the gesture tutorial and note the longer pause in
between each gesture
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Reason for revert: Test failure in question wasn't related to this topic b/328016248
Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN
Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).
You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.
For reference, the navbar width is 108dp and taskbar is 220dp.
Defaults to 0, i.e. you can only invoke within the visible navbar.
Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
This ensures that any global animation scale applies properly
Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.
Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537
Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105
Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.
This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.
Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
Bug: 327579977
Flag: ACONFIG com.android.systemui.predictive_back_system_anims TRUNKFOOD50
Test: atest BackProgressAnimatorTest
Test: atest BackAnimationControllerTest
Test: Manual, i.e. extensively testing all three system animations with quick swipes in succession
Change-Id: Ia8815088240084ce22246baa6d3562812462ab19
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!
This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.
Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure
the gesture works as expected (e.g. can quick switch, go home, or to
overview with all tasks visible).
Flag: none
Fixes: 324495241
Change-Id: If3b61f7d1725ee573fad38140bfeb77f3a6cea1e
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.
Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A
Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
* Individual text view and cancel button still
have their own a11y actions, but top level
view doesn't need one
Test: Tested w/ switches to ensure parent view
doesn't get selected. Tested w/ Talkback to
ensure we can still cancel through talkback
Fixes: 323462927
Change-Id: I60d21f6e768c59f29f51007f56ff784821487895
