This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.
Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
(cherry picked from commit 2b2d8cc90b)
Merged-In: I60d6fd3b3eb39921edafb12faace743d16de270f
Widgets added with tap-to-add do not emit an ITEM_DROP_COMPELTED event,
so this change updates AppEventProducer to check for
WIDGET_ADD_BUTTON_TAP event so that it can emit an ACTION_PIN
event for these widgets as well.
Also moves the stats logging for tap to add to after
Launcher.addPendingItem is called, so that the PendingAddItem's container
is set to CONTAINER_DESKTOP.
Bug: 323886237
Test: manual, add widget and confirm event is produced through logging,
and widget no longer appears in suggestions
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add STAGING
Change-Id: Iaf46a408d05f61864a79f87b23160364b6513323
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection
Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246
Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
Only set bubble bar alpha to 0 and mark it collapsed when bubbles are
hidden.
When bubble bar should be hidden due to system ui state, only update
visibility.
Bug: 324068295
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: trigger a buble from bubbles test app
- swipe to home screen
- observe bubble bar is shown
- swipe notification shade down and away again
- observe bubble bar is hidden when shade is open, and shown when
closed
- expand bubble bar
- repeat swipe shade down and away, observe expanded bubble is hidden
while shade is open and bubble is expanded when shade is swiped away
Change-Id: Icc717ab250061f14f02a558eb9f7301fdc08c5c7
This is a combination of two issues:
1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info
Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
Bug: 326550571
Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set
Flag: none
(cherry picked from commit fca7ee23ba)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9c4039e12dbc20dabf1d7e62b06bfd650706eaa7)
Merged-In: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"
Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
InsetsResizeAnimationRunner.
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection
Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246
Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
* This only works for fullscreen tasks, app pairs aren't
properly launching yet
* We re-layer the leash to be above launcher since live tiles
are originally below
* The new task comes in from TaskAnimationManager#onTaskAppeared
Bug: 316485863
Test: Tested w/ tapping fullscreen apps in overview when
their thumbnail is scrolled off screen. Animation occurs for
both live tile and thumbnail
Change-Id: I5a3c079244a1517becb845ce25ff9f4e671383b1
b/318394698 was fixed so we can now remove these logs.
Fix: 321837497
Test: N/A
Flag: NONE
Change-Id: Ifc8b18238778f6aa2c0ad1be5df627c07cbaf1d8
(cherry picked from commit 7e5d855886)
Disable quickswitch gestures when in desktop mode enviroment as well as
questures outside desktop mode that will result in the user entering
desktop mode.
Flag: NONE
Test: atest ShowImeOnAppStartWhenLaunchingAppFromQuickSwitchTest
atest QuickSwitchBetweenTwoAppsForwardTest
atest QuickSwitchBetweenTwoAppsBackTest
atest QuickSwitchFromLauncherTest
atest QuickswitchTest
atest -c NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar
atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTrackpad
atest -c NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar
Fixes: 330148342
Change-Id: If11901e6642036f8b8dda38b3419f6c10980d902
Desktop task should behave like any other task in overview and should
not show up as a large tile.
Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: Swipe fullscreen task into overview
Open overview from home
Swipe freeform task into overview
Test: Image test will be added in b/319237536
Change-Id: Iefca85747de7595357813d5ed999df0e4b51120a
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true
Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device
Change-Id: I5dce4b7e83fb17cc3a70565bfd5ce100a4cf72bb
This CL fixes the app and icon chip misaligned and wrong positioned in fake landscape and seascape.
The icon chip in seascape are still in RTL and it should be address in a different bug b/326377497.
Fix: 320314835
Fix: 326383211
Fix: 326383010
Bug: 328028913
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Test: manual. instructions described in the bug report.
Test: atest LandscapePagedViewHandlerTest
Test: atest SeascapePagedViewHandlerTest
Test: atest OverviewTaskSplitImageTest
Change-Id: I9be07cc4f4cf5ee6e1da0d954ed7664d96bd330c
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.
Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
This allows the user to scroll as quickly as they want.
Fix: 328749622
Test: manual
Flag: NONE
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
(cherry picked from commit a9a11b47c3)
With ag/26349940 we have fixed the bug where back swipe is not working
Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
KeyboardQuickSwitchView only ever has 2 direct children, and all of the task views we're actually concerned with are in a scrollview. removing the extra index handling as this is being handled properly downstream.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328692760
Fixes: 304518513
Test: opened KQS and tapped all tasks (6 + overview)
Change-Id: I4e919cce7f1ab55822f93d34c1533062a71aa879
The values are currently the same for all display and orientation
configurations, but they might change before launch.
There are a couple known imperfections:
* Swiping out of a hotseat app with very low velocity doesn't look
great
* Sometimes, if the window movement reaches its final location faster
than the background is done scaling, there is a small snap in icon
position
Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: verified with the flag on and off
Change-Id: Id54c7f0a76f62108d8b92a3b5e78634fff64dbef
