Commit Graph

11894 Commits

Author SHA1 Message Date
Sihua Ma
f418b2e16d Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
2024-03-13 15:21:34 -07:00
Tony Wickham
d1915657cc Avoid playing taskbar haptic when swiping up from home
Only play the haptic if the stashed value actually changed. In the
case of home-to-overview, taskbar is unstashed already.

Fixes: 314311118
Flag: none
Test: Manual, feel for haptics during home-to-overview
Change-Id: I36f70740d35bd98feafbb3980f861db16705b1da
2024-03-13 21:39:10 +00:00
Saumya Prakash
8a85cb5c9b Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into 24D1-dev 2024-03-13 20:12:47 +00:00
Schneider Victor-tulias
dba7cbae1a Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
2024-03-13 15:03:45 -04:00
Jordan Silva
68d8275949 Converting orientation handler classes to kotlin
This conversion is a first step for the alignment bug fix and cleanup of the fake orientation classes. The goal is to have these classes following the new architecture using Kotlin, smaller, and testable.

Bug: 320314835
Bug: 328028913
Flag: N/A
Test: presubmit. manual.
Change-Id: If0d12ff8c69eca5528fbb6b092bddefd20bc37ba
2024-03-13 18:32:20 +00:00
Pat Manning
a9a11b47c3 Set next page immediately on subsequent arrow/tab presses when navigating overivew.
This allows the user to scroll as quickly as they want.

Fix: 328749622
Test: manual
Flag: NONE
Change-Id: I493841f11407e6fb9f15fd90b5a5e55fa4ed3ad3
2024-03-13 17:43:10 +00:00
Saumya Prakash
e46e12c0f6 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ad5e4c795624955ae2d4a984b93cf7ae900e28aa)
Merged-In: Iba766b8a19ddce37d9ca20afb0219d679ce36ace
Change-Id: Iba766b8a19ddce37d9ca20afb0219d679ce36ace
2024-03-13 17:34:37 +00:00
Andreas Agvard
6ce297a2ff Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-03-13 18:31:51 +01:00
Saumya Prakash
b5f0d06360 Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into main 2024-03-13 17:19:08 +00:00
Jordan Silva
18bafeb261 Fix overview live tile flickers when clicking on overview action buttons
When a Live Tile is present on overview and an action is triggered (e.g., Split, Select, Screenshot), the live tile flickers due to a competing snapshot modification and animation on UI thread. The live tile is updated to switch to screenshot and at the same time the finishRecentsAnimation is triggered.

This CL bumps the number of frames to wait after the view is updated to run the Runnable code. Bumping back the mDeferFrameCount to 2 solves the sync between rendering the snapshot and hiding the Live Tile.

Fix: 327380570
Flag: N/A
Test: Manual. Open an App -> Swipe to Overview (Live title) -> Click on Split.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:024a1018e4c96b43d8f122bb1c614c3e3ea5bab7)
Merged-In: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
Change-Id: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
2024-03-13 16:59:10 +00:00
Alex Chau
b9351e4edd Allow Task menu to draw down to screen bottom
- Use all available spaces minus inset to draw the task menu
- Also enabled scrolling for app chi1p menu

Fix: 329271577
Bug: 326952853
Test: manual
Flag: Nonee
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:26e487c6acd86c668518d379f90cb84f3d89a486)
Merged-In: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
Change-Id: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
2024-03-13 15:12:41 +00:00
Himanshu Gupta
201626b553 Merge "Using LauncherApps API for PS Settings and Setup Flow." into main 2024-03-12 21:17:22 +00:00
Winson Chung
98569d474e Merge "Disable slow recents animation handling" into 24D1-dev 2024-03-12 21:05:58 +00:00
Treehugger Robot
bf78c0babe Merge "Allow Task menu to draw down to screen bottom" into main 2024-03-12 21:04:21 +00:00
Treehugger Robot
eaf5bbd496 Merge "Reset stashed in Taskbar All Apps for gestures instead of IME insets." into main 2024-03-12 20:58:43 +00:00
Saumya Prakash
ad5e4c7956 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A

Change-Id: Iba766b8a19ddce37d9ca20afb0219d679ce36ace
2024-03-12 20:09:17 +00:00
Winson Chung
9c72bef282 Merge "Fix split selection for 3P launcher with animations off" into 24D1-dev 2024-03-12 19:51:31 +00:00
Sunny Goyal
68ee15d758 Merge "Simplefying listener interface for TriggerSwipeUpTouchTracker" into main 2024-03-12 19:12:19 +00:00
Alex Chau
26e487c6ac Allow Task menu to draw down to screen bottom
- Use all available spaces minus inset to draw the task menu
- Also enabled scrolling for app chi1p menu

Fix: 329271577
Bug: 326952853
Test: manual
Flag: Nonee
Change-Id: Ibdff07043f2c64495f97e11e80209bcc3f5dcb4f
2024-03-12 17:55:37 +00:00
Treehugger Robot
0cd5024c6b Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-03-12 17:52:22 +00:00
Vinit Nayak
1c8bd71675 Merge "Using fractions in MultiValueUpdateListener instead of absolute durations" into 24D1-dev 2024-03-12 17:48:18 +00:00
Schneider Victor-tulias
f3edea44e1 Disable slow recents animation handling
Flag: N/A
Fixes: 324228222
Test: programmatic delay and several gestures
Change-Id: I98f3575047e442a4f57582b40cc0f36f1f113356
(cherry picked from commit 5b9d94adc5)
2024-03-12 17:47:03 +00:00
Vinit Nayak
872d6953a1 Merge "Update Launcher state anim duration for pinned & transient taskbar" into main 2024-03-12 17:25:54 +00:00
Alex Chau
618d7ed2c6 Merge "Re-calculate mLastComputedCarouselTaskSize when its empty before getMaxScaleForFullScreen" into main 2024-03-12 13:07:02 +00:00
Sukesh Ram
8229228132 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I7c30fb2f3c94770fa79780d2e7748e931552ba56
2024-03-12 02:17:59 +00:00
Treehugger Robot
54ae7b9dc3 Merge "Disable slow recents animation handling" into main 2024-03-12 01:01:55 +00:00
Brian Isganitis
1956246b6e Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
2024-03-11 20:30:32 -04:00
Vinit Nayak
a7789a4593 Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-11 23:58:47 +00:00
Vinit Nayak
9a3c48468b Update Launcher state anim duration for pinned & transient taskbar
* We were syncing the duration of the animation to be at most
that of the taskbar/hotseat animation but only for transient taskbar.
* Now we sync for transient and pinned

Fixes: 328052756
Test: Anim jank doesn't repro
Change-Id: I21f20cbc08a2018498dde3eff871929e5a5b7d7d
2024-03-11 16:53:39 -07:00
Himanshu Gupta
616a1b828d Using LauncherApps API for PS Settings and Setup Flow.
Bug: 310027945
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I6e04a4b0c33d4526d83b51e512e1e4372ce1cca4
2024-03-11 16:13:08 -07:00
Sunny Goyal
df71298af6 Using fractions in MultiValueUpdateListener instead of absolute durations
This ensures that any global animation scale applies properly

Bug: 327645429
Flag: NONE
Test: Manual
Change-Id: I12205429dca5a87208fa9964b3307fb718af4fd0
(cherry picked from commit f584b32811)
2024-03-11 22:06:41 +00:00
Vinit Nayak
84ca0e859a Fix split selection for 3P launcher with animations off
* When animations were off, the currentState in
FallbackRecentsStateController is incorrect (we didn't need
that check at all)
* Surfaced a bug in MultiValueUpdateListener that is being
fixed in ag/26416537

Test: 1P + 3P launcher all of the following:
starting split from overview with animations and without
rotation
selecting second app before and after rotation
Fixes: 327346105

Change-Id: I4f19119c30a8669bba6ced06e30773f085a78047
(cherry picked from commit b274152194)
2024-03-11 22:00:27 +00:00
Jeremy Sim
2692ca8925 Merge "Prevent Save App Pair from showing up on 3p launcher" into main 2024-03-11 20:49:06 +00:00
Schneider Victor-tulias
5b9d94adc5 Disable slow recents animation handling
Flag: N/A
Fixes: 324228222
Test: programmatic delay and several gestures
Change-Id: I98f3575047e442a4f57582b40cc0f36f1f113356
2024-03-11 14:46:28 -04:00
Alex Chau
f03524ae74 Re-calculate mLastComputedCarouselTaskSize when its empty before getMaxScaleForFullScreen
- Follow-up on ag/26499257 to do the same on mLastComputedCarouselTaskSize
- Also changing the mLastComputedTaskSize check to isEmpty

Bug: 326550571
Flag: none
Test: Swipe up, quick switch with Pixel / 3P launcher
Change-Id: If934bf4baf2782cd752b5621ad5e9be4a2013c49
2024-03-11 17:57:00 +00:00
Saumya Prakash
50ae58df57 Merge "Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"" into main 2024-03-11 17:36:24 +00:00
Vinit Nayak
14d28ad455 Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
Merged-In: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-11 05:00:47 +00:00
Zongle Wang
bfb4ddfa48 Reimplement QuickSwitch compat libs (#4084)
* Reimplement makeDefaultActivityOptions

* No need to post again

* Cleanups

* Tweak LawnchairQuickstepCompat

* Let compatLibVR depend on compatLibVQ

* Let compatLibVS depend on compatLibVR

* Cleanup compatLibVT

* Let compatLibVU depend on compatLibVT

* Add ActivityManagerCompatVS.getRunningTasks back

* Fix ActivityManagerCompatVS

* Don't return null running tasks

* Annotate getTaskSnapshot

* Fix style

* Retrun list from getRunningTasks

* Tweaks

* Cleanups

* null check

* Add ActivityManagerCompatVS.invalidateHomeTaskSnapshot back

* Move ThumbnailData

* Fixed err

* Cleanup

* Add RequiresApi

* Make RemoteTransitionCompat as an interface

* Annotate ActivityOptionsCompat

* More interfaces

* Replace aidl files with generated sources

* Reformat

* Revert "Replace aidl files with generated sources"

This reverts commit ee450e696d.

Revert "Reformat"

This reverts commit 38c8f21ed3.

* Use launcherNullable

* Fixes more crashes

---------

Co-authored-by: MrSluffy <werdna.jac@gmail.com>
2024-03-10 11:24:14 +08:00
Brandon Dayauon
68c18236ad Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-08 21:32:22 -08:00
Treehugger Robot
41770fbc60 Merge "Fix overview live tile flickers when clicking on overview action buttons" into main 2024-03-09 02:03:56 +00:00
Ats Jenk
d573fde5bf Merge "Remove line between bubble bar and arrow" into main 2024-03-08 21:31:08 +00:00
Jordan Silva
024a1018e4 Fix overview live tile flickers when clicking on overview action buttons
When a Live Tile is present on overview and an action is triggered (e.g., Split, Select, Screenshot), the live tile flickers due to a competing snapshot modification and animation on UI thread. The live tile is updated to switch to screenshot and at the same time the finishRecentsAnimation is triggered.

This CL bumps the number of frames to wait after the view is updated to run the Runnable code. Bumping back the mDeferFrameCount to 2 solves the sync between rendering the snapshot and hiding the Live Tile.

Fix: 327380570
Flag: N/A
Test: Manual. Open an App -> Swipe to Overview (Live title) -> Click on Split.
Change-Id: Ibd22a58580b2e5e5b866deb4e7dc87945c7e38c4
2024-03-08 19:33:25 +00:00
Randy Pfohl
79c34b4dfe Merge "When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot" into main 2024-03-08 17:08:23 +00:00
Federico Baron
f9aa2a4a47 Merge "Remove logspam for resolved bug" into main 2024-03-08 16:29:17 +00:00
Ats Jenk
a8e77927b4 Remove line between bubble bar and arrow
Bubble bar background is a drawable that consists of a rounded rect and
a pointer arrow.
In light theme, the rounded rect has a 1 pixel wide border around it.
When drawing the arrow just above the rounded rect, the border is
visible as a line between the background rounded rect and the arrow.
Shifting the arrow down by 1 pixel to ensure that there is no visible
arrow between bubble bar and arrow.

Other option could be to draw the entire background as a single path.
This path can combine the rounded rect background and arrow. But we need
to control the alpha of the arrow separately from the background. This
we can't do with a single path.

Bug: 324442574
Flag: NA
Test: manual
Change-Id: Iaa58ae4700ed9ad43051cd386f03381e0c14e72c
2024-03-07 23:37:49 -08:00
Andy Wickham
3081537398 Consolidate settings for Assist.
Now there is just 1 toggle for all entrypoints.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
2024-03-08 03:43:41 +00:00
Jagrut Desai
754f171a98 Revert "Ensure taskbar insets for camera cutout only apply on the needed sides"
This reverts commit 40fc6eb323.

Reason for revert: <b/328182219>

Change-Id: I5b846919823d696933b7d9f4220c1797409fc8b8
2024-03-07 20:55:48 +00:00
Jeremy Sim
2b2d8cc90b Prevent Save App Pair from showing up on 3p launcher
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.

Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
2024-03-07 20:23:47 +00:00
randypfohl
fca7ee23ba When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot
Bug: 326550571

Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set

Flag: none

Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
2024-03-07 12:09:28 -08:00
Ats Jenk
60101ae7fc Merge changes from topic "bubble-bar-drag" into main
* changes:
  Fix bubble bar arrow visibility during animation
  Animate bubble bar location changes
  Introduce bubble bar location that is driven by shell
2024-03-07 19:42:17 +00:00