Commit Graph

24592 Commits

Author SHA1 Message Date
Samuel Fufa
6e5efb0929 Consolidate Hero search result with SearchResultIconRow
With this, we can now show app title and support drag/drop for shortcut results.

Bug: 172245107
preview: https://drive.google.com/file/d/1A4eKKTDPht-MDbfA2VFI3OuAO36fc3AS/view?usp=sharing
Change-Id: Icf94a2d23b44bfe5527aea71e27178906e5deb3e
2020-11-05 11:57:35 -06:00
TreeHugger Robot
a1733bceb7 Merge "fix the issue widget id can be wrong after restore" into ub-launcher3-master 2020-10-29 17:30:35 +00:00
TreeHugger Robot
90faddeff3 Merge "Quick fix from ag/12914139" into ub-launcher3-master 2020-10-29 06:38:13 +00:00
Tracy Zhou
991e8208cc Quick fix from ag/12914139
Test: N/A
Change-Id: I0b8274f8a912d091cfbbebafdee220b5e46ee74f
2020-10-28 22:34:23 -07:00
Pinyao Ting
f39f351a0d fix the issue widget id can be wrong after restore
Bug: 171774227
Test: manual testing
1. randomly add/remove widgets to workspace
2. create a backup (Settings > System > Backup)
3. reset the device
4. restore from the backup
5. verify all of the widgets are restored properly

Change-Id: Id65e474dd9349aca715d7e6b88f8d58bc63066ae
2020-10-28 22:04:35 -07:00
TreeHugger Robot
1e9453f09c Merge "Removing workaround for battery defender" into ub-launcher3-master 2020-10-28 23:36:07 +00:00
TreeHugger Robot
a90ddeea57 Merge "Settings/Play/Suggest layout polish" into ub-launcher3-master 2020-10-28 22:12:52 +00:00
TreeHugger Robot
8f48f23039 Merge "IME bounds after DOWN->UP Motion event sequence" into ub-launcher3-master 2020-10-28 21:22:51 +00:00
Hyunyoung Song
a34766a176 IME bounds after DOWN->UP Motion event sequence
Bug: 170739594

Change-Id: I1aa8dd2ced7c017e57d3c14c02d5b78900a46caa
2020-10-28 12:49:56 -07:00
TreeHugger Robot
426f6ac276 Merge "Use event time of app side for latency metrics" into ub-launcher3-master 2020-10-28 10:40:27 +00:00
Riddle Hsu
b30adcb232 Use event time of app side for latency metrics
There are 2 reasons not to use MotionEvent#getEventTime:
1. There is an existing TouchEventReported metric for touch latency.
2. In instrumentation test, the event time is set when creating
   the motion event for injection. It may cause the results to be
   5 times slower than the real case. That may lead to miss the
   cost from app to system.

Bug: 166614700
Test: Enable statsd log: "adb shell cmd stats print-logs"
      Touch gesture navigation bar or launch app from launcher.
      adb logcat | grep statsd | grep "(48)"
Change-Id: Ica5e7df685fe737bbc3ac60c3ec35bad15466726
2020-10-28 09:13:48 +00:00
Tracy Zhou
55940ecfc7 Render and track live tile position when launching another app from Overview
Fixes: 165394366
Fixes: 170338328
Test: Manual
Change-Id: Idfcd423cbe062af33564eaa9e83ec21fbac0cdf9
2020-10-27 15:45:01 -07:00
TreeHugger Robot
ceb8618f09 Merge "Finishing recents task before starting share screenshot flow" into ub-launcher3-master 2020-10-27 20:41:54 +00:00
Andy Wickham
aeaa2c92de Merge "Changes COMPILE_SDK to S." into ub-launcher3-master 2020-10-27 20:09:50 +00:00
TreeHugger Robot
a48f6efbe1 Merge "Integrating snapshot logging in Launcher" into ub-launcher3-master 2020-10-27 19:08:01 +00:00
Sunny Goyal
b694a69f53 Integrating snapshot logging in Launcher
> Workspace snapshot is logged when the workspace loads (at most once a day)
> Removing unnecessary thread jumping when logging folders
> Preference snapshot is logged on process start and whenever something changes

Change-Id: I93767de89b11522d843c0e8300d1f108c78f6d90
2020-10-27 11:25:43 -07:00
Hyunyoung Song
9fc27da5f8 Settings/Play/Suggest layout polish
Bug: 170792963
Bug: 170750779
Change-Id: I69b09f5360e165c3b1b33e259cdd0f390ce6fa60
2020-10-27 16:45:54 +00:00
Andy Wickham
4a97458253 Changes COMPILE_SDK to S.
Change-Id: I5d4d84027904a7d7861e897ace1f7ce9fc04f4a4
2020-10-26 17:00:36 -07:00
Sunny Goyal
54aae4f95d Finishing recents task before starting share screenshot flow
Bug: 170338559
Change-Id: Ieccdc492c7d1a60b47b90c6683e60e8a143ca80d
2020-10-26 16:02:17 -07:00
Tony Wickham
2c956a4651 Merge "Add null check between calling onMotionPauseDetected() and Changed()" into ub-launcher3-master 2020-10-26 22:08:00 +00:00
Schneider Victor-tulias
47dfc3a3ca Merge "Fix All Apps Search plugin shortcut icon redrawing issue." into ub-launcher3-master 2020-10-26 20:57:17 +00:00
Winson Chung
4ff3548d96 Merge changes from topic "enter-pip-gesture-nav-launcher" into ub-launcher3-master
* changes:
  Updating pip transition calls with shared lib
  Improve PIP enter transition w/ gesture nav (3/N)
2020-10-26 19:43:27 +00:00
TreeHugger Robot
f9317597ef Merge "Add a feature flag to expand smartspace to three rows" into ub-launcher3-master 2020-10-26 18:37:26 +00:00
Schneider Victor-tulias
3ee7018227 Fix All Apps Search plugin shortcut icon redrawing issue.
BubbleTextViews animate the update from their placeholder icons to their high res icons. Added a field to allow restricting what BubbleTextViews' icon updates should be animated. Updated SearchResultIconRow to store the icon Drawable rather than the resource id to prevent unecessary redrawing.

Fixes: 170966269

Demo: https://drive.google.com/file/d/1FBdEl11mHZk1SpCMRY4XZAGt5TVZ01W4/view?usp=sharing

Change-Id: Ib55dafdf5b5fed00d343af5f95f3dd3f08c4ee8e
2020-10-26 14:25:35 -04:00
Winson Chung
6f4e65f62f Updating pip transition calls with shared lib
Bug: 143965596
Change-Id: I761726ca9666689d4359240b065997e3342eab65
2020-10-25 22:26:55 -07:00
Hongwei Wang
5b5f3c6609 Improve PIP enter transition w/ gesture nav (3/N)
Directly transition Activity to PiP mode in launcher if the Activity
claims auto-pip support. Video is taken by commenting out the
requirement of setting the auto-pip flag.

Note that we need app to actively push up-to-dated
PictureInPictureParams to the framework, otherwise we won't be get
- PictureInPictureParams on first entering
- Staled PictureInPictureParams if the aspect ratio is changed

Video: http://rcll/aaaaaabFQoRHlzixHdtY/abenIxLFI1pZzF2O8t4TbS
Bug: 143965596
Test: see demo videos
Change-Id: Iea9a6ff39a79431ac1afa14aea812c500b3ca3b2
2020-10-25 21:14:10 -07:00
TreeHugger Robot
bc3a5d516e Merge "[pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result" into ub-launcher3-master 2020-10-23 23:23:52 +00:00
Hilary Huo
9c43bfa798 [pixel-search] URGENT: bug fix for teamfood: fix crash when tapping on a screenshot result
Bug: b/171596755
Change-Id: I125404dbe5a4e5f8e3bdc233e3a82db3dca48f42
2020-10-23 15:48:12 -07:00
Tony Wickham
3cc1aa960d [automerger skipped] End the attaching animation early when we settle on the end target am: fd54a8e84a -s ours
am skip reason: Change-Id I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc with SHA-1 1cc12ebc12 is in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12907696

Change-Id: I5490ccf0af9a8e0a8625d4467e38b9fbe2251826
2020-10-23 20:44:33 +00:00
Tony Wickham
fd54a8e84a End the attaching animation early when we settle on the end target
The attaching animation can take longer than the transition to recents
when you let go, and the ADJACENT_PAGE_OFFSET calculation is different
when there's a running task vs not. So after the transition to recents
ended, the calculation of the still playing attaching animation would
change, causing the jump you see in the bug. Now we make sure to end
the attaching animation if it's still running when we settle on an
end target to avoid this issue.

Fixes: 168563692
Change-Id: I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc
Merged-In: I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc
(cherry picked from commit 1cc12ebc12)
2020-10-23 19:43:12 +00:00
TreeHugger Robot
e6239cebd0 Merge "Fixing robo test compilation" into ub-launcher3-master 2020-10-23 18:13:03 +00:00
Tony Wickham
c1a785914a Add null check between calling onMotionPauseDetected() and Changed()
Some listeners such as ScreenPinnedInputConsumer only care about the
first pause detection and thus clear the MotionPauseDetector in
onMotionPauseDetected(). Because clear() sets mOnMotionPauseListener
to null, we need a second null check before onMotionPauseChanged().

Fixes: 169329910
Change-Id: I4fc30d67ad808a5b0c8feb10cc5392d7cae042b1
2020-10-23 11:02:05 -07:00
Sunny Goyal
84acb18dc2 Fixing robo test compilation
Change-Id: I1b1192f4cbf1ea1916f2ec4cd607743b3483250a
2020-10-23 10:35:35 -07:00
Tony Wickham
9d2466418c Merge "End the attaching animation early when we settle on the end target" into ub-launcher3-master 2020-10-23 17:21:16 +00:00
TreeHugger Robot
4c3952dc60 Merge "Minor stylistic changes in Workspace.java." into ub-launcher3-master 2020-10-23 00:27:39 +00:00
Pinyao Ting
cb403d9e52 flip default value of minimal device feature flag
Test: manual
Change-Id: Iaf46dffb935bdf4b46e7c57d547bdc697250ec56
2020-10-22 16:07:08 -07:00
Tony Wickham
1cc12ebc12 End the attaching animation early when we settle on the end target
The attaching animation can take longer than the transition to recents
when you let go, and the ADJACENT_PAGE_OFFSET calculation is different
when there's a running task vs not. So after the transition to recents
ended, the calculation of the still playing attaching animation would
change, causing the jump you see in the bug. Now we make sure to end
the attaching animation if it's still running when we settle on an
end target to avoid this issue.

Fixes: 168563692
Change-Id: I3f37aecf9c93f2ec63dbdce561e7f5ba11be89cc
2020-10-22 13:59:09 -07:00
Tracy Zhou
a97557a15e Merge "Consider overscroll adjustment of RecentsView for live tile" into ub-launcher3-master 2020-10-22 18:22:56 +00:00
vadimt
ff39fd3e14 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
2020-10-22 11:14:10 -07:00
Tracy Zhou
932a327ebf Consider overscroll adjustment of RecentsView for live tile
Fixes: 171450807
Test: manual
Change-Id: I83eebf1f6b61c67f289db51aabe5a971815d0df1
2020-10-21 23:29:00 -07:00
Hilary Huo
f5ce80b8a0 [pixel-search] Latency analysis, add logging statement in launcher
Bug: b/170675311
Change-Id: I229ace399085bea1c3f9535eb713edd329dff8bd
2020-10-21 18:00:06 -07:00
Tracy Zhou
31b03941ef Merge "Track live tile better by considering resistance animation" into ub-launcher3-master 2020-10-21 20:03:57 +00:00
Tracy Zhou
0731273d54 Track live tile better by considering resistance animation
Fixes: 170338029
Test: Manual
Change-Id: I66536bae567aa94385d5e0352cec9d46d512927a
2020-10-21 12:03:40 -07:00
Alex Chau
e0a50c9e3f Merge "Use Diplay.getMetrics in DisplayController" into ub-launcher3-master 2020-10-21 17:02:57 +00:00
Tracy Zhou
d2c27a5950 Merge "[Live Tile] Support launching running task animation" into ub-launcher3-master 2020-10-21 07:19:48 +00:00
Tracy Zhou
8b488ccc2e [Live Tile] Support launching running task animation
Fixes: 170338170
Test: manual
Change-Id: I2526b7cfbacaea7899b8e2ed233f913630071d36
2020-10-20 23:42:44 -07:00
Andy Wickham
70e8b15721 Minor stylistic changes in Workspace.java.
Change-Id: Ib07611f27cbc427d11abccd8b74ea144485752f7
2020-10-20 15:36:18 -07:00
Alex Chau
acfac6187d Use Diplay.getMetrics in DisplayController
- This is a workaround of b/163815566, where DisplayMetrics is stale
  when onDisplayChanged is called.
- Instead of relying on stale DisplayConext, get the DisplayMetrics
  from the Display directly.
- Also optimized how DisplayController.Info is created by passing in
  Display only
- Use mDisplayContext.getDisplay directly if availalbe

Bug: 163815566, 160544577
Test: DPI looks correct on device boot
Change-Id: I2a7454bb8cf2073ce592e8662781b87fc998444f
(cherry picked from commit 177c38243dc3bf245d1f7db3c265dfb56522f441)
2020-10-20 20:19:57 +01:00
TreeHugger Robot
ff8febabb0 Merge "Makes Plugin Settings gear adjust to dark mode." into ub-launcher3-master 2020-10-20 17:46:09 +00:00
alexmang
6c666fb196 Add a feature flag to expand smartspace to three rows
In order to experiment with presenting more predicted content to the
workspace I have added a flag to expand smartspace to two rows.

This CL does not include any app relocation. If an app lives in a space
the expanded smartspace will occupy, it will be removed from workspace.

Change-Id: I38354dc81a34a495828cf7a69ddb04cc137e2e4e
2020-10-20 09:32:29 -07:00