Commit Graph

4763 Commits

Author SHA1 Message Date
Adnan Begovic
ee79e0f5d2 launcher3: Use @UiExecutor within ThemeManager.
Use the provided @UiExecutor within the ThemeManager
instead of referencing the MAIN_EXECUTOR directly.

Bug: 407593767
Test: ThemeManagerTest
Flag: NONE - new module
Change-Id: I6359adc1308bdb209dcf6c6e1c2d3fc7f4438585
2025-04-15 09:04:44 -07:00
Sebastián Franco
526d80a550 Merge "No-op change, remove methods from BaseLauncherActivityTest into Utilities" into main 2025-04-14 16:21:19 -07:00
Sebastian Franco
d330fdce3a Adding screenrecord for IntegrationReorderWidgetsTest
Bug: 408279425
Flag: EXEMPT bug fix
Test: IntegrationReorderWidgetsTest
Change-Id: I302a35304a145f90d7d49f93044787350c466ad1
2025-04-14 13:56:48 -07:00
Sebastian Franco
c08c7de5e3 No-op change, remove methods from BaseLauncherActivityTest into Utilities
Bug: 324261526
Test: all test that inherit BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I0851373d179f064721a3a618853a05796cc1379f
2025-04-14 13:38:20 -07:00
Brandon Dayauon
e42fd21462 Merge "Update Tapl test for Private Space Add button" into main 2025-04-14 13:07:21 -07:00
Brandon Dayauon
3759f1428b Update Tapl test for Private Space Add button
See artifact: https://android-build.corp.google.com/test_investigate/invocation/I00100010386298382/test/TR74629693245670294/?itab=tests&ttab=artifacts

When aconfig flag is moved to staging the button is now "Add" rather than "Install" which will need to fix.

bug: 360313403
Test: presubmit
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I3a3e658d1a9d2b9d0795b5cef5d062ddfbe2b8ba
2025-04-14 10:38:10 -07:00
Sunny Goyal
040ff3a7bf Adding HomeScreenRepo to expose homescreen data as repository
Bug: 390572144
Test: Presubmit
Flag: com.android.launcher3.model_repository
Change-Id: If82a388a44d7a9c448f6eb4901c2acdb508ccfdc
2025-04-11 13:28:08 -07:00
samcackett
2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Sebastián Franco
59ae5808c7 Merge "Use LauncherActivityScenarioRule in BaseLauncherActivityTest" into main 2025-04-08 15:28:11 -07:00
Treehugger Robot
3dd0f30ac5 Merge "Remove 5x grid from canBeDefault grids" into main 2025-04-08 09:35:20 -07:00
Federico Baron
eec1d1d8f9 Remove 5x grid from canBeDefault grids
Bug: 407819792
Test: manual test
Flag: com.android.launcher3.one_grid_specs
Change-Id: I77c2fddc470d0dbaa6fc248ec30a5dbd4a86e0c2
2025-04-07 23:20:02 +00:00
Pat Manning
f6ee091c9c Merge "Dismiss tasks from center of task, not bottom." into main 2025-04-04 07:26:26 -07:00
Pat Manning
a1e23ded55 Dismiss tasks from center of task, not bottom.
Overview shows tooltip the first time it is opened, which blocks the bottom of the task, preventing the touch. By dismissing from the center of the task, we avoid this.

Bug: 403883013
Test: DismissTaskFromOverview#testDismissCurrentTaskFromOverview
Flag: EXEMPT bugfix
Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c
2025-04-04 07:25:45 -07:00
Charlie Anderson
e3defaa8e6 Merge "Update folder previews to new specs" into main 2025-04-04 00:02:52 -07:00
Charlie Anderson
6f5f8cac25 Update folder previews to new specs
Bug: 403616844
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: visually comparing against spec

Change-Id: I671b3de7d4ac574122ee3a33451f6cb1d6155f29
2025-04-03 16:42:35 -07:00
Sebastian Franco
089f07c2b6 Use LauncherActivityScenarioRule in BaseLauncherActivityTest
The goal is that eventually remove BaseLauncherActivityTest and
uase LauncherActivityScenarioRule by compositions instead of
using inheritance and move methods that make sense to have in
LauncherActivityScenarioRule and other in utility classes.

Bug: 324261526
Test: All Tests that inherit from BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I1b2f3ed9e9d41a9185711ba682895b0b3fffe2df
2025-04-03 15:35:20 -07:00
Jordan Silva
f0d253ef9d Merge "Remove unused overviewActionsButtonSpacing from DeviceProfile" into main 2025-04-03 13:48:07 -07:00
Jordan Silva
17fd5f13f4 Remove unused overviewActionsButtonSpacing from DeviceProfile
Bug: 404479758
Flag: EXEMPT. Clean-up code.
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceDefaultGridTest
Change-Id: Ieb9ec81f82e80d293f04de71d5c2575a4ce50301
2025-04-03 10:18:23 -07:00
Pat Manning
cb855eeeaf Fling cancel at same rate as fling so it is detected by touch controller.
Fix: 396447643
Test: TaplTestsQuickstep#testDismissCancel
Flag: EXEMPT bugfix
Change-Id: I1cf3ae6944d4765b54b78a86d4a81af1ed81e661
2025-04-01 09:33:49 -07:00
Sunny Goyal
50884dadfe Lazily loading theme icons
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps

Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
2025-03-31 13:07:03 -07:00
Uwais Ashraf
207d5fa3b5 Merge "Remove flag rule to turn off one grid in all image tests" into main 2025-03-30 14:11:59 -07:00
Sunny Goyal
45f1a5190c Merge "Using item inflater for predicted items and previews" into main 2025-03-28 15:18:11 -07:00
Will Osborn
5c00b41505 Merge "Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library" into main 2025-03-28 14:05:39 -07:00
Sunny Goyal
bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Will Osborn
ec8d20d0ed Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library
Test: locally tested on Tangor
Bug: 399371607
Flag: EXEMPT refactor

Change-Id: Ie52f53a2d5dee757a8dc3b19248736bc15e5e0c6
2025-03-28 12:08:36 +00:00
Shamali P
472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Sunny Goyal
2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Sunny Goyal
0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sunny Goyal
3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Priyanka Advani (xWF)
35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Federico Baron
e35b9039e8 Remove flag rule to turn off one grid in all image tests
Flag: EXEMPT TEST_ONLY
Bug: 398249160
Test: NexusLauncherImageTests
Change-Id: Ib62eee47b059d283442d9567b9208558b23ad371
2025-03-26 13:15:19 -07:00
Sunny Goyal
cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Treehugger Robot
2032de9d20 Merge "Fix miscellaneous TAPL testing issue" into main 2025-03-25 15:24:28 -07:00
Schneider Victor-Tulias
58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Sunny Goyal
e8d901fbdb Deflaking ShortcutsChangedTaskTest by not using an active model
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running

Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
2025-03-25 12:12:20 -07:00
Treehugger Robot
e0a018785e Merge "Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps" into main 2025-03-24 11:03:55 -07:00
Charlie Anderson
ca9a920fa9 Make sure loading icons from db for archived apps only happens once after restore.
- This is to enable users to theme and shape archived apps

Bug: 402303619
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: performing restore and toggling themed icons on/off
Change-Id: I5883f703c3b0c8df5ee303ea4d99b0c02743faa4
2025-03-21 13:29:14 -07:00
Alex Chau
df6dc455a7 Merge changes from topic "revert_task_content_view" into main
* changes:
  Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
  Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-21 04:14:36 -07:00
Treehugger Robot
d3e559a244 Merge "Add logging for which type of migration occurs." into main 2025-03-20 11:13:55 -07:00
Alex Chau
77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Federico Baron
c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Charlie Anderson
19c4a92ebc Avoid downgrading archived app icon when widget is restored and when apps are archived.
- Restored widget were requesting icons through iconcache, and overwriting the restored icon from restored db.
	- Manually archiving icons would delete icon in cache, we should instead reuse the icon from when it was installed.

Bug: 399649982
Test: Manually performing restore with apps, widgets and shortcuts.
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Change-Id: I4184af480f29eb3ef41173fe5edc5307f263d0b0
2025-03-19 21:28:37 -04:00
Federico Baron
896f1a66bf Add screenrecord for TaplUninstallRemoveTest#testUninstallFromAllApps
Flag: EXEMPT test only
Test: TaplUninstallRemoveTest#testUninstallFromAllApps
Bug: 386231522
Change-Id: Ic1f0f343153b2052438ea8ea6b9d84c429f844c1
2025-03-19 21:57:29 +00:00
Sebastián Franco
92330ddaf7 Merge "Removing ZipRule because it seems to break roboelectric tests" into main 2025-03-17 14:34:15 -07:00
Sebastian Franco
a67e735606 Removing ZipRule because it seems to break roboelectric tests
Fix: 402136065
Test: DeviceProfileTest
Test: DeviceProfileDumpTest
Flag: TEST_ONLY
Change-Id: I7c3777ebd725e2acb2511aef3874b031a56bcf1a
2025-03-17 14:33:28 -07:00
Sunny Goyal
66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Sunny Goyal
370eabf534 Merge "Making ModelDbController injectable" into main 2025-03-13 23:20:17 -07:00
Sunny Goyal
25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Sunny Goyal
1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
Andy Wickham
250d85698c Merge "Adds all_apps_blur flag." into main 2025-03-12 11:25:50 -07:00