Commit Graph

4763 Commits

Author SHA1 Message Date
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Treehugger Robot
091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Toni Barzic
83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Kevin Lim
f7ce5a06fe [Multiline] Clean-up multiline flag on Launcher3
Bug: b/409605328
Flag: EXEMPT removing multiline_search_bar
Test: Unit tests all passing
Change-Id: Id377b7c99af0d0265102888b8021c0809f53a6b9
2025-05-20 18:52:14 -07:00
Alex Chau
13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Treehugger Robot
5ae4fb14f4 Merge "Wait for all springs to finish before running end snapping and relayout." into main 2025-05-19 03:47:48 -07:00
Vadim Tryshev
a3e63d1e20 Merge "Skip all tests after a test times out" into main 2025-05-16 14:06:56 -07:00
Shamali Patwa
b7b5e60d9f Merge "Pass device profile as constructor arg to DatabaseWidgetPreviewLoader" into main 2025-05-16 14:06:39 -07:00
Sebastian Franco
57da21d3c4 launcher: Add e2e quickstep tests to NexusLauncherE2ETests
The test target apk will remain commented until we fininsh adding
all the tests there.

Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I989c85baf87cfb15eca817f0c725968dedf015ce
2025-05-16 21:03:03 +00:00
Shamali Patwa
35c051001c Merge "Centralize all entry points for widget picker" into main 2025-05-16 13:41:26 -07:00
Shamali P
4cb6ff3838 Pass device profile as constructor arg to DatabaseWidgetPreviewLoader
This is so, we can use it with compose, and let caller pass the needed
dependencies. May also convert to dagger in
 followup

Bug: 408283627
Flag: EXEMPT BUGFIX
Test: N/A
Change-Id: I9b04011ec2592df3bd02bd74ec4889eb05928e7f
2025-05-16 11:47:18 -07:00
Pat Manning
e229b40329 Wait for all springs to finish before running end snapping and relayout.
- Adds a SpringSet to track all running springs.
- Rearranges the code into blocks: end runnable, reflow, dismiss, neighbor bounce, etc.
- Renames all instances of draggedTaskView to dismissedTaskView for consistency
- To stop blocking touch earlier, run grid end translation without waiting for the neighbor bouncing to finish.
- Update TAPL split screen launching logic to wait for dismiss animation to end.

Fix: 415327465
Test: TaplTestsQuickstep.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I59ade102e35e3528971907e898dac9555c6de796
2025-05-16 19:10:00 +01:00
Alex Chau
557d8e6d7f Reland "Recreate Launcher activity when blur enabled changes"
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate

Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix

Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
2025-05-16 12:33:44 +01:00
Vadim Tryshev
3743ca97c7 Skip all tests after a test times out
That test can continue running in the "Time-limited test" thread,
and we don't know whether it makes sense to wait for its completion.

Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: I3bdd6e5b07f109124f938766b7f2e427d2e39b01
2025-05-15 13:44:40 -07:00
Alex Chau
38efd382b7 Merge "Revert "Recreate Launcher activity when blur enabled changes"" into main 2025-05-15 13:07:22 -07:00
Sunny Goyal
1d4a457680 Merge "Adding repository for AppsList data" into main 2025-05-15 12:23:44 -07:00
Priyanka Advani (xWF)
1f891a6b67 Revert "Recreate Launcher activity when blur enabled changes"
Revert submission 33554447-b/414789280

Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.

Fix: 417614196

Reverted changes: /q/submissionid:33554447-b/414789280

Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
2025-05-15 11:12:05 -07:00
Alex Chau
b7dd7bf1e0 Merge "Recreate Launcher activity when blur enabled changes" into main 2025-05-15 06:07:58 -07:00
Sunny Goyal
869b20cb27 Adding repository for AppsList data
Flag: com.android.launcher3.model_repository
Test: atest AppsListRepositoryTest
Bug: 390572144
Change-Id: I6e5993c91f77ed8f0b6f2c12c9d743c87a497134
2025-05-14 21:19:18 -07:00
Treehugger Robot
42aaacc11f Merge "Do not expect a desktop task has action views" into main 2025-05-14 19:11:34 -07:00
Brian Isganitis
70e62fce31 Merge changes from topic "taskbar-wmproxy-module" into main
* changes:
  Filter out DEFAULT_DISPLAY from Taskbar unit tests.
  Refactor test dagger graph to stub PerDisplayRepository instances.
  Only use mockito-kotlin in SandboxApplication.
2025-05-14 14:17:21 -07:00
Alex Chau
a6fa3db580 Recreate Launcher activity when blur enabled changes
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
2025-05-14 17:45:04 +01:00
Sebastián Franco
2175b3fc2e Merge "Remove flags from aconfig where the code was already cleaned" into main 2025-05-14 09:16:56 -07:00
Shamali P
8dc2f98338 Centralize all entry points for widget picker
So we have a central place to replace it with opening
WidgetPickerActivity behind a flag.

Bug: 408283627
Flag: EXEMPT minor refactor
Test: Existing tests
Change-Id: I1c26c3faec8549fd5c3057b4c26ab2ab109f6f0c
2025-05-13 17:15:25 -07:00
Sebastian Franco
c6f6cb8cba Remove flags from aconfig where the code was already cleaned
Fix: 409610210
Test: BackupAndRestoreDBSelectionTest
Flag: EXEMPT refacotr
Change-Id: Ic0910c7a5c3124a47128b8b70bd2600374d9c157
2025-05-13 16:25:15 -06:00
Treehugger Robot
5b77862850 Merge "Only show the Desktop shortcut when appropriate" into main 2025-05-13 09:15:04 -07:00
Pierre Barbier de Reuille
8ac46d7e37 Only show the Desktop shortcut when appropriate
The Desktop shortcut should only be shown if the task is on a display
that can host a desktop.

Bug: 405181230
Test: atest DesktopSystemShortcutTest
Test: Manual
Flag: EXEMPT (bug fix)
Change-Id: I4639aade4c3640a3c60b85e08981cbe46974df38
2025-05-13 14:41:13 +01:00
Toshiki Kikuchi
67a58b0dbf Do not expect a desktop task has action views
This CL changes TAPL not to expect having action views for a desktop
task.

Flag: EXEMPT - fix test
Bug: 416355555
Test: atest WMShellSmokeTestsDesktopMode
Change-Id: I9218415a5ff0b5a43758adb8cb6d3f3ea6cfcc6b
2025-05-13 20:33:52 +09:00
Sunny Goyal
fabe5b213d Merge "Adding support for diff in WorkspaceData, so that UI can apply incremental updates" into main 2025-05-12 18:27:05 -07:00
Brian Isganitis
bcf2a81aa3 Only use mockito-kotlin in SandboxApplication.
Flag: TEST_ONLY
Bug: 415826632
Test: Related tests
Change-Id: I8a2704a8b55a0fd785577d6641665a34c1c9b650
2025-05-12 15:51:52 -04:00
Treehugger Robot
70e3cd4b67 Merge "Simplifying startup latency logger by moving everything to a single class" into main 2025-05-12 12:41:47 -07:00
Treehugger Robot
de378a054f Merge "Fix FallbackRecentsTest with recents in window enabled" into main 2025-05-12 11:09:45 -07:00
Sunny Goyal
e40896639b Simplifying startup latency logger by moving everything to a single class
> Moving some latency logic out of Launcher and into logger
> This makes it easier to move the logger completely out of Launcher

Bug: 390572144
Test: atest StartupLatencyLoggerTest
Flag: EXEMPT refactor

Change-Id: I6f6d99e7ed6c77610534c64461ec34200780225f
2025-05-12 09:39:06 -07:00
Schneider Victor-Tulias
82050b85fa Fix FallbackRecentsTest with recents in window enabled
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
2025-05-12 10:27:41 -04:00
Treehugger Robot
950b841d3d Merge "Specify display ID for taskbar availability checks" into main 2025-05-11 18:45:29 -07:00
Sunny Goyal
473bc9a06a Adding support for diff in WorkspaceData, so that UI can apply incremental updates
Bug: 390572144
Flag: com.android.launcher3.model_repository
Test: atest WorkspaceDataTest

Change-Id: I5fead4fdedfa2f6ac03ca106f7f0a5900af3760e
2025-05-09 15:26:09 -07:00
Alex Chau
d95285cf7a Merge "Revert "Make Tapl check if actions view is enabled on overview"" into main 2025-05-09 13:06:15 -07:00
Coco Duan
b97962a927 Merge "Show all default widgets in glanceable hub widget picker" into main 2025-05-09 11:48:32 -07:00
Vinay Joglekar
73abff782b Revert "Make Tapl check if actions view is enabled on overview"
This reverts commit e8628ac605.

Reason for revert: https://b.corp.google.com/issues/416645195

Bug: 391276638
Change-Id: I7b8f1829c752d958e9b640cd5db0f9aeb9bfa2f0
2025-05-09 10:20:10 -07:00
Uwais Ashraf
1ae9814920 Merge "Create separate worker threads for IO work and lighter BG work" into main 2025-05-09 09:45:40 -07:00
Treehugger Robot
0dddfe6aae Merge "Account for magnetic detach when dismissing tasks in TAPL tests." into main 2025-05-09 08:12:58 -07:00
Coco Duan
cc55afe1fd Show all default widgets in glanceable hub widget picker
Update the predicate condition to correctly use the host's specified
filter for default widgets.

Fixes: b/415899961
Test: verify in hub widget picker on tablet
Test: atest WidgetPickerDataProviderTest
Flag: EXEMPT bugfix
Change-Id: I5a68d49dfda08059de880bca6964ac1620ffff36
2025-05-09 07:18:36 +00:00
Uwais Ashraf
c1102750dd Create separate worker threads for IO work and lighter BG work
Documentation largely pulled from Kotlin coroutines docs.

Flag: com.android.launcher3.enable_coroutine_threading_improvements
Bug: 416206104
Test: Presubmits
Change-Id: I89b7222e31680619e311fa9e9986da5c12d80ed4
2025-05-09 06:49:48 +00:00
Fengjiang Li
85958d3cc7 Merge "[Memory Leak Test] Support toggle theme from LauncherInstrumentation" into main 2025-05-08 08:39:17 -07:00
Pat Manning
015f0005b9 Account for magnetic detach when dismissing tasks in TAPL tests.
When the dismiss length is short, like in fixed landscape, we must account for a minimum distance to ensure dismissal

Fix: 415773066
Test: TaplTestsQuickstep#testOverview
Flag: EXEMPT Bugfix.
Change-Id: I31a1a9e0bbd23145455df35937cf85ce8ac2c20f
2025-05-08 16:15:29 +01:00
Sunny Goyal
57a195b790 Making workspaceData immutable
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated

Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
2025-05-07 13:21:21 -07:00
Shamali Patwa
fce9328959 Merge "Log when a required attribute is missing in the AutoInstall layout." into main 2025-05-07 06:21:12 -07:00
Fengjiang Li
05f7f5596f [Memory Leak Test] Support toggle theme from LauncherInstrumentation
Bug: 394613048
Flag: NONE - test code
Test: NONE - this CL is infra for follow up test
Change-Id: Idfdcee20c14159509b2a9be005485b24a17dd372
2025-05-06 21:36:31 +00:00
Treehugger Robot
0b0dd2683a Merge "Reparse all grids for secondary displays for DP" into main 2025-05-06 13:03:00 -07:00
Sunny Goyal
53cc9a7806 Merge "Moving predicted items to ItemIdMap instead of extraItems" into main 2025-05-06 10:29:39 -07:00