- Only IDP is updated when displayInfo changes but DPs of CD don't. As
a result taskbars on CD end up reusing the old config DPs. For
example, when user changes display size, displayInfo updates but
taskbars on CD continue using old DP resources.
- So, update DP for CD when DisplayInfo changes.
- Also added using supplied context with dpToPx for calculating radius
for taskbar roundedness at the ends.
Fix: 414933860
Test: m
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: I7d8ed3c5ba69b755a58d3462a5da9ed7fd404198
That test can continue running in the "Time-limited test" thread,
and we don't know whether it makes sense to wait for its completion.
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: I3bdd6e5b07f109124f938766b7f2e427d2e39b01
TaskbarRecentAppsController#reloadRecentTasksIfNeeded() triggers a call
to fetch Recents tasks, that call is expensive as it goes through WM
Shell and the system server. If we trigger reloadRecentTasksIfNeeded()
multiple times we're queueing up multiple calls to fetch Recents tasks.
With this CL we avoid queueing up multiple calls, and instead just make
one new call when the old one finishes. That way we can only ever have
one call getRecentTasks() call triggered through
reloadRecentTasksIfNeeded() posted at any one time.
Bug: 415090968
Flag: com.android.window.flags.enable_taskbar_recent_tasks_throttle_bugfix
Test: TaskbarRecentAppsControllerTest
Change-Id: I58b66e4564af4e64837317a9de7be398395d8568
Revert submission 33554447-b/414789280
Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.
Fix: 417614196
Reverted changes: /q/submissionid:33554447-b/414789280
Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
Added controller that would handles drags of launcher icons to the
bubble bar, displaying drop targets and creating application bubbles.
Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: build launcher
Change-Id: I593222d86f50248ceb2909ae73ccc021ef515e28
* changes:
Filter out DEFAULT_DISPLAY from Taskbar unit tests.
Refactor test dagger graph to stub PerDisplayRepository instances.
Only use mockito-kotlin in SandboxApplication.
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
Note: before this change, triggering overview keyboard (KB) shortcut at lock screen would result in the overview shown after the screen is unlocked. This behavior is counter-intuitive. And thus, this change will discard overview KB shortcut at lock screen regardless if an external display is connected,
Flag: EXEMPTED minor bug fix
Test: manually trigger overview KB shortcut at lockscreen in both the default & connected display. Observed that no overview is shown at lock screen and after unlock.
Test: manually trigger overview KB shortcut after lockscreen in both the default & connected display. Observed that the overview is shown at the focused display.
Test: atest NexusLauncherTests:RecentsAnimationDeviceState
Bug: 415040428
Change-Id: Ia585b7b62e5f8de5be6d7cda9ad24760398ca37a
Updates few autostashing related conditions to use
`isTaskbarShowingDesktopApps()` instead of `isInDesktopMode()`, as the
former covers the case where the desktop flavour taskbar is shown
consistently (on desktop devices).
Bug: 390665752
Bug: 415991381
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: On desktop device, verify that "Always show taskbar" is shown on
home/in overview/in app outside desktop mode, and verify that the popup
value shown is consistent with the value in desktop mode. Verify
that taskbar does not get auto-stashed on home, even if "Always
show Taskbar" value is false.
Change-Id: I4edfe20f5526210fdf767231d0906875fe04f806
Handle go home and go back to previous screen for overview, split and full screen task
Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.systemui.shared.cursor_hot_corner
Change-Id: Ia928f102df6908058c02949db02a73430cea5ef1
The Desktop shortcut should only be shown if the task is on a display
that can host a desktop.
Bug: 405181230
Test: atest DesktopSystemShortcutTest
Test: Manual
Flag: EXEMPT (bug fix)
Change-Id: I4639aade4c3640a3c60b85e08981cbe46974df38
All Taskbars are inflated on VirtualDisplays. We should ignore
DEFAULT_DISPLAY.
Flag: TEST_ONLY
Bug: 415326979
Test: Taskbar tests
Change-Id: If6700929840552001a8b16fa969003f2c21b3cfe
These are not being used yet in Taskbar, but they are hardcoding
DEFAULT_DISPLAY for the primary ID. In tests, we want the primary to be
considered the ID of the virtual display tests are running on.
This change also moves dagger classes to its own file for organization.
Flag: TEST_ONLY
Bug: 415326979
Test: Taskbar multivalent tests
Change-Id: Ibd0cdf46bc53dbd7a3dd5f34d7171d9a6cdebb38
* changes:
Add support for save app pairs to recents in window
Update RecentsView to allow re-apply load plan
Update AbstractQuickStepTest to check non-recents states correctly
If the recents view is not attached to window when reloadIfNeeded is called, then mTaskListChangeId will be set, but applyLoadPlan will exit early without actually applying the loaded tasks. This is an issue since the recents list will remain outdated until the task stack changes. This has been causing issues in tapl tests with recents window enabled. Delaying the setting of mAppliedTaskListChangeId until the end of applyLoadPlan to fix this.
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: TaplTestsQuickstep.testDismissLastGridRow
Change-Id: Iaa8441a74b54f86167a7963b0005c044f355d94e
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
This feature aims to work only for desktop mode. Add a check to
the desktop state when checking the aconfig feature flag.
Bug: 375648361
Test: EXEMPT flag update
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I19eb17d756f17892637bd303464748b505c89190
Note: enableOverviewOnConnectedDisplays must be true to enable the
functionality (taskbar button --> home) in the first place
Bug: 378443899
Test: m
Flag: com.android.window.flags.enable_reject_home_transition
Change-Id: Icf5e5939c8e4f59a7d87c30df0d74a151bdbd1d5
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated
Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
testOverviewForTablet was ignored for over a year and other tests cover
most of the test cases of the original test so removing
Add separate tests for grid re-balancing
Fix: 315376057
Flag: EXEMPT. Test
Test: TaplTestsQuickstep
Change-Id: I33016ccdb68b1c2039c626a6d32821de71509506
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s
Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
