Commit Graph

2287 Commits

Author SHA1 Message Date
Sunny Goyal
bb0f554148 Converting StatsLogManager to kotlin
This is make it easier to create factory classes for individual when adding more injected parameters

Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
2025-05-28 14:12:13 -07:00
Liran Binyamin
63850c4a1d Merge "Deflake BubbleBarViewScreenshotTest" into main 2025-05-28 13:17:10 -07:00
Liran Binyamin
f53c72b4ed Deflake BubbleBarViewScreenshotTest
Suppress animation to avoid flakes

Fix: 416207075
Flag: EXEMPT test only
Test: atest BubbleBarViewScreenshotTest
Change-Id: I6e3c6105cef4a5d74567de91de75e8bec7609b3c
2025-05-28 13:16:50 -07:00
Vadim Tryshev
f3112aea02 Removing ViewCaptureRule
Bug: 315482167
Flag: EXEMPT test fix
Test: presubmit
Change-Id: If60412dcec9614fefe897e766395660acb8fa4f8
2025-05-28 11:53:07 -07:00
Xiaoqian (Daisy) Dai
f767b504bf Merge "desktop-exploded-view: truncate the task header app title if it overflows" into main 2025-05-28 10:47:36 -07:00
Jagrut Desai
bcd634a31f Fix Settting Cache NPE
Test: Presubmit
Bug: 406906811
Flag: EXEMPT bugfix
Change-Id: If2dacf2686339a0c8b9e87fdd9a8e555a813aab1
2025-05-28 09:55:39 -07:00
Treehugger Robot
ccf83ca310 Merge "Remove screen record" into main 2025-05-28 09:34:23 -07:00
Pat Manning
a96d9ce82c Merge "Removing screen record annotations." into main 2025-05-28 07:21:28 -07:00
Alex Chau
b1eef72619 Remove screen record
Bug: 407406547
Test: N\A
Flag: EXEMPT test only

Change-Id: Ic413e82d506286ad0799025d4ea1904124bf534f
2025-05-28 15:02:51 +01:00
Pat Manning
f8a374e02d Removing screen record annotations.
Fix: 415773066
Fix: 412766455
Test: Manual.
Flag: EXEMPT cleanup.
Change-Id: I83b77d1d105f9c467fbb256d8d42cdd9e16b2332
2025-05-28 12:18:22 +01:00
Simon (Qiong) Sun
be9eea8f23 Merge "Support multiple tasks per split screen via SplitRemoteTargetHandles" into main 2025-05-27 18:11:37 -07:00
Treehugger Robot
97594d1e94 Merge "Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy" into main 2025-05-27 11:45:32 -07:00
Schneider Victor-Tulias
8f88cb272d Unregister AbsSwipeUpHandler's ContextInitListener on launcher destroy
- Unregister the init listener on launcher destroy to unblock the home button
- This also exposes a crash in AbsSwipeUpHandler.onRecentsAnimation start since the home bounds aren't available. So, also adding handling to reload the launcher on night mode change

Flag: EXEMPT bug fix
Fixes: 384423890
Fixes: 416536400
Test: changed dark theme then swiped/pressed home and overview buttons.
Change-Id: Ic26192e8d0e4e6b226fb9af6dba596aa78a09e96
2025-05-27 11:39:53 -07:00
Xiaoqian (Daisy) Dai
d108ef020b Merge "desktop-exploded-view: Fix various values for Task windows in desktop tile." into main 2025-05-27 09:25:51 -07:00
Saumya Prakash
a272ff81ad Merge "Report lower insets for SUW if expressive theme enabled" into main 2025-05-27 08:57:52 -07:00
Treehugger Robot
d5b20e3940 Merge "Add recents animation start timeout handling to TaskAnimationManager" into main 2025-05-23 19:10:36 -07:00
Treehugger Robot
52608ce7cb Merge "pin-shortcut: Use unpin option for AllApps apps that are pinned" into main 2025-05-23 18:27:54 -07:00
Wen-Chien Wang
9942721299 pin-shortcut: Use unpin option for AllApps apps that are pinned
For the apps in All apps view, if the app is already pinned in the
taskbar, we should show the unpin option for users to unpin it
instead of a pin option that is no-op.

Bug: 375648361
Bug: 418058610
Test: manual + TaskbarPopupControllerTest
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I770afcf3abd6cb08c574230d27c4cbcbb83b29a6
2025-05-23 23:00:30 +00:00
Xiaoqian (Daisy) Dai
a66268c9fc desktop-exploded-view: Fix various values for Task windows in desktop tile.
To match with the UX spec, this CL updates the insets based on the
number of tasks within a tile. It also sets a maximum height to the
task window when multiple apps are available.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: OrganizeDesktopTasksUseCaseTest
Bug: 414614454
Change-Id: Icfecc1e41dfd0b95bae10b495adae95fe10dfef2
2025-05-23 14:09:05 -07:00
Sebastián Franco
e1d31e5406 Revert "Revert "Moving DeviceProfile properties into DevicePrope..."
Revert submission 33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Reason for revert: Error is fixed

Reverted changes: /q/submissionid:33716851-revert-33672643-DataDeviceProfile1-XHYRAPLEBK

Change-Id: Ib86824134955903c11e51e52dbfd6368aba1cd50
2025-05-23 14:08:11 -07:00
Priyanka Advani (xWF)
7705e92d93 Revert "Moving DeviceProfile properties into DeviceProperties da..."
Revert submission 33672643-DataDeviceProfile1

Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.

Fix: 419867875

Reverted changes: /q/submissionid:33672643-DataDeviceProfile1

Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
2025-05-23 13:53:04 -07:00
Saumya Prakash
7adea11bfa Report lower insets for SUW if expressive theme enabled
This change addresses the desire to lower the footer for SUW content if
the expressive theme is enabled in SUW. This would remove the extra gap
at the bottom of the screen.

Fix: 409897759
Test: Enable expressive theme and relaunch SUW. Check that the bottom
buttons are closer to the bottom edge of the screen.
Flag: EXEMPT bugfix

Change-Id: I7a4961549ec888e57c89a564028843f1e8c0000b
2025-05-23 20:06:14 +00:00
Sebastian Franco
e1111e28c2 Moving DeviceProfile properties into DeviceProperties data class
Bug: 419264653
Flag: EXEMPT refactor
Test: DeviceProfileDumpTest
Test: All Image tests
Change-Id: I638f88cd76b926917965dbf9e70b5bdfff5971e0
2025-05-23 10:42:26 -07:00
Sebastián Franco
48e7365190 Merge "Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity" into main 2025-05-23 09:16:49 -07:00
Helen Cheuk
73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Sergey Pinkevich
6e0ace619f Merge "Convert DesktopVisibilityControllerTest to multivalent" into main 2025-05-23 01:56:12 -07:00
Rob Mickle
56ddb0a6ac Merge "Update test to use fake repository instead of mock." into main 2025-05-22 14:58:46 -07:00
Sebastian Franco
1fcb21621b Removing getOnceNotNull from BaseLauncherActivityTest to launcherActivity
This is to make tests by composition instead of inheritance.

Bug: 324261526
Flag: EXEMPT test only
Test: All test using BaseLauncherActivityTest
Change-Id: I616207da890e1979480d1b748f69a9c27c53f9db
2025-05-22 12:06:25 -07:00
Schneider Victor-Tulias
9705f8fefa Update TestLauncherActivity to send TAPL launcher stopped message
This removes the need for a workaround in LauncherInstrumentation.executeAndWaitForLauncherStop for FallbackRecentsTests with recents window enabled

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: FallbackRecentsTest
Change-Id: I1b974cb2bfff4c14e99abb96c35dcdff04ed0be7
2025-05-22 09:01:14 -07:00
Rob Mickle
61aab4893b Update test to use fake repository instead of mock.
Bug: 378443899
Test: OverviewCommandHelperTest
Flag: EXEMPT test cleanup up
Change-Id: Ie449a659bf6b1b33acbb6f9f6f45b800e31cf447
2025-05-22 07:42:34 -07:00
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Lucas Dupin
66923a912c Merge "Add recents position callback to SystemUiProxy" into main 2025-05-21 23:11:59 -07:00
Treehugger Robot
091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Toni Barzic
83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Lucas Dupin
02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
Xiaoqian (Daisy) Dai
7e21181997 desktop-exploded-view: truncate the task header app title if it overflows
A long app title can cause the close button to be covered.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413387821
Change-Id: Id66cabb271ac6f4772969335232e3e9638828571
2025-05-21 20:13:53 +00:00
Schneider Victor-Tulias
124b010ea9 Add recents animation start timeout handling to TaskAnimationManager
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.

Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
2025-05-21 15:55:44 -04:00
Sergey Pinkevich
d0fccf8773 Convert DesktopVisibilityControllerTest to multivalent
Bug: 397902030
Flag: NONE test fix, not actual code editing
Test: atest NexusLauncherTests:DesktopVisibilityControllerTest

Change-Id: Ie6ae4abb2a894d4f7403e77cf797cdce924fd9e3
2025-05-21 18:50:43 +00:00
Simon (Qiong) Sun
00063bcf2f Support multiple tasks per split screen via SplitRemoteTargetHandles
It enables support for assigning SplitRemoteTargetHandles to multiple tasks within a split-screen.

The changes include:

- Retrieving the list of split-screen tasks directly from `SplitBounds`.
- Iterating through the task list and setting the remoteTargetHandle for each individual task.
- General code refactoring to set the remoteTargetHandle.

Bug: 346295292
Bug: 360782849
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: manual test.
Video: Before: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/fnHVbaVwMWfvrOaez5eO6L
Video: After: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/dzv6tZMlAYG1bBBtYdsWxF

Change-Id: I1e8c8316947b0d4fd72c9cf36dff8ecd99d2f170
2025-05-21 17:51:09 +00:00
Helen Cheuk
444161df77 Merge "[Action Corner] Make home action corner irreversible" into main 2025-05-21 09:13:31 -07:00
helen cheuk
9598e4c78c [Action Corner] Make home action corner irreversible
The go home action for action corner should be irreversible for now.
When home action corner is triggered at homepage, it should just stay at homepage and would not go back to previous task.
Add flag for the reversible behavior for non-desktop mode home action corner. It is to be completed with dekstop mode in later release.

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.launcher3.enable_reversible_home_action_corner
Change-Id: Ib36581d0d3d81d4a7ff8f8d6265d8d5d5f5872fd
2025-05-21 14:26:01 +01:00
Pierre Barbier de Reuille
4ad6e804ec Merge "Create a flag to enable the desktop menu entry on Overview when ready" into main 2025-05-20 15:28:02 -07:00
Treehugger Robot
27312fa26d Merge "Prevent adding duplicate TaskAnimationManager launcher destroyed callbacks" into main 2025-05-20 15:22:24 -07:00
Pierre Barbier de Reuille
933c5324d0 Create a flag to enable the desktop menu entry on Overview when ready
Bug: 418822736
Flag: com.android.launcher3.enable_desktop_menu_on_secondary_display_bugfix
Test: atest DesktopSystemShortcutTest
Change-Id: I55b6493165f5307d3c247bb604441b093d5e8e9d
2025-05-20 15:55:41 +01:00
Alex Chau
13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Mykola Podolian
9e4b44afcd Merge changes from topic "remove_ipc" into main
* changes:
  [5/5] Removed unused IPC call.
  [4/5] Cover DragToBubbleController with tests.
  [3/5] Implement DragToBubbleController.
  [2/5] Hook up DragToBubbleController and prepare launcher to use it.
  [1/5] Added DragToBubbleController
2025-05-16 16:01:03 -07:00
Vadim Tryshev
a3e63d1e20 Merge "Skip all tests after a test times out" into main 2025-05-16 14:06:56 -07:00
Schneider Victor-Tulias
2e6148a430 Prevent adding duplicate TaskAnimationManager launcher destroyed callbacks
Flag: EXEMPT code cleanup
Bug: 416536400
Test: TaskAnimationManagerTest; ran test with and without change
Change-Id: I8bdee3adeeca07e386f3058910d5e2160359f7e9
2025-05-16 15:40:46 -04:00
mpodolian
8499319bc2 [4/5] Cover DragToBubbleController with tests.
Implement tests that check DragToBubbleController public API

Bug: 411506181
Flag: com.android.wm.shell.enable_create_any_bubble
Test: DragToBubbleController.kt
Change-Id: I48fe5f45921fbedbe0f1921dfd21e9ecb14406bc
2025-05-16 11:33:52 -07:00
Alex Chau
557d8e6d7f Reland "Recreate Launcher activity when blur enabled changes"
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Reland fix:
- Removed mBlursEnabled in BaseDepthController, and only use `mCrossWindowBlursEnabled` to control swapping between blur style and fallback style
- Temporary variables like `mPauseBlurs` and `hasOpaqueBg` should only affect if blurs are applied, but not result in swapping of blur style, otherwise this cause unnecessary redraw or activity recreate

Reason for revert: reland
Reverted changes: /q/submissionid:33581402-revert-33554447-b/414789280-CTVRJLPLRT
Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Test: PressBackFromLaunchedApp.testPressBackFromLaunchedApp
Flag: EXEMPT bugfix

Change-Id: Iac2b0c00811e0e79684da0cf77df76a120c1272a
2025-05-16 12:33:44 +01:00