Commit Graph

49869 Commits

Author SHA1 Message Date
Vinit Nayak
f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Alex Chau
bebeefe993 Merge "Reduce icon/text simultaneously when cellHeight is not enough for largest display size" into tm-qpr-dev 2023-01-13 00:57:04 +00:00
Jeremy Sim
9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk
1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk
984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
Christophe Pinelli
3cd6cbe6b4 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev 2023-01-12 18:15:31 +00:00
Ats Jenk
ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot
944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Luca Zuccarini
51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Vinit Nayak
1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Fengjiang Li
e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian
bf69ef034a Merge "Rename LoaderResults to LauncherBinder." into tm-qpr-dev 2023-01-11 22:47:34 +00:00
Stefan Andonian
fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Sunny Goyal
96bfea9d32 Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev 2023-01-11 22:32:01 +00:00
Stefan Andonian
e82476ad3b Rename LoaderResults to LauncherBinder.
LoaderResults implies a data object, not binding code specific to
Launcher UX containers. This CL merely renames this class and its
usages. It also adds a comment that explains why the functionality is
split into a base class and an implementing class.

Bug: 251502424
Test: Compilation worked correctly.
Change-Id: I01b5ac2f717e9b20612538d5c1e0ca947beb593f
2023-01-11 20:32:25 +00:00
Stefan Andonian
2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Jagrut Desai
50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang
d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Jeremy Sim
5f8dd20236 Fix transition animations for launch-from-staged operation
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
2023-01-10 15:44:23 -08:00
Jagrut Desai
4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai
ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel.
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
2023-01-10 22:57:35 +00:00
Ats Jenk
774f05226b Hide DesktopTaskView background while animating
While animating DesktopTaskView to/from fullscreen, hide the background.
Background should only show up when this taskview is shown in recents.
While it is animating, we don't need to show it.

Bug: 263264985
Test: manual, trigger transient taskbar, observe that background does
not flicker

Change-Id: I76d0eb1857645b7f04a0b2e1eebe2393c252c257
2023-01-10 11:39:17 -08:00
Sunny Goyal
5fe99d560e Fetching the session info on the background thread when launching pening icon
Bug: 242669604
Test: Verified that the RPC is not made on UI thread
Change-Id: I4299628b8b3e9aa2844f5556c57f47d997dd85e1
2023-01-10 11:02:58 -08:00
Alex Chau
616de308b7 Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev 2023-01-10 18:34:08 +00:00
Alex Chau
06f36e8568 Reduce icon/text simultaneously when cellHeight is not enough for largest display size
- Follow-up of http://ag/20691430
- Reduce iconDrawablePaddingPx to further recover space
- Then proportional reduce both iconSizePx and iconTextSizePx
- This will result in larger icon/text size in px when going from larger to largest for most devices
- For extremely large desnity (> largest for most devices), iconSizePx/iconTextSizePx will inevitably reduce due to smaller availalbe space

Fix: 264149604
Test: test different density between larger and largest, check that icon/text size continues to grow in px
Change-Id: I1633566b9372acf1393c7e997598cb3e46c4a507
2023-01-10 18:11:59 +00:00
Ats Jenk
83a8dad319 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev 2023-01-10 18:09:16 +00:00
Luca Zuccarini
fb4429f0b0 Revert^2 "Update timings for the Home <> All Apps transition."
e18ac479e5

Change-Id: Id09987b2c67be70e62349574973d4bc62b10bc9d
Bug: 263221786
2023-01-10 17:05:29 +00:00
Shan Huang
f43527d5df Merge "DO NOT MERGE Rename BackEvent to BackMotionEvent in LauncherBackAnimationController." into tm-qpr-dev 2023-01-10 16:46:55 +00:00
Thales Lima
bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Luca Zuccarini
d23cd42875 Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev 2023-01-10 13:50:50 +00:00
Thales Lima
03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Sebastián Franco
b66293e96d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev 2023-01-09 23:20:51 +00:00
Sebastian Franco
1cf1e3b025 Removing screen recording for testShortcutIconWithTheme
Bug: 260722220
Test: compiles
Change-Id: I7f5ac09bc7e9deb9af3e90dbd99826bb8c4db11f
2023-01-09 14:19:14 -06:00
Jagrut Desai
d8ea04a7f6 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev 2023-01-09 16:19:04 +00:00
Alex Chau
04658bcd42 Add debug logs for hotseat disapperaed bug
Bug: 260135164
Test: manual
Change-Id: Ic911ba0353b742feb753024543ca19930f11b47d
2023-01-09 12:43:16 +00:00
Vinit Nayak
72b186aefd Merge "Improves overview split adjacent launch animation" into tm-qpr-dev 2023-01-07 00:36:16 +00:00
TreeHugger Robot
2f4a1b9980 Merge "Re-enable AddConfigWidgetTest" into tm-qpr-dev 2023-01-06 21:34:05 +00:00
Schneider Victor-tulias
53808c3ed8 Merge "Fix NPE from getting swipe pip to home animator finish transation after the surface has been released" into tm-qpr-dev 2023-01-06 18:38:21 +00:00
Sebastian Franco
f34f35fddb Printing the workspace items to improve flake investigation.
Recording the screen to investigates flakes on ReorderWidgets
is really useful but it requires changing the code for that and
storing the video and most of the time the useful information
is just the end state so by logging the end state makes resolving
flakes easier

Fix: 261877803
Test: atest ReorderWidgets
Change-Id: If5d9745ebb57826a55b5df9d3599eed56c48298f
2023-01-06 12:29:11 -06:00
Bill Yi
a01abba905 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-01-06 18:19:10 +00:00
Sunny Goyal
3da648a80b Merge "Fixing work tab is not updated when work-mode changes" into tm-qpr-dev 2023-01-06 18:11:15 +00:00
Wei Sheng Shih
485c8777cc Merge "[ShellTransit] Stabilize QuickSwitch test since Launcher can resumed." into tm-qpr-dev 2023-01-06 03:27:56 +00:00
Bill Yi
6f5ae3635d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I75ef387d8a3b8da1239b8ca39372a75a77435acd
2023-01-05 17:41:08 -08:00
Brandon Dayauon
bae7e704a4 Merge "Add logging to work mode switch" into tm-qpr-dev 2023-01-05 23:21:35 +00:00
Sunny Goyal
3c2ee27a01 Fixing work tab is not updated when work-mode changes
Bug: 263399769
Test: Verified on device
Change-Id: I94d8f20bc70f2299d11d539d4821ba7e13253522
2023-01-05 14:53:28 -08:00
Vinit Nayak
daffdfa35c Merge "Toggle taskbar button nav assistant availability" into tm-qpr-dev 2023-01-05 21:28:23 +00:00
TreeHugger Robot
1973056e40 Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev 2023-01-05 20:04:07 +00:00
TreeHugger Robot
5b860ca3ed Merge "Re-enable the fast scroll in widget picker" into tm-qpr-dev 2023-01-05 19:55:51 +00:00
Vinit Nayak
da2819ed5f Improves overview split adjacent launch animation
* Translation gets scaled along with the parent,
so the secondary thumbnailView which has a translate on
it gets exaggerated as the parent goes to fullscreen
scale.
* Now we inversely scale translationX/Y properties,
however it seems like the interpolation is still slighly
off at the beginning of the animation (or maybe some other
value, such as pivot, etc)

Bug: 260814999
Test: Manually slowed down animation and observed
Change-Id: I831476b4ffb582fecbd166525ceea33623e66bdd
Merged-In: I831476b4ffb582fecbd166525ceea33623e66bdd
2023-01-05 11:54:22 -08:00