Commit Graph

62452 Commits

Author SHA1 Message Date
Brandon Dayauon
df4dfdba4d Update tests for ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH
PM said we can enable ENABLE_TWOLINE_ALLAPPS and ENABLE_TWOLINE_DEVICESEARCH flags.

Since I am enabling two-line text for all apps, it's possible that the text would have other texts within the app name itself. For example, if a title of an app is long for example "Amazon Shopping" the title can now be like "Amazon\nShopping". For tests to recognize its "Amazon shopping", I am resorting to identifying the app title based on the content description.

Turn on the two feature flags in another CL

bug: 287307252
test: manual
Change-Id: I8bdc3db710514c9098ccb5d9781a100ac9b35eab
2023-07-21 20:15:19 +00:00
Jeremy Sim
3ce64d592b Merge "Add unit tests for SplitSelectDataHolder" into udc-qpr-dev 2023-07-14 17:26:00 +00:00
TreeHugger Robot
fee828cd6c Merge "Enabling view capture analysis in Launcher tests." into udc-qpr-dev 2023-07-14 17:23:05 +00:00
Vadim Tryshev
baef466f61 Enabling view capture analysis in Launcher tests.
For now, only Alpha Jumps detector is implemented. The test will fail if
an alpha jump is detected.

The ignore-list for alpha jump detection ended up being uncomfortably
long, I plan dealing with this immediately after landing this CL.

Bug: 286251603
Test: presubmit, forrest
Flag: N/A
Change-Id: I3f44b02015e2ce93eb8b4071becbc44b36416459
2023-07-13 17:34:57 -07:00
Jeremy Sim
a8690f5eb6 Add unit tests for SplitSelectDataHolder
This CL adds unit tests for the SplitSelectDataHolder class.

Fixes: 288318661
Test: None
Change-Id: Ia09b928be1c73dcf8a198ea5ece16f0557fb5b0d
2023-07-13 15:28:04 -07:00
Treehugger Robot
3396b5c338 Merge "Creating a correctly populated mOccupied grid when reordering on foldables" into udc-qpr-dev 2023-07-13 20:31:37 +00:00
Tracy Zhou
d7496cb52b Merge "Fix testAllAppsFromHome failure" into udc-qpr-dev 2023-07-13 20:18:56 +00:00
Becky Qiu
5bcd1ca3d6 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373 am: 64746f8a29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I9f00b40302eba3683f2260f5efa5e5dbc3566f38
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 20:09:01 +00:00
Becky Qiu
64746f8a29 Fix the issue that on tablet/unfold, the allapps background color is wrong. am: aa6612d373
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24030571

Change-Id: I513daa1fdeb8d5582bd0cec9b8b2eb4d043f2543
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 19:02:27 +00:00
Tracy Zhou
29deae51ee Fix testAllAppsFromHome failure
Fixes: 291072758
Test: presubmit
Change-Id: If2cd0d5d67ab5b2b4b6ca918b6e7a8777ee9f030
2023-07-13 09:52:42 -07:00
Sunny Goyal
fc681dbe09 Merge "Adding some utility test rules" into udc-qpr-dev 2023-07-13 15:30:50 +00:00
Anushree Ganjam
e1a4eb4a09 Merge "Introduce Default Ime height." into udc-qpr-dev 2023-07-13 06:23:28 +00:00
Tracy Zhou
666c3b231d Merge "Introduce multi finger trackpad gestures to tapl tests" into udc-qpr-dev 2023-07-13 06:11:26 +00:00
Tracy Zhou
db476c3921 Introduce multi finger trackpad gestures to tapl tests
- Add tests to go to overview from home and all apps

Bug: 281732733
Test: presubmit
Change-Id: Ief6d72d7293ca7dff935e764362aa5ab271fd36b
2023-07-12 19:52:04 -07:00
Mady Mellor
d76c9cbcd7 Merge "Revert "Bubble bar drag to dismiss"" into udc-qpr-dev 2023-07-13 01:38:05 +00:00
Winson Chung
7d58acf943 Merge "Remove legacy unused proto tracing code to prevent confusion" into udc-qpr-dev 2023-07-12 23:50:53 +00:00
Treehugger Robot
a5af8b4276 Merge "Fix inability to remove or interact with folder when removing 2nd item from folder" into udc-qpr-dev 2023-07-12 23:17:30 +00:00
Mady Mellor
e7cc3997d0 Revert "Bubble bar drag to dismiss"
Revert submission 23879277-bubble_bar_dismiss

Reason for revert: issues with touch

Reverted changes: /q/submissionid:23879277-bubble_bar_dismiss

Change-Id: I4311abff0e542907b09b0aa865d68257b47f6af1
2023-07-12 22:27:17 +00:00
fbaron
5a7ea3069b Fix inability to remove or interact with folder when removing 2nd item from folder
Fix: 289960317
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon out of folder lets you open the app that remains where the folder was
Test: Verify in unfolded felix that going from 2 icon folder and dragging 2nd icon into remove droptarget removes the folder and turns it into a single clickable icon
flag: no flag
Change-Id: I26138ee9f8e7cdb45cafe2446dc4d1e3d6d8347f
2023-07-12 14:15:00 -07:00
Vinit Nayak
cf6b71a14e Merge "Allow pressing home button on recents if command queue not empty" into udc-qpr-dev 2023-07-12 20:58:59 +00:00
Vinit Nayak
f909a72f3f Merge "Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag" into udc-qpr-dev 2023-07-12 20:57:22 +00:00
Sebastian Franco
1c5514b566 Creating a correctly populated mOccupied grid when reordering on foldables
On ag/21680045 I copy the previous mOccupied but the right thing to do is to
create a new one with all the views information.

Some test stoped running inadvertently that's why we didn't catch this issue.

There is a separate cl with the test to ensure we can catch it later on.

Fix: 289584301
Test: ReorderWidgets
Change-Id: I27b5a6e38a556d1c73ff8fbbdd552da6045e5b64
2023-07-12 13:52:54 -07:00
Fengjiang Li
30b9bc7587 Merge "Recreate hotseat predictor whenever we query it due to workspace change" into udc-qpr-dev 2023-07-12 20:12:06 +00:00
Liran Binyamin
d0121222a5 Merge "Check that the bubble bar has bubbles before showing it" into udc-qpr-dev 2023-07-12 19:58:16 +00:00
Thales Lima
735b18ba4c Merge "Fix responsive folders" into udc-qpr-dev 2023-07-12 17:33:55 +00:00
Anushree Ganjam
5730f03c9f Introduce Default Ime height.
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
2023-07-12 17:21:40 +00:00
Ivan Tkachenko
e3d4a69749 Merge "Bubble bar drag to dismiss" into udc-qpr-dev 2023-07-12 17:13:50 +00:00
Fengjiang Li
ff15fbffec Recreate hotseat predictor whenever we query it due to workspace change
Fix: b/289013842
Test: unit test, also verified moving icons will recreate hotseat predictor
Change-Id: I1f19b17654b87156132a4e4dee26e12312589dba
2023-07-12 10:11:12 -07:00
Jordan Silva
511449fe9e Merge "Add function to update SysUiScrim duration for tests" into udc-qpr-dev 2023-07-12 16:43:43 +00:00
Liran Binyamin
1d7494b4a5 Check that the bubble bar has bubbles before showing it
ag/24024252 relied on the bubble bar being invisible to indicate that
the bar is empty. But that assumption was wrong. The bubble bar gets
hidden when the device is locked. The result is that unlocking the
device leaves the bubble bar stashed.

This change actually verifies whether the bubble bar is empty before
showing it.

Fixes: 290608658
Test: Manual:
      - Have some bubbles in the bar
      - Lock the device and unlock
      - Observe that the bubble bar is unstashed
Change-Id: I4ca5c10e0cec57d3c6b4e056e06ebcf04aa1571a
2023-07-12 12:36:25 -04:00
Brian Isganitis
69ac9b8169 Merge "Cleanup raw usage of AllAppsStore." into udc-qpr-dev 2023-07-12 16:31:11 +00:00
Liran Binyamin
7dd280eef3 Merge "Don't show the bubble bar when it is empty" into udc-qpr-dev 2023-07-12 15:09:21 +00:00
Liran Binyamin
2c1e84b3a1 Merge "Pass bubble bar offsets instead of position to WMShell" into udc-qpr-dev 2023-07-12 14:41:32 +00:00
Ivan Tkachenko
eceb797d2f Bubble bar drag to dismiss
* Added dismiss view to the taskbar
* Bubble drag to dismiss of:
  * A single bubble when the bubble bar stack is expanded
  * All bubbles when the bubble bar stack is colapsed
* Added dismiss related calls to WMShell in SystemUI through SystemUIProxy

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: Ibb62a0b1ab9fafa8a3acf07450ce2132ed605adc
2023-07-12 07:13:12 +01:00
Mady Mellor
db3cdd4e97 Merge changes from topic "mm_bubbleInfoFlags" into udc-qpr-dev
* changes:
  Show / hide the "update" dot on bubbles in bubble bar
  Handle any image / label changes for bubble updates in bubble bar
2023-07-12 01:00:10 +00:00
Becky Qiu
aa6612d373 Fix the issue that on tablet/unfold, the allapps background color is wrong.
As the new spec, it should use materialColorSurfaceDim for all devices.

Bug: 288493929
Test: manual, before: https://screenshot.googleplex.com/7YxpFGekwm6Gz6N, after: https://screenshot.googleplex.com/44Gr2dBfWSct7FK
Flag: no flag needed.
Change-Id: Ic33d9a758fe9fbaa0f735c874a545df711a18e2f
2023-07-12 00:25:58 +00:00
Vinit Nayak
46b2beea26 Cleanup ENABLE_SPLIT_FROM_WORKSPACE flag
Fixes: 270393906
Flag: none
Test: Compiles
Change-Id: I1431f544b26cef5cd417c9a5a97f183b49fe7adc
2023-07-11 17:05:17 -07:00
Vinit Nayak
64f3766ba7 Merge "Dismiss split select when tapping on home button" into udc-qpr-dev 2023-07-11 23:06:47 +00:00
Brian Isganitis
e9eacb38fa Cleanup raw usage of AllAppsStore.
Test: Compiles
Bug: 287523421
Flag: No
Change-Id: I35cdb1b281f251b74305129b583f29cdb29e15a6
2023-07-11 18:41:45 -04:00
Schneider Victor-tulias
19c22c20b2 Merge "Add debug tracing Launcher's lifecycle callbacks" into udc-qpr-dev 2023-07-11 22:35:53 +00:00
Mady Mellor
c299ad645a Show / hide the "update" dot on bubbles in bubble bar
Updates BubbleView to include logic to render the update dot on a
bubble. This only shows for BubbleBarBubbles, not the overflow.

We only show the dot (and the badge) when:
- the bubble has new content / appropriate flags set
- AND the bubbles are expanded
  OR on the first bubble when bubbles are collapsed
- AND when the flyout is not animating (this bit doesn't exist yet)

If a bubble has a dot and is opened, the dot will animate away.
To do this, we update the flags set on a bubble.

The flag needs to be set on WMShell side as well as Launcher side.
When a bubble is shown by WMShell, it automatically updates the flag.
This CL adds code to update the flag on Launcher side when we call
into WMShell to show the bubble.

Test: manual
Bug: 269670235
Change-Id: I32f652effa9a73c567981aa5a2a5864e9c3c0c66
2023-07-11 15:09:29 -07:00
Liran Binyamin
05ef774e6e Don't show the bubble bar when it is empty
Sometimes the bubble bar shows when the launcher process starts up
even when there are no bubbles.

bubblesShowingOnHome is set to true when the launcher transitions into
Home, but that state also triggers a call to showBubbleBar() which will
eventually set the visibility on the bar.
During initialization we also call setHiddenForNoBubbles to hide the bubble
bar if it's empty, but these events happen separately so the bar may or
may not be hidden.

This change avoids calling showBubbleBar when setBubblesShowingOnHome is
called and the bar is invisible. Instead the bubble bar will become visible
once bubbles are added.

Fixes: 290608658
Test: manual
       - Toggle bubbles off and back on in settings
       - Restart launcher
       - Observe the bubble bar is not displayed
Change-Id: I30640764d7b6eae64e1c5b5c687760465bf9a7b1
2023-07-11 17:12:00 -04:00
Liran Binyamin
1c03ed001d Pass bubble bar offsets instead of position to WMShell
This allows WMShell to calculate the position of the expanded view
correctly when the bubble bar is being expanded from stashed.

Test: See ag/24012908
Change-Id: I7b917e761c827135942d918917c920b06650f496
2023-07-11 17:08:09 -04:00
Jordan Silva
20d23f473a Add function to update SysUiScrim duration for tests
A new function was added to update the animation duration to 0 for testing.

Fix: 288392860
Test: HomeScreenFolderImageTest
Test: ResponsiveHomeScreenFolderImageTest
Flag: N/A
Change-Id: If0c9c169eb3339ae2940c88c57d69728ee844f71
2023-07-11 20:57:15 +00:00
Mady Mellor
1812924a53 Handle any image / label changes for bubble updates in bubble bar
When we get an update to a bubble it could mean that there's a new
message OR that something about the visual representation changed.

This CL modifies BubbleBarController to handle any visual changes
that might have occurred to an updated bubble (e.g. bubble image
changed).

It does this by updating the bubbleInfo on the existing bubble.

Test: manual
Bug: 269670235
Change-Id: I03d2510aef335dafccb32d6adcd4c6adf8b3297d
2023-07-11 13:34:46 -07:00
Mady Mellor
3e952e034c Merge "Unify calls to sysuiProxy#showBubble into one method" into udc-qpr-dev 2023-07-11 20:24:14 +00:00
Brian Isganitis
1a50287c08 Merge "Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""" into udc-qpr-dev 2023-07-11 19:39:07 +00:00
Brian Isganitis
f54c6fa4b4 Revert "Revert "Provide AllApps item OnLongClickListener through ActivityContext.""
This reverts commit 853a5b9e0c.

Fixes SecondaryDisplayLauncher class by using lambda instead of method
reference for #getAllAppsItemLongClickListener. This change is necessary
because mDragLayer is late-init.

Test: Home Settings > Developer Options > Launch Secondary Display
Bug: 289261756
Flag: No
Change-Id: I7b83f81651dde360edea6ee7bea6cc82441e6bef
2023-07-11 13:21:47 -04:00
Treehugger Robot
f69ebc04b0 Merge "Adding flag for use of ParametrizeReorderAlgorithm" into udc-qpr-dev 2023-07-11 17:15:34 +00:00
David Saff
aaf3094540 Merge "Revert "Provide AllApps item OnLongClickListener through ActivityContext."" into udc-qpr-dev 2023-07-11 12:32:36 +00:00