Commit Graph

3438 Commits

Author SHA1 Message Date
Cliff Wang
dd2222749b Merge "Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"" into main 2024-02-05 08:21:54 +00:00
Cliff Wang
ac82e995ca Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"
This reverts commit dd33b64a64.

Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.

Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
2024-02-05 04:46:17 +00:00
Vadim Tryshev
f9eced5768 Merge "Make sure TAPL waits for Launcher activity to stop each time it stops" into main 2024-02-03 02:33:53 +00:00
Vadim Tryshev
dd33b64a64 Make sure TAPL waits for Launcher activity to stop each time it stops
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.

We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
2024-02-02 15:21:20 -08:00
Vadim Tryshev
94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Vadim Tryshev
3f4401aa7e Merge "Adding text messages to some asserts in TaplAddConfigWidgetTest" into main 2024-02-02 18:21:35 +00:00
Sebastián Franco
fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00
Rohit Goyal
e807bdc26a Merge "UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled." into main 2024-02-02 08:37:49 +00:00
Fengjiang Li
2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Rohit Goyal
c475f22d8b UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Id9ba2ea833e8360ac8aa2c765beff402cff12ae2
2024-02-02 00:27:16 +00:00
Fengjiang Li
387fea9731 Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.

Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
2024-02-01 16:24:14 -08:00
Vadim Tryshev
1784a329e6 Adding text messages to some asserts in TaplAddConfigWidgetTest
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: Ia8164f60f49b377e41db72f97c4f90d167292574
2024-02-01 11:33:23 -08:00
Sebastian Franco
2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
David Saff
60379ac052 Merge "Assert keyguard gone at beginning and end of PortraitLandscapeRunner" into main 2024-02-01 00:15:39 +00:00
Shamali Patwa
bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Shamali Patwa
962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
David Saff
1121f8b5b9 Assert keyguard gone at beginning and end of PortraitLandscapeRunner
Should help distinguish if we have tests leaving things in a bad state,
or the intervening infrastructure.

Bug: 285935417
Change-Id: I5569472a9804cb21ee0646c72decb5f51be9ab01
2024-01-31 19:35:40 +00:00
Shamali Patwa
d3f5010ac5 Merge changes from topic "categories" into main
* changes:
  Add a default widget category provider that uses application category.
  Add a feature flag for displaying categorized widget recommendations.
2024-01-31 02:24:05 +00:00
Shamali P
c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Vadim Tryshev
a41fc4e4ad Merge "Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner" into main 2024-01-30 20:47:27 +00:00
Shamali P
6a9d114d40 Update OWNERS for picker directory to include new owners.
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.

Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
2024-01-30 20:10:24 +00:00
Sebastián Franco
ea73bf5d77 Merge "Removing the Worskapce as a dependency of CellLayout" into main 2024-01-30 02:19:19 +00:00
Shamali Patwa
279544e718 Merge "Add the testDragCustomShortcut back for phones." into main 2024-01-29 20:52:49 +00:00
Charlie Anderson
9147575693 Merge "Add unit tests to WorkspaceItemProcessor for processing apps" into main 2024-01-29 20:27:13 +00:00
Federico Baron
8960937d47 Merge "Fix testDragToFolder test" into main 2024-01-29 19:27:24 +00:00
Shamali P
458825a3fc Add the testDragCustomShortcut back for phones.
testDragCustomShortcut was ignored, but as discussed, enabling it for
phones - where the layout of picker is unchanged.

Bug: 322820039
Test: Un-ignoring the test
Flag: N/A
Change-Id: I3607812befc58c8a46b49a2587dfa6a1b572cd5b
2024-01-29 19:07:03 +00:00
Vadim Tryshev
9a94452dbc Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner
Bug: 285935417
Test: presubmit
Flag: N/A
Change-Id: I8c525b99e7dc434f0b68aad59a18908f4253b29b
2024-01-29 11:00:55 -08:00
Himanshu Gupta
ea9522eee5 Merge "Adding Test Parameters to Asserts." into main 2024-01-27 04:39:08 +00:00
Charlie Anderson
ca6f66cd88 Add unit tests to WorkspaceItemProcessor for processing apps
- also slightly improve some log messages and simplify some code

Test: presubmit / unit tests
Flag: None
Bug: 294386159
Change-Id: I6f75c0d34bf475d4e20d6250f67a56d5394b9c4e
2024-01-26 15:42:51 -06:00
Sebastian Franco
2986e0b4d1 Removing the Worskapce as a dependency of CellLayout
This will make it easier to test CellLayout, also we should avoid
circular dependencies as much as poisble.

This also allows the CellLayout to be created in other containers
that are not workspace.

Bug: 318417510
Test: creating HotseatReorderUnitTest in follow up cl
Test: TaplReorderWidgets
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ic45029a244cb11f8d6775c50b90af9c56f01eaa3
2024-01-26 09:28:57 -08:00
Himanshu Gupta
39d87bf229 Adding Test Parameters to Asserts.
Bug: 320703862
Flag: NA
Test: NA
Change-Id: I1dba86e3a24dc5b67c754087deca8794a38d83a0
2024-01-26 20:23:42 +05:30
Himanshu Gupta
eaeb666e43 Merge "Separating system and user-installed apps in PS container." into main 2024-01-26 14:22:19 +00:00
Jakob Schneider
fc433dd84d Merge "Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests." into main 2024-01-26 10:48:09 +00:00
Himanshu Gupta
0cc11dbcac Separating system and user-installed apps in PS container.
We add a horizontal line separator in PS container which demarcates
user-installed vs system installed apps in private space.
User-installed are shown above the separator, system ones below.

UX Mock: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?node-id=11546%3A310574&mode=dev
Mock Image: https://photos.app.goo.gl/Wj8sJkS7P7bRbovg8
Demo video: https://photos.app.goo.gl/MBw6HpDnf6PJqUfs8

Bug: 308054233
Flag: ACONFIG com.android.launcher3.Flags.private_space_sys_apps_separation DEVELOPMENT
Test: AlphabeticalAppsListTest
Change-Id: Iad8e289c49a05ac7ef1978bd8e4ebe7aa0add0ca
2024-01-26 11:04:13 +05:30
Colin Cross
698a721de6 Merge "Set use_resource_processor: false" into main 2024-01-25 19:10:21 +00:00
Rohit Goyal
9977121e8e Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests.
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
2024-01-26 00:40:17 +05:30
fbaron
9a16ca5215 Fix testDragToFolder test
The issue seems to be that when we begin drag we enter spring loaded mode which triggers the 'app swap' interaction, leading us to getting the wrong position for the app icon we're trying to drag into. Using photos app instead of gmail should make it so that we don't enter the app swap operation with playstore, meaning we would get the correct position for play store and we will drag the app there

Fix: 320484402
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: Id6f09be997046e7c450a2760ee95cc5735ad5673
2024-01-25 10:55:27 -08:00
Sebastián Franco
a808e7ea98 Merge "Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin." into main 2024-01-25 17:16:25 +00:00
Himanshu Gupta
d9026196d2 Merge "Restricting Accessibility flows for Private Profile." into main 2024-01-25 04:19:35 +00:00
Himanshu Gupta
f591ce5f17 Restricting Accessibility flows for Private Profile.
Adding PS apps to the home screen is restricted.
This CL prevents the same from accessibility drags.

Bug: 289223923
Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_accessibility_drag DEVELOPEMENT
Test: Ran Launcher3 Tests.
Change-Id: I3e2b7b196b96a4d2ba34d8ece5fd6e0463f17253
2024-01-25 04:19:20 +00:00
Colin Cross
f156b6bc7c Set use_resource_processor: false
These modules fail to compile when use_resource_processor is enabled
by default, disable them explicitly for now.

Bug: 319712088
Test: m javac-check
Flag: NA
Change-Id: I0f7ee108aab802ee1882f8017ea4b47346e38683
2024-01-24 15:52:06 -08:00
Sebastian Franco
f7654252b1 Moving ReorderPreviewAnimation into it's own file and rewrite to Kotlin.
This will make it easier to write unit testing.

Fix: 294473336
Test: manual testing
Flag: NA
Change-Id: I2d6cfd8110c5c2ef09c49150a0bd071bc948995c
2024-01-24 14:04:48 -08:00
Sebastián Franco
4d4c7e06eb Merge "Send ACTION_UP if there is an exception" into main 2024-01-23 18:40:53 +00:00
Sebastián Franco
4dc58c9d8b Merge "Send ACTION_POINTER_UP if there is an exception" into main 2024-01-23 18:40:33 +00:00
Vadim Tryshev
6be6906321 Send ACTION_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I22fa5a9da7384a44b35bdd3b21c79837dbbd11d2
2024-01-22 16:24:31 -08:00
Vadim Tryshev
d1108f24e5 Send ACTION_POINTER_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: Ica5fec6e5732383aed764682619453b2b3fac113
2024-01-22 16:14:10 -08:00
Rohit Goyal
f97d8ac08f Prefix PromiseIconUiTest with Tapl in AndroidManifest.xml for archiving.
* Archiving test for promise icons use a broadcast receiver.
* Due to recent class identifier change, manifest entry for the receiver was invalidated. This cl attempts to fix the breakage.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I061278d6cc3f49c579575a1af49ffe53770fd790
2024-01-22 17:26:24 +00:00
Uwais Ashraf
77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00
Vadim Tryshev
82bf25b017 Merge "Adding TestStabiility so that demoting transitioningToUnlocked_resetCallsPendingRunnable from presubmit works" into main 2024-01-19 21:14:20 +00:00