Commit Graph

73974 Commits

Author SHA1 Message Date
Cliff Wang
dd2222749b Merge "Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"" into main 2024-02-05 08:21:54 +00:00
Cliff Wang
ac82e995ca Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"
This reverts commit dd33b64a64.

Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.

Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
2024-02-05 04:46:17 +00:00
Tracy Zhou
6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Vadim Tryshev
f9eced5768 Merge "Make sure TAPL waits for Launcher activity to stop each time it stops" into main 2024-02-03 02:33:53 +00:00
Zak Cohen
379b5b0467 Merge "Hide widgets in the Work Profile tab when Work apps are paused." into main 2024-02-02 23:51:01 +00:00
Vadim Tryshev
dd33b64a64 Make sure TAPL waits for Launcher activity to stop each time it stops
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.

We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
2024-02-02 15:21:20 -08:00
Tony Wickham
cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak
92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Zak Cohen
3ae06bf4ca Hide widgets in the Work Profile tab when Work apps are paused.
The filter was missing from the refactor in ag/25502473.
There aren't currently WidgetPicker tests that would catch this behavior
but there should be.

Bug: 317452407
Test: Ran existing widget tests, looking at adding work profile tests.
Flag: none
Change-Id: I2ce8464a1c76505bfe7ce8cf4280bb5b576cdb1d
2024-02-02 13:28:39 -08:00
Shamali Patwa
e66a001ed6 Merge "Fix the horizontal margins on the left panel in the two pane picker." into main 2024-02-02 21:16:55 +00:00
Mady Mellor
5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev
94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou
d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
Vadim Tryshev
3f4401aa7e Merge "Adding text messages to some asserts in TaplAddConfigWidgetTest" into main 2024-02-02 18:21:35 +00:00
Shamali P
5e855d7912 Fix the horizontal margins on the left panel in the two pane picker.
The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.

Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.

Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT

Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
2024-02-02 18:20:38 +00:00
Sebastián Franco
fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00
Vinit Nayak
ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett
8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett
fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00
Rohit Goyal
e807bdc26a Merge "UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled." into main 2024-02-02 08:37:49 +00:00
Anushree Ganjam
61036608d1 Merge "Add logs for IME search button tap." into main 2024-02-02 07:58:28 +00:00
Fengjiang Li
2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Rohit Goyal
c475f22d8b UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Id9ba2ea833e8360ac8aa2c765beff402cff12ae2
2024-02-02 00:27:16 +00:00
Fengjiang Li
b9ba4b9813 Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NONE
Change-Id: I471c27b8b5d59850a4bf342fc2d8fee50d6fd65d
2024-02-01 16:24:18 -08:00
Fengjiang Li
387fea9731 Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.

Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
2024-02-01 16:24:14 -08:00
Sunny Goyal
b2f38376c4 Merge "Blocking gestureNav on taskFragments within the Launcher activity" into main 2024-02-02 00:23:29 +00:00
Rohit Goyal
ffb266462b Merge "UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist." into main 2024-02-02 00:21:21 +00:00
Mady Mellor
cc138663ca Launcher: use aconfig flag for bubble bar
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DISABLED
Test: make & enable / disable flag to check if it works:
      adb shell device_config put multitasking
         com.android.wm.shell.enable_bubble_bar true
Test: PlatformScenarioTests:
      android.platform.test.scenario.sysui.bubble.BubbleBarTest
Bug: 286246694
Change-Id: I0820973848675e8596e0e1605c7e43158d870382
2024-02-01 23:18:53 +00:00
Federico Baron
08b2acf898 Merge "Fix indexoutofbounds in Folder" into main 2024-02-01 23:07:17 +00:00
Sunny Goyal
2829c361f3 Blocking gestureNav on taskFragments within the Launcher activity
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Verified on device
Change-Id: Ie812e17012feb8e99e06d0593207a87ef0c768e3
2024-02-01 13:35:30 -08:00
fbaron
1f265cc907 Fix indexoutofbounds in Folder
Flag: NONE
Test: n/a
Fix: 322875847
Change-Id: I14f6ebe135014c806aee310e5919a72a6e8820f7
2024-02-01 13:09:55 -08:00
Rohit Goyal
25ef2e1eca UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iad3cc1a254b1543511976469c444eeaf869c7d50
2024-02-01 20:52:19 +00:00
Vadim Tryshev
1784a329e6 Adding text messages to some asserts in TaplAddConfigWidgetTest
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: Ia8164f60f49b377e41db72f97c4f90d167292574
2024-02-01 11:33:23 -08:00
Brandon Dayauon
3458141a9e Merge "Add Utility method in userCache to get badgeDrawables" into main 2024-02-01 18:02:17 +00:00
Schneider Victor-tulias
3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Sebastian Franco
2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Schneider Victor-tulias
8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
Bill Yi
ea784da63c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f148ef3d26 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26077678

Change-Id: I3d13835137d024b4191ae411bd1e8fff85310b85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-01 13:53:28 +00:00
Himanshu Gupta
69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta
3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Anushree Ganjam
1baf08e5b7 Add logs for IME search button tap.
Bug: 316779102
Flag: NA, Add logs
Test: Manual
Change-Id: I38af3b83e87afabe84807faccf5f8f3d080d93a2
2024-01-31 16:45:29 -08:00
Tracy Zhou
e757578908 Merge "Fix non-null check crash" into main 2024-02-01 00:21:05 +00:00
David Saff
60379ac052 Merge "Assert keyguard gone at beginning and end of PortraitLandscapeRunner" into main 2024-02-01 00:15:39 +00:00
Brandon Dayauon
72542b6058 Add Utility method in userCache to get badgeDrawables
- In userCache, create a utility method to get badgeDrawables via userHandle. As of this moment, this is used in Toast.

Bug: 312898415
Test: Manual photos:
before 0-state: https://drive.google.com/file/d/15OUcd8i1IoUU0BgMlZj-8e0YWsmtzY4E/view?usp=sharing
after 0-state: https://drive.google.com/file/d/15SH19xvdLzQt1QbHY2oAxPAFVXPZDchF/view?usp=sharing
before textHeader: https://drive.google.com/file/d/15OLpN2SNF9QNWMrs0Aos5fS-l39Op-wo/view?usp=sharing
after textHeader: https://drive.google.com/file/d/15PIi-K6FfdCtPwWg2GEP9SUE5ow2YXJ5/view?usp=sharing
Flags: None

Change-Id: Ia6f89e634cc0af47cae91add6ea62d3af452c441
2024-01-31 15:54:30 -08:00
Shamali Patwa
bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Andy Wickham
552df9b647 Merge "Re-apply all apps insets when unfolding." into main 2024-01-31 23:30:49 +00:00
Shamali Patwa
962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
Jeremy Sim
99cfd0905b Merge "Add error logging and better crash safety for app pairs" into main 2024-01-31 22:25:04 +00:00
Jordan Silva
2e75eeae32 Merge "Refactoring PagedOrientationHandler to extract functions from to quickstep" into main 2024-01-31 22:21:56 +00:00