Commit Graph

895 Commits

Author SHA1 Message Date
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
Tracy Zhou
419140aede Make sure touch only goes to the nearest button when it makes sense
- In NearestTouchFrame, we can't use view bounds alone since the buttons do not have the same root (3 buttons are in the main container, while the contextual buttons are in the contextual button container). This currently caused the issue that contextual button region, when the contextual buttons are invisible, triggers overview
- Need to add an empty space in the left / top area of the button nav to prevent view clicks from going into back (that's how it works in navigationbar/)

Bug: 25768138
Test: left and right of 3 buttons don't trigger back or overview
Change-Id: Idc26c0c8ac0ecc000300a6db2e3e6251f678dada
2024-01-30 14:27:48 -08:00
Tony Wickham
0961a69f61 Merge "Simplify/fix testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme" into main 2024-01-25 19:17:34 +00:00
Tony Wickham
58b3b5b52e Simplify/fix testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Instead of dealing with changing dark theme which can lead to races
with stale Taskbar icons, instead just go home and launch the IME
activity. This is sufficient because the taskbar height changes
when going between home and an app, and the IME will stash the
Taskbar during this transition.

Fixes: 320490387
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Flag: None
Change-Id: Ib5b1481751af0bf1fccda085c78174f6612441b9
2024-01-25 19:17:24 +00:00
Tony Wickham
ff08ceb595 Merge "Promote testQuickSwitchToPreviousAppForTablet to pre-submit" into main 2024-01-25 00:12:52 +00:00
Tony Wickham
a119f81854 Promote testQuickSwitchToPreviousAppForTablet to pre-submit
Fixes: 314873201
Test: testQuickSwitchToPreviousAppForTablet
Flag: None
Change-Id: I9d6b8b6aa1925f5133269a874cf7ca888c945ed3
2024-01-24 19:32:18 +00:00
Tracy Zhou
9c9befae5f Use nearest region for all the nav buttons in 3-button folded mode
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.

Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
2024-01-24 11:06:01 -08:00
Vadim Tryshev
f93d6ed80e Demoting new flaky test testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme to postsubmit
Bug: 320490387
Test: presubmit
Flag: N/A
Change-Id: I1e94ebc71089f68354069fd932be98dd53926ec4
2024-01-16 10:50:52 -08:00
Tony Wickham
dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Sunny Goyal
39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Sunny Goyal
6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Vadim Tryshev
5674552a5d Using a standard way to go to Overview in DWB Toast test
Standardizing reduces maintenance.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I0f59262a9f34c29a97c496f0f61c44ab1af56d04
2024-01-11 12:46:47 -08:00
Vadim Tryshev
132e6a64c9 Merge "Waiting for the state to settle after clear-all-tasks action" into main 2024-01-09 18:33:44 +00:00
Vadim Tryshev
f912287c8a Merge "Waiting for Recents activity to stop after starting apps" into main 2024-01-08 20:13:39 +00:00
Jagrut Desai
7a9686b49d Merge "Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-01-06 19:11:01 +00:00
Jagrut Desai
4f56608aec Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Test: Presubmit
Bug: 317798731
Flag: NONE
Change-Id: I05d430a4d8a306b672e89bb3033dfb41bbb9d000
2024-01-05 17:00:53 -08:00
Tony Wickham
762f8151f6 Improve Taskbar touchableRegion debuggability
- Add DebugTouchableRegion which includes the last region that we
  set as well as the reason (code path) for it, which we dump.
- If persist.debug.draw_taskbar_debug_ui is enabled, we will also
  outline the touchable region on the screen.

Flag: None
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Bug: 315393203

Change-Id: I70b37e8b8804c4a48ffe3956d2a24aa5eab452fd
2024-01-06 00:42:08 +00:00
Vadim Tryshev
edd7c4cc98 Waiting for Recents activity to stop after starting apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ifbc23289d040ad31d40434e9d81529c7800532e9
2024-01-05 16:19:56 -08:00
Jagrut Desai
ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Jagrut Desai
71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Tony Wickham
97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Jordan Silva
873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Jordan Silva
9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Tony Wickham
c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vadim Tryshev
6741d1affc Ignoring testQuickSwitchToPreviousAppForTablet
It fails on some targets

Test: presubmit
Flag: N/A
Bug: 318544733
Change-Id: Ia6e34f81942b3e911b637cd66eae4362e633eee5
2024-01-03 12:58:57 -08:00
Vadim Tryshev
943843a239 Merge "Re-promoting some tests to postsubmit" into main 2024-01-03 18:25:59 +00:00
Vadim Tryshev
5cc6b2ba52 Re-promoting some tests to postsubmit
Excluding TaplDragTest#testDragToFolder, which is failing on some devices

Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
2024-01-02 13:14:08 -08:00
Hyunyoung Song
0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00
Vadim Tryshev
b4ff22754a Waiting for the state to settle after clear-all-tasks action
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Idbbf48d5814fa457b3542ff972bfb86d31f04377
2023-12-31 18:36:20 -08:00
Federico Baron
1abb9a47b4 Merge "Align QSB with hotseat and workspace icons" into main 2023-12-20 17:36:12 +00:00
Schneider Victor-tulias
a7519cd0c6 Merge "Focus the first task in KQS when it is not currently running" into main 2023-12-20 14:58:18 +00:00
Priyanka Advani
1a0c6844eb Merge "Revert "Re-promoting some tests to postsubmit"" into main 2023-12-20 01:32:13 +00:00
Priyanka Advani
4c222bfb3c Revert "Re-promoting some tests to postsubmit"
This reverts commit 82a67a1a2d.

Reason for revert:b/317133692

Change-Id: Ibd66d2a113611380876c274d1c6203a7ab777a53
2023-12-20 00:33:25 +00:00
Vadim Tryshev
52a4bc76e9 Merge "Wait for RecentsActivity to stop after dismissing all tasks" into main 2023-12-19 22:37:22 +00:00
Vadim Tryshev
57b240ca02 Merge "Re-promoting some tests to postsubmit" into main 2023-12-19 22:20:50 +00:00
Uwais Ashraf
dbf585db73 Merge "Rename Tapl tests that do not match *Test.(kt|java) for easier groups" into main 2023-12-19 22:14:25 +00:00
fbaron
e69b6f49f7 Align QSB with hotseat and workspace icons
The QSB was a bit wider becuase icons visible size is a bit smaller than their actual size due to b/235886078 so we add a workaround to adjust QSB size based on the visible icon size

Bug: 281587788
Test: atest HomeScreenImageTest
Flag: NONE
Change-Id: I593ca2d588f08b830be0b2ac389c747b6f558b91
2023-12-19 13:52:45 -08:00
Vadim Tryshev
2152b04520 Wait for RecentsActivity to stop after dismissing all tasks
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I9afc27d4096417acaa1d4fb39de08b2a1ed8712a
2023-12-19 13:09:17 -08:00
Vadim Tryshev
82a67a1a2d Re-promoting some tests to postsubmit
Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: Idf3949b1f04b0ff761ef1216fa41e9e8d11e8cdd
2023-12-19 12:51:14 -08:00
Schneider Victor-tulias
4044669a90 Focus the first task in KQS when it is not currently running
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 316004088
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I8a91ca0dd32c6fc2352d285934a2c4f79ba1bb13
2023-12-19 10:48:40 -05:00
Uwais Ashraf
e0a4feb664 Rename Tapl tests that do not match *Test.(kt|java) for easier groups
Test: presubmits passing
Bug: 316551909
Flag: NA
Change-Id: Ib2070d7610927777376acf0ddefcbc90e582e6f6
2023-12-19 11:54:10 +00:00
Jeremy Sim
fb7f7c5a6f Merge "Use fade-in launcher for app pair launches from in-app taskbar" into main 2023-12-19 06:20:55 +00:00
Jeremy Sim
c2b598434c Use fade-in launcher for app pair launches from in-app taskbar
This CL temporarily patches a crash in this situation:

Inside of an app > Launch an unrelated app pair from Taskbar > Crash

The crash occurs because TaskbarActivityContext can't create a launcher animation (because Launcher isn't running). A different launch animation is needed for this case (similar to single apps), but for now, falling back to the fade-in launch at least allows the user to proceed without a crash.

Bug: 316485863
Test: Enter an app, launch an unrelated app pair, no crash
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I72b2956b5b44616367e24263f2287824ee1e8212
2023-12-19 11:27:04 +09:00
Jeremy Sim
34aa1c5366 Merge "Fixes two bugs with findLastActiveTasksAndRunCallback()" into main 2023-12-19 02:08:54 +00:00
Himanshu Gupta
314afce4f9 Fixing UserHandle for AppTarget Event from Launcher.
Currently, every non-foreground user AppTarget Event
is assigned the first userhandle present in the list
of UserProfiles cached with Launcher.
This causes issues when more than one profile is
present, as then appevents from either profiles are
indistinguishable.
This chane fixes that, based upon the recent fixes to
make Launcher and ItemInfo user profile aware.

Bug: 314124511
Test: Manual by clicking diff app targets
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TEAMFOOD
Change-Id: I188c828eeeff9b617ddf9a75bccea9b9ab38e506
2023-12-18 19:10:23 +00:00
Jeremy Sim
42a44d7984 Fixes two bugs with findLastActiveTasksAndRunCallback()
This CL changes findLastActiveTasksAndRunCallback to return a fixed array rather than an ArrayList.

1) This fixes a (minor) crash with app pairs, where we performed get(0) on an empty array when no running tasks were found.
2) This also fixes a live bug where app pairs would launch apps in the wrong order if app 1 was not found in running tasks, but app 2 was.

The function should be more robust now, preserving the indexing of the input keys.

Fixes: 316053131
Test: Clear all tasks from Overview, launch an app pair, launch succeeds
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I51d8ba823a2ec57e9ecfeede956e0afce1d653f4
2023-12-18 11:39:33 +09:00
Vadim Tryshev
de1e88da74 Waiting for Fallback Overview to stop after pressing Home
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I1128ca6eabe29e02d8039445696f7a006f6448bf
2023-12-17 15:45:51 -08:00
Vadim Tryshev
ae625f3d6a Merge "Converting more pressBack calls to calls that wait for animation" into main 2023-12-15 18:07:20 +00:00
Vadim Tryshev
56a5898331 Merge "Waiting for Fallback Overview to stop after pressing Home" into main 2023-12-15 18:04:55 +00:00
Jeremy Sim
9330619ee0 Fixes crash when launching app pairs with intent+intent
This CL adds a new case for app pair launches. When we launch app pairs with intents, we receive initialTaskId and secondTaskId as -1, which was previously unhandled and caused a crash. With this change, we find the left/top app leash a different way, by looking for windowingMode=WINDOWING_MODE_MULTI_WINDOW and endAbsBounds.left/top == 0.

Fixes: 316050315
Test: Clear all running tasks from Overview, launch app pair, no longer crashes
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: Ic356d71ad267f079242213ebc59322bf1fb86b7c
2023-12-15 17:17:24 +09:00