Commit Graph

2032 Commits

Author SHA1 Message Date
TreeHugger Robot
5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Alex Chau
5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Sebastian Franco
5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot
33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Pinyao Ting
cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
Sebastián Franco
f9d418b9f2 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev 2022-12-02 19:34:11 +00:00
Sebastian Franco
ac53846195 Ignore test while the solution for the flaky tests improve.
Bug: 261178121
Test: atest ReorderWidgets
Change-Id: Id0c6594e00486695c63e2cda53b1a5ee39478a1f
2022-12-02 11:33:00 -08:00
TreeHugger Robot
ed882317da Merge "Adding screenrecord to debug themeIconTest" into tm-qpr-dev 2022-11-30 08:17:13 +00:00
Brandon Dayauon
8267b7625f Merge "Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists" into tm-qpr-dev 2022-11-30 02:30:18 +00:00
Brandon Dayauon
7b53004999 Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists
Add a method that checks if three web suggests exist and another method to check for
predicted app row and web suggest exists.

bug: 225583735
test: Manual - photo: https://screenshot.googleplex.com/3NoSUm7nzTvf3gX
Change-Id: I7f9340229aaf4a0a3928933035f193a576995525
2022-11-29 13:35:56 -08:00
Sunny Goyal
d25f79c48f Adding screenrecord to debug themeIconTest
Bug: 260722220
Test: Updated
Change-Id: I20e590436e318f9a8914a8201d95584ab26de388
2022-11-29 09:31:13 -08:00
Sunny Goyal
ce4896cff5 Fixing shortcuts not getting theme icons
Bug: 238650110
Test: Updated ThemeIconsTest
Change-Id: I803cd6eefa4e393bf19901a44712622adac7f4b1
2022-11-28 09:48:50 -08:00
Pinyao Ting
ad932045ac Merge "Refactor GridSizeMigrationTaskV2" into tm-qpr-dev 2022-11-22 17:22:39 +00:00
Pinyao Ting
dec4305d0c Refactor GridSizeMigrationTaskV2
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.

This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
TreeHugger Robot
81a994e9a7 Merge "Increase icon size to be closer to spec" into tm-qpr-dev 2022-11-21 18:35:31 +00:00
Thales Lima
ae0d7ef782 Increase icon size to be closer to spec
Also change paddings because spaces changed

Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
TreeHugger Robot
c5b5044aff Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev 2022-11-18 01:09:23 +00:00
Sihua Ma
c6bd4ad21f Merge changes If022ec8d,I34341937 into tm-qpr-dev
* changes:
  Move LauncherWidgetHolder to widget package
  Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
2022-11-17 01:46:55 +00:00
Sihua Ma
8bbfcb6581 Move LauncherWidgetHolder to widget package
Making LauncherAppWidgetHost package-private as well

Bug: 235358918
Test: N/A
Change-Id: If022ec8d429579a972991872b2dc11db76719341
2022-11-16 14:31:14 -08:00
Sihua Ma
aa2b872d1c Move most of the functions in LauncherAppWidgetHost to LauncherWidgetHolder
Test: N/A
Bug: 235358918
Change-Id: I343419376491203a195154f2766b12e5def38879
2022-11-16 14:30:08 -08:00
Holly Sun
0d69c8dde9 Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results.
Also add simple prefix matching method.

Bug: 255355348
Test: manual
Change-Id: I35f2089924d774f3bcc1c05638a5d6b45ed7443f
2022-11-15 16:55:29 -08:00
TreeHugger Robot
8a03be1880 Merge "Added Tests for Secondary Display Launcher" into tm-qpr-dev 2022-11-15 22:41:51 +00:00
Jon Miranda
f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
TreeHugger Robot
8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda
e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
TreeHugger Robot
98f400397b Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev 2022-11-08 18:14:55 +00:00
Alex Chau
1feadf7d81 Merge "Improve spaces for folders" into tm-qpr-dev 2022-11-08 16:51:50 +00:00
Pat Manning
e1100b904d Unstash taskbar when transitioning to fallback overview.
Update LauncherInstrumentation taskbar visibility check to include assertions in fallback launcher using OverviewObject instead of LauncherObject.

Fix: 253042501
Test: manual
Change-Id: I9f2aa228e8aa97ef8ca1a4535b7f8fcded8a4572
2022-11-08 15:07:12 +00:00
Jon Miranda
d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Thales Lima
b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Sunny Goyal
679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
2022-11-04 14:41:14 -07:00
TreeHugger Robot
12aec8aa29 Merge "Waiting for app install to finish before procedding with the test" into tm-qpr-dev 2022-11-04 02:04:10 +00:00
Sunny Goyal
50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
Sebastián Franco
58502d0236 Merge "Wait in ReorderWidgets test for the workapce to load after changing it." into tm-qpr-dev 2022-11-03 18:55:50 +00:00
TreeHugger Robot
9e1f6002e5 Merge "Add delay after installing dummy app" into tm-qpr-dev 2022-11-03 17:17:09 +00:00
Sam Dubey
52a3bcd4bb Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev 2022-11-03 11:40:24 +00:00
Sam Dubey
a3577293b6 Revert "Support multi users scenarios in Tapl"
Revert "Reduce multi users tests runtime"

Revert "Add PlatformTesting to dependency."

Revert "Move platform testing util to separate gradle module"

Revert submission 20311444-user-switch-nosleep

Reason for revert: Part of DM+Platinum montiro as a likely culprit for b/257210412. Won't be submitted if proven otherwise.
Reverted Changes:
I90b1069de:Support multi users scenarios in Tapl
I706da86a3:Add PlatformTesting to dependency.
I605cd76c4:Move platform testing util to separate gradle modu...
I64b571dc4:Reduce multi users tests runtime

Change-Id: I6310efa59fe1755feb29bef28d890e684b7164c6
2022-11-03 10:08:13 +00:00
Benno Lin
8f669d20d7 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev 2022-11-03 06:42:19 +00:00
Winson Chung
38779f75da Add delay after installing dummy app
- Testing hypothesis that it's taking a while for the app to be
  properly installed and showing in all apps

Bug: 256659409
Test: com.android.launcher3.ui.TaplTestsLauncher3#testUninstallFromAllApps
Change-Id: Icb1bb8bb9d98751ac8c97b300ecc39372f39c345
2022-11-03 03:47:01 +00:00
Sunny Goyal
39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Saumya Prakash
ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00
Tony Wickham
6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Saumya Prakash
12731af30d Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I64c91c682009808690d696032ffadefc86dfbac9
2022-11-01 21:49:19 +00:00
Benno Lin
2e35f5152d Support multi users scenarios in Tapl
Tapl uses ContentProvider to get information from Launcher.
By default, it uses system user, who usually spwans the process
of instrumented tests, to send requests. Therefore, it can't get
the information of secondary user's Launcher process.

To solve the problem, the CL proposes to allow tests providing
UserInfo to Tapl, so that Tapl can use the right user's context
to get the test information. For more details, please refer to
go/multi-users-waiting-dd.

Test: https://android-build.googleplex.com/builds/abtd/run/L62400000957107134
Bug: 254402688
Change-Id: I90b1069de31e979138683049586bd87a7e7d813a
2022-11-01 14:36:24 +00:00
Sunny Goyal
c93eb630e6 Merge "Adding screenrecord for debug failing test" into tm-qpr-dev 2022-10-31 23:53:43 +00:00
Sunny Goyal
d6e9c601d8 Adding screenrecord for debug failing test
Bug: 256659409
Test: n/a
Change-Id: I1d804a92f81069df8d86f5b4ee2f21179f390d98
2022-10-31 13:25:17 -07:00
Sebastian Franco
285b749bcf Wait in ReorderWidgets test for the workapce to load after changing it.
Fix: 252860608
Test: atest ReorderWidgets
Change-Id: Idf99188837a475d0327174e264ab1d23d646d75d
2022-10-27 14:42:19 -07:00
Sihua Ma
17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Saumya Prakash
5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash
19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00