Commit Graph

49616 Commits

Author SHA1 Message Date
TreeHugger Robot
db8b97068b Merge "Add logs to aid missing unfold animation on launcher investigation" into tm-qpr-dev 2022-12-07 19:06:21 +00:00
Jon Miranda
6ba531d1aa Merge "Turn flag on by default: ENABLE_TASKBAR_REVISED_THRESHOLDS" into tm-qpr-dev 2022-12-07 17:33:53 +00:00
TreeHugger Robot
5e0d7ae019 Merge "Revert "Revert "Enable taskbar in overview by default""" into tm-qpr-dev 2022-12-07 17:14:15 +00:00
Alex Chau
5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Sebastián Franco
9adbab96b7 Merge "Creating a new alarm when drag X,Y change" into tm-qpr-dev 2022-12-06 17:17:26 +00:00
Nicolo' Mazzucato
1ee66e943a Add logs to aid missing unfold animation on launcher investigation
Bug: 261320823
Test: Manual
Change-Id: If714750c85ee49e66e21462ab9d2675ab0be8b55
2022-12-06 13:06:01 +00:00
Tony Wickham
ef8677169c Merge "Add feature flag to force taskbar to be persistent." into tm-qpr-dev 2022-12-06 06:12:23 +00:00
TreeHugger Robot
b3c9de2466 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-06 03:44:11 +00:00
Tony Wickham
7286c5be98 Add feature flag to force taskbar to be persistent.
This will allow us to test taskbar pinning before the entrypoint for
such a setting is finalized.

Test: manual, TODO: will need to update TaplTestsTaskbar to account for
this mode
Flag: FORCE_PERSISTENT_TASKBAR [off]
Bug: 258604917

Change-Id: I4535978563ffbe9a6cc6ece7720cdb75e787ff44
2022-12-06 00:51:46 +00:00
Sebastian Franco
5356ff955c Creating a new alarm when drag X,Y change
If the user is changing the X and Y of the reorder, wich requires
the user to move at least one Workspace cell from the previous
position, then it doesn't make sense to wait for the previous alarm to finish
to start a new reorder.

Also, I added a new test to run on foldable devices.

Fix: 259995663
Fix: 259295374
Test: atest ReorderWidgets (it mostly fails on postsubmit)
Test: modify ReorderWidgets.fullReorder to run 20 times and it should work, before the chagne it would fail.
Change-Id: Ic6b436ea1088f8092c849e9791862947e9035c9f
2022-12-05 16:37:45 -08:00
TreeHugger Robot
c4d6dee069 Merge "Cancel gestures on launcher destroy" into tm-qpr-dev 2022-12-05 20:25:47 +00:00
TreeHugger Robot
33c348f573 Merge "Make grid size migration less confusing for users." into tm-qpr-dev 2022-12-05 18:19:59 +00:00
Schneider Victor-tulias
65dda6d03e Cancel gestures on launcher destroy
A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.

Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
2022-12-05 08:11:50 -08:00
Bill Yi
714ec6b361 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I49ff3598e8d47485f9ee93178279bbf9abd3d367
2022-12-03 21:23:21 -08:00
Sihua Ma
7b467addea Merge "Replace title of system services with more specific ones" into tm-qpr-dev 2022-12-03 06:26:18 +00:00
Rajat Jain
a59f2231c5 Merge "Low contrast for Personal and Work Tab in launcher" into tm-qpr-dev 2022-12-03 05:00:45 +00:00
Sebastián Franco
fba141a3dc Merge "Adding screen ID parameter in CellLayoutLayoutParams" into tm-qpr-dev 2022-12-03 01:32:25 +00:00
Becky Qiu
c99da62f6f Merge "[Toast] Add a new type for AppSearch latency logging." into tm-qpr-dev 2022-12-03 01:23:33 +00:00
Sebastián Franco
9f775cab1a Merge "Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0" into tm-qpr-dev 2022-12-03 01:18:02 +00:00
Saumya Prakash
f6de6e364a Merge "Updated fonts to Google Sans in Setup screens." into tm-qpr-dev 2022-12-02 22:42:57 +00:00
Sebastian Franco
5bf936ac16 Preventing the text on ButtonDropTarget.resizeTextToFit size to go below 0
Bug: 260984829
Test: atest HomeScreenEditStateImageTest
Change-Id: I4aba76de512aedf5b4c921593fe43099700eb773
2022-12-02 14:05:24 -08:00
Sebastian Franco
2ceb3b5088 Adding screen ID parameter in CellLayoutLayoutParams
Bug: 188081026
Test: launcher compiles, this test doesn't change existing logic only the model
Change-Id: I7bcf6452d5ecb9b50914defc311ad06839220c92
2022-12-02 13:40:34 -08:00
Pinyao Ting
cc90d1b767 Make grid size migration less confusing for users.
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.

This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.

Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
2022-12-02 13:33:04 -08:00
Brian Isganitis
a5953002d4 Merge "Reduce top padding of Taskbar's All Apps tray." into tm-qpr-dev 2022-12-02 21:10:55 +00:00
Vinit Nayak
2cf7994908 Merge "Update test for change in calculation of split portrait clipping" into tm-qpr-dev 2022-12-02 20:13:48 +00:00
Sebastián Franco
f9d418b9f2 Merge "Ignore test while the solution for the flaky tests improve." into tm-qpr-dev 2022-12-02 19:34:11 +00:00
Sebastian Franco
ac53846195 Ignore test while the solution for the flaky tests improve.
Bug: 261178121
Test: atest ReorderWidgets
Change-Id: Id0c6594e00486695c63e2cda53b1a5ee39478a1f
2022-12-02 11:33:00 -08:00
Jon Miranda
01e90b7787 Merge "Add transient taskbar sizing for twoPanel devices." into tm-qpr-dev 2022-12-02 18:58:08 +00:00
TreeHugger Robot
cfa199537b Merge "Removing SearchActionItemInfo" into tm-qpr-dev 2022-12-02 17:31:25 +00:00
Anushree Ganjam
d7898e6083 Merge "Use CopyOnWriteArrayList to avoid ConcurrentModificationException." into tm-qpr-dev 2022-12-02 17:25:36 +00:00
TreeHugger Robot
c10a003aa0 Merge "Fade in/out taskbar when launching apps from or back to AllApps/-1" into tm-qpr-dev 2022-12-02 11:40:25 +00:00
Ats Jenk
1b499bfde8 Merge "Add a flag to not disable back gesture in launcher" into tm-qpr-dev 2022-12-02 06:12:51 +00:00
Vinit Nayak
190fa37647 Update test for change in calculation of split portrait clipping
* Updated code, wrote new test for new code
but forgot to update old test.

Fixes: 261110474
Test: FullscreenDrawParamsTest passes
Change-Id: I39a9029b69774f0ea7064da295c516f547bcbef2
2022-12-01 21:22:38 -08:00
Anushree Ganjam
51d05b9888 Use CopyOnWriteArrayList to avoid ConcurrentModificationException.
Bug: 204781396
Test: Manual
Change-Id: I5a28d34a5e404d2a4a4647c94dff632e02d57717
2022-12-02 03:04:11 +00:00
TreeHugger Robot
4093307b87 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-02 00:50:40 +00:00
Becky Qiu
1aff9578fd [Toast] Add a new type for AppSearch latency logging.
Bug: 261075521
Test: local
Change-Id: If480d326349027d0fe6e1208c68e49f1900cd3bf
2022-12-01 16:40:06 -08:00
Jon Miranda
a4aaf1aced Add transient taskbar sizing for twoPanel devices.
Bug: 259712417
Test: on two panel device, on tablet device
Change-Id: Iae273b6bbfb254288c234aa5882f39eb0b6a88b1
2022-12-01 16:28:29 -08:00
Saumya Prakash
030f2fc7b7 Updated fonts to Google Sans in Setup screens.
This change migrates the "All set" and Gesture Nav Tutorial screens to
use Google Sans fonts as aligned with SUW's design.

Before:
"All set" screen: https://screenshot.googleplex.com/7ptWroSfRiZLcRT.png
Gesture Nav Tutorial screen: https://screenshot.googleplex.com/6SuYs67NSD2WRkU.png

After:
"All set" screen: https://screenshot.googleplex.com/6UGrdR43h8aDJzU.png
Gesture Nav Tutorial screen: https://screenshot.googleplex.com/45NxPH2ezQsHxL4.png

Fix: 258241930
Test: Manual
Change-Id: I21cc19383f78e3d9e84b0d892cbd977f20b91e86
2022-12-01 23:20:02 +00:00
Sihua Ma
8820a2181b Replace title of system services with more specific ones
Before: https://screenshot.googleplex.com/8f5tGuw8c8zi6nX
Now: https://screenshot.googleplex.com/4SXGMoiZmYJ3auF

Fix: 258307358
Test: Manual
Change-Id: I549cbdbb99f0168c87cc1c122cad9aceb3231591
2022-12-01 14:37:47 -08:00
Ats Jenk
8121e0d8b1 Add a flag to not disable back gesture in launcher
Desktop mode prototypes enable freeform tasks on top of launcher.
Launcher is still partially visible in the back which means that
launcher will disable back gesture for the freeform tasks.

When desktop mode prototype 1 or 2 is enabled, skip disabling the back
gesture on launcher.

Bug: 259280363
Test: manual, enable desktop mode and launch an app, try back gesture
  from edge

Change-Id: I1d5eb81c7b28fb452c9566e358d77a5b2c19d450
2022-12-01 14:06:02 -08:00
Jon Miranda
12053e958f Merge "Fix window x-axis movement after gesture ends." into tm-qpr-dev 2022-12-01 20:03:57 +00:00
Vinit Nayak
18d5634176 Merge "Update for stashed taskbar animation" into tm-qpr-dev 2022-12-01 19:26:11 +00:00
Alex Chau
cd76ac24b6 Fade in/out taskbar when launching apps from or back to AllApps/-1
- Added isHotseatIconTopWhenAligned to control both iconAlignment and stash animation to just fade in if hotseat icon isn't on top of the screen in the aligned state

Fix: 257355864
Fix: 213455090
Test: Launch apps from/back to home, taskbar animate from/to hotseat
Test: Launch apps from/back to AllApps/-1, taskbar fade in/out
Test: Repeat aboth with transient or persistent taskbar
Change-Id: I6bdae615ff9e199d23cbfe2d26c8d46a08fbc436
2022-12-01 18:56:30 +00:00
TreeHugger Robot
42faae4a49 Merge "Refactor all_apps.xml contents to all_apps_content.xml" into tm-qpr-dev 2022-12-01 06:09:49 +00:00
Becky Qiu
5c46bea3bc Merge "[Toast] Remove feature flag for rich answer, use all apps flag instead." into tm-qpr-dev 2022-12-01 02:00:31 +00:00
Brian Isganitis
deac0d529a Reduce top padding of Taskbar's All Apps tray.
The top padding looks too high because the code is assuming we have a
search bar at the top of the bottom sheet. Until we implement search, we
should temporarily reduce padding for the taskbar implementation.

Before:
  - No tabs: https://screenshot.googleplex.com/AAPdR5nbwepWQ82.png
  - Tabs: https://screenshot.googleplex.com/3DnQp6PKhqXyRag.png

After:
  - No tabs: https://screenshot.googleplex.com/A8enwnSs8r78ccj.png
  - Tabs: https://screenshot.googleplex.com/A3fAy2bXgmSPrG9.png

Test: Manual
Bug: 216683257
Change-Id: Ie0837acc3aed162b9428a209962be2a102c515c8
2022-12-01 00:21:28 +00:00
Vinit Nayak
3b1f5849ce Update for stashed taskbar animation
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected

Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen

Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
2022-11-30 11:56:40 -08:00
Sunny Goyal
9a616213e1 Removing SearchActionItemInfo
> Instead introducing an interface for handling click events
> Linking this interface to other UI which handle clicks

Bug: 259733681
Test: Presubmit and verified manually
Change-Id: I9cbf2d009d64254f513deb909a151e46e860d039
2022-11-30 10:59:07 -08:00
Bill Yi
687050a6c5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Icc29007bba50bcceaaec8137968455017147d39e
2022-11-30 02:45:01 -08:00
TreeHugger Robot
ed882317da Merge "Adding screenrecord to debug themeIconTest" into tm-qpr-dev 2022-11-30 08:17:13 +00:00