Commit Graph

16091 Commits

Author SHA1 Message Date
Tony Wickham
cf563e5f2d Add a quick scrub threshold
Change-Id: I184ca2bd3d97e58f8fe8841a66571ca101ee3dc2
2018-05-02 12:03:22 -07:00
Tony Wickham
f325b19de3 Merge "Gracefully handle some edge cases in quick scrub" into ub-launcher3-edmonton 2018-05-02 16:21:21 +00:00
Tony Wickham
7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi
bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
android-build-team Robot
cacf90cc48 Merge "Reusing the same bitmap and pixel array for shape detection" into ub-launcher3-edmonton 2018-05-01 23:32:17 +00:00
android-build-team Robot
4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
android-build-team Robot
3adb0b9f2a Merge "Fade in LauncherRootView in finishFirstPageBind." into ub-launcher3-edmonton 2018-05-01 20:59:00 +00:00
Jon Miranda
5916709219 Bound overscroll shift amount to avoid content from drawing on top (Y-val)
of the QSB.

Bug: 77538324
Change-Id: Idabc4365c5fe5cb1894fa0eb84ea9309b85f99a3
2018-05-01 13:57:33 -07:00
Jon Miranda
dbd9286abd Fade in LauncherRootView in finishFirstPageBind.
This ensures that the fade in animation will actually run, as DragLayer alpha
can be set by other means.

Bug: 72728697
Change-Id: I3ca0a6811b113e331119c74539a4421cfbdb51c9
2018-05-01 13:49:54 -07:00
Tony
f47e5ce3cf Gracefully handle some edge cases in quick scrub
- Switch to normal overview if task fails to launch in onQuickScrubEnd()
- Stop auto-advancing if recents isn't visible
- Wait until transition to quick scrub completes before launching

Bug: 77521777
Bug: 78557737
Change-Id: I5206c0d3c52bf792f52cf3e7adcf03f8a2de18bb
2018-05-01 14:21:04 -05:00
Tony
31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
Winson Chung
976047647e Merge "Also notify the user when a task view fails to launch." into ub-launcher3-edmonton 2018-05-01 18:41:02 +00:00
android-build-team Robot
a269a81881 Merge "Accessibility of clear-all button" into ub-launcher3-edmonton 2018-05-01 18:31:25 +00:00
Winson Chung
6dceb7755a Also notify the user when a task view fails to launch.
Bug: 78660939

Change-Id: I8041d3bdd6da1caed72affb1e295c416214a92d4
2018-05-01 11:27:02 -07:00
Vadim Tryshev
4e3e54a45a Accessibility of clear-all button
Making it visible to accessibility even when it’s completely hidden
behind a task. I had to mark it visible as a view. Now it’s invisible
only when there are no tasks in RecensView, to hide it from
accessibility.

Focusing on the button completely reveals it.

Bug: 72222505
Test: Manual
Change-Id: Ia31a1136e07faed93b4a44d5be69483d3b88364d
2018-05-01 11:20:14 -07:00
android-build-team Robot
954157a228 Merge "Remove associated task views if task is removed while Overview is showing" into ub-launcher3-edmonton 2018-05-01 18:12:34 +00:00
Winson Chung
3b0c3b981b Remove associated task views if task is removed while Overview is showing
Bug: 78660939
Change-Id: Iccfb09c985662c150f42d382b92d17f853abaaea
2018-05-01 10:04:46 -07:00
android-build-team Robot
c62cafe149 Merge "Import translations. DO NOT MERGE" into ub-launcher3-edmonton 2018-05-01 03:17:29 +00:00
Bill Yi
f65f5221b7 Import translations. DO NOT MERGE
Change-Id: Ia39b69f4fb3da457065d1416b387f920fdd51106
Auto-generated-cl: translation import
2018-04-30 18:41:54 -07:00
android-build-team Robot
4c6b638e24 Merge "Secondary split screen app will be next to the navigation bar (2/2)" into ub-launcher3-edmonton 2018-05-01 00:40:27 +00:00
android-build-team Robot
1e0b98fa6e Merge "Fixes the incorrect hover icon color in drop bar when dark theme" into ub-launcher3-edmonton 2018-04-30 23:22:00 +00:00
Mehdi Alizadeh
3e024c0e1c Fixes the incorrect hover icon color in drop bar when dark theme
Bug: 78641863
Test: Manual test with dark and light wallpapers
Change-Id: Ic3fb68f5c5f746482a7f23b11284e30ac3e10168
2018-04-30 16:05:25 -07:00
android-build-team Robot
59d6f26cd4 Merge "Adding a round rect background for the self in Overview" into ub-launcher3-edmonton 2018-04-30 22:51:59 +00:00
Sunny Goyal
36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
Bill Yi
c2032ee2f4 Import translations. DO NOT MERGE
Change-Id: I229a0d80355868f6197033b792dc1796973adebe
Auto-generated-cl: translation import
2018-04-30 15:28:15 -07:00
Matthew Ng
8013843fbd Secondary split screen app will be next to the navigation bar (2/2)
Refactored docked position code into PhoneWindowManager to determine
which side the docked app should go based on the position of the nav bar
in landscape (as portrait will only have top). Fixed the split screen
entrance animation for quick step's overview.

Change-Id: I0035214cecb9c6403c59f4b938c2d1ae924f34b0
Fixes: 73250406
Test: play around with splitscreen and minimized mode
2018-04-30 15:01:32 -07:00
android-build-team Robot
1ea6d9cb8e Merge "Fixing Search box not getting aligned properly based on insets" into ub-launcher3-edmonton 2018-04-30 21:31:50 +00:00
android-build-team Robot
6dcf142f61 Merge "Fixing task open animation in split screen mode" into ub-launcher3-edmonton 2018-04-30 21:27:38 +00:00
android-build-team Robot
fbf972e026 Merge "Making sure Clear-all button can't be clicked when transparent" into ub-launcher3-edmonton 2018-04-30 19:38:27 +00:00
Sunny Goyal
df296898da Fixing Search box not getting aligned properly based on insets
Bug: 77893699
Change-Id: If195395af7858c3115d695a308810480474541a5
2018-04-30 12:35:40 -07:00
Vadim Tryshev
83b4bb0421 Making sure Clear-all button can't be clicked when transparent
There are times when the button is visible, but completely transparent.
Fixing: now when transparent, it's invisible, consequently, unclickable.

Bug: 72222505
Test: Manual
Change-Id: I1be162b56d6e694199fad7845c64f3438415a190
2018-04-30 12:14:58 -07:00
android-build-team Robot
8492deaa13 Merge "Import translations. DO NOT MERGE" into ub-launcher3-edmonton 2018-04-30 18:34:17 +00:00
Vadim Tryshev
1c56935c30 Revert "a11y: disabling accessibility scrolling of the home screen"
This reverts commit 52b2b43c56.

Reason for revert: Per an email thread, this CL is considered a hack.

Change-Id: Id97fc9a398184ba18c2188d858218bc2d9ddc16e
(cherry picked from commit 310093d050)
2018-04-30 18:07:13 +00:00
Bill Yi
43b5cfe76b Import translations. DO NOT MERGE
Change-Id: I6a00a8461cd13c680453375914405c7f93806258
Auto-generated-cl: translation import
2018-04-30 10:53:33 -07:00
Sunny Goyal
2e4596a448 Reusing the same bitmap and pixel array for shape detection
Bug: 76162466
Change-Id: I785d9b8673b2b8b0a56a146143b375c412e9322a
2018-04-30 09:23:29 -07:00
android-build-team Robot
3aa3eb51e2 Merge "Alpha-optimizing Clear All button." into ub-launcher3-edmonton 2018-04-28 03:20:08 +00:00
Vadim Tryshev
94ab3eee48 Alpha-optimizing Clear All button.
Similar approach is used for its sister buttons in System UI
(like id/dismiss_text which is
"FooterViewButton extends AlphaOptimizedButton").

Bug: 72222505
Test: Manual
Change-Id: Ibb8157bfbf2bf9cddb501c1e80fb9c7c79bb694b
2018-04-27 20:02:38 -07:00
android-build-team Robot
e15329d222 Merge "Fixing task misalignment" into ub-launcher3-edmonton 2018-04-28 01:42:38 +00:00
Vadim Tryshev
84b46f0257 Fixing task misalignment
Bug: 78793769
Test: Manual
Change-Id: I49f8213bf412f63fc296a8be5bd49950e4c01175
2018-04-27 18:00:14 -07:00
android-build-team Robot
68f138990b Merge "Let Launcher handle proxy touch events even if it is not focused" into ub-launcher3-edmonton 2018-04-28 00:25:01 +00:00
Sunny Goyal
09cc13e20c Let Launcher handle proxy touch events even if it is not focused
Bug: 74616863
Bug: 78367228
Change-Id: I8c9271e95583793af0832e3b07c988261b6267e8
2018-04-27 17:14:05 -07:00
Hyunyoung Song
cbebaa19f9 Add user event logging for clear all button (follow up CL)
Bug: 72222505

Change-Id: I95e3bb8dbf55e9ae4ca8de4040eb89ddfb161368
2018-04-27 16:39:23 -07:00
Sunny Goyal
5fdd300e8a Fixing task open animation in split screen mode
Removing duplicate logic for task bounds calculation and using
ClipAnimationHelper everywhere

Bug: 78126501
Change-Id: I5ed8b2f9162f0bd6144a849f5b677963776d325c
2018-04-27 16:36:19 -07:00
android-build-team Robot
50483ea4e6 Merge "Add user event logging for clear all button Bug: 72222505" into ub-launcher3-edmonton 2018-04-27 23:33:13 +00:00
Mehdi Alizadeh
7ad04f35f8 Merge "Refactor initializing LauncherAccessibilityDelegate" into ub-launcher3-edmonton 2018-04-27 23:14:01 +00:00
Hyunyoung Song
63311a2ddc Add user event logging for clear all button
Bug: 72222505

----------------------------------------------
Verified

UserEvent: action:TAP
UserEvent:  Source child:CLEAR_ALL_BUTTON
UserEvent:  Elapsed container 8142 ms, session 11322 ms, action 0 ms
----------------------------------------------
Change-Id: I3ace51c30129728017c5eb198c52ab1bfd94c0ac
2018-04-27 15:54:15 -07:00
Mehdi Alizadeh
8588fd0ea2 Refactor initializing LauncherAccessibilityDelegate
Bug: 77638406
Test: None
Change-Id: Ibf9f4fcabe42400abc91aa4b94417a8ff0449248
2018-04-27 15:38:52 -07:00
android-build-team Robot
15260fdd00 Merge "Enable Clear-all button by default" into ub-launcher3-edmonton 2018-04-27 20:44:02 +00:00
Vadim Tryshev
cc0c98ad94 Enable Clear-all button by default
Making it work with all 4 combinations of RTL and flip-recents.

Bug: 72222505
Test: Manual
Change-Id: Ifb2428e006674abfe9a2609fd3d8f3f648eff0b8
2018-04-27 13:32:28 -07:00
android-build-team Robot
c2c907edec Merge "Preventing new object creation during animation frame" into ub-launcher3-edmonton 2018-04-27 19:15:32 +00:00