Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
I was being cautios on my previous fix for this same
isse, cautios because I'm modifying an object by reference
That's why I was only updating the container when the icon being
dropped was PendingAddShortcutInfo but we can change the container
on every icon (we don't need to in the Widget case which is the
other if statement), we can be sure it is a safe operation because
we later update the info anyway rendering the previous info invalid.
Fix: 413784315
Test: WIP
Flag: EXEMPT bug fix
Change-Id: I60ecdb52be1c7bf0584cb1c74ee15b85961e5012
Instead of the dispatcher specifying the type, the UI checks th diff. This
ensures that the UI is updated correctly in all paths
Bug: 390572144
Flag: EXEMPT refactor
Test: Manually verified folder edit path where these callbacks were getting dispatched
Change-Id: Ib73eed5da87a847753a78453a48ab4fc495c1199
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.
Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest
Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
When we remove an in-between or last empty page, we manually set the
current page but don't update the description that's set on the
accessibility view. Due to which, when talkback focuses on it, it sees
the stale page count in the description.
This fix ensures to keep the state updated during removal.
Bug: 390360063
Fix: 390360063
Test: Talkback
Flag: EXEMPT BUGFIX
Change-Id: Idd9a54d3a1ee43e56f51db78e614776eca6a12f7
Rather than register a StateListener for each LauncherAppWidgetHostView, just register one StateListener which, upon launcher state is changed to NORMAL, iterate over all child views under Workspace and perform a11y action if view tag is set.
Fix: 397978703
Test: presubmit
Flag: EXEMPT bug fix
Change-Id: I044d012b74eaa5356196c5503318fa8ab389ec46
Revert submission 31445615-model-callbacks
Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>
Reverted changes: /q/submissionid:31445615-model-callbacks
Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events
Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
Bug: 379649357
Test: Verified manually that the fixes work for announcements.
Flag: EXEMPT bug fix
Change-Id: I0a2e989eb34adbd975a7211d8334d264d64b3933
This ensures that the dragInfo has not been set to null before the AccessibilityDragListener's
onDragEnd is called. Previously, this was breaking long accessibility moves.
Bug: 387563703
Test: Verified locally that this fixes the issue.
Flag: EXEMPT bug fix.
Change-Id: I8d25c3865a0a025a9dad341ea39062cb3658a763
The feedback occurs when an icon hovers over an empty available space in
Workspace and Hotseat, as well as over other icons to create folders.
This is now compliant with the Multi-sensory Design Language spec.
Test: manual. Verified haptics while dragging icons over Workspace and
Hotseat.
Test: manual. Verified haptics with adb shell dumpsys of Launcher and
checking the MSDL token history.
Flag: com.android.launcher3.msdl_feedback
Bug: 371314631
Change-Id: I7d039ddf9d05faa39a6e6e3f9a84217d8916adc0
When a widget is added while talkback is enabled, the widget resize
frame does not automatically close when subsequently changing workspace
pages. This is because touch events which usually would cause the
widget resize frame to close, get intercepted by talkback before they
get to the resize frame.
Bug: 374044529
Test: manual - activate talkback, add new widget, and change page
Flag: EXEMPT bug fix
Change-Id: I2b8db22fa237a188c6705e9c6e57b12c1a7cd2f6
Flag: NONE - abstraction with no logic changes.
Test: Built and ran locally, for launcher3 and third party launchers
Bug: 224595066
Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
This CL updates the color for the app pair background, and adds a way for an app pair icon to redraw as a different color when switching containers.
Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I615cb95d51f7c4c120ad306246d9491bf4452229
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.
This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).
Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
