Commit Graph

83104 Commits

Author SHA1 Message Date
Sebastian Franco
cc18ee380e Do not modify the original item info when adding a new item in Worksapce
Fix: 418114270
Test: NA
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dbd6f0d18f69d5d33862aaad015c4c8c5907fb46)
Merged-In: Ic0dd00da4f363868a1c2abeeb736b86f6f706631
Change-Id: Ic0dd00da4f363868a1c2abeeb736b86f6f706631
2025-06-25 21:04:11 -07:00
Android Build Coastguard Worker
1a3a1dea81 Merge cherrypicks of ['googleplex-android-review.googlesource.com/33860411', 'googleplex-android-review.googlesource.com/33706471', 'googleplex-android-review.googlesource.com/34060509'] into 25Q3-release.
Change-Id: I334d9728efead5bec804992102d2e63e61b6a9bf
2025-06-24 19:52:31 -07:00
Jagrut Desai
4970befcdc Fix Taskbar Icon going beyond screen
The problem: Currently, when users increases font size to fullest and also display size to fullest, taskbar icons goes beyond screen. The isssue is event worst when there is bubble bar present in the Taskbar. This is currently a problem with 3 button nav button.

The Solution: The solution is in two parts.
Part 1: figure out amount of icons we need to remove from hotseat for the taskbar icons to not got beyond screen and not collide with nav buttons or bubble bar.
Part 2: Once we figure out how many icon we need to not show in takbar which are present in the hotseat, we need to modify the takbar icon alignment controlled to modify alpha animation and eventually the visibility of those taksbar views. We also need to modify taskbar icon layout logic so that we don't take space for invisible taksbar icons and we layout next visible icon on the place of invisible icons.

Test: Manual, Presubmit
Bug: 412835965
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:8def3264e3f4fa3a2354dfa693751ea3d5f33f36)
Merged-In: I8dea948df09c0a86871a9ac649f312ecf281545a
Change-Id: I8dea948df09c0a86871a9ac649f312ecf281545a
2025-06-24 19:49:03 -07:00
Toni Barzic
710f20e89c Remove all apps divider when it shouldn't show
Update TaskbarView logic to remove all apps divider when it's not
expected to show (if the taskbar is showing desktop tasks), instead of
just assuming it was never added. This handles an edge case where
`shouldShowDesktopTasks()` may return false initially for taskbar on
home screen, until home screen visibility as seen by taskbar controllers
is updated when transitioning out of desktop mode.

Bug: 416402113
Test: On desktop first device, disable
      enable_desktop_taskbar_on_freeform_displays, go to desktop mode,
      then minimize/close all desktop windows. On home screen, verify
      taskbar is shown, and contains only pinned apps - no divider is
      shown between all apps and pinned apps.
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:f10c3e9afe8aa866fe21c797a5aade262bd4fcdc)
Merged-In: I7bb419d87420575cebe0c332111797678b07d654
Change-Id: I7bb419d87420575cebe0c332111797678b07d654
2025-06-24 19:48:57 -07:00
Sebastian Franco
0579ceb4e4 Do not hidde action buttons on FixedLandscape
Also, I moved some of the boolean expressions to a method in the
rotation handler to avoid repeating code and to make the expressions
more legible.

Bug: 401483343
Flag: com.android.launcher3.one_grid_specs
Test: RecentOrientedStateTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0a7bf1db572262d3263f623a1a41fe75076858e4)
Merged-In: I84c1a6e90ede827fd93ec44c3937acaf45f02413
Change-Id: I84c1a6e90ede827fd93ec44c3937acaf45f02413
2025-06-24 19:48:49 -07:00
Android Build Coastguard Worker
8150c5e116 Merge cherrypicks of ['googleplex-android-review.googlesource.com/34111776'] into 25Q3-release.
Change-Id: I52272b48cad14b3021f04186f3228c8a23d12ba7
2025-06-21 11:37:04 -07:00
Shamali Patwa
bb223dedb6 Revert the WIDGET_CROSSFADE_DURATION_MILLIS to 125
Partially reverts ag/33592869

- It seems that it was meant for close animation, however this value
is mainly used for open animation.

Bug: 424740625
Test: See demo
Flag: EXEMPT BUGFIX
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ee94bdd219120e430e1a262729d9409615ef4130)
Merged-In: I574fc18919d58bc0be3529350ac29bcf8f42f9e4
Change-Id: I574fc18919d58bc0be3529350ac29bcf8f42f9e4
2025-06-21 11:32:30 -07:00
Android Build Coastguard Worker
7baa4dd4d0 Merge cherrypicks of ['googleplex-android-review.googlesource.com/34015381'] into 25Q3-release.
Change-Id: I9c62d9fc921e5ab2ced836461b77e58d3bd7f7af
2025-06-17 18:17:38 -07:00
Fengjiang Li
539d1ab151 [Memory Leak] Fix leak of rotation button view from NavbarButtonsViewController#mFloatingRotationButton
Clear mFloatingRotationButton from NavbarButtonsViewController#onDestroy()

Fix: 424253928
Test: manual - rotate screen in comet and verfiy no leaks
Flag: NONE - released code
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:b693a10d6493556ef30d7011eee6804bd7890f89)
Merged-In: I43ef6bcf67e44e76eb17d80e0d996d2066f154e0
Change-Id: I43ef6bcf67e44e76eb17d80e0d996d2066f154e0
2025-06-17 18:15:53 -07:00
Android Build Coastguard Worker
6f1453026e Merge cherrypicks of ['googleplex-android-review.googlesource.com/33988406'] into 25Q3-release.
Change-Id: Id1a096de98f548a023402a5f5c2edb7e8752c43c
2025-06-16 16:47:17 -07:00
Fengjiang Li
2594314a58 Fix crash from PreviewSurfaceRenderer#recreatePreviewRenderer()
This is a forward fix of ag/33841218.

IllegalStateException is thrown because getResources() has already been
called in ContextThemeWrapper.applyOverrideConfiguration().

We should avoid getting configuration from ContextThemeWrapper, which
will generate ContextThemeWrapper#mResources and trigger
IllegalStateException from subsequent
ContextThemeWrapper#applyOverrideConfiguration().

Instead, we should get configuration from mPreviewContext which is
ContextWrapper.

Fix: 423802089
Flag: NONE - released code
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0c218842940c0920b88c9eb2ac30ef76a16edf08)
Merged-In: Ic3d29d7bb2cbf3483e757e5a90ac8d8989adc613
Change-Id: Ic3d29d7bb2cbf3483e757e5a90ac8d8989adc613
2025-06-16 16:44:26 -07:00
Android Build Coastguard Worker
c46dc5a85c Merge cherrypicks of ['googleplex-android-review.googlesource.com/33937778', 'googleplex-android-review.googlesource.com/34016070'] into 25Q3-release.
Change-Id: I3e7f338f11587afdd5349d75b29a81dd38b27523
2025-06-13 20:36:49 -07:00
Schneider Victor-Tulias
202bb8e797 Fix a missing null-check in AbsSwipeUpHandler
Flag: EXEMPT bug fix
Fixes: 423027896
Test: ran launcher
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c633e26434aeb9d1a4c4630d6db1d4ab477a1a1d)
Merged-In: I44ae9215a83f169c1fa052d322ba5346312536b3
Change-Id: I44ae9215a83f169c1fa052d322ba5346312536b3
2025-06-13 20:36:02 -07:00
Alex Chau
19666ccb53 Mark TaskSnapshot from onAnimationCanceled Nullable
- TaskSnapshot from onAnimationCanceled can be null, and our Kotlin assumes it's not and throws NullPointerException. Handle it gracefully instead.
- Even though onAnimationCanceled doesn't provide updated screenshot, we still have the screenshot taken on swipe up as backup to show

Fix: 413581605
Test: Manual (see steps in bug)
Flag: EXEMPT bug fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7eb6b3fa1557873423d2fc6c286103ef141a24ff)
Merged-In: Ic4aaa8e1a50a4e2a8b7b87baff5f2b1819a7e8ab
Change-Id: Ic4aaa8e1a50a4e2a8b7b87baff5f2b1819a7e8ab
2025-06-13 20:35:49 -07:00
Android Build Coastguard Worker
3db164e7e2 Snap for 13618210 from f8d94de717 to 25Q3-release
Change-Id: I077390a23566a59272c42e6ca971675e164214aa
2025-06-09 16:21:26 -07:00
Shamali Patwa
f8d94de717 Merge changes from topic "p-shortcut-impl" into main
* changes:
  Widget Picker: Update the launcher integration to support shortcuts
  Widget Picker: Update UI layer to support shortcuts
  Widget Picker: Update data layer to support shortcuts
2025-06-09 11:02:42 -07:00
Will Osborn
c8e9d91d67 Merge "Add flag enable_simultaneous_overview_trigger_on_extended_desktop" into main 2025-06-09 06:34:49 -07:00
Treehugger Robot
5f0e09cea8 Merge "Disable Suggestions on Grouped Task Views" into main 2025-06-09 06:27:35 -07:00
Treehugger Robot
34134a3529 Merge "[Dagger] Move LauncherRestoreEventLoggerImpl to LauncherAppModule" into main 2025-06-09 06:14:25 -07:00
Sam Cackett
1aea34dc7f Disable Suggestions on Grouped Task Views
Bug: 422977902
Flag: EXEMPT. Bugfix
Test: Manual. Split 2 apps, long press to select. Select shouldn't work.
Change-Id: Iefdc0825268e506108728b8683a1cc708249463e
2025-06-09 11:35:31 +01:00
Treehugger Robot
f23a5060ee Merge "Do not enter desktop mode if the existing fullscreen task is refocused" into main 2025-06-08 19:10:57 -07:00
Android Build Coastguard Worker
083a0acd5f Snap for 13614183 from fb0f2ff41d to 25Q3-release
Change-Id: Ie9a58a4a87eab89605836f95defe062f4d11ec03
2025-06-08 14:17:51 -07:00
shamalip
077234aff5 Widget Picker: Update the launcher integration to support shortcuts
Updates drag and drop, tap to add and preview related code.

Bug: 370950552
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Drag and drop shortcuts on home screen
Change-Id: Iccfe329296dbf4b0770628e77df5cd9b42ac9b21
2025-06-08 20:40:21 +00:00
shamalip
d885e21660 Widget Picker: Update UI layer to support shortcuts
Updates the relevant references to read from the appropriate widget info
 object.

Bug: 370950552
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Open picker for home screen and lockscreen hosts
Change-Id: I1b2a543b69686d859775618a406901591a32f555
2025-06-08 20:10:54 +00:00
shamalip
bb86bde284 Widget Picker: Update data layer to support shortcuts
Adds sealed class for widget info that can contain either appwidget info
or shortcut info.

Also kept the aosp config.xml empty to keep everything eligible for
 featured

Bug: 370950552
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Open picker for homescreen and lockscreen hosts
Change-Id: Iceafc2c1234063b16421f90bf00cf96114e9870c
2025-06-08 20:10:53 +00:00
Android Build Coastguard Worker
10779cab1c Snap for 13613609 from bcb814268c to 25Q3-release
Change-Id: I6434696b616485e9f60880734012d25905e98c95
2025-06-07 14:19:13 -07:00
Treehugger Robot
fb0f2ff41d Merge "Add remove system shortcut to folder items" into main 2025-06-07 14:08:44 -07:00
Bill Yi
bcb814268c Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-06-07 09:33:58 -07:00
Alex Chau
5cd2b21417 Merge "Ignore invalidateHandlerWithLauncher_runsGestureAnimationEndCallback that has never passed" into main 2025-06-07 01:29:11 -07:00
Alex Chau
638e9bfc7c Ignore invalidateHandlerWithLauncher_runsGestureAnimationEndCallback that has never passed
Test was added but never passed on certain target.

Bug: 418979038
Fix: 423041240
Test: presubmit
Flag: EXEMPT Test Only
Change-Id: Id5317c90a97795a8b0cfb76872f75078d3801913
2025-06-07 01:26:53 -07:00
Treehugger Robot
2e01263504 Merge "Refactor WorkspaceTouchListenerUnitTest test." into main 2025-06-06 22:32:06 -07:00
Eric Lin
0791ff9bef Refactor WorkspaceTouchListenerUnitTest test.
Refactor WorkspaceTouchListenerUnitTest test to follow Mockito-Kotlin
(go/mockito-kotlin) best practice.

Bug: 387193964
Flag: EXEMPT bug fix
Test: atest Launcher3RoboTests:WorkspaceTouchListener
Change-Id: I9b1e0a8ea024f7cd6a2e890f4be4902ce80bab07
2025-06-06 20:35:18 -07:00
Android Build Coastguard Worker
3f52740df1 Snap for 13611907 from 5135248ada to 25Q3-release
Change-Id: Ieb13fe06f10b76973dff9649f2c0d0ddc6e33620
2025-06-06 18:19:08 -07:00
Treehugger Robot
892b0fc99b Merge "GAR - Update AllApps text color and font" into main 2025-06-06 17:40:30 -07:00
Treehugger Robot
4047867239 Merge "Implement InMemoryLauncherPrefs backed by InMemorySharedPreferences." into main 2025-06-06 17:20:16 -07:00
Treehugger Robot
5fa3ea28c0 Merge "Add TopTaskTrackerTest" into main 2025-06-06 16:37:04 -07:00
Saumya Prakash
5792cc00ad Merge "Adjust back button's padding for SUW" into main 2025-06-06 15:19:34 -07:00
Federico Baron
ffd3ced53f Add remove system shortcut to folder items
Bug: 419289205
Test: NexusLauncherImageTests
Flag: com.android.launcher3.enable_long_press_remove_shortcut
Change-Id: I4bba230d13696d8d9dc02e232f8a302ae9e893e0
2025-06-06 22:02:32 +00:00
Brandon Dayauon
b024e4d5c5 GAR - Update AllApps text color and font
Update color to onSurface. And font to google sans (flex) which in this case should be variable-title-small since the textsize is 14sp.

bug:418937498
Test manually:
Before DT: https://hsv.googleplex.com/4949187362816000
Before LT:  https://hsv.googleplex.com/5152308714274816
After DT: https://hsv.googleplex.com/6619686841090048
After LT: https://hsv.googleplex.com/6278208621117440
Flag: EXEMPT bug fix

Change-Id: Ib0225bcef38353c451e8fdffefcba97655f97ef1
2025-06-06 14:53:19 -07:00
Vinay Joglekar
c03dd96a10 Fix overview blur state when gemini is over the app.
When app overlay (CtS or Gemini) is involved, overlay is the
firstAppTarget and the actual lowest layer is another target in apps

Instead of blurring behind the lowest firstAppTarget, find the lowest
among all apps targets between all RemoteTargetHandles. This is
determined using layer id.

Fix: 422111861
Test: Launch any app, Long press power button to start Gemini, Swipe up
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I46aa3f642ec3446221ee31d0cf8242970bece9b2
2025-06-06 14:50:38 -07:00
Treehugger Robot
5135248ada Merge "Fix incorrect talkback announcement for app -> home" into main 2025-06-06 14:35:25 -07:00
Brian Isganitis
8f8e82c02d Implement InMemoryLauncherPrefs backed by InMemorySharedPreferences.
Flag: EXEMPT bugfix
Bug: 415787583
Test: InMemoryLauncherPrefsTest
Change-Id: I507d02e45c7ace1cf6cb8df7018f6767e1fdb8af
2025-06-06 17:11:16 -04:00
Anushree Ganjam
ab5b7f56ab [Dagger] Move LauncherRestoreEventLoggerImpl to LauncherAppModule
LauncherRestoreEventLoggerImpl should be available to NexusLauncher as
well. It was a mistake it was exposed only to Quickstep version.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Id36deef2790373651684acb8f03f91ca9e0e662c
2025-06-06 14:09:48 -07:00
Saumya Prakash
1cc6065149 Adjust back button's padding for SUW
This change adjusts the placement for the back button in setup wizard of
16dp. This aligns with the UX design.

Fixes: 418936840
Test: Launch setup wizard and quickly verify a gap between the back
button and the SUW buttons.
Flag: EXEMPT bugfix

Change-Id: Ie7680a5a97e78430b8f7a7fecc8e1c1ee045aa8a
2025-06-06 19:31:11 +00:00
Treehugger Robot
5917e69fa3 Merge "Don't show tasks shown in taskbar within overflow UI" into main 2025-06-06 12:24:36 -07:00
minch
16e53eec2b Add TopTaskTrackerTest
Fix: 406325205
Test: TopTaskTrackerTest
Flag: EXEMPT adding test
Change-Id: Ia4e9de25ff7d19f952e5229edf0b08480c109860
2025-06-06 19:18:57 +00:00
Schneider Victor-Tulias
672c8a10e4 Fix incorrect talkback announcement for app -> home
This change removes the talkback announcement for the background app LauncherState, which defaulted to "Recent apps".

Flag: EXEMPT bug fix
Fixes: 418854152
Test: attempted home/overview/quick switch gestures from home and app
Change-Id: I1f390902dfddd2e8576743dbbddce65121690f14
2025-06-06 15:03:51 -04:00
Treehugger Robot
0fd9ae0277 Merge "Run gesture end callback after gesture animation has ended." into main 2025-06-06 12:00:35 -07:00
Shamali Patwa
a4add54457 Merge changes from topic "no-widget-msg" into main
* changes:
  WidgetPicker: Pass no widgets available message to widgets list
  WidgetPicker: Implement no widgets available message
2025-06-06 11:52:00 -07:00
Pablo Gamito
853c970b54 Merge "Remove json viewer config" into main 2025-06-06 10:56:47 -07:00