A wide variety of gesture navigation bugs were caused if launcher happened to be recreated mid-gesture and we didn't handle it gracefully. Updated lifecycle callbacks to immediately cancel the ongoing gesture if launcher is destroyed.
Fixes: 244593270
Fixes: 257976590
Test: forcefully(programmatically) recreate on every other gesture nav handle touch down; check that following gestures are not broken and animations are not frozen
Change-Id: Ia8e936e26a42cfe26fc6bcd9eefb25d37bc08749
Grid size migration is a confusing experience for users because the
content of the grid is not predicatable to the user. Part of the reason
was the dedupe logic which merges items from new grid into old grid,
this mean if user removes an item, change to another grid and go back,
user will see that same item re-appears.
This CL keeps the content of target grid the same as source gird, i.e
user will will get the exact same set of app icons/shortcuts/folders and
widgets (if size permits) across grid sizes. The only difference being
their placement in the grid.
Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: I1732c91e441ad44bc43e0a943566a83563d12b07
* Updated code, wrote new test for new code
but forgot to update old test.
Fixes: 261110474
Test: FullscreenDrawParamsTest passes
Change-Id: I39a9029b69774f0ea7064da295c516f547bcbef2
Desktop mode prototypes enable freeform tasks on top of launcher.
Launcher is still partially visible in the back which means that
launcher will disable back gesture for the freeform tasks.
When desktop mode prototype 1 or 2 is enabled, skip disabling the back
gesture on launcher.
Bug: 259280363
Test: manual, enable desktop mode and launch an app, try back gesture
from edge
Change-Id: I1d5eb81c7b28fb452c9566e358d77a5b2c19d450
- Added isHotseatIconTopWhenAligned to control both iconAlignment and stash animation to just fade in if hotseat icon isn't on top of the screen in the aligned state
Fix: 257355864
Fix: 213455090
Test: Launch apps from/back to home, taskbar animate from/to hotseat
Test: Launch apps from/back to AllApps/-1, taskbar fade in/out
Test: Repeat aboth with transient or persistent taskbar
Change-Id: I6bdae615ff9e199d23cbfe2d26c8d46a08fbc436
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected
Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen
Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
> Instead introducing an interface for handling click events
> Linking this interface to other UI which handle clicks
Bug: 259733681
Test: Presubmit and verified manually
Change-Id: I9cbf2d009d64254f513deb909a151e46e860d039
Add a method that checks if three web suggests exist and another method to check for
predicted app row and web suggest exists.
bug: 225583735
test: Manual - photo: https://screenshot.googleplex.com/3NoSUm7nzTvf3gX
Change-Id: I7f9340229aaf4a0a3928933035f193a576995525
Previously we setClamp to false right after the gesture ends.
So when the page settle animation gets the page offset, it would
get the unclamped version which would cause the window to move
in the x-axis movement even if the window didn't actually move
during the gesture.
Now we ensure that we setClamp to false after the page transition
ends so that the scroll offset is consistent all the way until
the end of the animation.
Bug: 258851206
Test: 1. swipe a bit diagonally to bring up taskbar with
no x-axis window movement
2. release
3. there should be no x-axis movement on window
Change-Id: Ic9949d11f2e8bc7ccbd737555a3d5551f09456da
Bug: 260101467
Test: open chrome, enter url to pull up ime, swipe up to show taskbar,
tap on taskbar icon
Change-Id: Ic8be6c2bb82fc9b8ab83572cb8622ac157078ea9
