Commit Graph

49892 Commits

Author SHA1 Message Date
Bill Yi
c084cd761e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I755d591028eba2dfa55fea32f1461472ec7da3d0
2023-01-15 20:52:29 -08:00
TreeHugger Robot
77a388c79e Merge "Predictive swipe: show extra app icons at bottom of All Apps's RecyclerViews" into tm-qpr-dev 2023-01-14 06:03:52 +00:00
Tony Wickham
a329718dcf Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev 2023-01-14 01:09:52 +00:00
Sebastián Franco
519714449f Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev 2023-01-14 00:59:47 +00:00
Brandon Dayauon
994bed564e Merge "split the scrolling logging into work,personal, and search" into tm-qpr-dev 2023-01-14 00:32:54 +00:00
Fengjiang Li
3774824cea Predictive swipe: show extra app icons at bottom of All Apps's RecyclerViews
The maximum center scale of All Apps to Home is 90%. It means we should add 5% height to All Apps's RecyclerView to render extra app icons.

Test: manual
bug: b/264906511
Change-Id: I2e970580810220e25d7fc3a86c19abaf87ba2c6e
2023-01-13 15:55:17 -08:00
Randy Pfohl
dcd79bd6cd Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev 2023-01-13 23:02:41 +00:00
Lucas Silva
97976bc345 Merge "Display back button on home settings." into tm-qpr-dev 2023-01-13 19:06:27 +00:00
Sebastian Franco
877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Alex Chau
6367188b33 Merge "Update overview actions top margin" into tm-qpr-dev 2023-01-13 18:05:01 +00:00
Johannes Gallmann
4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
TreeHugger Robot
60c7dfec29 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev 2023-01-13 15:49:07 +00:00
Luca Zuccarini
da31c5e3a3 Merge "[Toast] Add a feature flag for result launch animations." into tm-qpr-dev 2023-01-13 15:14:55 +00:00
TreeHugger Robot
5f3784d147 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev 2023-01-13 13:01:03 +00:00
Vinit Nayak
f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Alex Chau
bebeefe993 Merge "Reduce icon/text simultaneously when cellHeight is not enough for largest display size" into tm-qpr-dev 2023-01-13 00:57:04 +00:00
Jeremy Sim
9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk
1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Alex Chau
f4269f01d7 Revert "Add debug logs for hotseat disapperaed bug"
This reverts commit 04658bcd42.

Reason for revert: root cause found
Bug: 260135164

Change-Id: I809662780d042923de015ff4cb810b3da5169f83
2023-01-12 22:21:07 +00:00
Ats Jenk
984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
randypfohl
9c5fa66d2f Cleaning up UI jank while quick switching
Moving a few calls into the UI helper executor thread, as per the associated bug. duplicated the lines so the synchronous nature of clearing previous state wouldn't affect potential timings.

Test: local testing, rotating screen. quick switching apps.

Bug: 257470365
Change-Id: I59abad9ba51c0b19d467646752aa34ae7ef3ec1d
2023-01-12 19:06:04 +00:00
Christophe Pinelli
3cd6cbe6b4 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev 2023-01-12 18:15:31 +00:00
Ats Jenk
ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot
944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Tony Wickham
7d192c0e71 Remove extra overview threshold if the transient taskbar is already open
Test: Swipe to overview when taskbar is already opened vs not
Fixes: 264555943
Change-Id: Ib4c31b085ca51e50fd7442ff9a27a5f47822c242
2023-01-12 16:48:35 +00:00
Luca Zuccarini
51c89ca493 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev 2023-01-12 14:06:07 +00:00
Nicolo' Mazzucato
696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
2023-01-12 09:19:48 +00:00
Johannes Gallmann
031fbcc564 Prevent workspace enter animation for predictive back
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
2023-01-12 10:06:18 +01:00
Vinit Nayak
1d7e050bc6 Respect nav button tinting in SUW
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
2023-01-11 21:29:37 -08:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Fengjiang Li
e884c2c79f Support predictive back from all apps to home
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
2023-01-11 22:55:28 +00:00
Stefan Andonian
bf69ef034a Merge "Rename LoaderResults to LauncherBinder." into tm-qpr-dev 2023-01-11 22:47:34 +00:00
Stefan Andonian
fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Sunny Goyal
96bfea9d32 Merge "Fetching the session info on the background thread when launching pening icon" into tm-qpr-dev 2023-01-11 22:32:01 +00:00
Stefan Andonian
e82476ad3b Rename LoaderResults to LauncherBinder.
LoaderResults implies a data object, not binding code specific to
Launcher UX containers. This CL merely renames this class and its
usages. It also adds a comment that explains why the functionality is
split into a base class and an implementing class.

Bug: 251502424
Test: Compilation worked correctly.
Change-Id: I01b5ac2f717e9b20612538d5c1e0ca947beb593f
2023-01-11 20:32:25 +00:00
Stefan Andonian
2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Brandon Dayauon
f54e016c82 split the scrolling logging into work,personal, and search
- moved collapse/extend logging with the other scroll logging

bug: 263817965
test: Manual - WW
Change-Id: I9cd57b895c0c2edb7fe39ef98dced574d09a0953
2023-01-11 10:09:27 -08:00
Alex Chau
7351218fab Update overview actions top margin
Bug: 260596114
Test: manual
Change-Id: Ic5f51a8d0505571272e5ad03bd16db2b903fd697
2023-01-11 15:41:52 +00:00
Luca Zuccarini
50ef8004e0 [Toast] Add a feature flag for result launch animations.
Bug: 250588519
Test: manual
Change-Id: I6d605bf8b1008a3b12497e1d04601735ad79c001
2023-01-11 13:16:02 +00:00
Jagrut Desai
50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height.
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
2023-01-11 04:16:07 +00:00
Tony Huang
d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Jeremy Sim
5f8dd20236 Fix transition animations for launch-from-staged operation
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
2023-01-10 15:44:23 -08:00
Jagrut Desai
4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai
ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel.
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
2023-01-10 22:57:35 +00:00
Ats Jenk
774f05226b Hide DesktopTaskView background while animating
While animating DesktopTaskView to/from fullscreen, hide the background.
Background should only show up when this taskview is shown in recents.
While it is animating, we don't need to show it.

Bug: 263264985
Test: manual, trigger transient taskbar, observe that background does
not flicker

Change-Id: I76d0eb1857645b7f04a0b2e1eebe2393c252c257
2023-01-10 11:39:17 -08:00
Sunny Goyal
5fe99d560e Fetching the session info on the background thread when launching pening icon
Bug: 242669604
Test: Verified that the RPC is not made on UI thread
Change-Id: I4299628b8b3e9aa2844f5556c57f47d997dd85e1
2023-01-10 11:02:58 -08:00
Alex Chau
616de308b7 Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev 2023-01-10 18:34:08 +00:00
Alex Chau
06f36e8568 Reduce icon/text simultaneously when cellHeight is not enough for largest display size
- Follow-up of http://ag/20691430
- Reduce iconDrawablePaddingPx to further recover space
- Then proportional reduce both iconSizePx and iconTextSizePx
- This will result in larger icon/text size in px when going from larger to largest for most devices
- For extremely large desnity (> largest for most devices), iconSizePx/iconTextSizePx will inevitably reduce due to smaller availalbe space

Fix: 264149604
Test: test different density between larger and largest, check that icon/text size continues to grow in px
Change-Id: I1633566b9372acf1393c7e997598cb3e46c4a507
2023-01-10 18:11:59 +00:00
Ats Jenk
83a8dad319 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev 2023-01-10 18:09:16 +00:00
Luca Zuccarini
fb4429f0b0 Revert^2 "Update timings for the Home <> All Apps transition."
e18ac479e5

Change-Id: Id09987b2c67be70e62349574973d4bc62b10bc9d
Bug: 263221786
2023-01-10 17:05:29 +00:00