Commit Graph

116 Commits

Author SHA1 Message Date
Vinit Nayak
6fa1ab9441 Merge "Unify split options into single option" into tm-qpr-dev 2023-02-03 06:07:41 +00:00
Saumya Prakash
334094da9e Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev 2023-02-02 21:54:10 +00:00
Saumya Prakash
b1291e6ae2 Redesign the tutorial for the go home gesture
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.

Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
2023-02-02 18:14:14 +00:00
Vinit Nayak
5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Brian Isganitis
7881b81aa7 Add settings asset to persistent Taskbar tooltip.
Test: Manual (3 button)
Bug: 263157739
Change-Id: I8daf3c08e48ef1f9ec190af301333d279878aa59
2023-01-31 14:07:34 -08:00
Brian Isganitis
49af57bad3 Capitalize Taskbar in EDU tooltip and update strings.
See https://b.corp.google.com/issues/263157739#comment14.

Test: Manual
Bug: 263157739
Change-Id: If487761a097154c9a4a7091ce88de4f707abadc9
2023-01-25 19:10:28 -08:00
Brian Isganitis
b21ad2da8c Implement initial transient Taskbar EDU tooltips.
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
2023-01-20 15:16:12 -08:00
Ikram Gabiyev
448e0ade10 Filter recents view instances by package name
Filter instances of GroupTasks based on package name
as a part of support for multi-instance

Add a feature flag to toggle multi-instance features

See the video below for how to use the demo.
Note: some extra UI elements were added since video
was recorded, but the filtering process is the same.
http://recall/-/da585DRwKRZK3S2xxcQrSm/gW9HZnbCvGyH1DQiVizOW2

See go/multi-instance for more info about the feature

Bug: 253520408

Test: manually tested the instance filtering

Change-Id: I19c947ca353699096388b9fbbdca6d75cb0041a7
2022-12-28 00:10:48 +00:00
Brian Isganitis
77de0d5a28 Add EDU lottie animations for persistent and transient.
This CL introduces separate lottie assets for light and dark themes, as
well as each step. Each asset contains all of the steps currently but is
constrained to a min and max frame. In future CLs, we will optimize the
storage these take up by using the global assets and controlling min and
max frames programmatically, or trimming each individual asset.
Additionally, we should only be importing one theme variant and then
converting to the opposite programmatically, but the color mappings are
not ready yet.

Future polish to the EDU sheet, such as better handling the stashed
taskbar, will be introduced in future CLs.

Test: Manual in transient and persistent modes.
Bug: 217261955
Change-Id: I5b219ea02e25de0c5c887b5b5640f909e1219287
2022-12-08 14:06:09 +00:00
Brian Isganitis
50b3b62eba Merge "Add a11y titles for taskbar windows." into tm-qpr-dev 2022-11-18 01:56:22 +00:00
Brian Isganitis
61b01e2c2a Add a11y titles for taskbar windows.
Test: Manual with Talkback.
Fix: 228389333
Change-Id: If30311166fde155d04cf1c9a6865c98d380a93ea
2022-11-17 20:56:04 +00:00
Schneider Victor-tulias
6386d4b55b Update All set page subtitle to use the same device name used acrss the SUW
Fixes: 252972556
Test: launched the all set page on a large screen, foldable and phone
Change-Id: Id6cb86ff85aeb1453f96e707dc4921d23513c406
2022-11-17 10:58:55 -08:00
Vinit Nayak
bddda819d2 Merge "Update unsupported split app error text" into tm-qpr-dev 2022-11-15 20:06:46 +00:00
Pat Manning
39a3ac6fe5 Update string for "swipe to go home" when in button nav.
Bug: 252938555
Test: manual
Change-Id: Id52867ec6a9b82a44ab0a803a9824258d9ad4044
2022-11-15 11:19:32 +00:00
Vinit Nayak
b2711a81e6 Update unsupported split app error text
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
2022-11-14 15:20:25 -08:00
Sunny Goyal
c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
Schneider Victor-tulias
8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
Schneider Victor-tulias
38c59cfe4a Update gesture nav tutorial with updated phone landscape layouts
- Updated layout files to support landscape mode on phones
- Updated All Set page to say "tablet" rather than "phone" on tablets
- Hiding feedback view during gestures for better visibility
- Renamed files and resources to say "tablet" rather than "foldable"
- Added custom layout logic for the mock hotseat on foldables
- Updated feedback view margins

Test: manual
Fixes: 215063763
Fixes: 206895841
Fixes: 219251891
Change-Id: I56f7f33dd0617bdeeca4863f7d5de0143376c8bf
2022-03-08 13:57:42 -08:00
Merissa Tan
d41ce4980d Create new DesktopNavbarButtonsViewController class.
This CL creates a new DesktopNavbarButtonsViewController class to allow
for taskbar buttons and status icons customization on desktop
environment.

Recall: http://recall/clips/e008d2de-36d3-47f6-954a-5ce18bac69a5

Bug: 213964564
Bug: 196757951
Test: Switch between different system navigation modes and verify the
desktop taskbar buttons stay on screen.

Change-Id: Ie7a9a044fad3b60cd37d910b8eb78c8734aadfd5
2022-01-18 17:10:15 -08:00
TreeHugger Robot
05de8c874f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev am: c0a6d3fc8f am: e81cab2fa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346766

Change-Id: I03d32f4df17adc36982ad03896583ede306934d3
2022-01-13 21:06:28 +00:00
TreeHugger Robot
c0a6d3fc8f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev 2022-01-13 20:36:44 +00:00
Sebastian Franco
411b71bf09 TalkBack doesn't announce when a task has being closed.
Adding announceForAccessibility() in createTaskDismissAnimation()
to announce the task has being closed.

Test: Manually tested
Fix: 186744160
Change-Id: I71f57e7ba03a61b2ced7e338da4251637e89bd16
2021-12-09 20:27:51 +00:00
Tracy Zhou
74fd7af92d Add content descriptions to task bar nav buttons
Fixes: 209608812
Test: manual
Change-Id: Iba50abfb2a3d33104b6d88574df0bc7b5daf1d3a
2021-12-08 10:44:31 +00:00
Schneider Victor-tulias
e9bd547a54 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6 am: ad5f39c990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I5a88a4c01933f42f86a656b59d8737509120ac36
2021-12-06 16:03:01 +00:00
Schneider Victor-tulias
fc846eef41 Update taskbar edu strings for i10n.
Fixes: 200777300
Test: none
Change-Id: I9d6e2575940d2fcdd354c94036662c178f9d6eee
2021-12-01 16:04:33 -08:00
Schneider Victor-tulias
a3fe68dcb1 Implement AccessibilityDelegateImpl for the Taskbar
- Added accessibility actions to open pop up menu
- Added accessibility actions to open an app/shortcut to the top/left or bottom/right

Fixes: 204453506
Bug: 198438631
Test: attempted all actions individually, attempted combinations of actions (eg. open pop up menu -> move to left/right)
Change-Id: I76a4237035a0ebfe88b8b5f147b574bb2629f20c
2021-11-30 23:02:55 -08:00
Nick Chameyev
0288d2e8bb Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-11-01 10:36:34 +00:00
Nick Chameyev
5c446d9ed4 Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-10-29 10:17:18 +00:00
Vinit Nayak
3e9bd87ca9 Prevent launching app in split if task split is unsupported
Bug: 204026157
Change-Id: Ie13ac74e0c1d357db242d49083be97f0f45e6ca5
2021-10-26 11:10:23 -07:00
sfufa@google.com
7a620d3673 [Search] Hide A-Z list when search is entered from QSB
preview attached to bug report

Bug: 201781284
Test: manual
Change-Id: I572360d2d49b38577a7d77115aede4c3269d42e9
2021-10-15 15:49:43 -07:00
Vinit Nayak
8217054355 Add toast instructing user to select second split app
Fixes: 200131929
Change-Id: I1825fba64a42cef1d067bd5e085273d1eca68fce
2021-09-28 10:26:21 -07:00
Android Build Prod User
da403a97aa Merge "Updates Taskbar Edu steps." into sc-v2-dev 2021-08-27 00:03:47 +00:00
Andy Wickham
f9ea9ce1cd Updates Taskbar Edu steps.
They are now:

1. Switch apps
2. Splitscreen
3. Docking

They all use the same (blank) placeholder image.

Bug: 180605356
Test: Manual

Change-Id: I53b3f71519c50a1d93f800490d3127e4d669e068
2021-08-26 10:22:20 -10:00
Vinit Nayak
6174106f68 Add Split button in OverviewActions
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)

Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
2021-08-26 11:49:38 -07:00
Andy Wickham
a0cc0903e8 Adds additional pages to Taskbar Edu.
Currently there are pages for the following:
 - Splitscreen
 - Customize (add apps/predicted apps)
 - Docking (long press to hide)

At the moment they all use the same placeholder
image from before.

Button states:
 Page 1: Close and Next
 Page 2: Back and Next
 Page 3: Back and Done

You can also swipe left and right between the pages.

Demo: https://drive.google.com/file/d/1_D3i-jZxCRRVHV92p6hG5cm3VGcJ_bhK/view?usp=sharing&resourcekey=0-KHLHTTx67JlmVv-UZoAUAw

Bug: 180605356
Test: Manual
Change-Id: Ibbb81610a611f6ca412e53ed90dc1c67764f417e
2021-08-23 15:12:39 -10:00
Andy Wickham
13f3ffed95 Adds initial Taskbar Edu implementation.
Currently it just pops up with one placeholder image for splitscreen.
The Next button doesn't do anything.

Screenshots:
Light: https://screenshot.googleplex.com/B27CwBcwobHTghN.png
Dark: https://screenshot.googleplex.com/48EuJZv8evd5RGW.png

Known issues:
 - Back gesture is picked up behind by the app behind the taskbar.
 - When the flag is enabled, the Edu shows up each time you open
   an app, rather than only the first time.

Bug: 180605356
Test: Manual
Change-Id: Ifba9aa59abf1501b5f8ddebb3fcc13df85f6efaa
2021-08-17 09:57:47 -07:00
Schneider Victor-tulias
bfe33b057a Update Gesture navigation tutorial to match new specs
- Updated strings
- Updated removed 'next' button when there are followign steps
- Added timeout to automatically continue the tutorial
- Combined back left and right into one step

Bug: 192009114
Bug: 177005427
Test: manual
Change-Id: I58b9017c4d69b5d097326c7d5be156a63951fb1a
2021-07-09 19:38:16 +00:00
Schneider Victor-tulias
8a3a857668 Update Gesture nav tutorial.
- Seperated back left and right edge tutorial steps
- updated back left and right tutorial step strings
- Removed feedback view timeout
- Added accessibility focus on title when feedback view appears
- Added logic to show feedback when the tutorial fragment is stopped then resumed

Test: manual

Bug: 169687177
Fixes: 188116424
Fixes: 188115939
Fixes: 188124784
Fixes: 188555152
Fixes: 188972969

Change-Id: I97755a455bf3fa4674955d5cc91ed8b02f484b76
2021-05-25 14:16:41 -07:00
Schneider Victor-tulias
29f61d5d21 Updated gesture navigation tutorial.
- Removed 'x' button and added tappable 'skip' text to exit the tutorial.
- Updated tutorial step indicator
- updated AVD colors.
- removed unused AVDs
- Increased the visible duration of the feedback view

Test: Manual
Bug: 148542211
Bug: 169687177
Change-Id: Ice61b1273ff270b068d008b5259d100c66057478
2021-05-18 20:00:26 +00:00
Andy Wickham
53a44a2e51 Merge "Update gesture navigation tutorial." into sc-dev 2021-05-12 09:31:44 +00:00
Schneider Victor-tulias
e3af6c6513 Update gesture navigation tutorial.
- Updated gesture navigation feedback videos.
- Added feedback motion loop videos.
- Updated strings.
- Added alternate strings for when the user launches tutorial steps from the Tips app.

Test: manual
bug: 169687177
Change-Id: I87d475e1510a25ffefea14dbd0b224a063e7cad8
2021-05-11 18:14:29 -07:00
Andy Wickham
474c616e98 Adds AllSetActivity in Launcher.
Mostly copied from its location in Tips.

Some exceptions:
 - Accent color (used for the icon at the top and link text)
   is derived from intent extras to match the rest of SUW.
   If needed, we could also pass other colors this way;
   currently they just use default light/dark mode colors.
 - Currently there is no animation in the middle. Not sure
   if one is expected, but we can add it later if so.

Bug: 184722307
Test: Manually passing arbitrary colors via adb:
adb shell am start -a com.android.quickstep.action.GESTURE_ONBOARDING_ALL_SET --ei accent_color_dark_mode -2134901760 --ei accent_color_light_mode 2147418112

Change-Id: I1fb8b20b88b7485d28f06afd2b421999ad847266
2021-05-04 18:44:22 -07:00
Schneider Victor-tulias
fb552936fd Complete gesture nav sandbox for for UXR.
- Removed All set screens altogether.
- Added "x" button to feedback view. This button now launches a dialog that allows the user to skip the tutorial.
- Added a progress tracker to the feedback view.
- Created a launch option to launch the back, home, then overview gesture tutorials in order.
- Added a button in the feedback view to progress through the tutorial.
- Updated tutorial animations to AnimatedVectorDrawables (with green accents).

Bug: 148542211

Test: manual
Change-Id: Icf3ec424141069895f97da74cd4ae881ff898d3f
2021-04-19 13:41:57 -07:00
Schneider Victor-tulias
3ce81f275f Update gesture navigation string resource for translations.
Updated the gesture navigation tutorial skip dialog's subtitle string resource and description:
1. increase char limit.
2. Added a placeholder string.
3. Updated the description to be clearer for translators.

bug: 185381331
Test: none
Change-Id: I6f06991694d48a9babf98777b377393f32998956
2021-04-16 13:38:26 -07:00
Samuel Fufa
ac120c9a47 [Search] make AbstractSlideinView#createColorScrim overridable
+ Introduce feature flag for people tile results

Bug: 183972880
Bug: 184003600
Test: Manual
Change-Id: Ia8b3af4e99a66f640f6f42fc5886d9cbfb5e913c
2021-04-06 03:18:07 -05:00
Schneider Victor-tulias
6062b851be Add strings for gesture navigation tutorial.
Added string resources needed for the gesture navigation tutorial.

Test: none.

Bug: 169687177
Change-Id: I75b863141954f6459693dfb6f16ed0d1fff9920d
2021-03-25 11:09:57 -07:00
Vinit Nayak
d987a828e8 Initial commit of new split screen work.
TODO:
* Extract out common elements in TaskShortcutFactory.MultiWindowFactory
for commonalities between new and old way of
invoking split screen
* Integrate with WM APIs (b/182002789)
* Write tests for SplitSelectStateController

Bug: 181704764

Change-Id: Ice35adb4ea82897f5e2433dc9b93a549f3d511b5
2021-03-15 15:42:32 -07:00
Samuel Fufa
062a8fd979 Introduce feature education for AllApps Search
Preview: https://drive.google.com/file/d/1eXf3K6kFh0bHcYlpwW_voSRjY9RQalJN/view?usp=sharing&resourcekey=0-IABjrtXM5JhHvSf-7yc4tg

Edu can be dismissed permanently by pressing "Got it" button or typing. Swiping down defers edu until next visit to all apps

- Move fallback search to quickstep
Bug: 178100472
Test: Manual

Change-Id: I920aab366330758e81f8b9fa62736abf82fe5cac
2021-01-25 15:17:34 -06:00
Winson Chung
f99351888c Revert "Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ...""
This reverts commit 087a9e39b6.

Change-Id: I05b17a6e4aaaef6de3c2fa26aad45a39eb2833f9
2020-10-23 09:27:48 -07:00
Alistair Delva
087a9e39b6 Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ..."
Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert submission 12738409-merge_ub-launcher3-master_6877130

Reason for revert: Introduced crashes to global presubmit

Reverted Changes:
I624658ce6:Merge commit '8d14dbe041199d611839140f1c9285fd4174...
Iccd2f1e3a:Merging from ub-launcher3-master @ build 6877130
I791d64951:Merging from ub-launcher3-master @ build 6877130
Icdd32ab01:Merging from ub-launcher3-master @ build 6877130

Bug: 169963211
Change-Id: I77a4ae59e823147beae8dd7cb9b54ccdace2c7f4
2020-10-05 14:46:26 +00:00