Commit Graph

78693 Commits

Author SHA1 Message Date
Treehugger Robot
9cafa2f8e2 Merge "Revert "Revert "Don't allow Desktop tasks to go outside Overview..."" into main 2024-11-04 15:34:43 +00:00
Sam Cackett
1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00
Sam Cackett
127eb0b44d Merge "Revert "Don't allow Desktop tasks to go outside Overview task bounds"" into main 2024-11-04 10:01:08 +00:00
Manusaran Reddy Avula (xWF)
e906e733be Revert "Don't allow Desktop tasks to go outside Overview task bounds"
Revert submission 30114356-desktop-task-view-corner-clipping

Reason for revert: Culprit for b/376872073

Reverted changes: /q/submissionid:30114356-desktop-task-view-corner-clipping

Fix: 376872073
Bug: 376206104
Change-Id: I51c8b11a868a727145f0bc8a6feb13352a8cbead
2024-11-04 10:00:23 +00:00
Treehugger Robot
22a60f4940 Merge "Recycle tasks that are split when split select anim complete for reuse" into main 2024-11-02 06:13:53 +00:00
Uwais Ashraf
ca39594be9 Recycle tasks that are split when split select anim complete for reuse
Fix: 376428479
Flag: EXEMPT bugfix
Test: Manual verification of heap dumps
Change-Id: I8574c68da76227258985cb77955548352275049d
2024-11-02 00:48:26 +00:00
George Lin
a64d474286 Merge changes from topic "shape_communication_with_fix" into main
* changes:
  Shape screen communication with the Launcher's app (2/2)
  Fix grid entry is missing
2024-11-01 21:10:50 +00:00
Liran Binyamin
5aa29ea9df Merge "Update the flyout collapsed position" into main 2024-11-01 20:08:07 +00:00
George Lin
2b6f265bf9 Shape screen communication with the Launcher's app (2/2)
This is a revertx2 of ag/29934361 with the fix of b/376371559

Support querying / preview / apply for the shapes from the Launcher's
app.

Test: Manually tested that it works
Fixes: 376371559
Bug: 348664593
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I232040f4c3661f149de4c88810e51f6dd8bac9c3
2024-11-01 18:07:05 +00:00
George Lin
50d2c82de6 Fix grid entry is missing
Test: Manually tested that the entry shows up again
Fixes: 376371559
Flag: EXEMPT bugfix
Change-Id: I8ecc842b948f0ed0676d3600d9538450012c7e80
2024-11-01 17:37:55 +00:00
Liran Binyamin
6563429e2b Update the flyout collapsed position
This change ensures that we're updating the distance to the flyout's
collapsed position before we start collapsing it. The distance is
initially calculated before we start expanding, but when a new bubble
is added while we're fully expanded, and if we previously had 1
bubble and now have 2, the collapsed position changed, so we need to
update it before we start collapsing.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 376276297
Test: manual
      - dismiss all bubbles
      - create 1 bubble
      - after the flyout is fully expanded create a second bubble
      - observe the flyout is updated with the contents of the second
        bubble
      - observe when the flyout collapses, it collapses to the dot
        on the second bubble
Change-Id: I219886fd6463d69692d9945d901d1f3ad3cb26a0
2024-11-01 11:56:36 -04:00
Treehugger Robot
72a6d4539a Merge "Don't allow Desktop tasks to go outside Overview task bounds" into main 2024-11-01 12:35:20 +00:00
Bill Yi
567584433f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-01 03:15:17 +00:00
Liran Binyamin
65edaf53af Merge "Hide bubble dot after flyout init" into main 2024-10-31 22:46:56 +00:00
Mykola Podolian
db427334f2 Merge "Preserve bubble bar state." into main 2024-10-31 20:57:36 +00:00
Tony Wickham
0f954d9d3b Merge "TaskbarManager now sets TaskbarUIController for RecentsWindowManager" into main 2024-10-31 20:17:21 +00:00
Liran Binyamin
0e8093ae92 Hide bubble dot after flyout init
After the flyout initializes to its collapsed state, hide the
notification dot so that the flyout and dot will seem visually as
one.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 376276297
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie581ddcd56a26844526f80b2169639c1a7d87500
2024-10-31 15:56:19 -04:00
mpodolian
647266f298 Preserve bubble bar state.
Added logic to save and then restore existing bubbles in the
TaskbarSharedState object.

Bug: 375482371
Test: Manual. Switch between pinned and unpinned taskbar. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/d8hVHxksAokx85J8P7etoC
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I34f580f1c652859f427385edc0ccadd447e1400f
2024-10-31 11:50:46 -07:00
Wen-chien Wang
71ec86e398 Merge "Add margins to KQS view that is triggered from transient taskbar" into main 2024-10-31 18:06:49 +00:00
Mady Mellor
886387fd58 Merge "Fix an issue where the overflow wouldn't show if the flag was disabled" into main 2024-10-31 17:18:28 +00:00
Treehugger Robot
2891d5cb47 Merge "Add listener to update taskInfo when task change via transition" into main 2024-10-31 16:30:42 +00:00
Jordan Silva
2627657ab6 Add listener to update taskInfo when task change via transition
This change ensures the task information in TopTaskTracker stays updated with any task modifications. For instance, switching a task between freeform windowing and fullscreen will now update in TopTaskTracker, and consequently, in the RecentTasksList used by RecentsModel and RecentsView. This resolves a previous bug where switching a freeform task to fullscreen wasn't reflected, causing the new Fullscreen task and an incorrect DesktopTask state to display in the Overview.

Fix: 356355595
Flag: com.android.window.flags.enable_task_stack_observer_in_shell
Test: Manual.
Change-Id: Ib4a6eb8ea6abd21903018b05186c516511526746
2024-10-31 16:29:34 +00:00
Liran Binyamin
3955e224be Merge "Handle new bubble notification during animation" into main 2024-10-31 13:56:06 +00:00
Bill Yi
0c9dc91394 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2b760d662d7d2b00fd7f3f645dd84b682c2c3842
2024-10-30 18:31:35 -07:00
Treehugger Robot
9486f5b455 Merge "OneGrid Grid Option Updates" into main 2024-10-30 22:06:11 +00:00
Holly Jiuyu Sun
5cf9dd0840 Merge "[clean-up] Clean up Quick Launch V2 and V1." into main 2024-10-30 22:05:41 +00:00
Liran Binyamin
0242d124c2 Handle new bubble notification during animation
When a new bubble notification is pushed during an ongoing animation
we now update it to reflect the new bubble.
 - If the current animation is in the middle of animating in,
   we only update the animating bubble without interrupting the
   current animation. The flyout content will show the data for the
   new bubble.
 - If the current animation is in the IN state, then the flyout is
   showing and we're just waiting for it to be hidden. In this case
   we update the flyout and reschedule the hide animation to run after
   a delay.
 - If the current animation is animating out,
   - If we're in the middle of collapsing the flyout, we reverse it
     so it shows with the new content and reschedule the hide animation
   - If the flyout is gone already, then we reverse the handle animation
     and show the flyout. If the handle animation is not running, then
     the animation is already over.

Not really related to this change, but while testing one of the tests
was flaky, so rewrote it to make it deterministic.

25x runs: https://android-build.corp.google.com/test_investigate/invocation/I56000010330987902/test/TR44729496826317635/

Demo of interrupting the animation while animating out: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cu4fLeFlnDkg7mDVaaDTB

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 277815200
Fixes: 346400677
Test: atest BubbleBarFlyoutControllerTest
Test: atest BubbleBarViewAnimatorTest
Change-Id: I2b4af36d39bedbdfc4a08a988967ccbc33c06522
2024-10-30 16:57:08 -04:00
Ana Salazar Maldonado
4525546646 Merge "Add flag for launcher contrast tile" into main 2024-10-30 20:51:06 +00:00
Charlie Anderson
6963d7c0e3 Merge "Add custom talkback action for unarchiving apps" into main 2024-10-30 20:50:04 +00:00
Tony Wickham
87455f28fc TaskbarManager now sets TaskbarUIController for RecentsWindowManager
- FallbackTaskbarUIController can take in a generic
  RecentsViewContainer parameter, i.e. RecentsActivity or
  RecentsWindowManager.
- When changing Overview targets to RecentsWindowManager, which is not
  an Activity, we still update the TaskbarUIController

Test: Switch between default Home activities with the flag on and off,
ensure Taskbar works as expected in each case (3P vs 1P launcher).
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 368030750
Fixes: 365775636

Change-Id: Ife775e8c226f8c73ec9e1f97b4a6f2972f6c905f
2024-10-30 20:21:26 +00:00
Mady Mellor
e07699ae6a Fix an issue where the overflow wouldn't show if the flag was disabled
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - check that optional overflow flag is off and get
               bubbles in bubble bar, overflow should be present
Bug: 358304168
Change-Id: I1eb709003d4dcdde7ae465b837a2c68d40b1a828
2024-10-30 12:30:14 -07:00
Treehugger Robot
c798f7800a Merge "Convert GridSizeMigrationLogic and DbEntry to Kotlin" into main 2024-10-30 19:27:20 +00:00
Brian Isganitis
f9dea5e095 Merge changes I20cff11c,I751cdab5 into main
* changes:
  Stop suspending Launcher Taskbar in tests.
  Sandbox SettingsCache for Taskbar tests.
2024-10-30 19:05:14 +00:00
Charlie Anderson
eac269ac81 Add custom talkback action for unarchiving apps
Bug: 373746865
Test: manually with Talkback
Flag: EXEMPT bugfix
Change-Id: I8c9efc029c2172e0dacd644b34f4930f50a7f8aa
2024-10-30 14:44:08 -04:00
fbaron
ebc10c9ecc OneGrid Grid Option Updates
Bug: 330900048
Flag: com.android.launcher3.one_grid_specs
Test: n/a
Change-Id: I919195dbc7ac78c3be42f0f9d7620193a24d7e99
2024-10-30 11:38:09 -07:00
Charlie Anderson
04cac2fc6a Merge "Convert IconShape to use Dagger" into main 2024-10-30 17:43:52 +00:00
Brandon Dayauon
5d927b25e8 Merge "Fix crash when pausing work profile." into main 2024-10-30 17:17:31 +00:00
Treehugger Robot
5c9a48d5ed Merge "Revert "Shape screen communication with the Launcher's app (2/2)"" into main 2024-10-30 17:10:58 +00:00
fbaron
65ee96c65d Convert GridSizeMigrationLogic and DbEntry to Kotlin
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2f9373fbc52a3d1c29242f7cd5a4042af617f0af
2024-10-30 09:32:49 -07:00
Ana Salazar Maldonado
870e8832ff Add flag for launcher contrast tile
Bug: 341217082
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Change-Id: I13720e037e51d33541012f5dcb49306284ea8899
2024-10-30 16:32:02 +00:00
Charlie Anderson
c8e557a394 Convert IconShape to use Dagger
Bug: 372012340
Test: presubmit
Flag: EXEMPT dagger change
Change-Id: Ic4161fc0eac45cd71191f048472df01691018949
2024-10-30 11:34:15 -04:00
Daniel Chapin
cd958b38ac Revert "Shape screen communication with the Launcher's app (2/2)"
Revert submission 29934361-launcher-communication

Reason for revert: b/376371559 

Reverted changes: /q/submissionid:29934361-launcher-communication

Change-Id: I26b2339fdb4da11312d4587ab31c23880ef0d746
2024-10-30 14:56:08 +00:00
Charlie Anderson
859bbaa718 Merge "Convert PackageManagerHelper to use Dagger" into main 2024-10-30 14:24:15 +00:00
Schneider Victor-tulias
de739c226d Merge "Fix launcher crash on configuration changed" into main 2024-10-30 14:08:49 +00:00
samcackett
3ae3d297e6 Don't allow Desktop tasks to go outside Overview task bounds
Wrap TaskThumbnailView's in a new DesktopTaskContentView. This is in order to correctly crop the thumbnail children contained in the DesktopTaskView, otherwise any freeform task screenshots at the edges of the DTV leak outside the bounds.

We need a new container to do this, otherwise we will cut off the icon
or the hover border if we apply an outline to the DesktopTaskView itself.

Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest
Change-Id: Ic51438e63aaf671a0a8156815d11fc7fa12beac0
2024-10-30 07:22:45 +00:00
Vinit Nayak
d626cdd727 Merge "Disable OrientationEventListener in RotationTouchHelper#destroy()" into main 2024-10-30 01:38:32 +00:00
Toshiki Kikuchi
c6b29e374c Merge "Handle display windowing mode change in onConfigChanged" into main 2024-10-30 01:25:23 +00:00
Ana Salazar Maldonado
9c907b5d4f Merge "Revert "Add flag for launcher pill"" into main 2024-10-30 01:00:29 +00:00
Cosmin Băieș
a8190abb3a Merge "Cleanup ENABLE_HIDE_IME_CAPTION_BAR flag" into main 2024-10-30 00:19:01 +00:00
Yuichiro Hanada
ca23e23655 Merge "Move the animator for the minimization to WMShell" into main 2024-10-29 23:19:09 +00:00