Commit Graph

137 Commits

Author SHA1 Message Date
Vinit Nayak
1d3035e024 Prevent widgets from entering split
Bug: 296502210
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Change-Id: I1a166f6ca0fe5fd2fa1d29b97b8856e52985e0c1
2023-11-10 12:17:12 -08:00
Vinit Nayak
5f09091583 Show split select instructions toast when starting split on workspace
* Used same animation properties that RecentsView uses to
show the instructions view unfolding
* TODOs:
  * UI polish (correct asset, animation timings, etc)
  * Hook into existing animations (if possible)
  * Migrate recentsView splitInstructionsView to use same/similar code path;
    remove RecentsView#safeRemoveDragLayerView

Bug: 276361926
Test: Create split w/ and w/o flag, works as expected
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I7a51b71c358902399ad73b650287cdbf1dad07c6
2023-07-14 17:49:42 -07:00
Saumya Prakash
afda61d92c Merge "Update the strings in the gesture nav tutorial" into udc-dev am: 0d87c4766e am: 87085d3b4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23659350

Change-Id: I7718af3e47d2d076e73812f277040dd89e01e3a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 05:25:55 +00:00
Saumya Prakash
b932cf4b64 Update the strings in the gesture nav tutorial
Change the strings for the instructions and feedback for the gesture navigation tutorial to align with new UX changes.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 286547594
Test: Manually went through the redesigned tutorial and verified that
the new strings correctly show up. Also checked that the previous
tutorial remains unchanged.

Change-Id: I27a3e8c0f09e7755e6087ce5b004b687f229d153
2023-06-12 21:26:43 +00:00
Saumya Prakash
7a69792b26 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev am: 372de4f521 am: 4522e5d2ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493333

Change-Id: I0efd0da5bea9f4490b2688aaf295a320947eceea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-11 23:56:40 +00:00
Saumya Prakash
e2711c254a Enforce the correct orientation for the gesture navigation tutorial
The lottie animations used for the gesture navigation tutorial are
designed for specific orientations depending on the device. This change
ensures that users are in the correct orientation for their device. For large screen users in portrait mode, we display a prompt to rotate the screen.

Flag: ENABLE_NEW_GESTURE_TUTORIAL
Fix: 277781713
Bug: 276515961
Test: Manually went through the tutorial starting from both
orientations on handheld, foldable, and tablet to ensure that the prompt
was shown and hidden correctly. Also ensured that gestures cannot be
completed in the background while the prompt is being shown.

Change-Id: I86ae566721f240264177ad4ec7fc12e58d1b95cd
2023-06-09 21:41:07 +00:00
Ikram Gabiyev
5b914fb5ce Merge "Remove contentDescription attribute in filter icon" into udc-dev am: 749a2d2a6a am: 786046540d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23418186

Change-Id: Ica90e655735160e315e915dbf6b10b3b00c46173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 20:34:57 +00:00
Ikram Gabiyev
45b33a1a55 Remove contentDescription attribute in filter icon
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
2023-05-24 14:01:04 -07:00
Ats Jenk
9f11519936 Show a persistent toast when selecting desktop apps on home screen
When desktop stashed state changes, show a persistent popup on home
screen to select an app that will be launched on desktop.

Flag: persist.wm.debug.desktop_mode_2
Bug: 261234402
Test: launch an app on desktop, swipe home, observe the popup, launch an
  app, observe app is launched on desktop and popup is hidden
Test: stash desktop apps by going home while on desktop, press on the
  "exit desktop" button in the popup, observe popup is hidden, launch an
  app, observe it is launched in fullscreen

Change-Id: I66fe0ab977fa7b2059f149d7d0ab0cf92192c967
2023-05-18 09:31:27 -07:00
Schneider Victor-tulias
b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Jagrut Desai
c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
Brian Isganitis
3ef917a4e3 Cleanup ENABLE_TASKBAR_EDU_TOOLTIP: remove EDU sheet.
Test: Manual
Fix: 270396268
Change-Id: I3cebdb6646060cf6793e5ffc638213dde41338c0
2023-04-10 12:55:18 -04:00
randypfohl
1c0a27a28e Updating overview tutorial to new simple tutorial flow
test: built and tested on multiple devices. recorded videos and shared in chat.

bug: b/253520701, b/253521660, b/241813570

Change-Id: I57f88f5fb35c6a7b1219fac6e992bb84354b91ef
2023-03-20 23:16:10 +00:00
Saumya Prakash
60c419b9b7 Merge "Redesign the gesture tutorial for the Back gesture" into tm-qpr-dev 2023-03-20 18:48:34 +00:00
Saumya Prakash
fd79b4dfbd Redesign the gesture tutorial for the Back gesture
This change adds in a new animation and layout to change the existing back tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the overview gesture. Large screen animations are also added for Home and Back tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 241813570
Bug: 253521922
Bug: 253520701
Test: Manual
Change-Id: Ied18b88a83a3b673a7cf40fd33b6013f24998e44
2023-03-17 23:20:36 +00:00
Ats Jenk
bac6d4946a Merge "Remove empty desktop tile" into tm-qpr-dev 2023-03-09 00:31:50 +00:00
Ats Jenk
4d01acf44e Remove empty desktop tile
Do not show the desktop tile in overview when there are no apps on the
desktop.

Bug: 270399069
Test: have desktop mode proto 2 enabled, launch an app in fullscreen,
  open overview, observe no desktop tile
Test: move an app to desktop, be on desktop, open overview, observe
  overview is opened with desktop tile focused
Test: have an app on desktop, go home and launch an app in fullscreen,
  open overview, observe fullscreen app is focused, desktop is peeking
  in from right
Test: have an app on desktop and a fullscreen app in overview, open
  desktop from overview, close the desktop app, open overview, observe
  desktop tile is not shown
Change-Id: Ia8657d5b260043a630f32b35f2560ea93273d421
2023-03-08 11:49:48 -08:00
Jagrut Desai
1dc99f3848 Announce for accessiblity when taskbar is invoked/closed
Test: Manual
Bug: 265620540
Change-Id: I6660be7716ec59c765f3d54f8fe9889eaaf56e10
2023-03-08 09:54:10 -08:00
Ats Jenk
4d397e2ebb Add empty view to desktop tile in overview
Show an empty view when there are no tasks on the desktop.

Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
  desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
  is shown in overview and empty view is hidden

Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
2023-02-17 16:48:47 -08:00
Schneider Victor-tulias
de7ceba80b Add the KeyboardQuickSwitchView (2/2)
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
Saumya Prakash
0c72529fae Update strings on "All set" screen.
Change the string to "Swipe up to go home" to match new UI changes.
Screenshot: https://screenshot.googleplex.com/5SqP2fQFPKdybcr.png

Fix: 263561675
Test: Manual
Change-Id: Iffc81fa8ea532729096a106e0182200d897375e7
2023-02-08 23:41:56 +00:00
Vinit Nayak
6fa1ab9441 Merge "Unify split options into single option" into tm-qpr-dev 2023-02-03 06:07:41 +00:00
Saumya Prakash
334094da9e Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev 2023-02-02 21:54:10 +00:00
Saumya Prakash
b1291e6ae2 Redesign the tutorial for the go home gesture
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.

Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
2023-02-02 18:14:14 +00:00
Vinit Nayak
5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Brian Isganitis
7881b81aa7 Add settings asset to persistent Taskbar tooltip.
Test: Manual (3 button)
Bug: 263157739
Change-Id: I8daf3c08e48ef1f9ec190af301333d279878aa59
2023-01-31 14:07:34 -08:00
Brian Isganitis
49af57bad3 Capitalize Taskbar in EDU tooltip and update strings.
See https://b.corp.google.com/issues/263157739#comment14.

Test: Manual
Bug: 263157739
Change-Id: If487761a097154c9a4a7091ce88de4f707abadc9
2023-01-25 19:10:28 -08:00
Brian Isganitis
b21ad2da8c Implement initial transient Taskbar EDU tooltips.
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
2023-01-20 15:16:12 -08:00
Ikram Gabiyev
448e0ade10 Filter recents view instances by package name
Filter instances of GroupTasks based on package name
as a part of support for multi-instance

Add a feature flag to toggle multi-instance features

See the video below for how to use the demo.
Note: some extra UI elements were added since video
was recorded, but the filtering process is the same.
http://recall/-/da585DRwKRZK3S2xxcQrSm/gW9HZnbCvGyH1DQiVizOW2

See go/multi-instance for more info about the feature

Bug: 253520408

Test: manually tested the instance filtering

Change-Id: I19c947ca353699096388b9fbbdca6d75cb0041a7
2022-12-28 00:10:48 +00:00
Brian Isganitis
77de0d5a28 Add EDU lottie animations for persistent and transient.
This CL introduces separate lottie assets for light and dark themes, as
well as each step. Each asset contains all of the steps currently but is
constrained to a min and max frame. In future CLs, we will optimize the
storage these take up by using the global assets and controlling min and
max frames programmatically, or trimming each individual asset.
Additionally, we should only be importing one theme variant and then
converting to the opposite programmatically, but the color mappings are
not ready yet.

Future polish to the EDU sheet, such as better handling the stashed
taskbar, will be introduced in future CLs.

Test: Manual in transient and persistent modes.
Bug: 217261955
Change-Id: I5b219ea02e25de0c5c887b5b5640f909e1219287
2022-12-08 14:06:09 +00:00
Brian Isganitis
50b3b62eba Merge "Add a11y titles for taskbar windows." into tm-qpr-dev 2022-11-18 01:56:22 +00:00
Brian Isganitis
61b01e2c2a Add a11y titles for taskbar windows.
Test: Manual with Talkback.
Fix: 228389333
Change-Id: If30311166fde155d04cf1c9a6865c98d380a93ea
2022-11-17 20:56:04 +00:00
Schneider Victor-tulias
6386d4b55b Update All set page subtitle to use the same device name used acrss the SUW
Fixes: 252972556
Test: launched the all set page on a large screen, foldable and phone
Change-Id: Id6cb86ff85aeb1453f96e707dc4921d23513c406
2022-11-17 10:58:55 -08:00
Vinit Nayak
bddda819d2 Merge "Update unsupported split app error text" into tm-qpr-dev 2022-11-15 20:06:46 +00:00
Pat Manning
39a3ac6fe5 Update string for "swipe to go home" when in button nav.
Bug: 252938555
Test: manual
Change-Id: Id52867ec6a9b82a44ab0a803a9824258d9ad4044
2022-11-15 11:19:32 +00:00
Vinit Nayak
b2711a81e6 Update unsupported split app error text
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
2022-11-14 15:20:25 -08:00
Sunny Goyal
c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
Schneider Victor-tulias
8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
Schneider Victor-tulias
38c59cfe4a Update gesture nav tutorial with updated phone landscape layouts
- Updated layout files to support landscape mode on phones
- Updated All Set page to say "tablet" rather than "phone" on tablets
- Hiding feedback view during gestures for better visibility
- Renamed files and resources to say "tablet" rather than "foldable"
- Added custom layout logic for the mock hotseat on foldables
- Updated feedback view margins

Test: manual
Fixes: 215063763
Fixes: 206895841
Fixes: 219251891
Change-Id: I56f7f33dd0617bdeeca4863f7d5de0143376c8bf
2022-03-08 13:57:42 -08:00
Merissa Tan
d41ce4980d Create new DesktopNavbarButtonsViewController class.
This CL creates a new DesktopNavbarButtonsViewController class to allow
for taskbar buttons and status icons customization on desktop
environment.

Recall: http://recall/clips/e008d2de-36d3-47f6-954a-5ce18bac69a5

Bug: 213964564
Bug: 196757951
Test: Switch between different system navigation modes and verify the
desktop taskbar buttons stay on screen.

Change-Id: Ie7a9a044fad3b60cd37d910b8eb78c8734aadfd5
2022-01-18 17:10:15 -08:00
TreeHugger Robot
05de8c874f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev am: c0a6d3fc8f am: e81cab2fa4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16346766

Change-Id: I03d32f4df17adc36982ad03896583ede306934d3
2022-01-13 21:06:28 +00:00
TreeHugger Robot
c0a6d3fc8f Merge "TalkBack doesn't announce when a task has being closed." into sc-v2-dev 2022-01-13 20:36:44 +00:00
Sebastian Franco
411b71bf09 TalkBack doesn't announce when a task has being closed.
Adding announceForAccessibility() in createTaskDismissAnimation()
to announce the task has being closed.

Test: Manually tested
Fix: 186744160
Change-Id: I71f57e7ba03a61b2ced7e338da4251637e89bd16
2021-12-09 20:27:51 +00:00
Tracy Zhou
74fd7af92d Add content descriptions to task bar nav buttons
Fixes: 209608812
Test: manual
Change-Id: Iba50abfb2a3d33104b6d88574df0bc7b5daf1d3a
2021-12-08 10:44:31 +00:00
Schneider Victor-tulias
e9bd547a54 Merge "Update taskbar edu strings for i10n." into sc-v2-dev am: 6c9dbb8db6 am: ad5f39c990
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16374605

Change-Id: I5a88a4c01933f42f86a656b59d8737509120ac36
2021-12-06 16:03:01 +00:00
Schneider Victor-tulias
fc846eef41 Update taskbar edu strings for i10n.
Fixes: 200777300
Test: none
Change-Id: I9d6e2575940d2fcdd354c94036662c178f9d6eee
2021-12-01 16:04:33 -08:00
Schneider Victor-tulias
a3fe68dcb1 Implement AccessibilityDelegateImpl for the Taskbar
- Added accessibility actions to open pop up menu
- Added accessibility actions to open an app/shortcut to the top/left or bottom/right

Fixes: 204453506
Bug: 198438631
Test: attempted all actions individually, attempted combinations of actions (eg. open pop up menu -> move to left/right)
Change-Id: I76a4237035a0ebfe88b8b5f147b574bb2629f20c
2021-11-30 23:02:55 -08:00
Nick Chameyev
0288d2e8bb Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-11-01 10:36:34 +00:00
Nick Chameyev
5c446d9ed4 Move floating rotation button handling to Launcher
Moves handling of floating rotation button when navigation
bar is not created to the launcher. This button was not
showing when taskbar is visible as it was initialized in
navigation bar (which is not created for large screens).

Bug: 200103245
Test: rotate phone when autorotate disabled on inner screen
Test: showing rotate suggestion when gesture nav enabled/disabled
Change-Id: I13dd555bcd811f1524be7ab9ad51b2b012b3b749
2021-10-29 10:17:18 +00:00
Vinit Nayak
3e9bd87ca9 Prevent launching app in split if task split is unsupported
Bug: 204026157
Change-Id: Ie13ac74e0c1d357db242d49083be97f0f45e6ca5
2021-10-26 11:10:23 -07:00