- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
this accounts for padding as well as extra ring inset for
PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
the system drag and drop, instead of using the current scale which
might be in the process of animating
Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838
Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
- Don't stash until drag ends, but immediately stash at that point
(regardless of success or failure, though failure will animate to the
original icon before stashing)
- Send transient taskbar's bounds to WM Shell via intent extra such that
they ignore drag events in that region
Test: manual in persistent and transient taskbar
Bug: 269814838
Fixes: 268526633
Fixes: 259645384
Change-Id: I5ded3998046f259ed6e79cb4ed765ad7b0c72e45
Enables clipToPadding property for the
workspace view so it clips the views coming
from the outside of the workspace.
Bug: 267670594
Test: manual test by folding and unfolding with
several pages on a foldable device
Change-Id: Ibcb6ecd1ce784a66fdee35969b7f460bbb32f638
- BackgroundAppState extends OverviewState, so in some cases we will
transition to background app, which inadvertently triggers global
drag and drop from being enabled
Bug: 269819279
Test: Enter split, cycle the screen and try to drag an app from the
transient bar
Change-Id: I0e8c5e8bbaa0220fc870d2db866152864253010f
* Moving things out of RecentsView to avoid
dependency on a non-testable class
* Also helping prevent bloating RecentsView.java
Bug: 266482558
Test: Single Chrome instance in recents. Initiate split
with Chrome from workspace, tap on Chrome again in Taskbar,
ensure no crash.
Change-Id: I99ec704479ffaa860f4d80c2cb9f54182f31f41a
Show an empty view when there are no tasks on the desktop.
Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
is shown in overview and empty view is hidden
Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
- Added support for escape(backtick on some keyboards) keyboard keys
- Added support for d-pad left and right keyboard keys
- Fixed janky behaviour when quick switching too quickly.
- Removed unused code
Bug: 269618928
Test: Tried quick switch very quickly, tried escape, d-pad left and right keys in RTL and LTR modes
Change-Id: Ie03207cb349891e9c2de18502f3f65b7c8f9c018
Bug: 231648761
Fixes: 269392826
Test: Unable to reproduce 269392826, but verified this doesn't
break existing paths to adjust the insets
Change-Id: I8aa82f3fb77e627ac02352ef31b788b81c2ca901
- We need to reset icon alignment whenever icon layout bound
changes. This fixes the issue where we build an icon
alignment animator before any of the views are laid out.
- Separated animation logic between.
createTransientAnimToIsStashed and createAnimToIsStashed
* The values still require a bit more tuning but this gets us
a lot closer to spec for many of the motion polish.
Bug: 267806083
Bug: 246634367
Bug: 246635237
Test: manual
Change-Id: Id122134b22ef4e418ce632e4a8137239dc8bb313
> Allowing support for overring shortcut badge
> Updating pendingShortcutInfo so that the
handler can be easily overridden
Bug: 268253894
Test: Verified on device
Change-Id: I3184cb6494bc98c7eed33798b35b4e6e6a1e7ddc
These can be used instead of the base types by views that want to use
container launch animations, to avoid duplicated boilerplate due to
implementing LaunchableView.
Bug: 250588519
Test: manual
Change-Id: I355b1a8de933c61313372fc7e00791cd0faef629
Enable highlight around focused overview item when desktop windowing
prototypes are enabled.
This highlight was built for and enabled with keyboard quickswitch feature.
We don't support quickswitch on desktop yet.
Disable the quickswitch, but keep the border highlight.
Bug: 269342116
Test: enable desktop windowing proto, use an external keyboard and
alt+tab to switch between apps, observe highlight in overview, no
quickswitch popup
Test: enable desktop windowing proto, enable
ENABLE_KEYBOARD_QUICK_SWITCH, observe that alt+tab still opens
overview
Test: disable desktop windowing proto, enable
ENABLE_KEYBOARD_QUICK_SWITCH, observe alt+tab opens the quickswitch
popup, and highlights in overview
Change-Id: I15b36f082610f4ce38143856c84fef723f1b8ba0
The EDU explains how to drag to splitscreen applications, but this operation is unavailable in overview. Therefore, let's only attempt to show the EDU when we are in an application.
Test: Manual
Fix: 269363653
Change-Id: I97aa5c76b44562189862432fb3856bf5634c6e4b
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers
Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.
Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
Test: Enter split selection from workspace/all apps,
with 1, 0, or more apps in overview
Fixes: 269363674
Change-Id: I8eba01960dd7e3c2683fe8f1d21e81de3b8245a2