Commit Graph

50300 Commits

Author SHA1 Message Date
Ats Jenk
431c0c05fd Merge "Add empty view to desktop tile in overview" into tm-qpr-dev 2023-02-22 19:30:55 +00:00
Sebastián Franco
ee24d3f9f4 Merge "Correctly add seam to MultipageCellLayout when resizing widget" into tm-qpr-dev 2023-02-22 18:24:09 +00:00
Sunny Goyal
936cd17a11 Merge "Simplifying some scrollbar binding logic in all-apps" into tm-qpr-dev 2023-02-22 18:09:32 +00:00
Tony Wickham
3d1bb16493 Merge "Fix taskbar drag view scale when returning to original icon" into tm-qpr-dev 2023-02-22 16:24:48 +00:00
Luca Zuccarini
8ca28c4e63 Merge "Introduce launchable versions of common view types." into tm-qpr-dev 2023-02-22 12:19:50 +00:00
Nick Chameyev
92c93bdda5 Merge "[Unfold transition] Hide invisible workspaces during animation" into tm-qpr-dev 2023-02-22 11:20:16 +00:00
Pat Manning
1b27affb03 Merge "Animate grid tasks to modal state." into tm-qpr-dev 2023-02-22 11:18:47 +00:00
Thales Lima
85f734b587 Merge "Rename variables for better understanding" into tm-qpr-dev 2023-02-22 09:36:43 +00:00
Andy Wickham
41d0cec7de Merge "Set All Apps scale to 1 to start." into tm-qpr-dev 2023-02-22 09:23:14 +00:00
Kevin Lim
2d5c2399ed Merge "[DenserUI] Add feature flag for app icon in inline shortcuts." into tm-qpr-dev 2023-02-22 04:05:40 +00:00
Tony Wickham
00f89fbbf6 Fix taskbar drag view scale when returning to original icon
- Use getSourceVisualDragBounds() if the target view is BubbleTextView;
  this accounts for padding as well as extra ring inset for
  PredictedAppIcon
- Also ensure we always use the final drag view scale when switching to
  the system drag and drop, instead of using the current scale which
  might be in the process of animating

Test: drag regular and predicted icons in taskbar, but drop it in a
region that doesn't accept it (e.g. the taskbar itself), check that the
return animation scales and offsets more correctly than before
Bug: 269814838

Change-Id: Ie8398b2617340e1d2568773563aa0263a3366940
2023-02-22 03:41:03 +00:00
Tony Wickham
2a567ec85a Merge "Fix a couple of drag and drop issues from transient taskbar" into tm-qpr-dev 2023-02-22 03:38:38 +00:00
Vinit Nayak
54c262cd67 Merge "Move split functions from RecentsView to SplitSelectStateController" into tm-qpr-dev 2023-02-22 02:15:46 +00:00
Brandon Dayauon
97baa50a07 Merge "Make shortcuts on people row themed" into tm-qpr-dev 2023-02-22 01:44:04 +00:00
Sebastian Franco
317c4faeea Correctly add seam to MultipageCellLayout when resizing widget
Fix: 270227019
Test: atest FoldableItemsIntegrity
Test: atest ReorderWidgets
Change-Id: Idf3d820112fe53202f0dab00c78682c31a692bc1
2023-02-21 17:09:45 -08:00
Tony Wickham
16cfed3d1f Fix a couple of drag and drop issues from transient taskbar
- Don't stash until drag ends, but immediately stash at that point
  (regardless of success or failure, though failure will animate to the
  original icon before stashing)
- Send transient taskbar's bounds to WM Shell via intent extra such that
  they ignore drag events in that region

Test: manual in persistent and transient taskbar
Bug: 269814838
Fixes: 268526633
Fixes: 259645384
Change-Id: I5ded3998046f259ed6e79cb4ed765ad7b0c72e45
2023-02-22 00:46:51 +00:00
Winson Chung
d30ef72606 Merge "Fix issue with global drag from taskbar being disabled" into tm-qpr-dev 2023-02-21 22:50:31 +00:00
Kevin Lim
d8c97f669f [DenserUI] Add feature flag for app icon in inline shortcuts.
Bug: 268667774
Test: Tested in functional change: ag/21409510
Change-Id: Ifbd0bf1ed244e09b85236c02be289bfc026599e3
2023-02-21 21:39:38 +00:00
TreeHugger Robot
73a2334f7f Merge "Remove setImeIsVisible/setTouchesEnabled as its already handled by insets." into tm-qpr-dev 2023-02-21 21:15:22 +00:00
TreeHugger Robot
fd2471b990 Merge "Make sure we start new activity only in UI thread." into tm-qpr-dev 2023-02-21 21:13:26 +00:00
Schneider Victor-tulias
8129ebfd04 Merge "Keyboard quick switch polish" into tm-qpr-dev 2023-02-21 21:03:30 +00:00
Jon Miranda
6bb01ee8ca Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev 2023-02-21 20:09:41 +00:00
Stefan Andonian
b7221177b4 Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev 2023-02-21 18:12:55 +00:00
Stefan Andonian
df11959779 Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"
This reverts commit 6f9a57186c.

Reason for revert: A Bug where only device preferences were being used, not the main shared preference file.

Bug: 269569568
Test: Verified this on device.
Change-Id: I8422b2d7073537bd46c3a91033bd2281bbd306b7
2023-02-21 18:12:11 +00:00
Nick Chameyev
47f3322b90 [Unfold transition] Hide invisible workspaces during animation
Enables clipToPadding property for the
workspace view so it clips the views coming
from the outside of the workspace.

Bug: 267670594
Test: manual test by folding and unfolding with
 several pages on a foldable device
Change-Id: Ibcb6ecd1ce784a66fdee35969b7f460bbb32f638
2023-02-21 15:05:32 +00:00
TreeHugger Robot
9769b2844c Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev 2023-02-21 03:24:41 +00:00
Jon Miranda
7a73f3ee82 Seamless handoff between stashed handle and taskbar.
Bug: 267806083
Bug: 246634367
Test: manual
Change-Id: I0c3d7a19aaa36a323c6fb3349852727f56842bb2
2023-02-21 01:42:30 +00:00
Pat Manning
550181e69e Animate grid tasks to modal state.
Bug: 265641913
Test: OverviewActionsControllerTest.java
Change-Id: I5cfa5bc3a9e0fdc024d0d709bfb2b5eccd6ea5a2
2023-02-20 17:10:01 +00:00
Thales Lima
ffc68b0516 Rename variables for better understanding
Fix: 263097925
Test: build
Change-Id: I495a2bda4d301d1660d394d978940669ef404ce7
2023-02-20 16:40:19 +00:00
Winson Chung
3bce15d2a2 Fix issue with global drag from taskbar being disabled
- BackgroundAppState extends OverviewState, so in some cases we will
  transition to background app, which inadvertently triggers global
  drag and drop from being enabled

Bug: 269819279
Test: Enter split, cycle the screen and try to drag an app from the
      transient bar
Change-Id: I0e8c5e8bbaa0220fc870d2db866152864253010f
2023-02-18 06:34:08 +00:00
Becky Qiu
43577a6604 Make sure we start new activity only in UI thread.
Bug: 269576728
Test: local
Change-Id: I76ee93e54d6e645a62a427d0a779277532efae4a
2023-02-18 01:32:31 +00:00
Vinit Nayak
c97bb4600f Move split functions from RecentsView to SplitSelectStateController
* Moving things out of RecentsView to avoid
dependency on a non-testable class
* Also helping prevent bloating RecentsView.java

Bug: 266482558
Test: Single Chrome instance in recents. Initiate split
with Chrome from workspace, tap on Chrome again in Taskbar,
ensure no crash.

Change-Id: I99ec704479ffaa860f4d80c2cb9f54182f31f41a
2023-02-17 17:28:08 -08:00
Ats Jenk
4004c9d42d Merge "Show highlight around the selected overview tile" into tm-qpr-dev 2023-02-18 01:06:00 +00:00
Ats Jenk
4d397e2ebb Add empty view to desktop tile in overview
Show an empty view when there are no tasks on the desktop.

Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
  desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
  is shown in overview and empty view is hidden

Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
2023-02-17 16:48:47 -08:00
Jon Miranda
ddb909603a Remove setImeIsVisible/setTouchesEnabled as its already handled by insets.
Bug: 260101467
Test: manual
Change-Id: Iba22a6db61abd4be0b2a15b2e4099d9bc03ddbc9
2023-02-18 00:27:03 +00:00
Ale Nijamkin
7729aa4cc6 Merge "[Launcher] App grid support for reset (1/4)." into tm-qpr-dev 2023-02-18 00:14:25 +00:00
Andy Wickham
4f0d0a2666 Set All Apps scale to 1 to start.
This avoids a bug on the first back gesture in All Apps from
search back to the A-Z list, where the apps scaled to 0-1 quickly
as part of the reset logic added in ag/21182334.

Bug: 269541162
Test: Install launcher, open all apps, tap search bar, go back.
Change-Id: I0dbd7275a80b585acf6f05ef1ef25c7c47f59ff6
2023-02-18 00:01:17 +00:00
Andy Wickham
5969e0524a Merge "Reset fast scroller when All Apps resets." into tm-qpr-dev 2023-02-17 23:57:56 +00:00
Schneider Victor-tulias
0bba3d6184 Keyboard quick switch polish
- Added support for escape(backtick on some keyboards) keyboard keys
- Added support for d-pad left and right keyboard keys
- Fixed janky behaviour when quick switching too quickly.
- Removed unused code

Bug: 269618928
Test: Tried quick switch very quickly, tried escape, d-pad left and right keys in RTL and LTR modes
Change-Id: Ie03207cb349891e9c2de18502f3f65b7c8f9c018
2023-02-17 15:44:04 -08:00
Stefan Andonian
8989f839f5 Merge "Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"" into tm-qpr-dev 2023-02-17 23:12:08 +00:00
Sunny Goyal
82864d5e13 Merge "Using internal format cache for loading user badged label" into tm-qpr-dev 2023-02-17 21:09:26 +00:00
Sunny Goyal
85d15e78d0 Merge "Adding support for customizing shortcut pinning logic" into tm-qpr-dev 2023-02-17 20:45:58 +00:00
Sunny Goyal
4d18ad4825 Simplifying some scrollbar binding logic in all-apps
Bug: 256684299
Test: Manual
Change-Id: I1cee6cb783f0f805d9a0f0a4b2b668a709cacf1a
2023-02-17 12:28:46 -08:00
Robin Lee
aafeb82613 Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"
This reverts commit 2a58ddb89f.

Reason for revert: b/266987957

Change-Id: I4a4a1f01a693d703f4dc87e8169fbf374729d274
2023-02-17 19:45:27 +00:00
Winson Chung
192e7afc3c Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev 2023-02-17 19:44:52 +00:00
Winson Chung
0371d0f699 Only call per-user calls for gesture settings observer
Bug: 231648761
Fixes: 269392826
Test: Unable to reproduce 269392826, but verified this doesn't
      break existing paths to adjust the insets
Change-Id: I8aa82f3fb77e627ac02352ef31b788b81c2ca901
2023-02-17 19:44:29 +00:00
Jon Miranda
13e9b9f889 Translate the taskbar icons to match nav handle shape.
- We need to reset icon alignment whenever icon layout bound
  changes. This fixes the issue where we build an icon
  alignment animator before any of the views are laid out.
- Separated animation logic between.
  createTransientAnimToIsStashed and createAnimToIsStashed
* The values still require a bit more tuning but this gets us
  a lot closer to spec for many of the motion polish.

Bug: 267806083
Bug: 246634367
Bug: 246635237
Test: manual
Change-Id: Id122134b22ef4e418ce632e4a8137239dc8bb313
2023-02-17 10:56:59 -08:00
Sunny Goyal
239d6e9b8d Adding support for customizing shortcut pinning logic
> Allowing support for overring shortcut badge
> Updating pendingShortcutInfo so that the
  handler can be easily overridden

Bug: 268253894
Test: Verified on device
Change-Id: I3184cb6494bc98c7eed33798b35b4e6e6a1e7ddc
2023-02-17 18:07:23 +00:00
Sunny Goyal
efad3c2f92 Using internal format cache for loading user badged label
Bug: 267683009
Test: Manual
Change-Id: I7d1df2704c4513bd80e2b6adb7a3921637fa617b
2023-02-17 18:05:25 +00:00
Alex Chau
ac4c866538 Merge "Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed" into tm-qpr-dev 2023-02-17 17:49:18 +00:00