Commit Graph

808 Commits

Author SHA1 Message Date
Becky Qiu
70c9aee083 Merge "Revert "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev 2023-01-27 20:52:26 +00:00
Becky Qiu
d5311f6541 Revert "Expose getSearchBox from the HomeAllApps class"
Revert submission 20714047-b_255390519

Reason for revert: broken test b/266169958 (P0 bug) and broken UI for the EDU card

Reverted changes: /q/submissionid:20714047-b_255390519

Change-Id: I250003c1b3d07637dde596225f08a6bd3cb84365
2023-01-27 20:11:26 +00:00
Sebastián Franco
68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Ling Wo
38aa60c38f Merge "Expose getSearchBox from the HomeAllApps class" into tm-qpr-dev 2023-01-19 21:29:12 +00:00
Sebastian Franco
de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
Luca Zuccarini
55d828b6f5 Add Tapl support for swiping from All Apps to Workspace.
This mirrors the way we swipe from Workspace to All Apps, with minor
differences for selecting the start position of the swipe motion.

Bug: 260218332
Test: included
Change-Id: I9fe2284b1c920ebed87a6bab3dfc9c8c29aa2d5d
2022-12-21 15:38:51 +00:00
Ling Wo
8ba48c1e65 Expose getSearchBox from the HomeAllApps class
Doc: https://docs.google.com/document/d/1OlN-A3Z5_UjWk-QkxC4JaYWesFDNHkHTox94__rLmR0

Bug: b/255390519
Test: local testing
Change-Id: I72410035bbcfd2215815dbf6c3d6bd86d692b8c6
2022-12-20 04:13:59 +00:00
vadimt
befcfa40b9 Not waiting for animations for Launcher clicks
Waiting for animations to finish can make the test wait for too long if there is an ongoing animation somewhere, for example, in an app we are trying to swipe from.

Test: presubmit
Bug: 256567004
Change-Id: Ida494128a18342bee3dbdae6d713c854c86912c1
2022-12-19 18:02:07 -08:00
Alex Chau
f8b79d4235 Use overridden default xml for TwoPanelWorkspaceTest
- Partially reverted TAPL and TwoPanelWorkspaceTest changes on http://ag/19195512

Fix: 262627208
Fix: 262632384
Test: TwoPanelWorkspaceTest
Change-Id: I8b793bfb3874cc6305ce8b0f9f7b0a116d01222b
2022-12-15 15:48:09 +00:00
Alex Chau
8a7dc2b244 Merge "Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute" into tm-qpr-dev 2022-12-14 21:50:34 +00:00
Brandon Dayauon
f772ba18ab Merge "Change method name as suggested" into tm-qpr-dev 2022-12-08 00:18:26 +00:00
Brandon Dayauon
bb3146271b Change method name as suggested
bug: 261098912
bug: 261099706

test: Manual - presubmit go/forest
Change-Id: I2e18ddaf2b9647bccaecccbfa7faf88e51b84f12
2022-12-08 00:15:06 +00:00
Alex Chau
766cd2b4b9 Remove unnecessary GridDisplayOption_defaultSplitDisplayLayoutId attribute
- Can use deviceCategory to make grid specific to splitDisplay instead
- Update TwoPanelWorkspaceTest for new workspace items

Fix: 233736588
Test: Clear launcher and check the default
Test: TwoPanelWorkspaceTest
Change-Id: I6ad3a2d866d847af281e10b802edbd4bcc892c39
2022-12-07 15:18:28 +00:00
Alex Chau
5dec2aceb1 Revert "Revert "Enable taskbar in overview by default""
This reverts commit 6f0b0fe742.

Bug: 245320601
Reason for revert: Re-land "Enable taskbar in overview by default"

Change-Id: Ie722a608d6bd7168744ffc81c156e4307d4c1d2d
2022-12-06 19:45:29 +00:00
Brandon Dayauon
7b53004999 Searching for Golden Gate Bridge should show three queries and check if predicted app row and web suggest exists
Add a method that checks if three web suggests exist and another method to check for
predicted app row and web suggest exists.

bug: 225583735
test: Manual - photo: https://screenshot.googleplex.com/3NoSUm7nzTvf3gX
Change-Id: I7f9340229aaf4a0a3928933035f193a576995525
2022-11-29 13:35:56 -08:00
Jon Miranda
f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
TreeHugger Robot
8dd01f3ac2 Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev 2022-11-09 01:07:11 +00:00
Jon Miranda
e7011d2b87 Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."
This reverts commit d5a6b5f688.

Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"

Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
2022-11-08 21:56:52 +00:00
TreeHugger Robot
98f400397b Merge "Unstash taskbar when transitioning to fallback overview." into tm-qpr-dev 2022-11-08 18:14:55 +00:00
Pat Manning
e1100b904d Unstash taskbar when transitioning to fallback overview.
Update LauncherInstrumentation taskbar visibility check to include assertions in fallback launcher using OverviewObject instead of LauncherObject.

Fix: 253042501
Test: manual
Change-Id: I9f2aa228e8aa97ef8ca1a4535b7f8fcded8a4572
2022-11-08 15:07:12 +00:00
Jon Miranda
d5a6b5f688 Add TaskbarModeSwitchRule to test both transient/persistent taskbar.
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
  We can address testing this functionality in a separate CL

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
2022-11-07 14:18:37 -08:00
Sunny Goyal
679ec33cc7 Waiting for the apps-unfreeze flags instead of enforcing it
Bug: 256898879
Test: Will wait for presubmit flakyness to clear
Change-Id: Ie2341338bbebfd892998e078d07d31f003ab8d43
2022-11-04 14:41:14 -07:00
Sunny Goyal
50097ef272 Waiting for app install to finish before procedding with the test
Bug: 256659409
Test: Presubmit
Change-Id: Ia0f4cdd072c4c439d09070b0395fcfd6909c2a8f
2022-11-03 13:33:41 -07:00
Sam Dubey
52a3bcd4bb Merge "Revert "Support multi users scenarios in Tapl"" into tm-qpr-dev 2022-11-03 11:40:24 +00:00
Sam Dubey
a3577293b6 Revert "Support multi users scenarios in Tapl"
Revert "Reduce multi users tests runtime"

Revert "Add PlatformTesting to dependency."

Revert "Move platform testing util to separate gradle module"

Revert submission 20311444-user-switch-nosleep

Reason for revert: Part of DM+Platinum montiro as a likely culprit for b/257210412. Won't be submitted if proven otherwise.
Reverted Changes:
I90b1069de:Support multi users scenarios in Tapl
I706da86a3:Add PlatformTesting to dependency.
I605cd76c4:Move platform testing util to separate gradle modu...
I64b571dc4:Reduce multi users tests runtime

Change-Id: I6310efa59fe1755feb29bef28d890e684b7164c6
2022-11-03 10:08:13 +00:00
Benno Lin
8f669d20d7 Merge "Support multi users scenarios in Tapl" into tm-qpr-dev 2022-11-03 06:42:19 +00:00
Saumya Prakash
ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00
Tony Wickham
6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Saumya Prakash
12731af30d Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I64c91c682009808690d696032ffadefc86dfbac9
2022-11-01 21:49:19 +00:00
Benno Lin
2e35f5152d Support multi users scenarios in Tapl
Tapl uses ContentProvider to get information from Launcher.
By default, it uses system user, who usually spwans the process
of instrumented tests, to send requests. Therefore, it can't get
the information of secondary user's Launcher process.

To solve the problem, the CL proposes to allow tests providing
UserInfo to Tapl, so that Tapl can use the right user's context
to get the test information. For more details, please refer to
go/multi-users-waiting-dd.

Test: https://android-build.googleplex.com/builds/abtd/run/L62400000957107134
Bug: 254402688
Change-Id: I90b1069de31e979138683049586bd87a7e7d813a
2022-11-01 14:36:24 +00:00
Saumya Prakash
5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash
19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00
Saumya Prakash
f1a4121784 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-10-26 20:31:44 +00:00
Saumya Prakash
96cad794d7 Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I17628f1fa3869b575ec404a2a630a6927e3c1d14
2022-10-24 22:47:24 +00:00
Ling Wo
ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Schneider Victor-tulias
ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
TreeHugger Robot
7c9144328a Merge "Making Launcher TAPL check orientation only when the expected orientation is set by the test" into tm-qpr-dev 2022-10-17 22:58:51 +00:00
vadimt
9853497f6c Making Launcher TAPL check orientation only when the expected orientation is set by the test
This makes life simpler for tests that don't care about orientation

Bug: 245576832
Test: presubmit
Change-Id: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
Merged-In: I3c247826c6cac0e20c93a2fad9b81775fd2ebaa8
2022-10-17 19:48:46 +00:00
TreeHugger Robot
126d178358 Merge "Revert "Enable taskbar in overview by default"" into tm-qpr-dev 2022-10-17 17:40:17 +00:00
Alex Chau
6f0b0fe742 Revert "Enable taskbar in overview by default"
This reverts commit 517131ae1c.

Reason for revert: Reverting until b/251747761 is addressed
Bug: 245320601

Change-Id: Ic5ebc071f092c8f91ff879a59d89c3be4326c90e
2022-10-17 14:38:09 +00:00
Pat Manning
956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
Ling Wo
5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
Alex Chau
517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Ming-Shin Lu
4d4f62ac77 TAPL: add setIgnoreTaskbarVisibility in LauncherInstrumentation
As now FlickerTests is leveraging TAPL to interact devices CUJs,
we realized in LauncherInstrumentation will verify task bar visibility
automatically to expect it always visible when quick-switch, which is
not always reliable since the task bar may be hidden by manual or
when the activity requests to show IME.

Add setIgnoreTaskbarVisibility in LauncherInstrumentation for the caller
to ignore taskbar visibility if the test does not need to verify it.

Bug: 228012334
Bug: 240306344
Test: atest FlickerTests:SwitchImeWindowsFromGestureNavTest
      in tablet device
Test: atest NexusLauncherOutOfProcTests:com.android.quickstep.\
       TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet

Change-Id: Id0a35561523d733b8434acb702ec7dcaa466a1c2
2022-10-05 11:37:37 +08:00
Pat Manning
a34a9a0a18 Add screenshot test for edit state drop targets.
see: go/tapl-run-on-hold-event

Bug: 241386128
Test: HomeScreenImageTest.java
Change-Id: I5d6421c8da7d06a9eb77da249957c64d413524f1
2022-09-29 11:12:31 +01:00
TreeHugger Robot
4298b36ef4 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev 2022-09-21 03:50:08 +00:00
vadimt
f132bd7d3f Adding a comment for goHome()
Bug: 187761685
Test: presubmit
Change-Id: I2917daa90f22cc0da0169c287b02cc4cf37a8f4b
2022-09-19 19:08:43 -07:00
Nicolo' Mazzucato
d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Alex Chau
7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
Yein Jo
dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00