Commit Graph

50090 Commits

Author SHA1 Message Date
vadimt
3c2ab8b1e1 Marking that we process REQUEST_ENABLE_ROTATION
Bug: 187761685
Test: presubmit
Change-Id: I8239cd59dada685618fb273ef5840d30756ec84a
2023-02-06 15:00:49 -08:00
Winson Chung
537c380bcb Merge "Revert "Include SysUI state in stashing check"" into tm-qpr-dev 2023-02-03 18:02:17 +00:00
Fengjiang Li
0510c290a0 Merge "[Predictive Back] Hide inactive recycler view when work profile is enabled on tablet" into tm-qpr-dev 2023-02-03 18:01:24 +00:00
Tony Wickham
632e9a84c4 Merge "Don't applyState if taskbar is already destroyed" into tm-qpr-dev 2023-02-03 17:55:30 +00:00
Pat Manning
cbedc7ed08 Merge "Move overview actions to task menu when no focused task." into tm-qpr-dev 2023-02-03 13:51:54 +00:00
Sunny Goyal
de15772052 Merge "Exposing method to register content providers in sandbox context" into tm-qpr-dev 2023-02-03 07:34:10 +00:00
Vinit Nayak
6fa1ab9441 Merge "Unify split options into single option" into tm-qpr-dev 2023-02-03 06:07:41 +00:00
Vinit Nayak
c1799a8221 Merge "Set StateManager to BackgroundAppState if end gesture is LAST_TASK" into tm-qpr-dev 2023-02-03 06:05:22 +00:00
Fengjiang Li
c717f48a2d Merge "[Predictive Back] Remove animation on cancel for all apps to home" into tm-qpr-dev 2023-02-03 03:44:19 +00:00
Jon Miranda
554c431d40 Merge "Iterative improvement to the taskbar stash animation." into tm-qpr-dev 2023-02-03 02:39:10 +00:00
Jon Miranda
5903751ee3 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev 2023-02-03 01:34:05 +00:00
Tony Wickham
9fb8883017 Don't applyState if taskbar is already destroyed
Test: Open overview while unfolded, then fold; ensure hotseat remains
visible
Fixes: 260135164

Change-Id: I788a9a682a7d5fabbea7c478231fc7abe92e95b9
2023-02-03 01:00:21 +00:00
Stefan Andonian
6a4e9a34ab Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev 2023-02-03 00:27:14 +00:00
Jon Miranda
b1e85e9b70 Iterative improvement to the taskbar stash animation.
Test: manual
Bug: 246632728
Change-Id: I4e4051faaf699a462c90acf87afcee11a0b4165b
2023-02-02 23:52:23 +00:00
Winson Chung
0499f31aa5 Revert "Include SysUI state in stashing check"
This reverts commit 62c74f9633.

Reason for revert: b/267543857

Change-Id: Ifc2fc3abfc07c92acef560fd3eef7d799f3e28bf
2023-02-02 23:33:15 +00:00
Sunny Goyal
305cb87891 Exposing method to register content providers in sandbox context
Bug: 263286512
Test: presubmit
Change-Id: I04a8160afec2ea0d153eca113537a8778d8f3514
2023-02-02 15:20:58 -08:00
Jon Miranda
2b25ded506 Update notification dot renderer when we update the taskbar icon size.
Test: swipe to home with an app that has a notification dot
      observe no jump in dot size
Bug: 264709741

Change-Id: I5d56fe57e74ed7b094477ecd8727152f3f522042
2023-02-02 23:10:42 +00:00
Vinit Nayak
576592575b Set StateManager to BackgroundAppState if end gesture is LAST_TASK
* Setting stateManager to QUICK_SWITCH results in calling
launchTasks() in the current TaskView in recycler view, however
if the end is LAST_TASK, there's no need to launch anything.
* Currently this isn't an issue with fullscreen tasks because
Launcher's onStop() cancels the animation, but that isn't the
case in the specific step of locking/unlocking the device AND
in splitscreen. Tracked at (b/267674372)

Test: Bug no longer repros. Did other quickswitch gestures and
also going to overview with split and fullscreen apps
Fixes: 265734073

Change-Id: Ie553c7b5db7e59e0cd8aba1723c25ad923690d5c
2023-02-02 14:16:31 -08:00
Saumya Prakash
334094da9e Merge "Redesign the tutorial for the go home gesture" into tm-qpr-dev 2023-02-02 21:54:10 +00:00
Fengjiang Li
201848bff3 [Predictive Back] Remove animation on cancel for all apps to home
Framework has supported (ag/20876922) sending back progress on cancel. So no need to re-do the work on app side.

Bug: b/267664388
Test: manual, this CL has no visual change
Change-Id: I47c751d12a9b2c602ac6f3028665b996990fbd7e
2023-02-02 13:06:18 -08:00
Saumya Prakash
b1291e6ae2 Redesign the tutorial for the go home gesture
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.

Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
2023-02-02 18:14:14 +00:00
Pat Manning
7b8f766b85 Move overview actions to task menu when no focused task.
Bug: 265641913
Test: manual
Change-Id: I03a88275b399940468246a69365f76f7deda724e
2023-02-02 11:37:15 +00:00
Nicolò Mazzucato
b70a68a6d7 Merge "Improve launcher tracing around unfold animation" into tm-qpr-dev 2023-02-02 10:14:47 +00:00
TreeHugger Robot
858092151c Merge "Force persistent taskbar all apps icon to light version." into tm-qpr-dev 2023-02-02 03:14:23 +00:00
Vinit Nayak
5a6863f14a Unify split options into single option
* No more split left/right/top, only have
splitscreen and icon shows vertical or horizontal
split windows
* Replace existing split icon for FreeForm

Fixes: 264930810
Test: Tested landscape and portrait, workspace,
overview, allapps

Change-Id: I443f93b6b01760b726bf9f024fb1324fdf0ed03c
2023-02-01 17:27:57 -08:00
Jon Miranda
9443403104 Merge "New taskbar threhsolds 30/100/180/300" into tm-qpr-dev 2023-02-01 23:46:40 +00:00
Vinit Nayak
5be7cde8fa Merge "Fix bug with selecting a secondary task as second splitscreen app via Taskbar" into tm-qpr-dev 2023-02-01 22:47:51 +00:00
Stefan Andonian
1d7f703514 Migrate "isRotationAllowed" setting to LauncherPrefs.
This semi-complicated case requires use of a context in order to get the
default value. That is why it was migrated by itself.

Bug: 261635315
Test: Manually tested all the base functionality of the launcher.
Change-Id: I40d8ccd414402b55921a0a224264414d3245871b
2023-02-01 20:26:41 +00:00
Brian Isganitis
748094b185 Force persistent taskbar all apps icon to light version.
Persistent taskbar background is always dark regardless of device theme,
so we should make the icon always light for now.

Test: Manual
Fix: 262837720
Change-Id: I8f66af874e07f68e1943245e9cd49c3b3107915f
2023-02-01 12:07:58 -08:00
TreeHugger Robot
8baae80cdf Merge "Dispatch onAnimationStart and End to maintain proper state" into tm-qpr-dev 2023-02-01 18:58:56 +00:00
TreeHugger Robot
18be12d0dd Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev 2023-02-01 18:51:31 +00:00
Fengjiang Li
a007740815 [Predictive Back] Hide inactive recycler view when work profile is enabled on tablet
This CL will make sure scale animation doesn't reveal the offscreen main/work recycler view on tablet in all apps to home transition

Bug: b/267226558
Test: manual, see before/after video in bug
Change-Id: I9a8add0ac2c902e3f4315de099939f9297f6604a
2023-02-01 10:18:52 -08:00
Nicolo' Mazzucato
06578ff8b1 Improve launcher tracing around unfold animation
This will make it explicit in a trace when we're waiting for one additional frame after onResume to start processing unfold animation related progresses

Bug: 267287854
Test: recorded trace locally after unfolding
Change-Id: I3b13842f018c6f23cbb5bc1c1cfd77e5c38dad98
2023-02-01 17:46:56 +00:00
Tony Wickham
4edce0100a Dispatch onAnimationStart and End to maintain proper state
The AnimatorPlaybackController from createLauncherStateFromSuwAnimation
does not ever get started (it's all user-driven) and thus some internal
state is not updated properly, namely mIsStashed is never set to false
even though the animation unstashes visually. This will break the first
"real" unstash animation after SUW. Thus, when the animation from SUW is
completed, we now dispatch onAnimationStart() and End() to ensure the
proper state is updated.

Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
  Then, skip to the end and swipe to home; ensure first app launch
  properly stashes taskbar
Fixes: 263533070
Change-Id: I9553b8a884fb84303e2e97f14b9a7051e9de4709
2023-02-01 16:18:18 +00:00
Jeremy Sim
0b4b89bdcf Fix bug with selecting a secondary task as second splitscreen app via Taskbar
This patch makes it so that the correct task will be chosen when selecting a second splitscreen app via Taskbar.

Prior to this patch, the Taskbar app selection function -- which attempts to match the tapped icon to a running TaskView -- assumed that the TaskView in question was always a solo (non-grouped) Task. This resulted in the wrong app being selected for split when the desired Task happened to be the secondary app in a pair.

Fixed by checking to see if the desired app is primary or secondary, and returning the correct Task, IconView, and ThumbnailView for the split operation.

Fixes: 265244769
Test: Manual
Change-Id: Ie1122d1b49151d70dec9711fe558fba7752b7d8e
2023-02-01 15:40:06 +08:00
Tony Huang
c3cb117b01 Merge "Fix divider hidden delay if quick swipe to home" into tm-qpr-dev 2023-02-01 03:31:00 +00:00
Brian Isganitis
1a4eb297ee Merge changes Iaf02a42a,I8daf3c08 into tm-qpr-dev
* changes:
  Enable taskbar EDU tooltip flag.
  Add settings asset to persistent Taskbar tooltip.
2023-02-01 01:34:59 +00:00
TreeHugger Robot
5107dff0eb Merge "Fix bug with trying to split an app with itself" into tm-qpr-dev 2023-01-31 23:42:29 +00:00
Brian Isganitis
7eb187b197 Enable taskbar EDU tooltip flag.
Test: Manual
Fix: 263157739
Change-Id: Iaf02a42a2ff02b25b5068c7241f894e586c42e1b
2023-01-31 14:07:56 -08:00
Brian Isganitis
7881b81aa7 Add settings asset to persistent Taskbar tooltip.
Test: Manual (3 button)
Bug: 263157739
Change-Id: I8daf3c08e48ef1f9ec190af301333d279878aa59
2023-01-31 14:07:34 -08:00
Alex Chau
2eacb5c601 Merge "Clear PredictorState targets when it's re-registered" into tm-qpr-dev 2023-01-31 21:59:14 +00:00
Pat Manning
f667823a8e Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev 2023-01-31 21:13:46 +00:00
TreeHugger Robot
71e2763b6e Merge "[QL-v3] Add feature flag." into tm-qpr-dev 2023-01-31 20:41:02 +00:00
Alex Chau
e5c1edb31b Clear PredictorState targets when it's re-registered
- After SUW, registerPredictor is called for hotseat, and then BaseLauncherBinder will call bindExtraContainerItems with empty items. A subsequent registerPredictor will then be triggered by LoadTask, but handleUpdate will skip the update due to no diff in PredictorState targets. As a result, HotseatPredictionController always have no items after SUW
- Clearing PredictorState when it's re-registerted will allow the respective prediction controller to receive new prediction items that comes with the registration.

Fix: 265340241
Test: Factory reset, pass SUW, prediction items are in hotseat
Test: Reboot, prediction items are in hotseat
Change-Id: Ie6e219028e7fde42854459d34806a04052dc41ba
2023-01-31 19:24:31 +00:00
TreeHugger Robot
fd02dce88f Merge "Add flag for new download app UI color and contrast update." into tm-qpr-dev 2023-01-31 19:16:06 +00:00
Sunny Goyal
126ac14112 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev 2023-01-31 18:20:35 +00:00
TreeHugger Robot
6e21d310c1 Merge changes I865871e5,Ie655de7a into tm-qpr-dev
* changes:
  Fixes to VoiceInteractionWindowController
  Fix TaskbarBackgroundRenderer not being applied correctly in 2 cases
2023-01-31 17:52:55 +00:00
TreeHugger Robot
1656f428b4 Merge "Fix missing item decorator for the search recycler view" into tm-qpr-dev 2023-01-31 17:52:07 +00:00
Pat Manning
7462c2ab62 Make showing back for bouncer only rely on back disable status, not home and recents as well.
Fix: 260655218
Test: manual. Create second user, switch to three button nav, set lockscreen password, lock and show IME on lockscreen.
Change-Id: I1d874196afc24d5bae86d525a81ae199152fc750
2023-01-31 14:57:26 +00:00
Jeremy Sim
c779ae54ce Fix bug with trying to split an app with itself
This patch fixes the following user flow:
1) App is already running
2) User initiates splitscreen from Home with that app
3) User selects the same app from Taskbar or AllApps

Previously, this caused a crash because the split-from-home initiation removed the corresponding app tile, causing a null pointer exception when the same task ID was used as a split target.

Fixed by adding a null check: if the target TaskView can't be found for any reason, fall back to launching the second app via Intent instead. If the app doesn't support multi-instance, the UI will now show an attempted split, followed by the message "This app can only be opened in 1 window."

Fixes: 263041522
Fixes: 266218404
Test: Manual
Change-Id: I39ed60c9ac758ac215391f0618f44f7fcee4f32c
2023-01-31 17:58:12 +08:00