Commit Graph

284 Commits

Author SHA1 Message Date
TreeHugger Robot
3467c51780 Merge "Change folder text color to match spec" into tm-qpr-dev 2023-01-30 21:45:13 +00:00
Thales Lima
d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Federico Baron
79a9bfed79 Change folder text color to match spec
We needed folder text color to use textColorPrimary. With this CL we update it to be that.

Test: Look at folder text color
Fix: 262450499
Change-Id: Icd540c7d3ff4431b4edc72f04ce7f8f14787aa5b
2023-01-26 20:26:29 +00:00
Sunny Goyal
adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Thales Lima
b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Sunny Goyal
fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Sunny Goyal
af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Pat Manning
0b16bba93a Set drop target font weight to medium.
Bug: 235886741
Test: manual.
Change-Id: Ie5b3f4159dee7e2eb8e614a15b57a0929f8eae71
2022-07-20 11:28:36 +01:00
Brian Isganitis
cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
James O'Leary
202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
James O'Leary
dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
James O'Leary
2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
James O'Leary
fe435ad44e Update app icon shadows
Allow use of white shadow, set radius to 1.0 and offset to 0.
Use 100% and 20% alpha, instead of 70% and 50%.
(nets out to same effect)
Make ambient and key shadows equivalent: there are deterministic
formulas for what contrast a shadow will create, and those formulas
were used for the spec. Ad-hoc attempts to try to increase visibility
are no longer needed and don't align with design intent

Bug: 213314628
Test: Manual inspection at runtime
Change-Id: Ie12d3d05488e16fea94e91be16c25448f450a44d
2022-05-12 18:28:39 +00:00
Sunny Goyal
d333091d79 Fixing wrong alpha for disbled icon
Bug: 230852221
Test: Verified manually
Change-Id: I73fb1ac73ff374cd67b3f26367814ea5b0b49a3b
2022-05-09 16:12:06 -07:00
Jon Miranda
48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Jon Miranda
b77878ebe3 Update folder preview and folder background colors.
Bug: 201332301
Test: light theme / dark theme
      open and close folder, ensure colors are accurate

Change-Id: I49198eb2faee03111be33051fd1cb08094844c77
2021-10-06 16:57:33 -07:00
Brian Isganitis
cbaf149f87 Update folder pagination dot color to match mocks.
Test: Folder page dot color matches mocks in light and dark mode.
Fix: 195045519
Change-Id: Ib485e51fbb903b1345ee865ddd8614f280e7608a
2021-08-09 16:03:54 -04:00
Steven Ng
a1dcbce15a Remove drop target button drawable padding if text isn't hidden
Test: manual
Fix: 194320733
Change-Id: I12adeaf37cee5a0fcf383641f24b7750f14daf27
2021-07-26 17:10:56 +01:00
Yogisha Dixit
2046730771 Update widget manipulation colors to match AOD.
This CL makes two changes:
1. Changes the colors we use from system_accent1_50 ->
system_accent1_100 (light wallpapers) and system_accent2_700 ->
system_accent2_600 (dark wallpapers).
2. Changes when we use the light/dark colors. Before: light accent color
when wallpaper luminosity < 0.3. After: light accent color when wallpaper luminosity < 0.7.

Bug: 192359286
Test: manual on light/dark wallpapers with light/dark theme
Change-Id: I28abfd77439a16b4bb637376fd88180d536364cf
2021-07-16 16:43:18 +01:00
Alina Zaidi
f03b1aeeb6 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev am: eefccccb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15155531

Change-Id: I92c997fbd0d0f47e78e5169e8cad9938bd2af0a0
2021-07-01 11:52:05 +00:00
Alina Zaidi
1b5efa3216 Reduce margin for DropTargetBar to avoid buttons to be truncated.
Bug: 187036287
Test: Tested manually by QA testing team on 4X5 grid size
Change-Id: Iaa4cd3e464ccf50427a5aa96d97093601e1d2948
2021-07-01 09:50:46 +01:00
Jonathan Miranda
9f113f76fa Merge "Update colors for non-v31 devices." into sc-dev am: 7a582f2d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15096360

Change-Id: Ib926073532c53a4db19e9930ade8c9efd776796d
2021-06-26 15:10:27 +00:00
Jonathan Miranda
7a582f2d7d Merge "Update colors for non-v31 devices." into sc-dev 2021-06-26 00:09:59 +00:00
Yogisha Dixit
3893eefe75 resolve merge conflicts of 1491ec31c5 to sc-v2-dev
Test: manual
Bug: 192076258
Change-Id: I44e02383cd8ce386811e24a1c4fd6ce62e38f90f
2021-06-25 17:23:22 +00:00
TreeHugger Robot
1491ec31c5 Merge "Update widget manipulation colors." into sc-dev 2021-06-25 15:18:45 +00:00
Yogisha Dixit
c0ac1dda74 Update widget manipulation colors.
Spec:
* Resize frame: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.OeO4S0j
* Drop target bar: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187910396
Change-Id: I6fd433796970c428841ee96e45ee4fca1ded3665
Merged-In: I6fd433796970c428841ee96e45ee4fca1ded3665
2021-06-25 08:43:29 +00:00
Jon Miranda
6a936e3ec4 Update colors for non-v31 devices.
Also renamed to popup color to popup shade to better differentiate
between the primary/secondary/tertirary popup colors.

Bug: 191496301
Test: Removed v31 colors to verify the non-v31 colors, that the shades are as expected
      Tested on wallpapaper with light text, again with dark mode
      Tested on wallpaper with dark text, and then again with dark mode

Change-Id: I3ec9ee7f85696ee48224740a1ec7f4abe42348ee
2021-06-24 11:07:52 -07:00
Jonathan Miranda
e7ce4caaed Merge "Fix folders being light in dark mode." into sc-dev am: 5546b258c3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15082515

Change-Id: I299041edaebfc0f333bcc7e56b3fe6489aa8c644
2021-06-23 20:32:45 +00:00
Jon Miranda
d47f715b51 Fix folders being light in dark mode.
- Simplifying the styles here, following the same pattern as
  the popup colors.

Bug: 175329686
Test: test wallpaper with light text, light mode
      test again in dark mode
      test wallpaper with dark text, light mode
      test again in dark mode

Change-Id: I04f92bd64de69c5e33fc1bff50c4ecc0e7c17d37
2021-06-23 11:22:25 -07:00
Jonathan Miranda
11a9b035f3 Merge "Update notification popup UI." into sc-dev am: 1bfd350ead
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15017911

Change-Id: I468cd0896be43857ce188186cfda9f3ae94c07fb
2021-06-19 04:11:19 +00:00
Jon Miranda
313b2c2d28 Update notification popup UI.
- Update UI to match specs.
- Only shows one notification (removed footer, animation code)

Bug: 175329686
Bug: 190402054
Test: open popup, dismiss notification from shade,
      open popup, click on notification
      checked RTL

Change-Id: I92672f94233d986ae5b5c54979980967308cb156
2021-06-18 22:42:44 +00:00
Yogisha Dixit
d417d36615 Merge "Center drop target icons in landscape mode." into sc-dev am: 3287dd9fa7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14980961

Change-Id: Id3f175c250acc0a40b9662c20c28c73c9fd35c13
2021-06-17 09:45:50 +00:00
Yogisha Dixit
3287dd9fa7 Merge "Center drop target icons in landscape mode." into sc-dev 2021-06-17 09:34:42 +00:00
Jonathan Miranda
897dfb5151 Merge "Update launcher text to match specs." into sc-dev am: f89c4280b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14986097

Change-Id: I8b19e0cde2a8bf295c87e5acb8b24bbd39635ce5
2021-06-16 20:53:12 +00:00
Yogisha Dixit
58c5e65763 Center drop target icons in landscape mode.
Spec: https://docs.google.com/presentation/d/1UxdDh8EFhPbdRWRwzjbpgL-j02ew4Ew3eG3XBCeoYdo/edit#slide=id.vXfwHn8

Test: manual
Bug: 187376586
Change-Id: I2025ba75061a5ca3a004dfef2b33cdbcc17a1408
2021-06-16 20:55:56 +01:00
Jon Miranda
a7783fd734 Update launcher text to match specs.
Bug: 190915409
Test: visual, manual
Change-Id: I9560f95a452cf92ca3eada2a13f3ed63cc9b44da
2021-06-15 14:47:30 -07:00
Alina Zaidi
b49556b21a Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev am: b5459c9ba5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14817823

Change-Id: Iaf5fb71dc31f9e94b053c74da4a148bef0f761da
2021-06-15 17:37:47 +00:00
Alina Zaidi
b5459c9ba5 Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev 2021-06-15 17:23:02 +00:00
Alina Zaidi
dfa6aa828c Update bottom widget picker and pin widget dialog layout in landscape mode.
Bug: 189726613
Test: Manually tested
Change-Id: I048740f949571423ab53bbb01e7128d9981b1ce7
2021-06-15 14:27:57 +01:00
Jonathan Miranda
7e8b2742c9 resolve merge conflicts of 11bf817e86 to sc-v2-dev
Bug: 190210234
Bug: 190164147
Test: manual

Change-Id: I155ee7efdbda10c05f87001ac4eaf07017a6d456
Merged-In: I230c33d7e4e1871d8d702737c56c79ce46504b8f
2021-06-14 20:32:58 +00:00
Jon Miranda
5688010306 Folder polish - update color extraction, fix contrast issues.
- Also fixes open/close animation when items were not getting clipped
  due to folder not being measured yet.

Bug: 190210234
Bug: 190164147
Test: manual
Change-Id: I230c33d7e4e1871d8d702737c56c79ce46504b8f
Merged-In: I230c33d7e4e1871d8d702737c56c79ce46504b8f
2021-06-14 17:54:19 +00:00
Brian Isganitis
93031bc2ae Revert "Revert "Update preferences to Material Next styling""
There should be enough free space to merge this change into S V2.

This reverts commit 19d623d921.

Test: Settings root, all apps, and about have new style on S
Bug: 187732263
Fix: 188254205, 188012913
Change-Id: I346bbf819f3fe1eb13b47125b53c15baab11e439
2021-06-11 16:04:35 -04:00
Jon Miranda
9b4448f477 Set folder dot color to spec.
Bug: 188095988
Test: manual
Change-Id: Idf4d7f7b8f95d1d112ece8cd03d9c7d441a5fe0f
2021-06-08 10:55:58 -07:00
Alina Zaidi
2e4d15d2b5 Make status bar icons visible in pin widget dialog scrim.
Use dark icons on status bar in light mode.

Bug: 189389865
Test: tested manually
Change-Id: I121fb59f52a9062ee301e1db3d8a3a7e9139ed5a
2021-06-07 18:22:55 +01:00
Yogisha Dixit
2ff963b0c7 Use a selector instead of loading resource for drop target.
Test: manual
Bug: 187355401,187035471
Change-Id: I65fef2c810c791c3282bd4a087359f6cff774cc4
2021-06-04 12:10:06 +01:00
Weilun Du
19d623d921 Revert "Update preferences to Material Next styling"
Revert "Add dependency for settings activity collapsing toolbar"

Revert submission 14740617-collapse3

Reason for revert: Build breakage
Reverted Changes:
I5ef658979:Add dependency for settings activity collapsing to...
I0ca55eecb:Update preferences to Material Next styling

Bug: 189919452
Change-Id: I4aa0bfc473334266a951d84064b4e8e406fff0a4
2021-06-02 22:04:44 +00:00
Brian Isganitis
9b8ab05a17 Update preferences to Material Next styling
Styles are forked from SettingsLib to avoid using any private APIs.

Test: Settings root, all apps, and about have new style on S
Bug: 187732263
Fix: 188254205, 188012913
Change-Id: I0ca55eecbc82cfa5d0b8707beb4bb7c82b2aa2b1
2021-06-01 19:44:19 -04:00
Brian Isganitis
d9463fbfdd Merge "Create settings activity layout with explicit toolbar" into sc-dev 2021-06-01 20:15:15 +00:00
Jonathan Miranda
8a51f11b63 Merge "Make BaseIcon.Workspace so that it can be overriden." into sc-dev 2021-06-01 18:17:43 +00:00
Jonathan Miranda
dfde41cf1e Merge "Change folderFillColor to colorBackgroundFloating." into sc-dev 2021-06-01 18:17:17 +00:00