Commit Graph

34936 Commits

Author SHA1 Message Date
Jonathan Miranda
273aa1c7af Merge "Update folder preview and folder background colors." into sc-v2-dev 2021-10-08 18:22:06 +00:00
TreeHugger Robot
4e9a3d5bdf Merge changes I499c59bd,Ia7260c60,I90846e65 into sc-v2-dev
* changes:
  When taskbar would be stashed in 3 button mode, hide icons instead
  Add flags to stash taskbar for app pinning and empty hotseat
  Migrate mStashedInApp to FLAGS_STASHED_IN_APP
2021-10-08 17:14:45 +00:00
Thales Lima
292a993c4a Merge "launcher: refactoring variables into arrays" into sc-v2-dev 2021-10-08 16:15:18 +00:00
Thales Lima
83bedbfe97 launcher: refactoring variables into arrays
There are a lot of variables that can be merged together into arrays
following some optimizations done in other places.

Bug: 191879424
Test: checking cell size and extra space in dumpsys
Change-Id: I1d73fbb5da2df2345ced7f46df5bae5d75d9d6b1
2021-10-08 13:36:56 +01:00
Tony Wickham
1bd4bf7ff1 When taskbar would be stashed in 3 button mode, hide icons instead
In 0 button mode, stashing morphs the icons into the home handle. In 3 button mode, that doesn't make sense, but we should still hide the icons (and just keep the 3 nav buttons). You still can't manually stash via long press in 3 button mode, but this will address other states where we automatically stash the taskbar when we want to hide the icons from users (e.g. when pinning an app).

Test: Pin an app from overview in 3 button mode, ensure the taskbar icons disappear until unpinning
Bug: 190192993
Change-Id: I499c59bd9d7871ff64696b67065cf9d4863222a5
2021-10-07 23:29:41 -07:00
Tony Wickham
db0c2f1b79 Add flags to stash taskbar for app pinning and empty hotseat
Test: pin an app from overview, watch taskbar stash automatically until unpinning
Test: turn off suggestions for hotseat, remove all items and watch taskbar stash automatically when opening an app
Fixes: 190192993
Fixes: 193937948
Change-Id: Ia7260c60a820af1a48c9e4a400a52753baf34d41
2021-10-07 23:29:41 -07:00
Tony Wickham
772732de9e Migrate mStashedInApp to FLAGS_STASHED_IN_APP
This is to prepare for different flags that could cause taskbar to be stashed in an app without the user explicitly long pressing to stash.

Test: run wwdebug and wwlogcat, ensure still get logs for long press stash events; other interactions like clipping tasks to above unstashed taskbar still work as before
Bug: 190192993
Bug: 193937948
Change-Id: I90846e650a438e03bdcfdf9c4bf919e19cc5abb3
2021-10-07 23:29:34 -07:00
TreeHugger Robot
96ddd1cfd8 Merge "Enable QUICK_WALLPAPER_PICKER for droidfood." into sc-v2-dev 2021-10-08 02:50:59 +00:00
TreeHugger Robot
70adfb5eb8 Merge "Add a new string for widget configuration drop target" into sc-qpr1-dev am: 52c93d17fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15992145

Change-Id: I2c4e9f4804240ade93ecbdae826f3d91a4411504
2021-10-08 01:31:28 +00:00
TreeHugger Robot
52c93d17fa Merge "Add a new string for widget configuration drop target" into sc-qpr1-dev 2021-10-08 01:09:24 +00:00
Samuel Fufa
3aae069e2b Merge "[Work profile] Fix flickering work mode switch" into sc-v2-dev 2021-10-07 23:42:42 +00:00
Brian Isganitis
5b2221637f Enable QUICK_WALLPAPER_PICKER for droidfood.
Test: Wallpapers show up in long-press menu by default.
Bug: 188222480
Change-Id: I51441b0f7f50f40adf4ff15c42a5be792723cc03
2021-10-07 18:37:26 -04:00
Alex Chau
5d2309285c Merge "Use displayId to determine CHANGE_ACTIVE_SCREEN" into sc-v2-dev 2021-10-07 19:35:43 +00:00
Andy Wickham
a01741bb61 Merge "Removes Smartspace Feedback flag." into sc-v2-dev 2021-10-07 18:36:11 +00:00
Brian Isganitis
e3b26d0102 Merge "Have PopContainerWithArrow require BaseDraggingActivity." into sc-v2-dev 2021-10-07 18:01:23 +00:00
TreeHugger Robot
c220b9a202 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-qpr1-dev am: 8b3ae2064b -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15995293

Change-Id: If05df732a392805ddba01756001100429ed163fb
2021-10-07 15:05:47 +00:00
Alex Chau
fe69980f90 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev 2021-10-07 14:52:05 +00:00
Vinit Nayak
7c2b52e5cf Merge "Show split options when overview actions hidden for grid" into sc-v2-dev 2021-10-07 14:51:44 +00:00
Vinit Nayak
c5ae15b481 Merge "Move back to end of screen on keyguard" into sc-v2-dev 2021-10-07 14:49:47 +00:00
TreeHugger Robot
8b3ae2064b Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-qpr1-dev 2021-10-07 14:48:19 +00:00
Bill Yi
b431ad7ad9 [automerger skipped] [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 39122b4f30 am: 90f1a4e085 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15997482

Change-Id: I1828cb7f9bc5392ce8ff01e38c76013bc0351a36
2021-10-07 13:59:11 +00:00
Alex Chau
4f140f96e8 Use displayId to determine CHANGE_ACTIVE_SCREEN
- Currently CHANGE_ACTIVE_SCREEN is dispatched when rotating too, which is incorrect. mScreenSizeDp is different in portrait and landscape, and varies more than swapping width/height due to different insets applied. Therefore, use the change of unique display id as a signal instead.

Fix: 202366729
Test: Rotate device, overview stays
Test: Unfold devices, overview goes away
Change-Id: Id8a7d4a1e237717521bfc5a5a67f23c4ee801c61
2021-10-07 14:44:01 +01:00
TreeHugger Robot
b01c390299 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-07 08:40:56 +00:00
TreeHugger Robot
27d9bc556e Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-10-07 08:40:51 +00:00
TreeHugger Robot
137dd35d26 Merge "[OneSearch] Log events with timestamp into logcat for debugging." into sc-v2-dev 2021-10-07 08:03:57 +00:00
Andy Wickham
e5f2877eaa Removes Smartspace Feedback flag.
Bug: 202296180
Test: Manual
Change-Id: Ifff851116c09c0729a8152a93eb2d758f7c9b126
2021-10-06 20:12:08 -07:00
Vinit Nayak
a08e806e25 Move back to end of screen on keyguard
* Animate it back into position after user unlocks
* Re-create taskbar on layout direction change so
PropertyHolders are recreated to take into account
new values

Fixes: 199852418
Test: Tested w/ password + pin for gesture + 3 button
Change-Id: Ie7f16f737a8fc12328c05d7628d0e3ae09fc08ca
2021-10-06 18:09:15 -07:00
Jon Miranda
b77878ebe3 Update folder preview and folder background colors.
Bug: 201332301
Test: light theme / dark theme
      open and close folder, ensure colors are accurate

Change-Id: I49198eb2faee03111be33051fd1cb08094844c77
2021-10-06 16:57:33 -07:00
Becky Qiu
f11ecb7f59 [OneSearch] Log events with timestamp into logcat for debugging.
Bug: 199289915
Test: example log: https://paste.googleplex.com/5741834610409472
Change-Id: I24b2e68b36cb897ae3e6ccc38cf0561d38af6751
2021-10-06 15:20:47 -07:00
Bill Yi
513a60cdc2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I40d86c2f147e60939fd428ff277a63c7a75f0e3c
2021-10-06 21:35:04 +00:00
Bill Yi
c3b9e7cf6b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic59a97dcc0eaf13c3554d01ef4d6b094d893e7bd
2021-10-06 21:34:22 +00:00
Bill Yi
90f1a4e085 [automerged blank] Import translations. DO NOT MERGE ANYWHERE 2p: 39122b4f30
Blank merge reason: commit message contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15997482

Change-Id: If745478a901821ee58e1598bebd3d0f7fbdd7333
2021-10-06 21:33:53 +00:00
Bill Yi
39122b4f30 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9179a69632df6353981c85d3b7613211f4b7ab78
2021-10-06 21:33:38 +00:00
Bill Yi
3ec748654e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I86b517b1fa0abfc0f14c6ffc7edcd98c14552647
2021-10-06 21:31:18 +00:00
sfufa@google.com
01e0009b71 [Work profile] Fix flickering work mode switch
Since there is no system broadcast with Intent.ACTION_MANAGED_PROFILE_ADDED, UserCache's user list does not get updated when a new profile is installed until launcher is restarted. This change fixes that problem by getting the freshest list of users directly from UserManager.

This change also applies the proper padding to work apps recycler-view after work mode switch is attached.

Test: Manual
Bug: 201191227
Change-Id: I0f570eba44ebb845d0d6f8c5f14a63f9a8c18539
2021-10-06 14:27:55 -07:00
Steven Ng
77940284eb Add a new string for widget configuration drop target
Test: manual. See screenshot in b/201286923
Fix: 201286923
Change-Id: I5be4f723523befe359b922273d11f57fb9f0b3fd
(cherry picked from commit 29f46c9628)
2021-10-06 17:38:03 +00:00
Tony Wickham
f9d2082cf3 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev 2021-10-06 17:36:45 +00:00
Alex Chau
aea42dc43e Only adjust min/max scroll for split screen in landscape
- Portrait's split placeholder is at top/bottom and does not affect scroll

Bug: 200537659
Test: Split left and split right in portrait / landscape, check if min/max scroll is correct
Change-Id: Ib7eb09d3cc44c8e0d962920ad094c73abc5f0dbd
2021-10-06 12:31:10 +01:00
Tony Wickham
66ed0ff23e Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
2021-10-05 18:14:51 -07:00
Vinit Nayak
6ab0d1e7be Merge "Reset state after split launch animation finishes" into sc-v2-dev 2021-10-06 00:56:48 +00:00
TreeHugger Robot
1bf753f7a6 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev 2021-10-06 00:14:46 +00:00
TreeHugger Robot
88eca11997 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-qpr1-dev am: ae6e81587c -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15976911

Change-Id: I0b5a4df2571878937bd5d72e5850d1489acdce4e
2021-10-05 23:14:08 +00:00
TreeHugger Robot
ae6e81587c Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-qpr1-dev 2021-10-05 22:58:32 +00:00
Vinit Nayak
0516737146 Reset state after split launch animation finishes
Previously we were clearing SplitSelectStateController
state too soon for fake landscape case where
as soon as the tasks launch the device does a rotation
animation since the new split tasks are in landscape.
Move restting state after animation finishes.

Fixes: 201980666

Change-Id: I23efd59fad444c47ae6c2048888a8570f22610fd
2021-10-05 15:29:24 -07:00
Vinit Nayak
0ff2ad6ff4 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev 2021-10-05 21:44:34 +00:00
TreeHugger Robot
feeb788941 Merge "Update logging to help debug b/200572078" into sc-v2-dev 2021-10-05 21:33:55 +00:00
Vinit Nayak
95ee358269 Show split options when overview actions hidden for grid
* We hide split option in task menu for focused task
if the user hasn't scrolled at all in overview
* We show option when user has scrolled because then
the split option from overview actions will be hidden
* Mostly uses the same logic as
RecentsView#updateActionsViewFocusedScroll()

Bug: 201380373
Test: Manual
Change-Id: Ia8769a67cfbb2e4414cd4d8e816e62245fc4bd2c
2021-10-05 14:28:07 -07:00
Brian Isganitis
6a1b0a5824 Have PopContainerWithArrow require BaseDraggingActivity.
Fix: 201978182
Test: No
Change-Id: I3ed46c07cce88b939d1a085ab62d5413ca217e5a
2021-10-05 14:38:14 -04:00
Pat Manning
a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak
01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00