Commit Graph

79603 Commits

Author SHA1 Message Date
minch
263bc2d3e8 Migrate to TaskViewsIterable & TaskViewsIterator - [n/n]
Use TaskViewsIterable to iterate all the current TaskViews
inside `RecentsView.updateGridProperties`. Remove all the indices
usage inside this function as well.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Verified that the TaskViews layout is correct in below scenarios:
      1. Swipe up from an fullscreen app or from home
      2. Dismiss the large tile, a TaskView in the middle either in the
         top row or the bottom row, dismiss the last TaskView.
      3. Clear all TaskViews
      4. Swipe up to the right side of the edge to have a normal
         TaskView as the snapped TaskView
      5. Alt+Tab with more than 6 apps to enter Overview, with a
         hidden TaskView from the alt+tab list as the snapped TaskView.
Change-Id: Ic01534ed03bcc654d5799f43f0cf659d2c86ca31
2024-12-23 15:55:05 +00:00
minch
304e0f29be Migrate to TaskViewsIterable & TaskViewsIterator - [4/n]
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Checked that TaskViews layout are correct in below scenarios:
      1. Dismiss the first TaskView
      2. Dismiss the last TaskView
      3. Dismiss a TaskView in the middle
      4. Remove all the TaskViews
Change-Id: I944503e9c1a65cded128efd5572734e887cdb027
2024-12-19 00:46:18 +00:00
Treehugger Robot
ee2e3ba257 Merge "Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size" into main 2024-12-18 16:09:36 -08:00
Treehugger Robot
1ad0e1555b Merge "Migrate using TaskViewCount as the indices" into main 2024-12-18 15:43:25 -08:00
Ana Salazar Maldonado
bc2b3ae3b0 Merge "Fix Title padding for the contrast tile" into main 2024-12-18 15:24:04 -08:00
Sebastián Franco
f07079d0ff Merge "Revert^2 "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-18 14:16:08 -08:00
Anushree Ganjam
59137e44e2 Merge "Update the All apps label to "Apps list"" into main 2024-12-18 14:07:36 -08:00
Sunny Goyal
21a84af378 Merge "Fixing module inheritence when overriding Launcher component" into main 2024-12-18 13:54:30 -08:00
Vinit Nayak
9f4ab8b89a Merge "Hide App Chip for smaller app in 90:10 flex split" into main 2024-12-18 12:00:48 -08:00
Sunny Goyal
60bad051c4 Fixing module inheritence when overriding Launcher component
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I1f726e9895f6872d0294a11ab0c52c6c619c2a3f
2024-12-18 10:38:00 -08:00
minch
55c301add0 Migrate using TaskViewCount as the indices
Do not rely on `getTaskViewCount` as the index information.
- Remove the use of the deprecated function `obtain` as well.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Enabled TalkBack on Tangor and entered overview with multiple
      opened apps, verified the information as below:
      1. The number of children pronounced by TalkBack is the number
         of RecentsView children.
      2. Talkback starts from the leftmost visible TaskView, which
         matches the logic that we added the TaskView in reverse order
         to the accessibility children list.
      3. Scrolled inside RecentsView, and checked the from and end
         indices of the a11 event are the same as before.
Change-Id: Ib3c37422ba940aed6c124a8cc0d4732144783d45
2024-12-18 16:46:46 +00:00
Saumya Prakash
1bcaab81e3 Merge "Close the multi instance menu when other things open" into main 2024-12-18 07:38:26 -08:00
Schneider Victor-Tulias
0b2c37ed72 Use DeviceProfile in NavBarGestureHandler and EdgeBackGestureHandler for the display size
DisplayController caches the display size, so when the user unfolds a foldable, the screen size is incorrect, which messes with the touch handling. Using DeviceProfile instead.

Flag: EXEMPT bug fix
Fixes: 361694048
Test: fold/unfold device during home/back/overview tutorial steps
Change-Id: Ie49f677f97ea5ddb0f91d2e662677edaaa81860a
2024-12-18 10:03:50 -05:00
Uwais Ashraf
7a829e98d8 Merge "Move cancellation of CoroutineScopes to bg thread as it can be slow." into main 2024-12-18 05:36:02 -08:00
Anushree Ganjam
8dae1be563 Update the All apps label to "Apps list"
Set the AccessibilityNodeInfo containerTitle to improve a11y for users
in predictionRow.

See expected behavior suggestion in  https://b.corp.google.com/issues/379640673#comment1

Video
Quickstep launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/eugH3ID7eenOuLwTszaLHk

Pixel launcher: http://recall/-/cOtJfHR6buEyEHnRyCqzVE/fftzwMRCy6N3o7OcwiGMdk

Bug: 379640673
Test: Manual
Flag: EXEMPT a11y bugfix
Change-Id: I23a8a142afb213c0801402a56bc134bc14f0f97d
2024-12-17 16:39:45 -08:00
Treehugger Robot
a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Uwais Ashraf
2470d3fdf5 Move cancellation of CoroutineScopes to bg thread as it can be slow.
Bug: 381317629
Fix: 383999850
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces for improvement
Test: Performance tests
Change-Id: Ic796fe578f5aa98ce060ac22341a1bcfa68061df
2024-12-17 23:33:55 +00:00
Ana Salazar Maldonado
e3f421211e Fix Title padding for the contrast tile
When drawing the pill, after the pill surrounds the text, add
horizontal_padding on each side instead of round_rect_padding. This is
the correct value since it is the space between the tile and the text.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: I48521dc05c04b561b271aa589712ed493af63189
2024-12-17 14:45:42 -08:00
Treehugger Robot
446ea7592f Merge "Let getOffsetToDismissedTask not rely on taskCount" into main 2024-12-17 14:37:52 -08:00
Vinit Nayak
cf332154c1 Hide App Chip for smaller app in 90:10 flex split
Bug: 384110883
Test: Tested with both halves made smaller,
large screen and small (phone has other existing bugs).
Lanscape and portrait.
Flag: com.android.wm.shell.enable_flexible_two_app_split

Change-Id: Ib6508c7b3192cc47fc8406cdf68c826bed29de5f
2024-12-17 13:52:39 -08:00
Sebastián Franco
12c346fbab Revert^2 "Making sure that test go to FixedLandscape on landscape"
This reverts commit d98bb0b979.

Reason for revert: b/383917141

Change-Id: I503fd7136b927064a54e428e422335c06e221e2e
2024-12-17 11:19:29 -08:00
Mykola Podolian
bd10730a57 Merge "Added an onClick listener to the bubble bar." into main 2024-12-17 10:36:14 -08:00
Stefan Andonian
fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Sihua Ma
1386bf57b7 Merge "Attempt on deflaking FolderTest" into main 2024-12-17 09:23:06 -08:00
Sihua Ma
e5a3789024 Attempt on deflaking FolderTest
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test deflake
Bug: 382305734
Change-Id: I7f66b5b8973c97f6bc03a739044fb8c90886e41e
2024-12-17 06:32:53 +00:00
Treehugger Robot
d3f591f614 Merge "Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly." into main 2024-12-16 22:06:32 -08:00
Treehugger Robot
254ba3092e Merge "Handle cancelled All Apps transitions." into main 2024-12-16 19:33:00 -08:00
minch
7fc34db11b Let getOffsetToDismissedTask not rely on taskCount
This is a preparation to migrate TaskViews iteration that
rely `getTaskViewCount` to the `TaskViewsIterable` and
`TaskViewsIterator`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on tangor with `adb shell wm density 480` to simulate
      phone layout, and verified overview layout is correct in
      scenarios below:
      1. Dismiss the first TaskView
      2. Dismiss the last TaskView
      3. Dismiss a TaskView in the middle
      4. Click `ClearAll` button to dismiss all the TaskViews
Change-Id: Icbaf1ea706906097fc6ac60ad3e2ab17d2781284
2024-12-16 23:39:24 +00:00
mpodolian
5391e14c3e Added an onClick listener to the bubble bar.
Previously, clicks were not handled because no listener was set on the
bubble bar.

Fixes: 383622825
Test: Manual. Ensure bubbles are on the home screen and set the
navigation mode to 3-button navigation. Click on the collapsed bubble
bar and observe the bar expanding.
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I99e1c20e40a9dd9da97b68817734c8ca1f656baa
2024-12-16 15:16:15 -08:00
Charlie Anderson
3eec1895ed Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly.
IPD#reset() was resetting the internal IDP dbFile to the factory default instead of current grid/db

This lead to LoaderTask and grid migration creating an empty DB for the wrong grid size, while the restored DB remained unused. Leading to an empty home screen because an empty DB file was used.

Bug: 377510898
Flag: EXEMPT bugfix
Test: manually testing backup & restore with various grid sizes
Change-Id: I709201e484afb8f12a4fde21198d2c5793d89ca1
2024-12-16 14:39:41 -08:00
Brandon Dayauon
9f481bb2ea Merge "Fix swipe up to home gesture when entering scheduler page" into main 2024-12-16 13:07:04 -08:00
Liran Binyamin
6592d90003 Merge "Fix bar visibility after dismissing while stashed" into main 2024-12-16 10:05:39 -08:00
Treehugger Robot
eeebf0111b Merge "Don't allow drag n drops to auto-switch pages during accessibility item moves." into main 2024-12-16 09:36:34 -08:00
Saumya Prakash
54c6cf7c38 Close the multi instance menu when other things open
This change ensures that if open, the Taskbar multi instance menu will close when
another long press app menu is launched, when a folder is opened, or
when Taskbar all apps is opened.

Fix: 383510315
Test: Open Taskbar multi instance menu and ensure it closes when other
views are opening (Taskbar all apps, a folder, and app long press menu)
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Id2d64c86a76978af8db56d3a083dc79a677a1a5d
2024-12-16 08:54:42 -08:00
Johannes Gallmann
c812907eb8 Merge "Add blur effect to predictive back-to-home animation" into main 2024-12-16 05:50:34 -08:00
Gustav Sennton
c66964125c Merge "Revert "Open Task into Desktop Mode when Taksbar is in DesktopMode"" into main 2024-12-16 05:42:38 -08:00
Xin Li
31814b7513 [automerger skipped] Merge "Merge 24Q4 into AOSP main" into main am: 848a909f3d -s ours am: 1ea0b3a66f -s ours
am skip reason: Merged-In Iaa1d8352b628aeb47f79a5c8e59256a3c45a2909 with SHA-1 c53bf7890a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/30116323

Change-Id: I682485435029f912f4ca9d45880c31f1e255c6fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-12-13 22:03:24 -08:00
Xin Li
dbddac3522 [automerger skipped] Merge 24Q4 into AOSP main am: 078f13fca8 -s ours am: 829423919d -s ours
am skip reason: Merged-In Iaa1d8352b628aeb47f79a5c8e59256a3c45a2909 with SHA-1 c53bf7890a is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/30116323

Change-Id: Ib02d0fae559af1a35335673f4a8a5919a2b2487f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-12-13 22:03:19 -08:00
Xin Li
1ea0b3a66f [automerger skipped] Merge "Merge 24Q4 into AOSP main" into main am: 848a909f3d -s ours
am skip reason: Merged-In Iaa1d8352b628aeb47f79a5c8e59256a3c45a2909 with SHA-1 c53bf7890a is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3413503

Change-Id: I2c39ed933c0eb46e91a59099edc6e030f7abfe08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-12-13 19:18:34 -08:00
Xin Li
829423919d [automerger skipped] Merge 24Q4 into AOSP main am: 078f13fca8 -s ours
am skip reason: Merged-In Iaa1d8352b628aeb47f79a5c8e59256a3c45a2909 with SHA-1 c53bf7890a is already in history

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3413503

Change-Id: I0c880bb1ff134d6960bdc501465a04edf6403b19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-12-13 19:18:31 -08:00
Andy Wickham
f6850bd4f2 Handle cancelled All Apps transitions.
Previously if this was cancelled mid-animation, the background
panel could get stuck on the screen.

To reproduce this consistently, I automatically cancelled the
animation 50ms after it started. Here's how that looked:
 - Before: https://drive.google.com/file/d/1tiW7mFehk3of-qYe1_HBZSmJLjU4VVmv/view?usp=drive_link&resourcekey=0-tH7YccjcNuXe8qKaL_8H2w
 - After: https://drive.google.com/file/d/1XpRy8FusaSZkJTGa7FHhUuqMUHkeI_UA/view?usp=drive_link&resourcekey=0-gvoyXE3puv7lW78kgKLEng

Fix: 383731295
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I9423b75800a002419a56a3fe3f93b2e7350aeaa0
2024-12-13 17:59:32 -08:00
Liran Binyamin
38dc7ef520 Fix bar visibility after dismissing while stashed
When updating the bubble bar visibility, allow it to become visible
if the only hidden bit is the stashed one and we're animating.

This fixes the visibility issue that appears after dismissing the
bar while stashed, and then sending an initial bubble, while still
stashed.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 383620113
Test: manual
       - create bubble
       - launch app
       - dismiss bubble with adb
       - create bubble with adb
       - observe bubble bar is visible during the animation
Change-Id: I7a955de068867829b3ccab11b2b0adc8d8e10239
2024-12-13 20:30:47 -05:00
Mykola Podolian
19e6afa1f6 Merge "Align the adjusted hotseat drop animation with the hotseat" into main 2024-12-13 17:13:30 -08:00
Wen-chien Wang
ad0b62daad Merge "pin-shortcut: Add pin shortcut to the context menu" into main 2024-12-13 17:00:42 -08:00
Xin Li
848a909f3d Merge "Merge 24Q4 into AOSP main" into main 2024-12-13 16:57:21 -08:00
Stefan Andonian
0f4e5e974d Don't allow drag n drops to auto-switch pages during accessibility item moves.
Bug: 379798547
Test: Manually tested this on device.
Flag: EXEMPT bug fix
Change-Id: Ic19a0d167525d5500ed1dacd3dcaaa4550b11261
2024-12-13 16:11:08 -08:00
Wen-Chien Wang
2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Treehugger Robot
5849df4002 Merge "[-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough" into main 2024-12-13 14:02:46 -08:00
Fengjiang Li
b8b16bd288 [-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough
Fix: 381017761
Flag: NONE - released code
Test: manual - record a video
Change-Id: I5bda4a234cdcc8227d4feb9a92a174d07e46f7a2
2024-12-13 12:11:41 -08:00
Treehugger Robot
9b6c58e6a9 Merge "Do not rely on getTaskViewCount to iterate TaskViews" into main 2024-12-13 11:59:41 -08:00