Commit Graph

73940 Commits

Author SHA1 Message Date
Rohit Goyal
25ef2e1eca UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iad3cc1a254b1543511976469c444eeaf869c7d50
2024-02-01 20:52:19 +00:00
Brandon Dayauon
3458141a9e Merge "Add Utility method in userCache to get badgeDrawables" into main 2024-02-01 18:02:17 +00:00
Schneider Victor-tulias
3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Schneider Victor-tulias
8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
Bill Yi
ea784da63c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f148ef3d26 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26077678

Change-Id: I3d13835137d024b4191ae411bd1e8fff85310b85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-01 13:53:28 +00:00
Himanshu Gupta
69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta
3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Tracy Zhou
e757578908 Merge "Fix non-null check crash" into main 2024-02-01 00:21:05 +00:00
David Saff
60379ac052 Merge "Assert keyguard gone at beginning and end of PortraitLandscapeRunner" into main 2024-02-01 00:15:39 +00:00
Brandon Dayauon
72542b6058 Add Utility method in userCache to get badgeDrawables
- In userCache, create a utility method to get badgeDrawables via userHandle. As of this moment, this is used in Toast.

Bug: 312898415
Test: Manual photos:
before 0-state: https://drive.google.com/file/d/15OUcd8i1IoUU0BgMlZj-8e0YWsmtzY4E/view?usp=sharing
after 0-state: https://drive.google.com/file/d/15SH19xvdLzQt1QbHY2oAxPAFVXPZDchF/view?usp=sharing
before textHeader: https://drive.google.com/file/d/15OLpN2SNF9QNWMrs0Aos5fS-l39Op-wo/view?usp=sharing
after textHeader: https://drive.google.com/file/d/15PIi-K6FfdCtPwWg2GEP9SUE5ow2YXJ5/view?usp=sharing
Flags: None

Change-Id: Ia6f89e634cc0af47cae91add6ea62d3af452c441
2024-01-31 15:54:30 -08:00
Shamali Patwa
bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Andy Wickham
552df9b647 Merge "Re-apply all apps insets when unfolding." into main 2024-01-31 23:30:49 +00:00
Shamali Patwa
962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
Jeremy Sim
99cfd0905b Merge "Add error logging and better crash safety for app pairs" into main 2024-01-31 22:25:04 +00:00
Jordan Silva
2e75eeae32 Merge "Refactoring PagedOrientationHandler to extract functions from to quickstep" into main 2024-01-31 22:21:56 +00:00
Shamali Patwa
ded14cc211 Merge "Update OWNERS for picker directory to include new owners." into main 2024-01-31 22:17:01 +00:00
Sunny Goyal
9491140eff Merge "Adding a flag to support activity overlay on home screen" into main 2024-01-31 21:40:26 +00:00
William Leshner
de36f8a8ec Merge "Filter widgets in widget picker activity by size." into main 2024-01-31 21:38:45 +00:00
Rohit Goyal
d4b2c8a858 Merge "UI Improvement: Fix unexpected progress bar around app icon added to Workspace after unarchival." into main 2024-01-31 20:42:08 +00:00
David Saff
1121f8b5b9 Assert keyguard gone at beginning and end of PortraitLandscapeRunner
Should help distinguish if we have tests leaving things in a bad state,
or the intervening infrastructure.

Bug: 285935417
Change-Id: I5569472a9804cb21ee0646c72decb5f51be9ab01
2024-01-31 19:35:40 +00:00
Sunny Goyal
fffb4feb4e Adding a flag to support activity overlay on home screen
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: N/A
Change-Id: Ic29c2c21da22554213a1792a38caf6907438c86d
2024-01-31 11:34:00 -08:00
Tracy Zhou
e22d4f7eea Fix non-null check crash
onConfigurationChanged can be triggered before all the buttons are initialized, including Space, in which case, we currently skip that rendering

Bug: 230395757
Test: cold start doesn't crash
Change-Id: If451ddbb6b2055a207372d6470eb0fe0faff0301
2024-01-31 19:31:59 +00:00
Jordan Silva
715e25adf4 Refactoring PagedOrientationHandler to extract functions from to quickstep
This CL extracts RecentsView methods from PagedOrientationHandler to RecentsPagedOrientationHandler. It will allow to have quickstep specific components in the newer interface, like IconAppChipView.

Bug: 320633351
Flag: N/A
Test: atest NexusLauncherTests
Test: atest TaplTestsSplitscreen
Test: atest TaplTestsQuickstep
Change-Id: Ie7de23bddccbdb8eac93eff66a5d929f5bf0ee3a
2024-01-31 18:58:15 +00:00
Jeremy Sim
e96d30bddb Make app pairs respond properly to disabled state
1) App pair member icons are now always redrawn when app pair icon is redrawn, allowing greyed out icons to be updated immediately when an app is disabled.
2) App pairs now check for disabled status when clicked. If one or both of the apps is disabled, app pair will not be launched, and the appropriate error message or affordance will be displayed.

Fixes: 323088270
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I7f2af75db0d8579d5d04583c0d3ead32714768e4
2024-01-31 16:01:55 +00:00
Schneider Victor-tulias
7e768fbf3b Handle slow gesture handling
Fixed broken gesture handling when RecentsAnimationCallbacks signals take too long.

Flag: NONE
Fixes: 285636175
Test: added a programmatic delay in RecentsAnimationCallbacks.onAnimationStart, attempted home/overview/quick switch gestures then quickly attempted another gesture during the delay
Change-Id: I59261d21ca4e2bd4b5496822e78c6db74eac10c7
2024-01-31 10:23:24 -05:00
Rohit Goyal
9ab4550ac3 UI Improvement: Fix unexpected progress bar around app icon added to Workspace after unarchival.
* In case app icon is added to workspace after unarchival completes for archived app, it shows a completely filled progress bar around the icon.
* This behaviour exists because the 'FLAG_ARCHIVED' flag is copied from `AppInfo` item.
* This cl updates the 'FLAG_ARCHIVED' flag for 'AllApps' item once unarchival completes.

Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I739225707a11bc9a6aa23e81775b4e036ce81a7e
2024-01-31 14:53:01 +00:00
Bill Yi
f148ef3d26 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8331d5152ba23f3fffa4f375d8a732985e16cf1f
2024-01-31 02:57:16 -08:00
Luca Zuccarini
ae741dec9f Merge "Update dependency on Shell utils." into main 2024-01-31 10:06:19 +00:00
Jeremy Sim
cfcf2255dc Add error logging and better crash safety for app pairs
This causes app pairs to log an error message if creation or icon inflation is attempted with contents != 2. App pairs with wrong numbers of members should not be created anymore.

Fixes: 317283244
Fixes: 322892793
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I5e454042719bb67187f900c546380bb44cfc34ac
2024-01-31 15:42:20 +08:00
Tracy Zhou
89fa4e35d8 Merge "Make sure touch only goes to the nearest button when it makes sense" into main 2024-01-31 06:26:32 +00:00
Tracy Zhou
c7d7418cae Merge "Center a11y button" into main 2024-01-31 06:25:55 +00:00
Automerger Merge Worker
f390e921a6 Merge "[automerger skipped] Merge Android 24Q1 Release (ab/11220357) am: 6810c19646 -s ours" into main 2024-01-31 02:26:16 +00:00
Shamali Patwa
d3f5010ac5 Merge changes from topic "categories" into main
* changes:
  Add a default widget category provider that uses application category.
  Add a feature flag for displaying categorized widget recommendations.
2024-01-31 02:24:05 +00:00
Anushree Ganjam
8ee9076f0e Merge "[PS] Show "Uninstall" in Long Press menu for Private Space apps." into main 2024-01-31 02:22:11 +00:00
Xin Li
ff3b91b257 [automerger skipped] Merge Android 24Q1 Release (ab/11220357) am: 6810c19646 -s ours
am skip reason: Merged-In I0708bf3c060ba84089722d0bd9480a4f4bd2b8e2 with SHA-1 1e60b1a4c4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25971170

Change-Id: I7a352fad4a3f3c7a87e827d568920ac4d6569cc2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 02:02:32 +00:00
Tracy Zhou
1a92257520 Center a11y button
Bug: 25768138
Test: a11y button is centered when visible
Change-Id: If9099575c12b51a90bc9e15e712cb629811d36e3
2024-01-30 16:54:10 -08:00
Anushree Ganjam
45ef544ae5 [PS] Show "Uninstall" in Long Press menu for Private Space apps.
Video : https://b.corp.google.com/issues/319250810#comment18

- Add SecondaryDropTarget.performUninstall()
- Make SecondaryDropTarget.getUninstallTarget() public static.

Test: Manual
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD
Bug: 319250810

Change-Id: If6488033a976914fdc0a50658fc0561dc1a6586a
2024-01-30 16:54:04 -08:00
Shamali P
c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Will Leshner
f0be49e693 Filter widgets in widget picker activity by size.
Bug: 322191186
Test: atest Launcher3Tests
Flag: NA

Change-Id: I003e05cc16ae576cda07d249d036d2f9dbacdcc2
2024-01-30 15:42:00 -08:00
Holly Jiuyu Sun
dd8de0a6d0 Merge "[PS] Update icon background for PS, Widget and web." into main 2024-01-30 23:34:05 +00:00
Tracy Zhou
419140aede Make sure touch only goes to the nearest button when it makes sense
- In NearestTouchFrame, we can't use view bounds alone since the buttons do not have the same root (3 buttons are in the main container, while the contextual buttons are in the contextual button container). This currently caused the issue that contextual button region, when the contextual buttons are invisible, triggers overview
- Need to add an empty space in the left / top area of the button nav to prevent view clicks from going into back (that's how it works in navigationbar/)

Bug: 25768138
Test: left and right of 3 buttons don't trigger back or overview
Change-Id: Idc26c0c8ac0ecc000300a6db2e3e6251f678dada
2024-01-30 14:27:48 -08:00
Jakob Schneider
ac7c1e3736 Merge "Initialize the archiving compat options during launcher3 startup." into main 2024-01-30 21:37:30 +00:00
Saumya Prakash
dc23966243 Merge "Don't show the Tasbar Pinning edu for 3 button nav users" into main 2024-01-30 21:20:45 +00:00
Vadim Tryshev
a41fc4e4ad Merge "Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner" into main 2024-01-30 20:47:27 +00:00
Shamali P
6a9d114d40 Update OWNERS for picker directory to include new owners.
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.

Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
2024-01-30 20:10:24 +00:00
Ats Jenk
fbf3393faf Merge "Send bubble bar bounds in display coordinates to wmshell" into main 2024-01-30 19:10:23 +00:00
Sunny Goyal
558196ef87 Merge "Splitting bindItems method to also accept already inflated views which will eventually allow us to inflate icons on the background thread" into main 2024-01-30 18:49:20 +00:00
Jakob Schneider
2f609d09f6 Initialize the archiving compat options during launcher3 startup.
This just sets an OP_CODE (cheap operation). It disables a help-dialog
for launchers who have not implemented archiving.

Test: PackageInstallerArchiveTest and also manually
Bug: 302114748
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ifa9335d7ad250218eec3863dcdd986118bba007c
2024-01-30 18:48:16 +00:00
Ivan Tkachenko
2e11769840 Merge "Fix RemoteTargetGluer crash" into main 2024-01-30 17:56:28 +00:00