Commit Graph

17448 Commits

Author SHA1 Message Date
Vadim Tryshev
14c6c8cee4 Improving tests to fix testBindNormalWidget_withoutConfig, and beyond
1. Make waitXXX methods fail if the condition diesn’t turn true.
2. Waiting for loading to complete in tearDown instead of reloading the
 model
3. Avoiding waiting for load-complete where loading didn’t start
4. Disabling last test in AddConfigWidgetTest
5. Waiting for loading to complete inside setupAndVerifyContents(), not
 outside
6. Unifying how we wait for loader to complete
7. Adding more logging

Bug: 117332845
Test: running all Nexus tests
Change-Id: I3070e1ac2b9161179cc3e0800b0cd8162807389a
2018-10-09 18:47:42 -07:00
TreeHugger Robot
02e900c3c9 Merge "Adding tests for fallback recents when a 3rd party launcher is installed" into ub-launcher3-master 2018-10-09 21:32:19 +00:00
Sunny Goyal
4ed58d6c03 Adding tests for fallback recents when a 3rd party launcher is installed
Change-Id: I1d4da13cc779f49832008b12b9628d01631faffe
2018-10-09 14:25:01 -07:00
Vadim Tryshev
2d5713634e Ignoring more tests
Bug: 117106893
Test: will see on TAP
Change-Id: Ic031cc6756473552fc11186f666bcb9debfcecb5
2018-10-09 10:31:33 -07:00
TreeHugger Robot
9720452363 Merge "Converting long item IDs to int" into ub-launcher3-master 2018-10-08 23:27:27 +00:00
Vadim Tryshev
b769edec46 Ignoring more tests
Bug: 117106893
Test: will see on TAP
Change-Id: I992edaff5e40e8c16188033b5cbda6b0228fc2b6
2018-10-08 16:05:11 -07:00
Sunny Goyal
efb7e84242 Converting long item IDs to int
> Items ids were already being typecasted to int when being bound on the UI
> Using a consistent type allow better use of platform data-structures
> Adding IntArray and IntSet as a replacement for various Collection classes

Change-Id: Id3c650ed2420c2bfca3bd7671d2b705b56112371
2018-10-08 14:52:39 -07:00
TreeHugger Robot
f307b6032e Merge "Groundwork for runtime-toggleable feature flags" into ub-launcher3-master 2018-10-08 17:26:57 +00:00
Ryan Lothian
688e9896fa Groundwork for runtime-toggleable feature flags
This is the first step in adding a flag toggler UI to launcher.
The change migrates a single flag (QSB_ON_FIRST_SCREEN) from a
boolean constant to a boolean method. In future, that will allow
us to return different values at runtime.

Bug: 117223984
Change-Id: I1e62c91dd941b8145166021bc0aa157733e62ea0
2018-10-08 13:17:30 -04:00
Vadim Tryshev
c09a12f065 Merge "More temporary logging to diagnose testPendingWidget_autoRestored" into ub-launcher3-master 2018-10-08 17:17:20 +00:00
Bill Yi
cd72d37a5f Import translations. DO NOT MERGE
Change-Id: Ibd887507837ddf4ad550f3fd8ae0086982fe1833
Auto-generated-cl: translation import
2018-10-06 18:42:21 -07:00
Vadim Tryshev
a7da86e14a More temporary logging to diagnose testPendingWidget_autoRestored
And waiting to loader to finish to improve determinism.

Bug: 117332845
Test: running Launcher
Change-Id: Icdfce969b61f8ceb952a2715037783458da4d4c4
2018-10-05 20:05:34 -07:00
Vadim Tryshev
51146bc7e6 Merge "Adding temporary logging to diagnose testPendingWidget_autoRestored" into ub-launcher3-master 2018-10-06 01:28:00 +00:00
Vadim Tryshev
c052e4e68a Adding temporary logging to diagnose testPendingWidget_autoRestored
This test fails

Bug: 117332845
Test: running Launcher
Change-Id: I300c856992b3d1f559c4c31525a45e2c4a960f11
2018-10-05 17:37:01 -07:00
Vadim Tryshev
acc9bbef6c Revert "Uncommenting WorkTabTest"
This reverts commit f76ea29772.

Reason for revert: The test now fails on ATP

Change-Id: Ic7bd89e61f4107338bbfaf63628646af427668d3
2018-10-05 21:51:53 +00:00
Vadim Tryshev
f76ea29772 Uncommenting WorkTabTest
It started to work locally in condition, I believe, identical to those
on ATP.

Bug: 112899690
Test: adb shell am instrument -e size large -w -r -e debug false com.google.android.apps.nexuslauncher.tests/androidx.test.runner.AndroidJUnitRunner
Change-Id: I2decb2142d15e025402c0c32b7b161dd28d102bb
2018-10-05 13:27:40 -07:00
Vadim Tryshev
4ada2d2cde Resetting loader state after each UI test run
This is to prevent tests from affecting tests running after them.

Bug: 117332845
Test: Ran all tests; will see on TAP
Change-Id: Ie93ef30477eb069c6b4df48c6fceaceb968edaf4
2018-10-05 12:03:17 -07:00
TreeHugger Robot
88c289eae3 Merge "Enabling "in test harness" flag with a direct call" into ub-launcher3-master 2018-10-04 23:45:18 +00:00
Vadim Tryshev
c295098e18 Enabling "in test harness" flag with a direct call
This allows running in-proc tests without enabling test harness on
Android and restarting Launcher.

Bug: 110103162
Test: TaplTests
Change-Id: Ife44eff4760eb1349a10847efe2c1f27643bf146
2018-10-04 16:33:45 -07:00
TreeHugger Robot
bd5a2dbb4f Merge "Fix issue where pointer id was being used to set as action index" into ub-launcher3-master 2018-10-04 20:20:40 +00:00
Hyunyoung Song
6b82a0843e Fix issue where pointer id was being used to set as action index
Bug: 117157432
Bug: 116744159

Context: In vary rare case, Pointer id can be higher than
MotionEvent.getPointerCount. When I was fabricating ACTION_POINTER_DOWN
event, I was using pointer id instead of index to create MotionEvent.
This resulted in stack trace as seen in the bug.

Change-Id: I802c2a45a274f0dda5984f1d266334fc8b6b0bea
2018-10-04 12:41:00 -07:00
TreeHugger Robot
bb24884801 Merge "Disable ShortcutsLaunchTest.testAppLauncher*" into ub-launcher3-master 2018-10-04 19:30:51 +00:00
Vadim Tryshev
5ec12a5d3a Disable ShortcutsLaunchTest.testAppLauncher*
Bug: 117106893
Test: will see on ATP
Change-Id: I2a38ef157b1e2efd4a433618c0570443ca34bdfb
2018-10-04 11:59:22 -07:00
TreeHugger Robot
18cc858445 Merge "Fix clipping issue on adaptive icons" into ub-launcher3-master 2018-10-04 17:47:52 +00:00
Sunny Goyal
b4e287a77c Only considering tap on recents view if finger didn't move
Bug: 114450749
Change-Id: Id99fd8c024140025b14973205f9080daa86db522
2018-10-04 10:01:08 -07:00
TreeHugger Robot
674e947979 Merge "Cancelling previous touch interaction when a new touch starts" into ub-launcher3-master 2018-10-03 23:35:27 +00:00
Hyunyoung Song
44bd6fd020 Fix clipping issue on adaptive icons
Bug: 116527322

More context: unlike previous issue that resulted in clipping on adaptive
icon due to launcher drawing issue (drawing outside the bounds, etc).
This issue is happening on b4 because when canvas is scaled after
the circle mask is digitized, there is a optical illusion that one line
of pixel seems missing. The issue is non observed if scaling is done
before setting the view bounds.

Change-Id: I7099075c88e77776c9cc4f23d79152293489cca2
2018-10-03 16:33:40 -07:00
TreeHugger Robot
b609c7970a Merge "Disabling testConfigCancelled_rotate" into ub-launcher3-master 2018-10-03 23:20:13 +00:00
TreeHugger Robot
8c23679c5e Merge "Disabling TestDragIcon tests" into ub-launcher3-master 2018-10-03 23:19:31 +00:00
Vadim Tryshev
7662701ee9 Disabling testConfigCancelled_rotate
It's flaky

Bug: 117106893
Test: will see on TAP
Change-Id: I452af39b0b3401d1ef875aee3c49eedd298a1cd3
2018-10-03 10:37:16 -07:00
Vadim Tryshev
7590edef0a Merge "Make @QuickstepOnOff and @PortraitLandscape available to all UI tests." into ub-launcher3-master 2018-10-03 17:23:43 +00:00
Vadim Tryshev
6ffb2c8faa Make @QuickstepOnOff and @PortraitLandscape available to all UI tests.
Also, fix rotation as Portrait as starting poin for all tests, to avoid
tests running in unexpected configuration.

Bug: 115645301
Test: run all Nexus tests
Change-Id: I3ab0e91db111eeefda77af2960c43962a119de0c
2018-10-02 17:32:01 -07:00
Winson Chung
69c9e4338f Merge "Break out of quickscrub if task fails to launch" into ub-launcher3-master 2018-10-03 00:20:41 +00:00
Vadim Tryshev
ef5bcacdea Disabling TestDragIcon tests
The bug below is for re-enabling disabled tests.

For now, we'd benefit more for enabling presubmits.

Bug: 117106893
Test: will see on TAP
Change-Id: Ia61e72be42405c7be4df6b5088b5a6d9c472bcaf
2018-10-02 17:12:58 -07:00
Winson Chung
f8e04b6464 Break out of quickscrub if task fails to launch
- Return the user to their previous state if quickscrub fails to launch
  the new task (ie. if it finishes itself mid-launch).

Bug: 117163033
Change-Id: If03cf0431be40d9b81dfcc5dffcb2bf4844bbbd2
2018-10-02 23:22:09 +00:00
Sunny Goyal
6c3f44b663 Cancelling previous touch interaction when a new touch starts
Bug: 79220524
Change-Id: I7157dcdc7af92e1e5689da56c87961a82a0e6a05
2018-10-02 11:29:49 -07:00
TreeHugger Robot
d9f52ae7ba Merge "Disabling ShortcutsToHomeTest tests" into ub-launcher3-master 2018-10-02 17:10:29 +00:00
Vadim Tryshev
a2dc3c7211 Disabling ShortcutsToHomeTest tests
The bug below is for re-enabling disabled tests.

For now, we'd benefit more from enabling presubmits.

Bug: 117106893
Test: will see on TAP
Change-Id: I322deb9a64423587b329004f6cab4da1ff4f197d
2018-10-01 17:28:53 -07:00
TreeHugger Robot
899b87cc6b Merge "Disabling TestDragIcon tests" into ub-launcher3-master 2018-10-01 19:36:00 +00:00
Vadim Tryshev
c78b6fa465 Disabling TestDragIcon tests
The bug below is for re-enabling disabled tests.

The problem is not reproable locally, at least after several hours of
attempts.

For now, we'd benefit more for enabling presubmits.

Bug: 117106893
Test: will see on TAP
Change-Id: Idd3f80accaf444eef29c151efea542924fcc713b
2018-10-01 12:27:35 -07:00
Sunny Goyal
15dba75e55 Merge "Caching widget labels in icon cache to avoid lookup at startup" into ub-launcher3-master 2018-10-01 18:53:42 +00:00
Hyunyoung Song
be2307bbea Reduce falsing on swipe down for notification shade.
b/116879058

Change-Id: If3dde635cdff09faf27dbab2cd022b9d246c7c2b
2018-10-01 11:41:37 -07:00
Sunny Goyal
ac8154a23d Caching widget labels in icon cache to avoid lookup at startup
Change-Id: Ie026ee47905454bd70e774d422cd7fe142aec7e2
2018-09-28 16:36:33 -07:00
TreeHugger Robot
ff2d0d0a9e Merge "Defer removing the task view until the app has drawn" into ub-launcher3-master 2018-09-28 18:30:56 +00:00
Winson Chung
d123a3d789 Merge "Ensure that we don't additionally crop the launcher surface" into ub-launcher3-master 2018-09-27 23:16:55 +00:00
Vadim Tryshev
11c524365b Merge "Attempting to fix flakes in AllAppsIconToHomeTest" into ub-launcher3-master 2018-09-27 22:43:21 +00:00
Winson Chung
2660ca5d0e Ensure that we don't additionally crop the launcher surface
- Now that we are controlling the launcher app surface as well while
  swiping up into overview, skip applying the crop to any opening
  remote animation targets.

Bug: 70341013
Test: Swipe up, and ensure everything still works
Change-Id: I87b4021c0fc0e2997185d4d12f26b2e06999ff57
2018-09-27 18:26:52 +00:00
Vadim Tryshev
43524d0daa Attempting to fix flakes in AllAppsIconToHomeTest
Pressing an icon in AllApps doesn't show a context menu.

The flake doesn't repro locally, the suspects are:
1. Too short wait time
2. App being partially covered by navbar.

Hence the fixes.

This patch is temporary, and will be replaced with a permanent one when
this will be converted to TAPL.

Test: AllAppsIconToHomeTest
Change-Id: I0a03ff8827a5bc7940af3ec956d4b62330a16c66
2018-09-26 18:15:42 -07:00
TreeHugger Robot
08a915c0ce Merge "Add some gesture logging to track down quickscrub launch issue" into ub-launcher3-master 2018-09-26 23:44:44 +00:00
Winson Chung
665bc46d54 Add some gesture logging to track down quickscrub launch issue
- Keep rudimentary log of the last few gestures for dumping with the BR
- Also renaming updateInteractionType since we only use it to change
  to the quickscrub starting interaction type now, which is less
  confusing

Bug: 112783625

Change-Id: Ic024684caf2841cd7c09df9481163ea0c0ae03bd
2018-09-26 23:33:36 +00:00