Commit Graph

3843 Commits

Author SHA1 Message Date
Alex Chau
ed9e3a8701 Merge "Convert TaksView to Kotlin" into main 2024-05-16 14:00:02 +00:00
Alex Chau
9565667813 Convert TaksView to Kotlin
- PS1: Android Studio conversion (unformatted, cannot compile)
- PS2: Fix compilation issues and formatting
- PS3: First pass ready for review
- PS4: Minor changes (Remove Consumer, remove unnecessary null-checks)
- PS5: Removed check() around taskContainers, which is now lateinit and should always be initiailzed. Also ensure TaskView is bound before adding to parent.
- PS6: Move a bunch of getters to use .property style
- PS8: Refacoted RecentsView.applyLoadPlan bind logic, to avoid inflating TaksView, bind, add then immediatley remove
- PS10: Turned more functions to express functions; added an extension function
- PS11: Re-order functions, no code changes
- PS12: Reverted unit express function back to {} style

Bug: 339787593
Test: Manual
Flag: NONE
Change-Id: I75c06cf29718d8f258a4124997bcb054f5eb056f
2024-05-16 12:33:28 +01:00
Treehugger Robot
91ff82f9f7 Merge "Reformatting a comment." into main 2024-05-15 16:56:55 +00:00
Pat Manning
9775908d31 Merge "Promote all apps exit search keyboard test to presubmit." into main 2024-05-15 13:55:19 +00:00
Pat Manning
9d1c002e48 Promote all apps exit search keyboard test to presubmit.
Bug: 310242894
Test: TaplKeyboardFocusTest
Change-Id: I9a803bf275b3377f0e26ea8a71c1113546a00616
2024-05-14 13:54:04 +00:00
Shamali P
4f492626bd Clean-up unused categories (follow up cleans up strings)
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00
Brandon Dayauon
a4c33bfbaa Merge "Remove comment on workProfileTest" into main 2024-05-13 18:28:06 +00:00
Anushree Ganjam
c7b561cec1 Merge "Verify the PrivateProfileManager.isEnabled() is called atleast once." into main 2024-05-10 23:30:27 +00:00
Brandon Dayauon
d7dc05f851 Remove comment on workProfileTest
Work profile doesn't fail to create anymore. Can remove commented line

bug: 339884168
Test: presubmit
Flag: n/a
Change-Id: I1783bb35fac3dff1762af911b3cccddaec367b0c
2024-05-10 13:43:49 -07:00
Vadim Tryshev
840b44043f Merge "Cleaning up TestProtocol" into main 2024-05-10 20:37:02 +00:00
Anushree Ganjam
cf0aa11122 Verify the PrivateProfileManager.isEnabled() is called atleast once.
Bug: 339847768
Test: Manual
Flag: NA, Test
Change-Id: Ib99299c86a5accd0f98b39ae012a25e5991e26d5
2024-05-10 13:10:13 -07:00
Hyunyoung Song
2ee174e696 Merge "Run test in postsubmit for openPrivateSpaceSettings_triggerCorrectintent Bug:339109319 Test: not needed as disabling test in presubmit Flag: NA" into main 2024-05-10 19:28:13 +00:00
Vadim Tryshev
c63c0f7f47 Reformatting a comment.
"b/197780098" can be mistaken for an indication that the code is
temporary and requires cleanup.

This is not the case here, so reformatting the code so that the query
searching for cleanup candidates doesn't see it.

Bug: 197780098
Test: presubmit
Flag: N/A
Change-Id: I076267dc8878763632b52d3449cb20cac331ed04
2024-05-10 12:27:39 -07:00
Vadim Tryshev
575d15f231 Cleaning up TestProtocol
Bug: 262282528, 279059025, 322823209
Test: presubmit
Flag: N/A
Change-Id: I9af6e3f1fc49b2ebf0d99df8c4514de0bddee8f2
2024-05-10 11:03:24 -07:00
hyunyoungs
380014f131 Run test in postsubmit for openPrivateSpaceSettings_triggerCorrectintent
Bug:339109319
Test: not needed as disabling test in presubmit
Flag: NA

Change-Id: Idf106f30d9f4de949385545566345913dc551920
2024-05-09 23:42:08 -07:00
Winson Chung
36f38cb028 Merge "Add multi-instance state to item infos" into main 2024-05-10 04:16:38 +00:00
Holly Jiuyu Sun
9ae3b91c44 Merge "[PS] Add TAPL test for tile injection." into main 2024-05-09 22:38:01 +00:00
Winson Chung
94e8ad0731 Add multi-instance state to item infos
- Add legacy resource for supported multi-instance apps that
  matches the current SystemUI resource of the same name, and will
  be removed as apps migrate to the V manifest property to declare
  multi-instance support
- Load the multi-instance state from PackageManager when the db is
  first loaded or when packages are updated
- The multi-instance check is then used to determine if an app pair
  can be saved (ie. whether the action can be shown)

Bug: 323112914
Test: atest NexusLauncherTests

Change-Id: I565b4bee4ab5f7040910306b1fd60a4fc3bf9a1c
2024-05-09 18:43:38 +00:00
Holly Sun
897791a9e7 [PS] Add TAPL test for tile injection.
Bug: 330892261
Test: tapl
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile nextfood

Change-Id: I4cfaefa26a81a1026d62d4206d90881f323bffd3
2024-05-08 16:51:16 -07:00
Sukesh Ram
60cab37a23 Remove Logs for TaplOverviewIconTest#testOverviewActionsMenu
Remove logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: Ie19cdb10234fd50fc64f259b5dafe9881162e23d
2024-05-08 22:29:48 +00:00
Jeremy Sim
7d69804e4e Merge "Fix bug with double-relayout of Overview Actions View" into main 2024-05-08 20:24:21 +00:00
Federico Baron
b09442e16a Merge "Reduce steps for goHome()" into main 2024-05-08 17:58:38 +00:00
Sihua Ma
8128575f46 Merge "Move cell layout tests to deviceless tests" into main 2024-05-08 16:50:44 +00:00
fbaron
39e1d52c1b Reduce steps for goHome()
The goHome gesture is slow enough sometimes that it gets confused with an overview gesture. Reducing the step count should resolve this (verified in atest and haven't had it fail after changing this)

Flag: NONE
Bug: 336606166
Test: TaplTestsTrackpad#switchToOverview
Change-Id: I7ad388968205addb363cfd9ff4b7eefece170d1b
2024-05-07 20:48:30 -07:00
Sihua Ma
1593bb4af2 Move cell layout tests to deviceless tests
Excluding Tapl tests

Also adding Launcher3 test assets to Launcher3TestResources

Bug: 297950111
Flag: None
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Change-Id: I101fc7229252016ec7e5015ed5f6a5b4dbba894d
2024-05-08 00:52:43 +00:00
Holly Jiuyu Sun
8834a6c450 Merge "[PS] Update Install button string." into main 2024-05-07 21:35:02 +00:00
Anushree Ganjam
405817f5f8 Merge "Remove Verify getProfileUser calls since it's making test flaky." into main 2024-05-07 18:19:57 +00:00
Jeremy Sim
41eadd1a91 Fix bug with double-relayout of Overview Actions View
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).

This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.

Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-07 11:18:24 -07:00
Schneider Victor-tulias
c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Himanshu Gupta
8b0d1fb614 Merge "Adding Tapl test for locking/unlocking Private Space" into main 2024-05-07 09:57:59 +00:00
Holly Sun
64f36f3679 [PS] Update Install button string.
Screenshot: https://screenshot.googleplex.com/B6UrJt92QMMgSuG

Bug: 338357091
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button nextfood
Change-Id: Ia408ccfa20ea3c142bd22c326954d278fa571815
2024-05-06 20:35:01 -07:00
Sunny Goyal
499b9d067f Merge "Creating a custom runner for multivalent tests with Launcher specific features" into main 2024-05-06 20:55:00 +00:00
Treehugger Robot
bdbb43679c Merge "Add screenrecord and demote TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat" into main 2024-05-06 20:25:22 +00:00
Sunny Goyal
0f4bc92653 Creating a custom runner for multivalent tests with Launcher specific features
Bug: 338128923
Test: Verified by modifying a test
Flag: None
Change-Id: I1f04e28847ff9c0f7af3c0d952038ad24d03c17e
2024-05-06 12:10:21 -07:00
Himanshu Gupta
bf51b4882e Adding Tapl test for locking/unlocking Private Space
In this test:
1. Private Space is created.
2. Lock Button is clicked, locked view is verified.
3. Unlock Button is clicked, unlocked view is verified.
4. Private Space is removed.

Doc: go/private-space-tapl

Bug: 322882655
Test: TaplPrivateSpaceTest
Flag: NA
Change-Id: I1c399a96ea14a4464113576d31eed8db1caf1f2a
2024-05-06 20:03:23 +01:00
fbaron
5498d1e73e Add screenrecord and demote TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat
Flag: NONE
Test: TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat
Bug: 338869019
Change-Id: Ia2a3ce8808d63e2d6197cf5ef26b274817b7729a
2024-05-06 11:17:35 -07:00
Schneider Victor-tulias
8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Sunny Goyal
8dec848ad2 Merge "Adding a special runner to run simulate multiple devices when running robo tests" into main 2024-05-04 03:13:27 +00:00
Sunny Goyal
86145f49fb Adding a special runner to run simulate multiple devices when running robo tests
Bug: 338128923
Test: Verrified by modifying a test
Flag: None
Change-Id: I133842d68e437b971da39e2081c8859515463cd3
2024-05-03 15:54:40 -07:00
Federico Baron
77237f0501 Merge "Demote testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty to postsubmit" into main 2024-05-03 22:27:39 +00:00
Kevin Lim
13595ff1fe Merge "[Deviceless] Move BubbleTextViewTest to multivalentTests for deviceless testing." into main 2024-05-03 22:11:44 +00:00
fbaron
fba55b4383 Demote testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty to postsubmit
Flag: NONE
Test: TaplTwoPanelWorkspaceTest#testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Change-Id: I284803b7ebe5c094dc46178d34cca952726df745
2024-05-03 13:34:15 -07:00
Willie Koomson
a6f1bd55d4 Merge changes from topic "update-widget-font" into main
* changes:
  Fix resize frame corner radius for widgets added with button
  Hide add button text if cell is too narrow
  Update font settings to match POR
2024-05-02 23:07:40 +00:00
Kevin Lim
c338db0a67 [Deviceless] Move BubbleTextViewTest to multivalentTests for deviceless
testing.

Bug: b/297950111
Flag: NA
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: Passes in SysUI Studio
Change-Id: Ib94e704836e0e21b8f8f05d987bec3e8ba633afa
2024-05-02 22:53:41 +00:00
Anushree Ganjam
8b770b7166 Remove Verify getProfileUser calls since it's making test flaky.
There is enough asserts in the test to verify SystemShortcut is not null.

Bug: 333909497
Test: Manual
Flag: NA
Change-Id: I287a910f0f101ce8bc2c1e8678dbff0ced30a1dc
2024-05-02 15:17:46 -07:00
Treehugger Robot
0ff6c0a50d Merge "Debug TaplAddConfigWidgetTest test" into main 2024-05-02 22:16:42 +00:00
Sukesh Ram
05d48b3986 Debug TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I90b419aa300df53247fc07e00aabe575a33fb95f
2024-05-02 20:32:09 +00:00
Willie Koomson
61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Sebastián Franco
76f2828d52 Merge "Print the test cases and the solutions of ReorderAlgorithmUnitTest" into main 2024-05-02 19:38:45 +00:00
Treehugger Robot
f7ed35fc87 Merge "Locking the All Apps view before asserting PS components." into main 2024-05-02 19:02:42 +00:00