Commit Graph

76071 Commits

Author SHA1 Message Date
Liran Binyamin
013a4121be Merge "Suppress bubble animation when IME is visible" into main 2024-05-16 18:22:38 +00:00
Liran Binyamin
2cbb6dc5e4 Suppress bubble animation when IME is visible
When the IME is visible we now don't animate the bubble bar.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 340532785
Test: manual
Change-Id: I31fcf6a1fe81d907a9a02780ba42813111ac7e90
2024-05-16 10:15:19 -04:00
Alex Chau
ed9e3a8701 Merge "Convert TaksView to Kotlin" into main 2024-05-16 14:00:02 +00:00
Charlie Anderson
a8058669d5 Merge "Adding additional logging around updated shortcuts" into main 2024-05-16 13:52:02 +00:00
Liran Binyamin
606e9fde47 Merge "Animate bubble update notifications" into main 2024-05-16 13:13:57 +00:00
Eghosa Ewansiha-Vlachavas
c36afd3e26 Merge "[2/n] Unify DesktopModeStatus between Shell and Sysui" into main 2024-05-16 12:43:26 +00:00
Chris Göllner
4b6d2d4fa3 Merge "Shortcut Helper - Integrate with launcher 3 button nav translation" into main 2024-05-16 12:40:22 +00:00
Alex Chau
9565667813 Convert TaksView to Kotlin
- PS1: Android Studio conversion (unformatted, cannot compile)
- PS2: Fix compilation issues and formatting
- PS3: First pass ready for review
- PS4: Minor changes (Remove Consumer, remove unnecessary null-checks)
- PS5: Removed check() around taskContainers, which is now lateinit and should always be initiailzed. Also ensure TaskView is bound before adding to parent.
- PS6: Move a bunch of getters to use .property style
- PS8: Refacoted RecentsView.applyLoadPlan bind logic, to avoid inflating TaksView, bind, add then immediatley remove
- PS10: Turned more functions to express functions; added an extension function
- PS11: Re-order functions, no code changes
- PS12: Reverted unit express function back to {} style

Bug: 339787593
Test: Manual
Flag: NONE
Change-Id: I75c06cf29718d8f258a4124997bcb054f5eb056f
2024-05-16 12:33:28 +01:00
Sam Cackett
1ee568bf13 Merge "Add metric logging for fake landscape usage" into main 2024-05-16 10:28:26 +00:00
Helen Cheuk
bd10f8f08d Merge "Fix navigation buttons focus state" into main 2024-05-16 10:27:02 +00:00
Pragya Bajoria
571c9b288d Merge "Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]" into main 2024-05-16 09:50:17 +00:00
Charlie Anderson
1e96d751d2 Adding additional logging around updated shortcuts
Bug: 338218961
Test: locally
Flag: N/A
Change-Id: Ic72ec2686de20036928c1e98b52677bd82368282
2024-05-15 14:18:21 -04:00
Treehugger Robot
91ff82f9f7 Merge "Reformatting a comment." into main 2024-05-15 16:56:55 +00:00
Song Chun Fan
59fa915e9e Merge "[Archive] Update the content description for the archived app" into main 2024-05-15 16:18:18 +00:00
Liran Binyamin
03a2ab1e56 Animate bubble update notifications
Updates to existing bubbles now cause the bubble bar to animate in
similarly to new bubble notifications.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: Ib53316889170e0392f055242c6206882084b4a46
2024-05-15 12:13:12 -04:00
Pat Manning
9775908d31 Merge "Promote all apps exit search keyboard test to presubmit." into main 2024-05-15 13:55:19 +00:00
Sam Cackett
155e558b5b Merge "Fix crash resulting from missing entry in the taskViewIdArray" into main 2024-05-15 12:48:08 +00:00
helencheuk
7278073b57 Fix navigation buttons focus state
Two focus states in the same screen because taskbar and launcher are two processes. And we could not use keyboard to navigate to the nav button, agreed with UX that it should not have focus state. Make it not focusable to remove focus state as we are unable to focus on it by keyboard anyways. Tested that it would not affect TalkBack and SwitchAccess.

Only one focus in testing video: https://drive.google.com/file/d/18X3dtsvqfCMpdI7sBRxnaKwUCQzhHn8n/view?usp=sharing

Bug: 327386991
Test: Manual, navigate by keyboard in homepage and ensure there is no focus in the nav buttons
Flag: ACONFIG com.android.launcher3.enable_focus_outline Nextfood
Change-Id: I289ecb1784f8eb9b58bb36b28059ce4f367cf84e
2024-05-15 12:03:09 +00:00
samcackett
a24cb0e0fc Fix crash resulting from missing entry in the taskViewIdArray
Bug: 338057269
Test: Manual
Flag: NA
Change-Id: Ifa99fe87423ba75f52c43248c8fd730667803d1a
2024-05-15 11:32:48 +01:00
Pragya Bajoria
d9900e0d17 Remove obsolete desktop stashing logic from platform/packages/apps/Launcher3 [5/n]
Bug: 309481654
Change-Id: Id7b5db662d578eb625171055d30c37cd59e7d73c
Flag: EXEMPT refactor since it is removing obsolete code with no changes to current behavior.
2024-05-15 09:16:13 +00:00
samcackett
76331b6c17 Add metric logging for fake landscape usage
- Reuse existing TaskSwitcherContainer for Overview metric logging
- Log current orientation state for Overview when interacting with
gestures or via three button nav
- Log current orientation state on each phone rotation

Bug: 332870519
Test: Manual
Flag: NA
Change-Id: Ia10cf1acb809432175daab55151998f0d77362f9
2024-05-15 09:42:08 +01:00
Treehugger Robot
8146b6281a Merge "[omni] Handle touch slop for LPAA." into main 2024-05-15 04:52:13 +00:00
Jeremy Sim
2301e66b8f [automerger skipped] Fix bug with flickering actions bar am: ee9e655c5c -s ours
am skip reason: Merged-In I1093363780db5e0780deda2ff14b4f7361d63940 with SHA-1 6198cf6544 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27324185

Change-Id: I43e9e93f01d1b6597e3db2afc2be30ad9ca38db3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-15 01:39:50 +00:00
Jeremy Sim
33062cf016 [automerger skipped] Fix bug with double-relayout of Overview Actions View am: 740a52a27c -s ours
am skip reason: Merged-In I1b6be4637ac8c8d424e7633c437fca376ecdd757 with SHA-1 41eadd1a91 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27270389

Change-Id: Ibc9e03a41b10be695e6bfc5a308329d0e05fc943
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-15 01:39:45 +00:00
Holly Sun
49dc99abb0 [omni] Handle touch slop for LPAA.
Only handle touch slop when the taskbar is pinned (not isTransientTaskbar).

Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I4dc6dba473455b02208ef254c271a767bd7c8d42
2024-05-14 16:16:02 -07:00
Brandon Dayauon
e369bd6502 Merge changes I7c303e66,Idc03b9d3 into main
* changes:
  Add floatingMaskView when animating to mimic bottom container.
  Add private_space_floating_mask_view flag.
2024-05-14 23:15:40 +00:00
Anushree Ganjam
a77c28cd78 Merge "Add 0-state web data loader logs" into main 2024-05-14 23:13:03 +00:00
Holly Jiuyu Sun
5334c82136 Merge "[omni] Dynamically configure timeout for LPAA." into main 2024-05-14 21:45:03 +00:00
Jeremy Sim
ee9e655c5c Fix bug with flickering actions bar
This CL fixes a bug caused by ag/27148514. The bug occurred because:

1) The new way we use FloatProperty to set the alpha did not have a working `get()` function, so it just returned a junk value, set to `-1f` (I didn't think `get()` would ever be called meaningfully for this property).

2) However, during certain UI interactions, `RecentsView#updateActionsViewFocusedScroll()` is called many times in a loop, which repeatedly tries to re-start the fade-in animation for actions bar. Pre ag/27148514, even though the fade-in animation was called repeatedly, it would start and then immediately stop running because it realized that it was already set to the desired alpha. However now that we return a junk value for `get()`, it didn't know to skip and just ran the full fade-in animation again and again.

Fixed by refactoring FLOAT_SETTER (now ALPHA_PROPERTY) and creating a new data class, OverviewActionsAlphaProperty, that handles some of the intricacies of this increasingly complicated alpha system.

Fixes: 339545510
Test: Swipe to Overview, move tiles around, actions bar does not flicker.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1093363780db5e0780deda2ff14b4f7361d63940
Merged-In: I1093363780db5e0780deda2ff14b4f7361d63940
2024-05-14 21:10:10 +00:00
Jeremy Sim
740a52a27c Fix bug with double-relayout of Overview Actions View
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).

This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.

Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
Merged-In: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-14 21:09:56 +00:00
Stefan Andonian
d82bf659d3 Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev am: 531ede6f45
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27345160

Change-Id: I934d089a73eec96c68be1520af285c443a3461c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 20:25:08 +00:00
Stefan Andonian
531ede6f45 Merge "Use ItemInfo with correct position when adding to Workspace via Accessibility." into 24D1-dev 2024-05-14 20:09:21 +00:00
Holly Sun
8b38295fb2 [omni] Dynamically configure timeout for LPAA.
Video: https://drive.google.com/file/d/1N7qOIolcSYM9n3z40FO9O6S_IdLJav9l/view?usp=sharing

Bug: 335018496
Test: manual
Flag: legacy CUSTOM_LPAA_THRESHOLDS disabled
Change-Id: I5b0f7cc7815ecd85c51254ad34f2be521c44795c
2024-05-14 12:42:28 -07:00
Charlie Anderson
22f9e52689 [automerger skipped] Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev am: 9f03ea256d -s ours
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311

Change-Id: I5c3305484a46bc16840703323d82cf7a64feaca9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 19:37:28 +00:00
Charlie Anderson
8f6a97a8e1 [automerger skipped] Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon. am: 0e4ebc9ff2 -s ours
am skip reason: Merged-In I8aac643ec5ca3162cd62bf1051cc751800c626dd with SHA-1 d073ab0b39 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27303311

Change-Id: I8e5a45ccc7436c5fdf9ae8cd351827b81f57c760
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-14 19:37:24 +00:00
Charlie Anderson
9f03ea256d Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into 24D1-dev 2024-05-14 19:21:06 +00:00
Charlie Anderson
8aa2898a58 Merge "Fix blank pink loading icons by ensuring that cache entry won't downgrade existing icon." into main 2024-05-14 18:57:09 +00:00
Shamali Patwa
8a5eddb923 Merge changes from topic "update-strings" into main
* changes:
  Add comments on suggestion category related strings
  Clean-up unused categories (follow up cleans up strings)
2024-05-14 18:38:54 +00:00
Stefan Andonian
68686cdfec Use ItemInfo with correct position when adding to Workspace via Accessibility.
Bug: 332651703
Flag: NA
Test: Verified that the issue isn't reproducible with the fix. The issue
was 100% reproducible before.
Change-Id: I01207396e19b4f7d14d6a147e5e5fb98bae9ea99

Change-Id: I81aad9758ee33b8acc2d6a1242e54f2a47124374
(cherry picked from commit 86d3c8814b)
2024-05-14 17:11:55 +00:00
Liran Binyamin
0d8b2206af Merge "Deflake BubbleBarViewAnimatorTest" into main 2024-05-14 16:53:28 +00:00
Eghosa Ewansiha-Vlachavas
1c44de9cdb [2/n] Unify DesktopModeStatus between Shell and Sysui
Remove `DesktopModeStatus` from quickstep and instead access through
shell/shared to shell/shared.

Flag: None
Bug: 335401172
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest

Change-Id: I42f8b6e5f97f13fda22ed34bda4aa712ead53349
2024-05-14 15:26:15 +00:00
Pat Manning
9d1c002e48 Promote all apps exit search keyboard test to presubmit.
Bug: 310242894
Test: TaplKeyboardFocusTest
Change-Id: I9a803bf275b3377f0e26ea8a71c1113546a00616
2024-05-14 13:54:04 +00:00
Chris Göllner
fa09b12443 Merge "Convert SysUiState flags from int to long" into main 2024-05-14 10:44:40 +00:00
Luca Zuccarini
de2e793f53 Merge "Tune the window to icon and home scaling animation." into main 2024-05-14 09:12:24 +00:00
Orhan Uysal
3da07952c5 Merge "Disable drag from taskbar while in desktop." into main 2024-05-14 09:02:45 +00:00
Ben Lin
aca7b1cb19 Merge "Update SystemUiProxy signature." into main 2024-05-14 02:22:02 +00:00
Liran Binyamin
097261619b Deflake BubbleBarViewAnimatorTest
Fix an issue where we were verifying the status of the animator on the
test thread, which may have been modified on the main thread.

100x runs: https://android-build.corp.google.com/abtd/run/L42700030003806035/

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 339437686
Test: abtd link above
Change-Id: I7e0d67e6ca4b2f905ff80f317355d8d5ed0a912b
2024-05-14 00:22:00 +00:00
Shamali P
d07ed6b49b Add comments on suggestion category related strings
Also, deletes unused strings.

Bug: 339570620
Test: N/A
Flag: N/A
Change-Id: I3c53f9788c9734b6962b61d2a13b4445b91892ca
2024-05-13 23:23:34 +00:00
Shamali P
4f492626bd Clean-up unused categories (follow up cleans up strings)
Bug: N/A
Test: Unit tests
Flag: N/A
Change-Id: Id3bd76858d731b9e0eb977c094ebd3b19e1338ce
2024-05-13 23:13:56 +00:00
Bill Yi
ca277a0bf0 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-13 20:34:51 +00:00