Commit Graph

6683 Commits

Author SHA1 Message Date
Vinit Nayak
fd5e2ff933 Merge "Show all nav buttons when IME showing" into sc-v2-dev 2021-09-08 21:44:01 +00:00
TreeHugger Robot
b44b73ee3a Merge "Moving roboelectic tests to instrumentation tests" into sc-v2-dev 2021-09-08 18:40:37 +00:00
TreeHugger Robot
f87a7409b2 Merge "isable taskbar edu for tests" into sc-v2-dev 2021-09-08 18:36:08 +00:00
Tony Wickham
f8a064f347 isable taskbar edu for tests
Test: clear TASKBAR_EDU_SEEN pref, ensure edu shows during normal usage
Bug: 199100151
Change-Id: I8e59cfa22ccba77c588a0902d46021dd72c6e77d
2021-09-08 08:10:16 -07:00
Tony Wickham
238bf4f30d Merge "Update taskbar color in onConfigurationChanged()" into sc-v2-dev 2021-09-08 15:08:36 +00:00
Sunny Goyal
3e9a29c4d6 Moving roboelectic tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I197bc47181308bb0b79f3815a892b733abbcd1fd
2021-09-08 10:23:30 -04:00
Tony Wickham
abaa481bfb Update taskbar color in onConfigurationChanged()
Test: Change wallpaper, ensure taskbar updates to match
Fixes: 199045474
Change-Id: I7ec8bbec8e31d2d03c09bf487ab55c86b95917e7
2021-09-07 15:39:53 -07:00
Vinit Nayak
7f4f499515 Show all nav buttons when IME showing
* Keep home and recents button, and rotate back button
to be down when IME shows in 3 button task bar.
* Move IME switcher to left side of taskbar for 3 button,
keep on right side for gesture nav.

Bug: 191399224
Test: Tested RTL and LTR, gesture + button nav
with and w/o IME.

Change-Id: I7959d26986e546596e2436b8b5eb7668f44b55cf
2021-09-07 14:43:17 -07:00
Alex Chau
a8da6905a9 Always reset focusedTask to -1 on reset
- Keep old focused task causes old focused task to be restored after applyLoadPlan: http://cs/android/packages/apps/Launcher3/quickstep/src/com/android/quickstep/views/RecentsView.java?l=1365
- This caused the nth task to be focused rather than the first task
- The fix is to reset focusedTask in reset when exiting overview, focused task will be set properly next time through applyLoadPlan when overview is relaunched

Fix: 199150523
Fix: 198420226
Test: TaplTestsNexus.testOverviewActions
Test: Quick switch > launch app > swipe home > swipe up to overview > snap to focused task
Test: split screen > swipe home > swipe up to overview > snap to focused task
Change-Id: I06399626ed3ee033345bd67296d79d59a98a507f
2021-09-07 18:42:39 +01:00
TreeHugger Robot
13e121e35a Merge "Snap to task from other grid row if dismissing non-snapped focused task and not enough tasks remain in current grid row to snap to." into sc-v2-dev 2021-09-06 16:16:00 +00:00
Pat Manning
017dbbe715 Snap to task from other grid row if dismissing non-snapped focused task
and not enough tasks remain in current grid row to snap to.

Test: manual
Fix: 196200215
Change-Id: I611ffc457769d57ac0d13657fafa73a4a741f877
2021-09-06 14:53:00 +00:00
Alex Chau
61cb7c0310 Hide overview actions when focused task is not snapped
- Overview actions is still click able when focused task is slightly off snap position and the alpha is between 0 and 1
- This is not desired and we should simply hide the actions when focused task is not snapped

Bug: 199040817
Test: manual non grid and non-grid
Change-Id: Ifda800fc4169a05c8128e7b3802d2ab4a5af4ae8
2021-09-06 13:05:35 +01:00
TreeHugger Robot
1e86bd0ec6 Merge "Select remote apps based on stagePosition instead of hardcoded values" into sc-v2-dev 2021-09-04 04:32:10 +00:00
Vinit Nayak
58dd901bc1 Select remote apps based on stagePosition instead of hardcoded values
* LauncherSplitScreenListener returns taskIds guaranteeing index 0
to be leftTop task and index 1 to be rightBottom. Use that
instead of assuming remote target index 0 will be leftTop and
index 1 is right bottom as provided

Bug: 181704764

Change-Id: I2bc358ff3c2f2d127b81e10824e2c13f3ad718df
2021-09-04 04:31:56 +00:00
Tony Wickham
79ff586c10 Call onUserUnlocked() before adding callbacks am: 5a36b919b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15756866

Change-Id: I03e5411032285015489f4b8bceb8b023e9c12909
2021-09-04 03:13:40 +00:00
Winson Chung
507e976690 Merge "Provide internal IME insets" into sc-v2-dev 2021-09-03 23:46:16 +00:00
TreeHugger Robot
eb5f5f7807 Merge "Disable FolderNameEditText on Taskbar" into sc-v2-dev 2021-09-03 23:00:33 +00:00
Tracy Zhou
2ccfa02fde Merge "Stash/unstash the task bar based on states" into sc-v2-dev 2021-09-03 22:49:07 +00:00
Tony Wickham
5a36b919b5 Call onUserUnlocked() before adding callbacks
This gives us a chance to initialize things in onUserUnlocked() if we're already unlocked, before doing any other logic that might use those variables.

Test: None (unable to reproduce)
Fixes: 184773649
Change-Id: I72ed91ae6202ec816f9bdceb4d9fd03b9a002816
2021-09-03 22:07:18 +00:00
Tony Wickham
d345751849 Disable FolderNameEditText on Taskbar
Test: Can rename folder on home screen, but tapping folder name in taskbar does nothing
Bug: 180051157
Change-Id: Ief19805683f754995baf24d7f41f3979841d5bd3
2021-09-03 12:50:15 -07:00
Tracy Zhou
527b39cd28 Stash/unstash the task bar based on states
Bug: 193938970
Test: go to any app, stash/unstash, and make sure the states are preserved
Change-Id: I3adf826407e90275687ecea8302abf7a004f1df7
2021-09-03 12:43:04 -07:00
Hongwei Wang
bfec974f59 Do not trigger PiP on tapping on TaskView
Regression from ag/15158868, we should not send onUserLeaveHint on
tapping on the app icon in Recents / Overview.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/fr0fdecPEned7rMjgdWhCQ
Bug: 198682451
Test: manual, tap on app icon in Recents, see video
Change-Id: I66888a75eec30d7e8ba7e09059399381516812ac
2021-09-03 11:10:05 -07:00
Winson Chung
543c226ffa Provide internal IME insets
Bug: 197727397
Test: Collapse taskbar, open IME
Change-Id: Ia251be1d5892a58b062f241bdafc5dbfc223e4c3
2021-09-03 10:22:56 -07:00
TreeHugger Robot
983adea20f Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-09-03 16:51:05 +00:00
TreeHugger Robot
fb0eaf2bee Merge "Animate scrolling grid into place when there is a gap between last tasks and clear all." into sc-v2-dev 2021-09-03 12:23:06 +00:00
Nick Chameyev
6b53e3101e Merge "Add taskbar icons unfold animation" into sc-v2-dev 2021-09-03 11:19:22 +00:00
Pat Manning
96dad8b039 Animate scrolling grid into place when there is a gap between last tasks
and clear all.

- Stagger animation starts
- Adds a grid translation property to TaskView for animating these
translations.

Also fixes an issue where the gap between clear all and focused task is
greater than spacing between grid tasks and clear all.

Test: manual
Fix: 188793333
Change-Id: Ib2ba8b1b84dc63c4ba186bd0b9b4962d3c66ce5a
2021-09-03 11:33:53 +01:00
Nick Chameyev
4dd4159fdc Add taskbar icons unfold animation
Adds 'move from center' animation for taskbar icons when
unfolding foldable devices.

Moves unfold transition progress provider from quickstep
launcher activity to TouchInteractionService to widen
the scope when this provider is available to cover
both launcher activity and taskbar.

Launcher activity and taskbar get their own instances
of unfold transition progress provider using
ScopedUnfoldTransitionProgressProvider wrapper.
This wrapper allows to get transition progress provider
that emits events only when clients are ready to handle them.

Bug: 193794563
Test: manual
Change-Id: I27581bd4e145a74f526bf60f2a545e56ded322f9
2021-09-03 10:25:52 +01:00
Shawn Lin
fe2aed97c5 Merge "[DO NOT MERGE] Update QuickStepContract.getWindowCornerRadius API" into sc-v2-dev 2021-09-03 03:57:09 +00:00
Vinit Nayak
461a6cffd9 Merge "Quickswitch with staged split" into sc-v2-dev 2021-09-02 22:46:08 +00:00
Vinit Nayak
57e261ceef Quickswitch with staged split
* UI polish/animations needed.
* One known bug (b/198310766), temp work around is to
swipe up to home.

Bug: 181704764
Test:
* Open apps in staged split and quickswitch
between GroupedTaskView and fullscreen apps.
* QS to fullscreen app and then go into overview
and re-launch split screen tasks
* QS to fullscreen app, wait 5 seconds,
swipe into overview, no GroupedTaskView shown

Change-Id: I0ce10a944d86be5c927eeaaef922559a40f39923
2021-09-02 11:44:36 -07:00
Samuel Fufa
d74703d63d Merge "Remove HotseatEduActivity from AOSP" into sc-v2-dev 2021-09-02 18:18:19 +00:00
Vinit Nayak
fb624f8501 Merge "Hide overview and app icon split option when appropriate" into sc-v2-dev 2021-09-02 17:42:53 +00:00
Bill Yi
e75e9e6507 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1c7791015bc0bbfcd512864e9a4fbbbef58999f8
2021-09-02 04:36:47 +00:00
y
0115d73890 Remove HotseatEduActivity from AOSP
Bug: 191882450
Test: manual
Change-Id: Ic60ef6fec6c3d8162cb3d11b0ed3c9f89f6b5704
2021-09-01 16:59:47 -07:00
TreeHugger Robot
7b313224e9 Merge "Only call setCurrentPage in applyLoadPlan if mCurrentPage is outdated" into sc-v2-dev 2021-09-01 21:25:09 +00:00
Alex Chau
06c7d0cb56 Only call setCurrentPage in applyLoadPlan if mCurrentPage is outdated
- Apply the same for all 3 setCurrentPage cases as they can all causes page jumping

Bug: 197493120
Test: manual
Change-Id: I5f7013ce3ce4d6fe84c67123618c3bebeeffc43a
2021-09-01 18:43:40 +01:00
Vadim Tryshev
fc88784f8d Merge "Revert "Band-aid for getHomeActivities returning null"" into sc-v2-dev 2021-09-01 17:30:55 +00:00
Alex Chau
f0b8ef9dfd Only restore previous currentPage in applyLoadPlan if mCurrentPage is outdated
Bug: 197493120
Test: manual
Change-Id: I196088c848f9fa8ec23f6c803226d674ba3e088b
2021-09-01 15:10:37 +01:00
Vinit Nayak
0b73d1014f Hide overview and app icon split option when appropriate
Don't show app menu icon split option or overview
action split option when current taskView is already in
split or there are not at least 2 tasks with which to
invoke split

Fixes: 197245395
Test: Tested with small and large screen,
dismissing tasks in overview, with and without
GroupedTaskView as main running task

Change-Id: I90cc3c39e4d94662cb87314a210d45d145b6e026
2021-08-31 20:23:36 -07:00
Evan Rosky
8a0e91b330 Merge "Fix NPE that happens occasionally on start-up" into sc-v2-dev 2021-09-01 01:29:06 +00:00
vadimt
5cca2265b6 Revert "Band-aid for getHomeActivities returning null"
This reverts commit 42a7d1af83.
REASON FOR REVERT: the underlying framework bug is fixed

Test: presubmit
Bug: 187080582

Change-Id: If580a35196ba9a9c5e3a5da642a2ea3aa3d9048e
2021-08-31 18:04:59 -07:00
TreeHugger Robot
ff705eabe6 Merge "Fix some taskbar stashing issues" into sc-v2-dev 2021-08-31 22:38:01 +00:00
Evan Rosky
c12b7355b1 Fix NPE that happens occasionally on start-up
Was not checking if topActivity was null.

Bug: 189935087
Test: boot phone thousands of times.
Change-Id: I3c779be5f09d82d52a3df9478c801a1963e0a5c2
2021-08-31 15:10:47 -07:00
Tony Wickham
ff2171d232 Merge "Fix NPEs when swiping up from keyguard" into sc-v2-dev 2021-08-31 21:59:54 +00:00
Tony Wickham
42b0395fee Fix some taskbar stashing issues
- Don't allow long press to stash between taskbar icons
- Ensure taskbar_icon_touch_size is respected; previously it wasn't, because BubbleTextView@shouldIgnoreTouchDown() was returning true in the padding region. For taskbar, we want the whole icon size to be touchable.
- Cancel long press when passing touch slop to avoid swipe down being detected as long press

Test: long press on taskbar background, both between icons and not; swipe down on taskbar
Fixes: 198305464
Change-Id: I36f1d792e91da9a3bf57a2bef1e974b299c4e25c
2021-08-31 14:06:09 -07:00
Tony Wickham
b922452bf5 Fix NPEs when swiping up from keyguard
- In onRecentsAnimationCanceled
- In applyLoadPlan

Test: Lock screen from home screen, swipe up from bottom of keyguard
Fixes: 197622171
Change-Id: Ibb6b292cb99ad2f08e402c1a6e311b819c5f7d73
2021-08-31 10:02:59 -07:00
TreeHugger Robot
667bda8448 Merge "Revert "Revert "Migrating all model tests to Instrumentation tests""" into sc-v2-dev 2021-08-31 10:52:02 +00:00
Sunny Goyal
777d49062f Revert "Revert "Migrating all model tests to Instrumentation tests""
This reverts commit 7a4a30d86d.

Test: Presubmit
Reason for revert: Fixing original bug

Bug: 196825541
Change-Id: Id4b1eb24a89564d264266d305aebea52917dfcd9
2021-08-31 10:51:52 +00:00
TreeHugger Robot
438f796626 Merge "Launch multiple tasks at once" into sc-v2-dev 2021-08-30 21:18:28 +00:00