Commit Graph

4629 Commits

Author SHA1 Message Date
Sunny Goyal
fd4264b2b5 Merge "Jailing the saved instance state of all the dynamically generated views" into ub-launcher3-burnaby-polish 2015-10-05 18:26:19 +00:00
Sunny Goyal
d1a0e8b5c8 Jailing the saved instance state of all the dynamically generated views
Using itemId instead of generating a new id for each item. This is because
if the process gets killed, View.generateId will get reset but we will still
receive the generated item id map in onRestoreInstance. This will cause
conflicts with newly generated item ids.

We wrap all the generated homescreen views inside a single sparse array. This
ensures that we do not cause any conflict with dynamically generated views in
other parts of the UI.

Bug: 16840760
Change-Id: I6fe69c2e1dd463402f51222715fae31b9d4dd240
2015-10-05 18:25:49 +00:00
Winson
6febe1f361 Fixing regression when removing last item from folder.
- The regression caused the folder and all its contents to be removed
  before the new item could be moved to the place of the folder.  In
  addition, in this case, the LauncherModel would get out of sync with 
  the db because we move the last item to the workspace, but don’t 
  remove it from the contents, so deleting the folder would remove the
  item’s mapping in sBgItemIdMap.

Bug: 24620815
Change-Id: I17137f28b0f1617a890488c7a9c5b8a9e8df0e91
2015-10-02 18:26:48 -07:00
Sunny Goyal
95bae9a43d am c84e6e19: Disabling widget debug
* commit 'c84e6e19363c590bbfbac17e9ab7cc61a04d552a':
  Disabling widget debug
2015-10-02 20:23:05 +00:00
Sunny Goyal
c84e6e1936 Disabling widget debug
Change-Id: I876a904358ce455c97a7a25a34c66af5e9316469
2015-10-02 12:48:37 -07:00
Winson
44818e07af Fixing regression in removing widgets via accessibility.
- Regression was introduced in ag/765323, but not visible in normal 
  drag and drop because the view is already removed from the parent.
  However, when accessibility is enabled, it was only removing it from
  the db, but not from the parents.

Change-Id: I37483d0cd6306d270441b11e6f05247d58b88521
2015-10-02 18:44:18 +00:00
Sunny Goyal
935eedad97 Merge "Do not reinflate/rebind widgets if we are going the rebind the full workspace anyway." into ub-launcher3-burnaby-polish 2015-10-02 17:40:35 +00:00
Winson
34ef93ccd6 am 058c21db: Ensure accessibility delegate is set on all apps icons.
* commit '058c21db49f4f058b7d84c8de55d3c649918ab70':
  Ensure accessibility delegate is set on all apps icons.
2015-10-02 17:21:59 +00:00
Winson
058c21db49 Ensure accessibility delegate is set on all apps icons.
Bug: 24605237
Change-Id: I801e2aca1732c021b06d996d907f368f97277cf9
2015-10-02 17:16:15 +00:00
Sunny Goyal
a682a5d8c7 Make sure that the dimensions are not negative when drawing pending widget
Bug: 24585203
Change-Id: I3d328d0e1fe81d2704bb5b9d4b340a367bfb9249
2015-10-01 19:36:59 -07:00
Sunny Goyal
6bec75fe70 Do not reinflate/rebind widgets if we are going the rebind the full
workspace anyway.

Bug: 23820213
Bug: 24582781
Change-Id: I2cb4927916fed64a69100beb41ee14653ea1d70a
2015-10-01 18:51:50 -07:00
Winson Chung
1845049c66 Merge "Replace Long.compare() with implementation." into ub-launcher3-burnaby-polish 2015-10-01 22:53:15 +00:00
Winson
12fb9fc3c3 Replace Long.compare() with implementation.
- Long.compare() was added in API level 19.

Change-Id: Ic7020c941403c10daa6feacdc737c6a82676ada0
2015-10-01 15:34:08 -07:00
Winson Chung
0e32c14ada Merge "Fixing regression in search bar animation." into ub-launcher3-burnaby-polish 2015-10-01 19:33:58 +00:00
Winson
a2dc7c351d Fixing regression in search bar animation.
- The other case should fall through to the animation even 
  when there is no search bar overlay.

Change-Id: Id91bea78b56934cc1c3379777068adc100f11dba
2015-10-01 12:19:23 -07:00
Sunny Goyal
eaaed098a6 Merge "Adding progress information for preload icons in content description" into ub-launcher3-burnaby-polish 2015-10-01 18:36:29 +00:00
Sunny Goyal
9ccacb544b Merge "Fixing 'Item removed' announced twice when using accessible DnD" into ub-launcher3-burnaby-polish 2015-10-01 18:25:28 +00:00
Sunny Goyal
c469aadd92 Adding progress information for preload icons in content description
Bug: 24086091
Change-Id: Id8fb024973f4affd998627d30077e2764b07edc4
2015-10-01 11:24:59 -07:00
Winson Chung
2c4d2ccd90 Merge "Don’t create dummy app info." into ub-launcher3-burnaby-polish 2015-09-30 23:00:57 +00:00
Winson
5fbe0746dd Don’t create dummy app info.
Bug: 24539514
Change-Id: I5d14a4d9993e072451f8e7ed9a4cea219ae5d246
2015-09-30 15:44:05 -07:00
Winson Chung
850de64c0d Merge "Fixing other missing cases of truncated sorts." into ub-launcher3-burnaby-polish 2015-09-30 00:06:55 +00:00
Winson
46a06da01c Fixing other missing cases of truncated sorts.
Bug: 24505761
Change-Id: I9b9358e8b134f0c4aac32ac536d9c8a1f0629957
2015-09-29 16:58:02 -07:00
Tony Wickham
58ecbe40f6 Flipped widths of Nexus 4 and Nexus 5 in InvariantDeviceProfile.
Without this change, Nexus 4 uses the Nexus 5 device profile and
vice versa. But because the profiles have exactly the same values,
it didn't matter that they were flopped.

Change-Id: I3fd788e040feb8de5bb5f5e336acbd4ac995dc0f
2015-09-29 15:19:32 -07:00
Winson
c088049113 Highlighting sectioned apps on fast-scroll.
- This CL fixes an old assumption we had about the height
  of rows in AllApps, and ensures that we account for the
  difference in height between the predictive icons and the
  normal icons.
- In addition, we refactor FastBitmapDrawable to have multiple
  states, which it manages in drawing itself, including the
  press state and fast scroll focus states.  And we also refactor
  some of the fast scroll logic in the all apps recycler view
  out to its own class.

Change-Id: I1988159b2767df733bbbfc7dc601859cde6c9943
2015-09-28 17:32:19 -07:00
Sunny Goyal
5189454083 am e1899e44: Merge "Adding size check when generating holographic outline" into ub-launcher3-burnaby
* commit 'e1899e44368f7602afc5b87a75102e7ff551982c':
  Adding size check when generating holographic outline
2015-09-28 19:21:58 +00:00
Sunny Goyal
e1899e4436 Merge "Adding size check when generating holographic outline" into ub-launcher3-burnaby 2015-09-28 19:17:25 +00:00
Sunny Goyal
81284287a7 am de9590be: Adding null check when creating icon bitmap
* commit 'de9590be4ca2779ae0f7f64a48ac8b90472484f8':
  Adding null check when creating icon bitmap
2015-09-28 18:46:18 +00:00
Sunny Goyal
bf1a98f596 Adding size check when generating holographic outline
Bug: 24426913
Change-Id: Ic7c9c767ea60ae4b25e064127105d94104233596
2015-09-28 11:34:23 -07:00
Sunny Goyal
de9590be4c Adding null check when creating icon bitmap
Bug: 24299267
Change-Id: I596e4a8dbd4e45cffff75e6cf7bbbf7ec45c8ec9
2015-09-27 19:05:04 +00:00
Winson
f768d93468 Fixing regression in L3 with search bar transition.
Change-Id: Ia4155a653012c5d23df21167233fe766e5479347
2015-09-25 23:21:00 +00:00
Winson
17e2d49547 Use Long.compare() instead of truncating values for comparison.
Bug: 24116808
2015-09-25 23:20:13 +00:00
Sunny Goyal
d21301e674 Cancelling the stateannouncer when entering button drop target
Change-Id: Ia10298e1d4862fc5f46894fa6d934207d6e9c117
2015-09-25 12:17:08 -07:00
Sunny Goyal
7aaa841c35 Fixing 'Item removed' announced twice when using accessible DnD
Change-Id: I2d8781155619d22a41c3f363be7909d411c62fa9
2015-09-25 12:06:13 -07:00
Sunny Goyal
e78e3d734b Accessibility fixes
1) Use a different content description for temporary new page
2) Use different accessibility description for add widget toast
3) Announce when an item is deleted
4) Announce when hovering over a drop target
5) Announce state during drag-n-drop and widget resize (similar to seekbar)

Bug: 23573321, 24057944
Change-Id: Icabb317625e70c78e11c0b4f99b9339172d93594
2015-09-25 10:22:47 -07:00
Winson
2949fb5b16 Fixing talk-back folder icon removal regression.
Change-Id: I0b7fff645828d5198500973f1c9ea74f406a1a43
2015-09-24 18:21:16 +00:00
Sunny Goyal
f27cb0e6b1 resolved conflicts for 8ac727b2 to ub-launcher3-burnaby-polish
Change-Id: I34e679bae7faae3c7ca725263fe6cc7c5611e63a
2015-09-23 16:12:02 -07:00
Winson Chung
5a7a1ce0a7 Merge "Fixing workspace state issue with option menu." into ub-launcher3-burnaby-polish 2015-09-23 22:51:27 +00:00
Sunny Goyal
8ac727b2c6 Using custom threadpool executor instead of the one defined in AsyncTask
Change-Id: I8fe95d932c5de14c74f0576bfc3d1f641d12b448
2015-09-23 15:39:14 -07:00
Sunny Goyal
4c67dce43f am ce0a8946: Merge "Preventing nullpointer exception when cloning rawList" into ub-launcher3-burnaby
* commit 'ce0a89461a7e72917c052844f8e9339d2047b1d0':
  Preventing nullpointer exception when cloning rawList
2015-09-23 18:40:52 +00:00
Sunny Goyal
ce0a89461a Merge "Preventing nullpointer exception when cloning rawList" into ub-launcher3-burnaby 2015-09-23 18:34:56 +00:00
Sunny Goyal
e4d16e41e9 am 7ca99110: Using an executor with increased queue size for loading previews
* commit '7ca991104e3ac2e99fcde5599416f82b4d66aad1':
  Using an executor with increased queue size for loading previews
2015-09-23 18:03:02 +00:00
Sunny Goyal
7ca991104e Using an executor with increased queue size for loading previews
An async task can be in the queue even if it has been cancelled. It
is removed only after it gets executed once. So the executor can get
blocked if there are some tasks which are running, and we keep posting
and cancelling preview load tasks.

Bug: 24306650
Change-Id: I836c8d53258542cc6f31952dff84323cc057437c
2015-09-23 10:48:50 -07:00
Winson
4616347537 Fixing workspace state issue with option menu.
- Hitting a ctrl key combo will actually call onPrepareOptionsMenu(), which
  will change the state of the workspace incorrectly.  Instead, listen for
  the menu button, and only allow the user to enter overview mode if they
  are currently not dragging or in an overlay state (like all apps or
  widgets).
- Also making the overview buttons focusable so that they are focused when
  you go into overview mode.

Bug: 22483367
Change-Id: Ie6e9febd8a5a4e7ad25d745639d42d1c7b9801b4
2015-09-22 17:33:39 -07:00
Sunny Goyal
6a706b1dd7 Preventing nullpointer exception when cloning rawList
Bug: 24299525
Change-Id: I92018a3da7d75afc2c6997302f8e0492eb78e62f
2015-09-22 16:56:55 -07:00
Adam Cohen
9ae42fff6f am b3fff9d9: Merge "Cleanup some incorrect / noisey calls to CustomContentCallbacks#onShow / onHide" into ub-launcher3-burnaby
* commit 'b3fff9d98a3e3c886d4efa912d7ad6753dd7ec9c':
  Cleanup some incorrect / noisey calls to CustomContentCallbacks#onShow / onHide
2015-09-21 17:40:50 +00:00
Adam Cohen
b3fff9d98a Merge "Cleanup some incorrect / noisey calls to CustomContentCallbacks#onShow / onHide" into ub-launcher3-burnaby 2015-09-21 17:34:05 +00:00
Adam Cohen
ed10c013bd am 36bde9a9: Merge "Add fake CustomContent screen for testing Launcher interface" into ub-launcher3-burnaby
* commit '36bde9a9e50412329237081e595d732b7da93e0b':
  Add fake CustomContent screen for testing Launcher interface
2015-09-19 00:35:57 +00:00
Adam Cohen
36bde9a9e5 Merge "Add fake CustomContent screen for testing Launcher interface" into ub-launcher3-burnaby 2015-09-19 00:32:53 +00:00
Adam Cohen
4b66bf3cff Cleanup some incorrect / noisey calls to CustomContentCallbacks#onShow / onHide
-> In some instances, onResume would incorrectly call onShow
-> When pressing Home from CustomContent, we'd get a sequence of onHide,
   onShow, and then onHide due to some deferred actions in onNewIntent.
   Got rid of the onShow.

issue 17629011

Change-Id: I9b4f2ef682f5a7060e68210866fa05452076e428
2015-09-18 17:32:00 -07:00
Tony Wickham
20bd2c10c1 am 6ed058cb: Wallpaper preview parallax matches the actual wallpaper\'s.
* commit '6ed058cb6bfbb5756721e0d7f4a80a1c08ee665c':
  Wallpaper preview parallax matches the actual wallpaper's.
2015-09-18 20:41:14 +00:00