Commit Graph

4989 Commits

Author SHA1 Message Date
TreeHugger Robot
fa39cdcbac Merge "Refactor app open code." 2021-01-11 23:23:15 +00:00
TreeHugger Robot
e8ea45182a Merge "Add BROADCAST_CLOSE_SYSTEM_DIALOGS to recents package" 2021-01-11 22:16:22 +00:00
TreeHugger Robot
c2d0989c82 Merge "Disabling fling gesture for assistant over deferred region" 2021-01-11 21:36:52 +00:00
Jon Miranda
f725e955cb Refactor app open code.
Move all the logic that calculate the app open float properties
to a separate class.

This is in preparation for the new app launch properties.

Change-Id: I1a008b2ea1379cbf667c5ad3ad58ece04bd88185
2021-01-11 15:58:58 -05:00
Bernardo Rufino
e0484de39a Add BROADCAST_CLOSE_SYSTEM_DIALOGS to recents package
It uses AM.closeSystemDialogs() and should have the permission. I had
created the protection level in ag/13090697 but forgot to actually
request the permission.

Bug: 177228919
Bug: 159105552
Test: atest CloseSystemDialogsTest
Test: atest android.server.wm.WindowMetricsActivityTests#testMetricsMatchesLayoutOnActivityOnCreate
Change-Id: I661dac17f2160ed36adb1a193e739c200169a37d
2021-01-11 19:25:24 +00:00
Jason Chang
cfbfea9172 Merge "Fix triggering One-handed mode introduces gesture conflict issues (2/n)" 2021-01-10 03:38:37 +00:00
Jason Chang
be5af2de6b Fix triggering One-handed mode introduces gesture conflict issues
(2/n)

Define a new larger gesture height instead of replacing
existing navigation_bar_gesture_height with RRO.

Bug: 159580663

Test: manual
Change-Id: Icdd70b28d9b2629171fb60a0c9d603f6a69f076a
2021-01-07 15:20:10 +08:00
Schneider Victor-tulias
b76e4dbc51 Merge "Temporarily disable visibility-gated hotseat and prediction row updates." 2021-01-06 15:20:27 +00:00
TreeHugger Robot
18a1aa543b Merge "Removing shelf from 2-button gesture mode" 2021-01-05 21:15:59 +00:00
Sunny Goyal
5c953ed47d Disabling fling gesture for assistant over deferred region
Fixing missing trigger when using fling gesture

Bug: 130186141
Bug: 175839420
Test: Verified fling does not work over keyboard dismiss button
Change-Id: Id15320122cf9183c591416962634561a1ddc6fa0
2021-01-05 12:54:54 -08:00
TreeHugger Robot
6511fd5b40 Merge "Using default timeout for 3-button QS" 2021-01-05 20:06:43 +00:00
Sunny Goyal
9b1e77377b Removing shelf from 2-button gesture mode
Test: Manual
Bug: 175137718
Change-Id: Ifb64b4dcac53252aefa8ee0bd6434f90f1d868b7
2021-01-05 19:07:21 +00:00
TreeHugger Robot
5fa687dd98 Merge "Add transition when swiping from fullscreen to enter PiP" 2021-01-01 00:51:15 +00:00
TreeHugger Robot
618ba37e04 Merge "Add additional fake task views on overview gesture completion." 2020-12-23 01:34:00 +00:00
Schneider Victor-tulias
20bbaa3390 Add additional fake task views on overview gesture completion.
Added motion pause listening to animate an additional fake task view on overview gestures in the sandbox.

Test: manual

Demo: https://drive.google.com/file/d/1EpewbIAxiMUEz0Fqdfbok5q9xpWS6NWz/view?usp=sharing
Change-Id: Ifd0aed0a2bbb3204ae32c833b8466952679700e3
2020-12-22 16:10:09 -08:00
Hongwei Wang
0f6b6cc7a2 Add transition when swiping from fullscreen to enter PiP
There are some artifacts actually come from test app implementation
- when in landscape fullscreen, sourceRectHint would include the black
  background on both sides
- when settled in PiP, app does the transition which causes the final
  glitch
Would address these later in the test app itself

Video: http://rcll/aaaaaabFQoRHlzixHdtY/cOco1yoMXwFzSifFqQET9U
Video: http://rcll/aaaaaabFQoRHlzixHdtY/f3IWG09DRO9aUNnzqSdPLU
Bug: 171802909
Test: see video
Change-Id: I783e51e78277b1179a7e8de50050b7c9e1a6de17
2020-12-17 15:56:01 -08:00
Tracy Zhou
5e394d9a9a Merge "Place recents above app only after the initial touch down" 2020-12-17 03:17:01 +00:00
Vadim Tryshev
bcc2b5ff34 Merge "Instrumenting app-to-pip CUJ." 2020-12-17 02:04:28 +00:00
TreeHugger Robot
ad8d9454d4 Merge "Fix some task view fling calculations" 2020-12-17 00:34:47 +00:00
vadimt
f20a330a5c Instrumenting app-to-pip CUJ.
Bug: 169221267
Test: manual, presubmit
Change-Id: I7fed51af63665ba9b0596f7f01bf3182643fb0a3
2020-12-16 15:39:05 -08:00
Tracy Zhou
bc3ec9fb66 Place recents above app only after the initial touch down
The problem is that currently upon touch down we place recents above app, before recents view is visible, so instead home screen is revealed.

Here is the breakdown:
Initial touch down -> app on top
First move event -> updateFinalShift -> recents on top
End target = home -> app on top

Fixes: 175423704
Test: manual
Change-Id: I81a4fea34c983ac2e6921f4e3515ef3193201069
2020-12-16 15:22:08 -08:00
Tony Wickham
b956a03067 Fix some task view fling calculations
- Map to progress 1 instead of dividing by 0 if expectedDuration == 0
- Map to starting progress one frame ahead based on velocity
- Change direction of velocity so it's in the same direction as the
  task progress (0 is down and 1 is up).

Change-Id: I5ac3f8a0d6c616bd303ac1a902242964bb33d3c7
2020-12-16 09:31:26 -08:00
TreeHugger Robot
2df0ef38a0 Merge "Synchronizing model data access" 2020-12-16 09:59:19 +00:00
TreeHugger Robot
ff720daffd Merge "Ignoring crash if the 3p icon surface is no longer valid" 2020-12-16 09:58:39 +00:00
Schneider Victor-tulias
5aad9d87d7 Temporarily disable visibility-gated hotseat and prediction row updates.
Pending a resolution in b/174174514, disabling the visibility-gating of hotseat and all app prediction row updates. Updates will be allowed regardless of visibility.

Test: manual
Change-Id: I10e4dae9aad9af7b799fdad3b231c734e383b493
2020-12-15 16:00:59 -05:00
Tony Wickham
79ec120b3f Merge "Fix TaskViewTouchController crash in seascape" 2020-12-15 18:45:15 +00:00
vadimt
dad74879cc Using default timeout for 3-button QS
It's 5 sec, and it works better both
for test runs under stress and for
users in the field that invoke the gesture
slowly.

Test: presubmit
Bug: 169221288
Change-Id: If1d04b63e3d490d7865b9141fc3be34a21693c39
2020-12-14 15:42:44 -08:00
Tracy Zhou
d0269cd0da Merge "Match the live tile cut out to the correct task view position in landscape mode" 2020-12-14 23:34:39 +00:00
Tracy Zhou
51d9ab7a22 Match the live tile cut out to the correct task view position in landscape mode
Bug: 171838067
Test: test live tile in landscape mode

Change-Id: I12c375305e19917a53e30d9e40dc709f828ad4a6
2020-12-14 13:58:37 -08:00
Sunny Goyal
fee1b25fee Fixing PendingArgs not cleared when going home
Bug: 174781600
Test: manual
Change-Id: I2f192b0f60d843b49b290fa70b76f562fca81e36
2020-12-14 12:30:47 -08:00
TreeHugger Robot
e1358149fc Merge "Removing unused tracing" 2020-12-14 18:21:37 +00:00
Ice Chang
feb22118bf Merge "Add swipes left method in Background.java" 2020-12-12 16:33:16 +00:00
vadimt
c610f26404 Removing unused tracing
Test: presubmit
Bug: 139891609
Change-Id: I30b432d329d6606b3d955409c167bddbacce8a37
2020-12-11 19:43:49 -08:00
Tony Wickham
e3386502cf Fix TaskViewTouchController crash in seascape
Previously, we were using scroll direction POSITIVE as a catch all
to mean "up" but in seascape, we actually want NEGATIVE. Added
getUpDirection() to capture that. Tried to clarify the code a bit
by putting all the methods used solely by TaskViewTouchController
together with documentation. It's still pretty confusing and feels
redundant, but couldn't think of an obvious way to simplify.

Test: Swipe up and down on a task in all permutations of:
- 3 button mode
- Gesture navigation
- Portrait
- Landscape
- Seascape
- LTR
- RTL
- Home rotation allowed
- Home rotation disallowed

Fixes: 174009771
Fixes: 173567204
Change-Id: Id0f8d6f4365d888eb46182d8544d18206795dfb8
2020-12-11 17:30:41 -08:00
TreeHugger Robot
3b83609977 Merge "Not using blocking call to populate task title for logging" 2020-12-11 23:38:44 +00:00
TreeHugger Robot
04ed82860e Merge "Jank: taking screenshot in helper thread for quick switch" 2020-12-11 22:44:42 +00:00
TreeHugger Robot
ef9f1e0af5 Merge "Adding tracing for app-to-overview" 2020-12-11 19:25:06 +00:00
Sunny Goyal
e98f980a98 Ignoring crash if the 3p icon surface is no longer valid
Test: Verified on device locally
Change-Id: I5684731c3a66d5690f83878f3c4726d859349bd4
2020-12-10 16:59:28 -08:00
Sunny Goyal
cfcefb0c47 Synchronizing model data access
Test: Presubmit
Bug: 173328873
Change-Id: Ifc1724e17ebfa2ee5f21bb3f272986b8a14fdbc1
2020-12-10 16:24:19 -08:00
vadimt
4b77e83a42 Not using blocking call to populate task title for logging
For now, passing null title

Bug: 175048504, 173072373
Test: presubmit
Change-Id: Ia2ed5433be9490d71786c98b8244f1c76e4e3088
2020-12-10 23:47:12 +00:00
vadimt
5794fa1aba Jank: taking screenshot in helper thread for quick switch
This operation is prone to lock contention.

Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db
2020-12-10 12:48:05 -08:00
TreeHugger Robot
cbf8fe08da Merge "Moving removing task after QS to a background thread." 2020-12-10 20:34:15 +00:00
Sunny Goyal
189fa681b1 Merge "DO NOT MERGE Revert "Handle uiMode changes"" 2020-12-09 22:37:05 +00:00
vadimt
3b55aab715 Adding tracing for app-to-overview
It will help finding jank in the quick switch
scenario.

Also removing tracing for cases when it's done
by the jank monitor.

Test: manual
Bug: 174892351
Change-Id: I16fc784ddb52203dba54eab2700b5a04a10088ff
2020-12-09 12:32:23 -08:00
Tracy Zhou
2268a7cb27 Merge "Render animation for launching settings in live tile mode" 2020-12-09 18:16:35 +00:00
Tracy Zhou
f985f13ec1 Render animation for launching settings in live tile mode
Right now the animation is pretty basic. Will need to fine tune it.

Fixes: 172626326
Test: manual
Change-Id: Ibc64f6a988e1c7ad3f32732e1db2f0f29489e3f9
2020-12-09 00:18:00 -08:00
Winson Chung
ff6d94dd92 DO NOT MERGE Revert "Handle uiMode changes"
Bug: 171707437
Test: Repro steps on bug

This reverts commit 0ad7b172e6.

Change-Id: If30cbb6c155e879dc8307a0a4a06dfb548b389a1
(cherry picked from commit 4b4341d3a7)
2020-12-09 07:33:40 +00:00
Schneider Victor-tulias
e5764199de Merge "Add the ability to control the mock app thumbnail and app icon to TutorialControllers." 2020-12-07 17:43:04 +00:00
Schneider Victor-tulias
7f66dde4de Add the ability to control the mock app thumbnail and app icon to TutorialControllers.
Giving the gesture nav tutorial sandbox environment a more accurate look and feel requires the ability to inject mock drawables. The choice of drawables should go to TutorialControllers.

Bug: 175019879

Change-Id: Ie5b03b3fa07b017c0596a58dedf65d3e866a0727
2020-12-07 16:27:37 +00:00
vadimt
1e71ba5b98 Moving removing task after QS to a background thread.
Blocking binder call was creating jank.

Test: manual, presubmit
Bug: 173467481, 173072373
Change-Id: Ib19d2a97ed8cf3e9763008b042ef48d89532cb58
2020-12-04 14:18:52 -08:00