Commit Graph

17917 Commits

Author SHA1 Message Date
Vadim Tryshev
f912287c8a Merge "Waiting for Recents activity to stop after starting apps" into main 2024-01-08 20:13:39 +00:00
Tony Wickham
a3daee40f3 Merge "Update kotlin formatting for TaskbarInsetsController" into main 2024-01-08 19:10:24 +00:00
Brandon Dayauon
4f673d2517 Merge "Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW" into main 2024-01-08 18:00:05 +00:00
Sam Cackett
ad51bc1df2 Merge "Reset AppChip chevron when closed" into main 2024-01-08 14:40:05 +00:00
samcackett
191b13e8d0 Reset AppChip chevron when closed
This CL fixes two issues:
1. It resets the chevron AnimatedVectorDrawable back to the start when
the TaskMenuView has finished closing. This stops it being re-opened in
any previously animated state and starts fresh each time.
2. The original position of the TaskMenuView is put back in its original
position when finished closing. If animations are disabled, the
TaskMenuView is never put back in its original position.

Video after this commit is applied: http://shortn/_gfy0pN6sKX

Fixes: 316998167
Fixes: 316996167
Test: Manual
  Open several apps. Open Overview. Expand a TaskMenuView. Swipe up to
  home. Open Overview again. TaskMenuView chevron should be facing down.
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD

Change-Id: I7d9e60b5c0a56cf809e9870573c3b51af5ded8c3
2024-01-08 13:44:51 +00:00
Riddle Hsu
d4d4eaaf31 Merge "Perform TaskView animation when reopening the current task" into main 2024-01-08 13:25:13 +00:00
Jagrut Desai
7a9686b49d Merge "Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-01-06 19:11:01 +00:00
Brandon Dayauon
3dd0f12cad Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW
Verified that there should be no jumping going on in the top app row between A-Z list and Toast.

bug: 312781931
Test: manual -video:
https://drive.google.com/file/d/11GX-5mVr5BoZY29IyX5FvrIA_yT57MOJ/view?usp=sharing
Flag: None

Change-Id: I5c35c04eb500f52780b0b77c542e0a861346a3fd
2024-01-05 17:09:23 -08:00
Jagrut Desai
4f56608aec Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Test: Presubmit
Bug: 317798731
Flag: NONE
Change-Id: I05d430a4d8a306b672e89bb3033dfb41bbb9d000
2024-01-05 17:00:53 -08:00
Tony Wickham
79f5536524 Update kotlin formatting for TaskbarInsetsController
Flag: none
Test: none
Bug: none
Change-Id: I2f83ce8bbbe89ac3fcee6f6b3c1100f387ddf76e
2024-01-06 00:42:08 +00:00
Vadim Tryshev
edd7c4cc98 Waiting for Recents activity to stop after starting apps
Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ifbc23289d040ad31d40434e9d81529c7800532e9
2024-01-05 16:19:56 -08:00
Jagrut Desai
21f3d770a0 Merge "Taskbar Pinning Animation Improvements" into main 2024-01-05 23:21:57 +00:00
Tony Wickham
8424eed91a Merge "Fix onIsStashedChanged() not called in 3 button mode" into main 2024-01-05 22:18:18 +00:00
Liran Binyamin
fdc5c72aa1 Merge "Add a test for stashed bubble bar" into main 2024-01-05 21:19:19 +00:00
Jagrut Desai
a3d3c06967 Taskbar Pinning Animation Improvements
Test: Manual
Bug: 312178646
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I708127be8301a61994168f780474c75be726815d
2024-01-05 12:12:12 -08:00
Tony Wickham
438e6c90af Fix onIsStashedChanged() not called in 3 button mode
Calling this ensures we update touchableRegion accordingly.

Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.

Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
  In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
2024-01-05 19:19:57 +00:00
Jagrut Desai
ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Liran Binyamin
40c1b93aee Add a test for stashed bubble bar
This change introduces a new test protocol event for unstashing the bubble bar.

It's not possible to do this via a UI event because the stashed handle is only visible when an app is in the foreground, but in that state none of the elements in TaskbarDragLayer are visible to accessbility.

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Change-Id: I4581bf95b07691429966ecbd573232047f820b69
2024-01-05 08:49:27 -05:00
Sergey Pinkevich
0f8d28024e Merge "Java crash on RecentsView.isTaskViewVisible method" into main 2024-01-05 11:34:55 +00:00
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Jagrut Desai
71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Johannes Gallmann
852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Tony Wickham
97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jordan Silva
873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Riddle Hsu
51ceb99715 Perform TaskView animation when reopening the current task
When using gesture navigation to switch task, if the next started
task moves the previous task in live tile to top, the appeared
task will be the previous animating task rather than the task
started by recents.

Previously, none of condition handles the case, which causes a
splash screen task view to stay on screen and the transition keeps
in running state.

By running the side task launch animation, it can indicate that
there is an additional task switch visually, and the recents
transition can be finished when the animation is finished.

Bug: 317160303
Test: Activity A's onResume always starts activity B (declares
      different taskAffinity) with FLAG_ACTIVITY_NEW_TASK.
      Use gesture to swipe from B to A. B should be visible
      instead of staying at recents with a splash screen view.

Change-Id: Id1a441561ac9958f71efe2440e4fb467bedc6947
2024-01-04 21:28:05 +08:00
Jordan Silva
9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Vinit Nayak
e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Tony Wickham
c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak
e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00
Tracy Zhou
e1c3332532 Merge "Correct contextual button width, height and touch area" into main 2024-01-03 21:11:24 +00:00
Vadim Tryshev
6741d1affc Ignoring testQuickSwitchToPreviousAppForTablet
It fails on some targets

Test: presubmit
Flag: N/A
Bug: 318544733
Change-Id: Ia6e34f81942b3e911b637cd66eae4362e633eee5
2024-01-03 12:58:57 -08:00
Sergey Pinkevich
c7dcb95b4c Java crash on RecentsView.isTaskViewVisible method
Bug: 316567614
Flag: NONE
Test: manual

Change-Id: I8e7a47a06a94ce0d9eb5921020cb19097873e8c4
2024-01-03 19:20:46 +00:00
Helen Cheuk
df20ea0ed4 Merge "Update BubbleTextView height to match parent so focus outline drawn could be fully displayed" into main 2024-01-03 18:38:29 +00:00
Vadim Tryshev
943843a239 Merge "Re-promoting some tests to postsubmit" into main 2024-01-03 18:25:59 +00:00
Sunny Goyal
05dc6db762 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17 am: cb1fc471bb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: Ib1b0eae5c1664f202312109da2391a250607108b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:59:03 +00:00
Sunny Goyal
cb1fc471bb Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I5a9c74659439b1dd04e124f9191796bc348d97f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:25:19 +00:00
Jagrut Desai
39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Johannes Gallmann
436b9939e3 Hide app icon during predictive back to home
Bug: 311337169
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: Manual, i.e. testing predictive back to home on device and verifying visually that app icon behaves correctly
Change-Id: I91491d91d004d81f4abc67c361c8824eba8dfdcd
2024-01-03 16:45:16 +01:00
Sergey Pinkevich
638ee17821 Select task is broken on display large size
The update of the focus task overlay should be at last, cause otherwise the first time the "Select" button doesn't work - the text is not highlighted.

Also, we need to update pivot of the selected task only if there is a grid overview enabled. Otherwise the bug is still reproducible on Felix.

Bug: 305125147
Flag: NONE
Test: Manual (both on Tangor and Felix in Portrait/Landscape mode with small/medium/large Display size)
Change-Id: Id928cee0949b9124aeb27cc8210a53993e72ba19
2024-01-03 14:44:12 +00:00
helencheuk
2174b0ad2e Update BubbleTextView height to match parent so focus outline drawn could be fully displayed
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq

Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
2024-01-03 12:14:25 +00:00
Tracy Zhou
650000f68f Correct contextual button width, height and touch area
Side note: this is unrelated to NearestTouchFrame

Bug: 313371759
Bug: 230395757
Test: https://screenshot.googleplex.com/6mF4ZPSob6z55Nh
Change-Id: I7e5217bef4b2cfb6d14d62d107e75b1267ffd2f4
2024-01-02 23:05:53 -08:00
Riddle Hsu
78611ea4ca Merge "Reduce redundant IPC when switching app by navigation bar" into main 2024-01-03 06:30:44 +00:00
Tracy Zhou
9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Jagrut Desai
25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Tracy Zhou
5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Vadim Tryshev
5cc6b2ba52 Re-promoting some tests to postsubmit
Excluding TaplDragTest#testDragToFolder, which is failing on some devices

Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
2024-01-02 13:14:08 -08:00
Hyunyoung Song
0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00