Commit Graph

83004 Commits

Author SHA1 Message Date
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Pierre Barbier de Reuille
b8c5350c07 Use the developer-option flag for pin to taskbar
Test: Manual
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Bug: 375648361
Change-Id: I2c26ae6a5f42fd01860d7534b86ff5ca11e7f7fc
2025-05-22 03:29:34 -07:00
Lucas Dupin
66923a912c Merge "Add recents position callback to SystemUiProxy" into main 2025-05-21 23:11:59 -07:00
Treehugger Robot
51291ec848 Merge "Create the RemoteTargetGluer based on the GroupedTaskInfo" into main 2025-05-21 22:57:56 -07:00
Treehugger Robot
405ed245ea Merge "Adding bugfix flag for remove shortcut in long press menu" into main 2025-05-21 22:35:20 -07:00
Andy Wickham
85ac41bc7f Only ignore All Apps left/right insets on tablets.
This was previously the case, but I think I mistakenly updated this
to include phones with the all_apps_sheet_for_handheld flag at some
point. However, there was also some broken logic with the panel bounds
on phones. panel.getLeft() would be 0 because that's relative to the
container, so we need to do getLeft() + panel.getLeft().

Landscape (camera on left): https://hsv.googleplex.com/5035787895701504
Seascape (camera on right): https://hsv.googleplex.com/6210562886205440
Portrait: https://hsv.googleplex.com/6563945312681984
Tablet: https://hsv.googleplex.com/6704696994562048

Bug: 419235232
Test: See HSVs above compared to before images in the bug
Flag: com.android.launcher3.all_apps_sheet_for_handheld
Change-Id: Id8b6f3367ee94ef22cb917e00518e843553b42d8
2025-05-21 19:23:53 -07:00
Kevin Lim
a735b96a40 Merge "[Multiline] If a multiline searchbox can scroll up, don't scroll all apps container" into main 2025-05-21 19:18:53 -07:00
Treehugger Robot
091890adbc Merge "Support workspace cells with two-line labels" into main 2025-05-21 18:25:15 -07:00
Treehugger Robot
0e955ac2b0 Merge "Restrict launcher bubble shortcut option." into main 2025-05-21 17:48:53 -07:00
Tony Wickham
e9ef7ad43c Migrate some logs to OverviewCommandHelperProtoLogProxy
This will allow us to see the logs in Winscope, including frame by
frame to make debugging easier.

Also added a log for Launcher#onNewIntent to help with Home button.

Test: EXEMPT log only update
Bug: 417248321
Bug: 384423890
Flag: NONE log only update
Change-Id: Ib24aeb78e44ff29542eb25411c51f77dba299a2e
2025-05-21 15:32:03 -07:00
Kevin Lim
dddf56f5b1 [Multiline] If a multiline searchbox can scroll up, don't scroll all apps container
Bug: b/390540638
Flag: EXEMPT bug fix
Test: Before: http://recall/clips/2c3e5774-c0ba-4a2d-b878-db3a6efec247
Test: After: http://recall/clips/3c98c52b-7f94-4dd4-a6f6-560403d4a426
Change-Id: I9dad962740ec31edad6213c41e2dec04deeedf0b
2025-05-21 15:28:01 -07:00
Andy Wickham
492a170aaf Remove RenderEffect on blur targets when no blur is desired.
This change replaces 0 blur radius RenderEffect with null RenderEffect
when no blur is needed. This is because even a 0 radius RenderEffect
forces the targets to be rendered on a separate layer, which clips to
the view bounds (overriding clipChildren="false") and likely creates
a hit to performance.

Demo: https://drive.google.com/file/d/1fuFP_yaqU2KSd28aUhpuopQg6KlMKv_w/view?usp=sharing&resourcekey=0-GWMy5kKhYVo-5u69XTzihQ

Fix: 413784556
Bug: 413359333
Bug: 416815515
Test: enable all apps blur, enter spring loaded from All Apps and home
Flag: com.android.launcher3.all_apps_blur
Change-Id: I85b0ef6c8556866821679f2f02adb4938c6431d1
2025-05-21 15:27:44 -07:00
Annie Lin
61867f4b3c Restrict launcher bubble shortcut option.
To respect current multi-window mode policies for non-resizeable activities, we should hide this option on small screens.

The bubble option will continue to show on large screens (unfolded Foldables and Tablets) but not on small screens (folded Foldables and Phones) for non-resizeable apps.

Bug: 411558731
Test: Manual - Enable the flag and try to bubble a shortcut via the longpress menu on launcher --> Does not show bubble option for non-resizeable apps on small screen but shows otherwise.
Flag: com.android.wm.shell.enable_create_any_bubble
Change-Id: I2546b1002c92e309b8f7f439480e2c87eaf951c4
2025-05-21 15:10:46 -07:00
Toni Barzic
3bd1f20e3b Implement spec to configure all apps height
Adds AllAppsSpec support, that can configure all apps height so the
container top aligns with the top of a row in the workspace grid.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: Ia5c939c7d3b6fed29a9c2f47233348a5e55b570f
2025-05-21 22:04:33 +00:00
Toni Barzic
83b8cc19ca Support workspace cells with two-line labels
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
*   enable two-line labels in `BubbleTextViews` for workspace (including
    folder children) items
*   Update cell dimension calculation to inform cell vertical padding

When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.

Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.

Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual

Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
2025-05-21 22:04:33 +00:00
Federico Baron
d664725fec Adding bugfix flag for remove shortcut in long press menu
Bug: 419289205
Flag: EXEMPT adding flag CL
Test: EXEMPT adding flag CL
Change-Id: I8b9ad99a7b207b55967b6d04f21973fac2bee6c2
2025-05-21 14:57:19 -07:00
Jordan Silva
3d348a0d27 Add focus border animation to IconAppChipView
Fix: 366177160
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB and navigate through the task menu.
Test: Manual using Mouse. Hover over the Chip and the Task Menu.
Change-Id: I785ad8723e5255186d744a20992ac0cd0968b380
2025-05-21 14:20:49 -07:00
Lucas Dupin
02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
minch
ded5807543 Create the RemoteTargetGluer based on the GroupedTaskInfo
Determine whether a `RemoteTargetGluer` for desktop should be
created based on GroupedTaskInfo instead of
`RecentsAnimationTargets.hasDesktopTasks`. The latter one is
inaccurate to assume that a desk may only have FREEFORM tasks.

Bug: 400866688
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: I6f35f41204790ada59317e0b4bd0a8965c9718eb
2025-05-21 13:42:08 -07:00
Xiaoqian (Daisy) Dai
7e21181997 desktop-exploded-view: truncate the task header app title if it overflows
A long app title can cause the close button to be covered.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413387821
Change-Id: Id66cabb271ac6f4772969335232e3e9638828571
2025-05-21 20:13:53 +00:00
Schneider Victor-Tulias
124b010ea9 Add recents animation start timeout handling to TaskAnimationManager
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.

Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
2025-05-21 15:55:44 -04:00
Sergey Pinkevich
d0fccf8773 Convert DesktopVisibilityControllerTest to multivalent
Bug: 397902030
Flag: NONE test fix, not actual code editing
Test: atest NexusLauncherTests:DesktopVisibilityControllerTest

Change-Id: Ie6ae4abb2a894d4f7403e77cf797cdce924fd9e3
2025-05-21 18:50:43 +00:00
Toni Barzic
d8526a858f Update hotseat qsb and icons visibility with alpha
Updates multi value alpha tracker for qsb and icons in hotseat to update
the view visibility when alpha is set to fully transparent. This
prevents fully transparent views from getting keyboard focus, or
interactions where tapping on seemingly empty parts of the home screen
launching search.

Test: On desktop device, where hotseat is hidden due to presence of
      tasbkar, verify that invisible hotseat icons, or qsb do not get
      focused during keyboard navigation. Verify that tapping just above
      taskbar in left bottom area of workspace is no-op.
Bug: 404868614
Flag: EXEMPT bugfix
Change-Id: Ibccd3536209c7966498863fcb3f006b721443c3c
2025-05-21 18:05:55 +00:00
Simon (Qiong) Sun
00063bcf2f Support multiple tasks per split screen via SplitRemoteTargetHandles
It enables support for assigning SplitRemoteTargetHandles to multiple tasks within a split-screen.

The changes include:

- Retrieving the list of split-screen tasks directly from `SplitBounds`.
- Iterating through the task list and setting the remoteTargetHandle for each individual task.
- General code refactoring to set the remoteTargetHandle.

Bug: 346295292
Bug: 360782849
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: manual test.
Video: Before: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/fnHVbaVwMWfvrOaez5eO6L
Video: After: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/dzv6tZMlAYG1bBBtYdsWxF

Change-Id: I1e8c8316947b0d4fd72c9cf36dff8ecd99d2f170
2025-05-21 17:51:09 +00:00
Schneider Victor-Tulias
6d532fe59d Fix broken state when tapping nav handle from running app.
When tapping the nav handle from running app, OtherActivityInputConsumer will start the recents window through TaskAnimationManager. The recents window would then typically be closed through the StateManager, however since the state isn't changing, then RecentsWindowManger never actually gets any signal to close the recents window. Added a new callback to fix this flow.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit tests. tapped nev handle from a runnign app
Change-Id: If1fe7de195a9a8a98c72629c7904d469a5768d7f
2025-05-21 10:35:11 -07:00
Kevin Lim
5db0796793 Merge "[Multiline] Clean-up multiline flag on Launcher3" into main 2025-05-21 10:23:51 -07:00
Jordan Silva
e14014cc88 Merge "Fix task icons sometimes not appearing in recents view" into main 2025-05-21 10:09:00 -07:00
Treehugger Robot
57de0ebf21 Merge "Make sure RecentsWindowManager is created for TaskbarUIController" into main 2025-05-21 09:56:04 -07:00
Liran Binyamin
328bf4ab1c Fix bar state when overflow is selected initially
Fix the state of the bubble bar when the initial state received
from sysui has the overflow selected, which can happen after
unfolding. This ensures that the arrow position is set correctly,
and that when tapping on the overflow in this state the bar
collapses.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - have floating bubble and expand
       - selecte overflow
       - unfold
       - observe overflow is expanded and bubble bar arrow position
         is correct
       - tap on the overflow bubble
       - observe bar collapses
Change-Id: I4a3d217ce951c7c7f2d17da89b0cd5905faf0eff
2025-05-21 12:49:02 -04:00
Helen Cheuk
444161df77 Merge "[Action Corner] Make home action corner irreversible" into main 2025-05-21 09:13:31 -07:00
Treehugger Robot
10b72a252d Merge "Revert "Temporarily revert allowing recents view to reapply load state"" into main 2025-05-21 07:15:41 -07:00
Alex Chau
f29a8dd4e2 Make sure RecentsWindowManager is created for TaskbarUIController
Bug: 418965555
Flag: EXEMPT bugfix
Test: local + presubmit

Change-Id: Ib45df9c0f04534cd88a1b2ae1ff4ab49f8999dff
2025-05-21 14:13:20 +00:00
Treehugger Robot
2cc2843f03 Merge "Dismiss task on default display if it is moved to external" into main 2025-05-21 06:45:24 -07:00
helen cheuk
9598e4c78c [Action Corner] Make home action corner irreversible
The go home action for action corner should be irreversible for now.
When home action corner is triggered at homepage, it should just stay at homepage and would not go back to previous task.
Add flag for the reversible behavior for non-desktop mode home action corner. It is to be completed with dekstop mode in later release.

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.launcher3.enable_reversible_home_action_corner
Change-Id: Ib36581d0d3d81d4a7ff8f8d6265d8d5d5f5872fd
2025-05-21 14:26:01 +01:00
Jordan Silva
ea25b86ce1 Fix task icons sometimes not appearing in recents view
- Call setTaskIconVisible(true) at the end of the gesture regardless of `setCurrentTask`.
- Resets the icon visibility when RecentsView resets to make sure the bad state won't get stuck.

Fix: 332744660
Flag: EXEMPT bug fix
Test: Manual test on device
Change-Id: Ie8b86efa4892298f0071ad304a8c77698c306d6a
2025-05-21 04:57:22 -07:00
Kevin Lim
f7ce5a06fe [Multiline] Clean-up multiline flag on Launcher3
Bug: b/409605328
Flag: EXEMPT removing multiline_search_bar
Test: Unit tests all passing
Change-Id: Id377b7c99af0d0265102888b8021c0809f53a6b9
2025-05-20 18:52:14 -07:00
Sebastián Franco
e010d8f654 Merge "launcher: Remove allow rotation setting from indexable settings" into main 2025-05-20 17:04:02 -07:00
Treehugger Robot
737a52ce07 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-05-20 16:11:42 -07:00
Treehugger Robot
432a419d4f Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-05-20 16:11:42 -07:00
Pierre Barbier de Reuille
4ad6e804ec Merge "Create a flag to enable the desktop menu entry on Overview when ready" into main 2025-05-20 15:28:02 -07:00
Treehugger Robot
27312fa26d Merge "Prevent adding duplicate TaskAnimationManager launcher destroyed callbacks" into main 2025-05-20 15:22:24 -07:00
Treehugger Robot
ab9921a5d5 Merge "Only update All Apps scrim (panel) when blur state changes." into main 2025-05-20 14:17:39 -07:00
Will Osborn
33f9e2c356 Dismiss task on default display if it is moved to external
https://photos.app.goo.gl/AdvkEkTvQdP2dXA26

Bug: 417451469
Flag: EXEMPT bugfix
Test: Local + presubmit
Change-Id: I2955aaee2b59bffb072330e5ebbfcf6d3d83dc3c
2025-05-20 20:34:15 +00:00
Saumya Prakash
4d4fd45f02 Merge "Modify Gesture nav edu to new UX specs" into main 2025-05-20 11:58:06 -07:00
Sam Cackett
10276b2d76 Merge "Add logs for split screen RemoteAnimationTargets" into main 2025-05-20 09:03:59 -07:00
Pierre Barbier de Reuille
933c5324d0 Create a flag to enable the desktop menu entry on Overview when ready
Bug: 418822736
Flag: com.android.launcher3.enable_desktop_menu_on_secondary_display_bugfix
Test: atest DesktopSystemShortcutTest
Change-Id: I55b6493165f5307d3c247bb604441b093d5e8e9d
2025-05-20 15:55:41 +01:00
Alex Chau
cb05c49ff0 Revert "Temporarily revert allowing recents view to reapply load state"
This reverts commit cea90d45a6.

Reason for revert: b/417535264 reland

Bug: 417535264
Change-Id: I8611ec59c9574021a0d925d35ee6523faebd6d18
2025-05-20 07:39:07 -07:00
Shamali Patwa
63469a8150 Merge changes from topic "picker-preview" into main
* changes:
  Add test for widget previews using remote views.
  Add preview for widgets using layout / remote views.
2025-05-20 07:37:36 -07:00
Cosmin Băieș
cba51f4023 Merge "Remove canImeRenderGesturalNavButtons and sysprop" into main 2025-05-20 03:41:58 -07:00
Treehugger Robot
9977ef7c2a Merge "Update Empty State to support Blur background" into main 2025-05-20 02:17:40 -07:00