Commit Graph

4763 Commits

Author SHA1 Message Date
Anushree Ganjam
de0d4498c8 Ignore the tests temporarily.
This is to measure the impact of OOM issue
https://googleplex-android-review.git.corp.google.com/q/topic:%22launcher-clearMock-RunListener%22

The tests will be  re-enabled on Jan 22. Currently NexusLauncherTests are
100% failing due to b/385147987 and b/388258969 which blocks us from
measuring the OOM issue fix impact.

Bug: 385147987
Bug: 388258969
Bug: 378520480
Test: Manual
Flag: TEST_ONLY
Change-Id: I1d804c7fcba3b48943025408a530981ff808d511
2025-01-16 16:26:51 -08:00
Sihua Ma
8fc266d063 Move tests to multivalent
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test migration
Change-Id: Idd9e52f281d955e87f6db638ebfd8218a4dcb77f
2025-01-17 00:04:27 +00:00
Anushree Ganjam
25717836e1 Merge "Use RunListener to Clear inline mocks at the end of each test class." into main 2025-01-16 13:28:04 -08:00
Anushree Ganjam
0a29e73ffb Use RunListener to Clear inline mocks at the end of each test class.
Inline mocks are leaking activity contexts and accumulation of these activity contexts led to OOM that resulted in test failure.

See https://github.com/mockito/mockito/issues/1614 for details on mockito caused memory leaks

This change works for both soong and gradle builds.

Bug: 378520480
Test: atest and android studio builds
Flag: TEST_ONLY
Change-Id: I4a50993621ea416a02a41dd2f9c330d1599f065c
2025-01-16 11:19:52 -08:00
Vinit Nayak
3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Treehugger Robot
22df0f9d20 Merge "Adding some source hints when generating theme icons" into main 2025-01-16 00:11:10 -08:00
Liran Binyamin
96dc022401 Pass the user id for intent app bubbles
When creating a new app bubble by long pressing on launcher icons,
pass the user id to wm shell so the bubble is created for the correct
user context.

Bug: 361173339
Flag: com.android.wm.shell.enable_bubble_anything
Test: atest BubbleAnythingTest
Test: manual
       - create work profile
       - long press on a work profile app icon -> Bubble
       - observe new bubble opens in the work profile context
Change-Id: Idb980bc6f74e85e85a9777f0d39e772b84feeb9c
2025-01-15 21:35:54 -05:00
Treehugger Robot
65ad1c2b19 Merge "Cleanup enableUseTopVisibleActivityForExcludeFromRecentTask flag" into main 2025-01-15 09:42:54 -08:00
Uwais Ashraf
5b13bb4adb Cleanup enableUseTopVisibleActivityForExcludeFromRecentTask flag
Fix: 342627272
Flag: com.android.launcher3.enable_use_top_visible_activity_for_exclude_from_recent_task
Test: TaplTestsQuickstep
Change-Id: I3217869ec6f9c623c55c2504607b386020da7292
2025-01-15 04:07:56 -08:00
Sunny Goyal
01a976f210 Adding some source hints when generating theme icons
Bug: 381897614
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ief779bb04cd69372ec3acd4501e283f09de41b4d
2025-01-14 16:00:46 -08:00
Treehugger Robot
bc3995222b Merge "Moving DisplayController to dagger" into main 2025-01-14 13:39:19 -08:00
Sunny Goyal
55dc2d1c31 Moving DisplayController to dagger
Separating various overrides to individual modules so that they can be reused in tests

Removing ContextualEduStatsManager and directly using SysUiProxy as all the usescases
are only in quickstep/
This avoids additional Module definition and delegation

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I096459d638553991ed01766002b874589c6b976e
2025-01-14 11:40:35 -08:00
Treehugger Robot
5850008ade Merge "Remove ScreenRecord for a closed bug" into main 2025-01-14 10:51:03 -08:00
Adnan Begovic
8d3eaf1a36 Merge "launcher3: Introduce onGridMigrationComplete callback." into main 2025-01-13 15:22:18 -08:00
Xiaoqian (Daisy) Dai
6dbd67ae7d Merge "desktop-exploded-view: Add header to individual windows." into main 2025-01-13 11:40:53 -08:00
Treehugger Robot
3ddd380c14 Merge "Remove ScreenRecord for a closed bug" into main 2025-01-13 10:19:05 -08:00
Adnan Begovic
4b9b9d7e40 launcher3: Introduce onGridMigrationComplete callback.
onGridMigrationComplete is invoked when grid migration
  successfully completes.

  ModelDelegate's can choose to observe this by overriding
  the callback.

Test: manual, existing
Flag: com.android.launcher3.one_grid_specs
Bug: 386802204

Change-Id: Iaca2e61a95c3d3decc12b2cc54461dba441202a0
2025-01-13 09:52:16 -08:00
Treehugger Robot
441a7ecfd1 Merge "Remove unused test debug tracing" into main 2025-01-13 09:35:05 -08:00
Treehugger Robot
7741fccfee Merge "Remove TaplIsTabletTest" into main 2025-01-13 08:16:27 -08:00
Schneider Victor-Tulias
2734f9854d Remove unused test debug tracing
Flag: EXEMPT debug tracing cleanup
Fixes: 289161193
Test: TaplAddWidgetTest
Change-Id: I3929379cbe77d6c1d74b80b705d63f073f3d21eb
2025-01-13 10:39:18 -05:00
fbaron
826f8f28e6 Remove TaplIsTabletTest
This test was there to verify if this check was causing other tests to fail, but it turns out that other tests were the problem. Remvoing this tests as now that we verified that it's a bit redundant

Bug: 366237798
Test: TaplIsTabletTest
Flag: TEST_ONLY
Change-Id: I925108b9ba39b96233f558c89d61791630aefe5a
2025-01-10 16:04:18 -08:00
Vadim Tryshev
aa836cff82 Remove ScreenRecord for a closed bug
Bug: 330232490
Test: presubmit
Flag: NONE Test change
Change-Id: I20d843b470bc83d0ad0f137ba4810b9872389897
2025-01-10 14:46:51 -08:00
Vadim Tryshev
3dafa1edff Remove ScreenRecord for a closed bug
Bug: 349439239
Test: presubmit
Flag: NONE Test change
Change-Id: If80c6681e6a3cb6c0bc81763c28ed7837c14c719
2025-01-10 14:46:42 -08:00
Michele Fan
89b039da83 desktop-exploded-view: Add header to individual windows.
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691

Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
2025-01-10 22:25:43 +00:00
Treehugger Robot
ce9ea2caef Merge "Simplifying IconShape" into main 2025-01-09 18:14:30 -08:00
Sebastián Franco
a237a71a1c Merge "Making sure we don't use Launcher when null" into main 2025-01-09 15:35:02 -08:00
Sunny Goyal
1138f5fe59 Simplifying IconShape
Removing various custom shapes and replacing it with a generic shape implementation. This works with any valid svg path.

Bug: 366237794
Flag: EXEMPT refactor
Test: atest IconShapeTest
Change-Id: I4665bc657b8bffc4d4efa30cebe00341b3140c55
2025-01-09 15:04:46 -08:00
Riddle Hsu
6eda95c70c Merge "Wait for launcher state before proceeding next test step" into main 2025-01-09 13:54:54 -08:00
Treehugger Robot
49337285b7 Merge "Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps" into main 2025-01-09 13:27:59 -08:00
Sebastian Franco
cc5911a57b Making sure we don't use Launcher when null
Fix: 386230683
Test: all test that use @PortraitLandscape
Flag: TEST_ONLY
Change-Id: I40dfd0e8f42a68649e1cbb2f8e69ce617a415f68
2025-01-09 13:04:37 -08:00
Stefan Andonian
56f17cfddf Attempt to fix TaplUninstallRemoveTest.testUninstallFromAllApps
Based on the video, it seems that existing app icons cause the long press menu
to be opened when the test bot is trying to scroll to open the AllApps page.
The fix is to clear the data so there are no icons that will interrupt said scrolling.

There might be 2 issues that are affecting this test based on my research. So if it still fails, that doesn't mean this change wasn't necessary. I think there might also be an issue with the test infrastructure.

Bug: 386231522
Test: Ran a go/abdt run to verify test isn't flaky. This does have 100% reproduction though.
Flag: EXEMPT test fix
Change-Id: Id2b1cf89eda39d1d921af0da544f92604c3f8591
2025-01-09 10:30:22 -08:00
Riddle Hsu
a584c24493 Wait for launcher state before proceeding next test step
Otherwise if scrollToAppIcon is called immediately, it could
interrupt the state that causes the test to be unable to drag
the icon into workspace.

Fix: 388510107
Flag: TEST_ONLY
Test: atest Launcher3Tests:ThemeIconsTest#testIconWithoutTheme
Change-Id: Ied77b3f8d2f19de18d054a80643f3d13c5641ac4
2025-01-09 12:58:39 +08:00
Sebastián Franco
4d0f53b478 Merge "Promote ReorderAlgorithmUnitTest since it's not failing anymore" into main 2025-01-08 19:35:42 -08:00
Treehugger Robot
dbbedf9e62 Merge "Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder" into main 2025-01-08 18:54:12 -08:00
Stefan Andonian
4a89d0ff9e Merge "Add ScreenRecord annotation to flaky test RequestPinItem" into main 2025-01-08 14:49:03 -08:00
Stefan Andonian
2c2e24f38d Add ScreenRecord to difficult to flaky test TaplDragTest.testDragToFolder
Bug: 383917141
Test: Passes Presubmit
Flag: EXEMPT flaky test investigation
Change-Id: Icf045821c42fdf9f8e60ae45d0d98ff2bc25e927
2025-01-08 14:17:02 -08:00
Stefan Andonian
8295c92e8e Add ScreenRecord annotation to flaky test RequestPinItem
Bug: 386243192
Test: Test runs fine with annotation.
Flag: EXEMPT unit test bug investigation
Change-Id: I27f8dc0fb55521ed37b743a0149dbe2ac60ad7ff
2025-01-08 12:53:08 -08:00
Treehugger Robot
13cb405ff0 Merge "Remove no longer meaningful upstream: true flag." into main 2025-01-08 12:29:51 -08:00
Sebastian Franco
a8e1984852 Promote ReorderAlgorithmUnitTest since it's not failing anymore
Fix: 332527963
Flag: TEST_ONLY
Test: ReorderAlgorithmUnitTest
Change-Id: I69257ff8a267f6f2e94f8d0c3c5e0c662ec5efb9
2025-01-08 12:20:13 -08:00
Treehugger Robot
b3a6b8c33d Merge "Fixing local atest runs of Launcher tests" into main 2025-01-08 10:44:53 -08:00
Rex Hoffman
74fa77e564 Removing Dead Flag
Test: CI
Bug: 386652866

Change-Id: I04537140ccd2526df4630c8cca6abbd327a7ca7f
Merged-In: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
2025-01-08 10:13:56 -08:00
Rex Hoffman
2c1c08a1ac Remove no longer meaningful upstream: true flag.
This used to direct robolectric tests to /external/robolectric rather than the older/unmaintained /external/robolectric-shadows, that has since been deleted.

Change-Id: If5065b2d25b5e5d8850f50dd4b25bd0ea7e3dd5c
Flag: TEST_ONLY
Test: CI
Bug: 386652866
2025-01-08 10:13:04 -08:00
Vadim Tryshev
ef95aa29fa Fixing local atest runs of Launcher tests
When running tests locally on CF, installing test apk either fails or returns INSTALL_FAILED_VERIFICATION_FAILURE.

Somehow this doesn’t happen when running on ATP.

For local runs, fixing by disabling verification.

Bug: 378782502
Test: local atest; presubmit
Flag: NONE Test change
Change-Id: I31b6d14587dbfed129ae3ddeef5e86f3c60432e9
2025-01-07 19:07:01 -08:00
Schneider Victor-tulias
a4c8c7fafb Merge changes Iceb7c9cf,I1e802e67 into main
* changes:
  Fix NPE in LauncherSwipeHandlerV2Test.setup
  Update recents states sent to tests by RecentsWindowManager
2025-01-07 07:46:03 -08:00
Schneider Victor-Tulias
878b2af8ea Update recents states sent to tests by RecentsWindowManager
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 382527932
Test: Tapl tests
Change-Id: I1e802e6787570e781d59e61cf03ce62c8a1edb47
2025-01-07 10:41:17 -05:00
Sunny Goyal
c369d1e4af Adding ThemeManager as a centralized place for controlling icon theming
Bug: 381897614
Flag: EXEMPT refactor
Test: atest ThemeManagerTest

Change-Id: Ib1dafdcc303f05f78cf586741c3d35243ab06e69
2025-01-06 21:53:22 -08:00
Treehugger Robot
bdcf3de348 Merge "Add screenrecord for TaplWorkspaceTest#testAddAndDeletePageAndFling" into main 2025-01-06 13:15:04 -08:00
fbaron
741321f44b Add screenrecord for TaplWorkspaceTest#testAddAndDeletePageAndFling
Flag: TEST_ONLY
Test: TaplWorkspaceTest#testAddAndDeletePageAndFling
Bug: 381918059
Change-Id: I8b595f049c97c1d4edf0de91f39d46a4c8bdefa3
2025-01-06 11:20:41 -08:00
Sunny Goyal
6d6529cff9 Merge "Converting LauncherPrefs to dagger" into main 2025-01-03 14:18:19 -08:00
Sunny Goyal
e79d453bc8 Converting LauncherPrefs to dagger
Fixing ENABLE_TWOLINE_ALLAPPS_TOGGLE not properly tied to IDP:
http://recall/-/ep7WJ8pKwCEklUN5J1mAkM

Bug: 361850561
Flag: EXEMPT dagger-migration
Test: atest LauncherPrefsTest FakeLauncherPrefsTest
Change-Id: Iba63d060f4a8c2e31033fca2a4638c559c161338
2025-01-03 13:49:53 -08:00