Commit Graph

1243 Commits

Author SHA1 Message Date
Shamali Patwa
286d458b78 Merge "Update Widgets tapl condition to match the new widget picker." into main 2025-06-06 08:18:06 -07:00
Shamali Patwa
bedc15ca4d Update Widgets tapl condition to match the new widget picker.
Bug: 408283627
Flag: com.android.launcher3.enable_widget_picker_refactor
Test: Test changes
Change-Id: I926d732c92b10c15d1ebda93d056d20df688bf0d
2025-06-06 05:23:28 -07:00
Ivan Chiang
21bdb605bf Fix the test case fail with PIA V2
In PackageInstaller V2 (PIA V2), the string is updated. Update the
test case.

Flag: android.content.pm.use_pia_v2
Bug: 420539987
Test: atest com.android.launcher3.dragging.TaplUninstallRemoveTest#testUninstallFromWorkspace
Change-Id: Icff1d7b44a34ebe940e66c57f9a6ea1a8477b8ec
2025-06-06 00:39:20 +00:00
Helen Cheuk
73661fda2e Merge "[Action Corner] Add padding between action corner and taskbar" into main 2025-05-23 06:35:28 -07:00
Schneider Victor-Tulias
9705f8fefa Update TestLauncherActivity to send TAPL launcher stopped message
This removes the need for a workaround in LauncherInstrumentation.executeAndWaitForLauncherStop for FallbackRecentsTests with recents window enabled

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: FallbackRecentsTest
Change-Id: I1b974cb2bfff4c14e99abb96c35dcdff04ed0be7
2025-05-22 09:01:14 -07:00
helen cheuk
6e5225bd77 [Action Corner] Add padding between action corner and taskbar
This is to avoid triggering unstashing taskbar and action corner at the same time.
A padding is added between the two areas.

Bug: 411091884
Test: TaplTestsTransientTaskbar
Flag: com.android.systemui.shared.cursor_hot_corner

Change-Id: I4e380a3d004977c96502af23f6126f22749e0a8f
2025-05-22 12:23:34 +00:00
Treehugger Robot
5ae4fb14f4 Merge "Wait for all springs to finish before running end snapping and relayout." into main 2025-05-19 03:47:48 -07:00
Pat Manning
e229b40329 Wait for all springs to finish before running end snapping and relayout.
- Adds a SpringSet to track all running springs.
- Rearranges the code into blocks: end runnable, reflow, dismiss, neighbor bounce, etc.
- Renames all instances of draggedTaskView to dismissedTaskView for consistency
- To stop blocking touch earlier, run grid end translation without waiting for the neighbor bouncing to finish.
- Update TAPL split screen launching logic to wait for dismiss animation to end.

Fix: 415327465
Test: TaplTestsQuickstep.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I59ade102e35e3528971907e898dac9555c6de796
2025-05-16 19:10:00 +01:00
Treehugger Robot
42aaacc11f Merge "Do not expect a desktop task has action views" into main 2025-05-14 19:11:34 -07:00
Toshiki Kikuchi
67a58b0dbf Do not expect a desktop task has action views
This CL changes TAPL not to expect having action views for a desktop
task.

Flag: EXEMPT - fix test
Bug: 416355555
Test: atest WMShellSmokeTestsDesktopMode
Change-Id: I9218415a5ff0b5a43758adb8cb6d3f3ea6cfcc6b
2025-05-13 20:33:52 +09:00
Treehugger Robot
de378a054f Merge "Fix FallbackRecentsTest with recents in window enabled" into main 2025-05-12 11:09:45 -07:00
Schneider Victor-Tulias
82050b85fa Fix FallbackRecentsTest with recents in window enabled
- Added a workaround to listen to onNewIntent without RecentsActivity in TouchInteractionService, allowing us to clean up the recents window appropriately
- Updated LauncherInstrumentation.executeAndWaitForLauncherStop to expect a state change instead of activity stop in 3P + recents window

Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I3756e268626d778a13be1f2c68f9d3157602534e
2025-05-12 10:27:41 -04:00
Treehugger Robot
950b841d3d Merge "Specify display ID for taskbar availability checks" into main 2025-05-11 18:45:29 -07:00
Alex Chau
d95285cf7a Merge "Revert "Make Tapl check if actions view is enabled on overview"" into main 2025-05-09 13:06:15 -07:00
Vinay Joglekar
73abff782b Revert "Make Tapl check if actions view is enabled on overview"
This reverts commit e8628ac605.

Reason for revert: https://b.corp.google.com/issues/416645195

Bug: 391276638
Change-Id: I7b8f1829c752d958e9b640cd5db0f9aeb9bfa2f0
2025-05-09 10:20:10 -07:00
Treehugger Robot
0dddfe6aae Merge "Account for magnetic detach when dismissing tasks in TAPL tests." into main 2025-05-09 08:12:58 -07:00
Pat Manning
015f0005b9 Account for magnetic detach when dismissing tasks in TAPL tests.
When the dismiss length is short, like in fixed landscape, we must account for a minimum distance to ensure dismissal

Fix: 415773066
Test: TaplTestsQuickstep#testOverview
Flag: EXEMPT Bugfix.
Change-Id: I31a1a9e0bbd23145455df35937cf85ce8ac2c20f
2025-05-08 16:15:29 +01:00
Fengjiang Li
05f7f5596f [Memory Leak Test] Support toggle theme from LauncherInstrumentation
Bug: 394613048
Flag: NONE - test code
Test: NONE - this CL is infra for follow up test
Change-Id: Idfdcee20c14159509b2a9be005485b24a17dd372
2025-05-06 21:36:31 +00:00
Jagrut Desai
d95a630277 Merge "Tapl widget change" into main 2025-05-02 10:49:24 -07:00
Schneider Victor-tulias
9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Toshiki Kikuchi
d2c4d9322e Specify display ID for taskbar availability checks
This CL adds a display ID to the query to check the availability of
taskbar.
On an external display, we always show the taskbar regardless of the
launcher state, so the existing checks don't make sense on the external
display.

Flag: EXEMPT - test fix
Fix: 408631713
Fix: 414092022
Test: atest WMShellFlickerTestsDesktopMode:com.android.wm.shell.flicker.OpenAppWithExternalDisplayConnected
Change-Id: I0281a3cffd182e57ecf56e8fb5e4d28d6a4384c3
2025-05-02 20:48:59 +09:00
Jagrut Desai
4fde59e821 Tapl widget change
- scroll if the header is under gesture region and click in same scroll loop

Test: Local, Presubmit
Bug: 402828709
Flag: EXEMPT bugfix

Change-Id: I90a5cf2829591aafd18ef625244def2c4d9e3980
2025-05-01 16:15:25 -07:00
Schneider Victor-Tulias
a56aa0d539 Update TAPL tests to dismiss all tasks safely
Flag: EXEMPT test refactor
Bug: 377678992
Test: pre/post-submit tests
Change-Id: I6a2225bea4f004bdc598e2c67ce26da9fd42f7a6
2025-05-01 16:04:32 -04:00
Treehugger Robot
675282b181 Merge "Revert^2 "Restrict nav mode UI checks within primary display"" into main 2025-04-30 20:53:19 -07:00
Mykola Podolian
5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00
Toshiki Kikuchi
d1a0e640cb Revert^2 "Restrict nav mode UI checks within primary display"
This reverts commit 9d7b814eec.

Reason for revert: Cache the taskbar primary display to reduce the number of binder calls and calm down Droidmonitor. Please check the difference between PS1 and PS2.

Bug: 414092022
Bug: 413244466
Bug: 408631713
Change-Id: I24138de2e2b9975fadcdf4a27402e06e212e4a19
2025-04-29 18:00:47 -07:00
mpodolian
9764250b60 Launcher TAPL test for dragging task bar icon to the bubble bar.
Added a test and TAPL objects to check dragging taskbar icons to the
bubble bar.

Fixes: 388910897
Test: TaplTestTaskBarIconDrag
Flag: EXEMPT test
Change-Id: I8a3e64a83c72a9f6b89b2f8a875ca6565d501701
2025-04-29 15:32:41 -07:00
Min Chen
31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Priyanka Advani (xWF)
9d5903bb10 Merge "Revert "Restrict nav mode UI checks within primary display"" into main 2025-04-28 12:18:34 -07:00
Priyanka Advani (xWF)
9d7b814eec Revert "Restrict nav mode UI checks within primary display"
This reverts commit 3ccfdbf6c4.

Reason for revert: Droidmonitor created revert due to Jank regression b/413244466.

Change-Id: I09276810e3611b54526ed3d2af7a35949a412b0c
2025-04-28 09:13:46 -07:00
Pat Manning
9fd78aa76d Merge "Drag tasks from center when perfoming dismiss cancel for tests." into main 2025-04-28 04:08:39 -07:00
minch
4e3d48e998 Fix integration tests with multi-desks on
Bug: 362720309
Test: Presubmit
Flag: EXEMPT tests failure fix
Change-Id: I381b8751083a7fb235cf597fd35314ca6f2c0a9b
2025-04-26 15:59:18 +00:00
Pat Manning
8eeaa6009c Drag tasks from center when perfoming dismiss cancel for tests.
Follow up to Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c

Fix: 412766455
Test: TaplTestsQuickstep#dismissCancel
Flag: EXEMPT bugfix.
Change-Id: Idcf17fe810a935c325d043519d2b8d216b3f5c13
2025-04-25 16:12:32 +01:00
Treehugger Robot
b6f127d82c Merge "Make Tapl check if actions view is enabled on overview" into main 2025-04-24 03:12:55 -07:00
Sam Cackett
e8628ac605 Make Tapl check if actions view is enabled on overview
Bug: 391276638
Flag: EXEMPT. Bugfix
Test: TaplTestsQuickstep
Change-Id: Ib167cc89244b34471a7bd84d6958ee4d2f006e51
2025-04-22 07:43:23 -07:00
Toshiki Kikuchi
3ccfdbf6c4 Restrict nav mode UI checks within primary display
This CL fixes the nav mode UI checks which currently assumes “navigation
mode” takes effect on all displays although the mode is only effective
on the primary display.

Flag: EXEMPT - test fix
Fix: 408631713
Test: atest WMShellFlickerTestsDesktopMode:com.android.wm.shell.flicker.OpenAppWithExternalDisplayConnected
Change-Id: I29f33957d696e9d5afda844f69388b74a8f78b77
2025-04-20 19:09:38 -07:00
Brandon Dayauon
e42fd21462 Merge "Update Tapl test for Private Space Add button" into main 2025-04-14 13:07:21 -07:00
Brandon Dayauon
3759f1428b Update Tapl test for Private Space Add button
See artifact: https://android-build.corp.google.com/test_investigate/invocation/I00100010386298382/test/TR74629693245670294/?itab=tests&ttab=artifacts

When aconfig flag is moved to staging the button is now "Add" rather than "Install" which will need to fix.

bug: 360313403
Test: presubmit
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I3a3e658d1a9d2b9d0795b5cef5d062ddfbe2b8ba
2025-04-14 10:38:10 -07:00
samcackett
2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Treehugger Robot
3dd0f30ac5 Merge "Remove 5x grid from canBeDefault grids" into main 2025-04-08 09:35:20 -07:00
Federico Baron
eec1d1d8f9 Remove 5x grid from canBeDefault grids
Bug: 407819792
Test: manual test
Flag: com.android.launcher3.one_grid_specs
Change-Id: I77c2fddc470d0dbaa6fc248ec30a5dbd4a86e0c2
2025-04-07 23:20:02 +00:00
Pat Manning
f6ee091c9c Merge "Dismiss tasks from center of task, not bottom." into main 2025-04-04 07:26:26 -07:00
Pat Manning
a1e23ded55 Dismiss tasks from center of task, not bottom.
Overview shows tooltip the first time it is opened, which blocks the bottom of the task, preventing the touch. By dismissing from the center of the task, we avoid this.

Bug: 403883013
Test: DismissTaskFromOverview#testDismissCurrentTaskFromOverview
Flag: EXEMPT bugfix
Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c
2025-04-04 07:25:45 -07:00
Pat Manning
cb855eeeaf Fling cancel at same rate as fling so it is detected by touch controller.
Fix: 396447643
Test: TaplTestsQuickstep#testDismissCancel
Flag: EXEMPT bugfix
Change-Id: I1cf3ae6944d4765b54b78a86d4a81af1ed81e661
2025-04-01 09:33:49 -07:00
Schneider Victor-Tulias
58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Alex Chau
77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Federico Baron
c3ac9c1c16 Fix attempt 2 for testDragToFolder
The reason the test fails is that since the tap targets are smaller, the
drag is too fast and the hover over icon to create folder time doesn't
elapse

Bug: 383917141
Test: TaplDragTest#testDragToFolder
Flag: TEST_ONLY
Change-Id: I3ba2b621f92f94dc52eb2b7ee6cd459ab9abb894
2025-03-06 15:34:13 -08:00
Treehugger Robot
872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Treehugger Robot
19e93afd91 Merge "Test all apps -> workspace drag for taskbar on home" into main 2025-03-03 11:59:21 -08:00
Toni Barzic
a5c5536d7d Test all apps -> workspace drag for taskbar on home
Adds TAPL test that verifies users are able to drag app items from all
apps to workspace when all apps is opened on from a pinned taskbar shown
on the home screen, as may be the case when a desktop mode taskbar is
shown on home screen.

Adapts LauncherInstrumentation to handle the case where taskbar is shown
on home - when verifying launcher states, it sets taskbar visibility
expectations to account for a posibility that taskbar is visible in
home, or workspace states. Adds a request to the test protocol to
determine whether taskbar should be visible on home.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: Ran TaplTestLockedTaskbar tests
Change-Id: I40b06da70aaa49b0a3e0673797e6c18773a72238
2025-03-01 00:31:46 +00:00