Commit Graph

566 Commits

Author SHA1 Message Date
Treehugger Robot
99f6d447ea Merge "Cleaning up temporary interfaces which were created for refactoring" into main 2024-10-11 23:02:52 +00:00
Sunny Goyal
43b01b9900 Cleaning up temporary interfaces which were created for refactoring
Bug: 366237794
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: Ic2c69bcdde1429c787903c24f0e19ea26b91d314
2024-10-11 11:03:47 -07:00
Brian Isganitis
0e27df431a Merge changes from topic "launcher-prefs-abs" into main
* changes:
  Add FakeLauncherPrefs with basic tests.
  Split LauncherPrefs into abs class / impl.
2024-10-10 19:31:04 +00:00
Sunny Goyal
266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Brian Isganitis
7f6ecaaa06 Add FakeLauncherPrefs with basic tests.
Flag: TEST_ONLY
Bug: 369504330
Test: go/testedequals
Change-Id: I1cc408451b1f6e316c0ec6b087989323bcd9da4d
2024-10-09 18:55:51 -04:00
Brian Isganitis
9cbc478574 Split LauncherPrefs into abs class / impl.
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.

LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.

Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
2024-10-09 18:55:51 -04:00
Sunny Goyal
f7ae1ec325 Merge "Moving manifest initialization to RoboApplication instead of a separate rule" into main 2024-10-09 07:52:37 +00:00
Sunny Goyal
6a207fc4f9 Moving manifest initialization to RoboApplication instead of a separate rule
This makes the behavior same as instrumentation test

Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
2024-10-08 11:00:22 -07:00
Sunny Goyal
9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Brian Isganitis
67ed920053 Merge changes from topic "brianji-object-sandbox" into main
* changes:
  Add SandboxApplication for keeping created contexts in sandbox.
  Allow specifying base for SandboxModelContext.
  Rename to ObjectSandbox.
2024-10-08 16:33:47 +00:00
Sunny Goyal
b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Brian Isganitis
d04464ac39 Add SandboxApplication for keeping created contexts in sandbox.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I14c277325bd4b3b7cf59ed31dedad338bf1e4440
2024-10-07 16:50:59 -04:00
Brian Isganitis
4d6194f432 Allow specifying base for SandboxModelContext.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I2d6c90eda30cb80fd7124d35bab62b1af1b10902
2024-10-07 16:50:59 -04:00
Fengjiang Li
49df29669d [Dagger] Make ScreenOnTracker provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: I305ee47f2da92972e9b5effe3c3e02504cd5a3b0
2024-10-07 11:45:16 -07:00
Sunny Goyal
95045ce03a Fixing test flakiness in Launcher initialization
Using same key for blob store and content provider based layouts

Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately

Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
2024-10-04 20:52:17 +00:00
Jagrut Desai
831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Sunny Goyal
e978f6cedb Converting some caching logic booleans to lookup flags
Bug: 366237794
Test: atest IconCacheTest
Flag: EXEMPT refactor

Change-Id: I0d25996181954df22e1cb61596be0a2694ee7068
2024-10-01 17:59:48 +00:00
Jagrut Desai
85a8898402 Remove unused TestProtocol
Test: Presubmit
Bug: 319501259
Flag: TEST_ONLY
Change-Id: Ibe261ec8820f5d6e8415f5085c21a0adfef37462
2024-10-01 09:24:38 -07:00
Charlie Anderson
e6fdb5e2be Update test activities with a non-default icon.
Check against default app icon in FolderIconLoadTest

Bug: 357441807
Bug: 369222239
Bug: 369240511
Flag: EXEMPT bc-triaged bugfix
Test: FolderIconLoadTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:65c1010029e65c7e3062fd5e1407fa53437ac417)
Merged-In: I0e224f5b8bf8c0a8c51d88abd7c562d8e1ff7a55
Change-Id: I0e224f5b8bf8c0a8c51d88abd7c562d8e1ff7a55
2024-09-30 17:31:30 +00:00
Treehugger Robot
0c1db56f2f Merge "Requesting ApplicationInfo in cached object" into main 2024-09-28 00:08:58 +00:00
Treehugger Robot
947a932a33 Merge "Cleanup for TAPL Debugging" into main 2024-09-27 21:21:49 +00:00
Sunny Goyal
f7c32a29fd Requesting ApplicationInfo in cached object
Bug: 363324203
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I92f3d3ed8c267b895dc439ba1f01eb67d7f63965
2024-09-27 14:04:16 -07:00
Archisha Baranwal
10467a8cf3 Merge "Adding programmatic provision of WRITE_SECURE_SETTINGS permission to Launcher3Tests." into main 2024-09-27 08:35:45 +00:00
Archisha Baranwal
0d11c4a7ef Adding programmatic provision of WRITE_SECURE_SETTINGS permission to
Launcher3Tests.

Bug: 361222449
Test: atest Launcher3Tests
Flag: EXEMPT test fixes

Change-Id: I4226c4c50047d71a99944fc4e5d70080d134c3d3
2024-09-27 05:53:59 +00:00
Sukesh Ram
e297bc0c0e Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 326908466
Test: Manual
Change-Id: I01dadc884929a8946f408997ddbcbd0ac4c820ec
2024-09-26 19:44:55 +00:00
Charlie Anderson
24061ff74f Merge "Update test activities with a non-default icon." into main 2024-09-26 19:16:41 +00:00
Charlie Anderson
65c1010029 Update test activities with a non-default icon.
Check against default app icon in FolderIconLoadTest

Bug: 357441807
Bug: 369222239
Bug: 369240511
Flag: EXEMPT bc-triaged bugfix
Test: FolderIconLoadTest
Change-Id: I0e224f5b8bf8c0a8c51d88abd7c562d8e1ff7a55
2024-09-26 03:59:10 +00:00
Sunny Goyal
37182de670 Fixing flakiness in robo tests
Bug: 352288591
Flag: EXEMPT test fix
Test: Presubmit
Change-Id: I15dd91815f7ae4d3cf3c9e1fd4c2b5e07052ab3f
2024-09-25 10:52:14 -07:00
Sunny Goyal
e1b7ca566e Merge "Moving various application into related methods to a separate class" into main 2024-09-24 22:05:52 +00:00
Randy Pfohl
31aefc3290 Merge changes from topic "windowRecents" into main
* changes:
  Cleaning up unusued handlers
  Moving RecentsWindowManager away from the singleton pattern
  Limited recents in window introductory cl
  abstracting fallback views to support container instead of activity
2024-09-24 16:13:30 +00:00
Sunny Goyal
28d6bbd6b4 Moving various application into related methods to a separate class
> This avoids duplicate RPCs when trying to get multiple properties
  from AppInfo
> This would be used in a followup cl when AppInfo is added to caching
  logic in IconCache

Bug: 366237794
Test: atest ApplicationInfoWrapperTest
Flag: EXEMPT refactor
Change-Id: I55b964d4f8cfa1ff1770e310ac278719495e285d
2024-09-23 22:09:24 -07:00
Sunny Goyal
f84b6edee7 Merge "Removing unnecessary package validation during grid migration" into main 2024-09-24 00:31:54 +00:00
Sunny Goyal
c3dd1c380f Removing unnecessary package validation during grid migration
package validation happens during loader anyway. And using MATCH_INSTALLED
for checking cross user apps may not work all the time

Bug: 363324203
Test: atest GridSizeMigrationUtilTest
Flag: EXEMPT bug fix
Change-Id: Id36e8fdff132242705ef53c85dc6567fbde5d952
2024-09-23 15:16:37 -07:00
Jagrut Desai
94c9fb7cf5 Refctor DisplayController#handleInfoChange
Test: Presubmit
Bug: 369140181
Flag: EXEMPT refactor DisplayController#handleInfoChange
Change-Id: I196fe0e843a60c518d882c25f9fbdcd3cb775ba6
2024-09-23 09:58:30 -07:00
randypfohl
c50aa8bf31 Limited recents in window introductory cl
Test: Built and tested locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I5352ba0b6c5bc196fbd1322d435a7e27e884f7b5
2024-09-20 16:09:50 -07:00
Treehugger Robot
f0123c9129 Merge "Reset taskbarModePreference on tearDown()" into main 2024-09-20 16:10:26 +00:00
Sunny Goyal
621918feda Changing min-sdk version of Launcher to 31
Bug: 368071216
Flag: EXEMPT refactor -> dead code removal
Test: Presubmit
Change-Id: I1f0113c56de56f12f3a174eb31c3f8e8a09407e6
2024-09-20 06:00:10 +00:00
Toshiki Kikuchi
5cec59a41d Reset taskbarModePreference on tearDown()
This CL forcefully resets taskbarModePreference on tearDown() to ensure
the following tests are not affected by the changes made by
`testTaskbarPinningChangeInLockedTaskbarChange`.

Bug: 368322666
Flag: EXEMPT bug fix
Test: nexus_unit_test_multi_device_platform
Change-Id: I8bd8e8ca8b4b832ed17e86fbdfc9bda7bf9ab16e
2024-09-20 00:47:18 +00:00
Toshiki Kikuchi
6ddfe9b179 Allow to show pinned taskbar when Launcher is visible
This CL allows freeform-first devices to lock the taskbar in a pinned
state when Launcher is visible.

Bug: 361419732
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual

Change-Id: Ic0d2740e33fee19c676d88aa2bcf370eb64366e8
2024-09-18 10:49:52 +00:00
Alex Chau
03aa04d45b Revert "Adds new log constant to track overview select tooltip misalignment"
This reverts commit cbc8bf0443.

Reason for revert: b/332485341 is fixed, revert logging constant previous added

Change-Id: I970a3af9905037a51bd9748324f35ac80de9b06b
2024-09-16 10:37:50 +00:00
Kevin Lim
f1b5855af7 [Testing] Renamed incorrectly named FloatingHeaderViewTest
FloatingHeaderviewTest was named with ...Tests (plural), preventing it from
being excluded from launcher-testing-helpers-robo and getting included
in some unintended tests.

Bug: b/341795751
Flag: EXEMPT test renaming.
Test: Running FloatingHeaderViewTest
Change-Id: I8149f0a5548e77674bb2a23a34bd7671e0a3b371
2024-09-12 20:57:14 +00:00
Treehugger Robot
c912c8fb8b Merge "Improving regex for detecting a local platform build" into main 2024-09-11 19:48:47 +00:00
Vadim Tryshev
460192588f Improving regex for detecting a local platform build
Platform build can now have versions line "eng.himans"

Bug: 187761685
Test: online regex verifier
Flag: NONE test change
Change-Id: I86b9324dfbbc36272215eae58af836e9a3741d70
2024-09-11 10:39:31 -07:00
Sunny Goyal
7a548377eb Remove obsolete features
Flag: EXEMPT legacy ENABLE_TWOLINE_DEVICESEARCH, ENABLE_ICON_IN_TEXT_HEADER, ENABLE_PREMIUM_HAPTICS_ALL_APPS
Bug: 270396358
Bug: 201388851
Bug: 270395143
Test: Verified manually
Change-Id: I88ca7b255d2ae4eba393c1aee52153ef0a459140
2024-08-30 13:04:08 -07:00
Sebastián Franco
6edce2ad75 Merge "Remove test to postsubmit while they are flaky" into main 2024-08-22 17:08:45 +00:00
Treehugger Robot
7369348ba8 Merge "Delete dead test SettingsActivityTest" into main 2024-08-22 10:01:55 +00:00
Alex Chau
eececf272e Merge "Reset mTopRowIdSet in applyLoadPlan" into main 2024-08-22 09:49:27 +00:00
Sebastian Franco
f989210f5b Remove test to postsubmit while they are flaky
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: TEST_ONLY
Change-Id: I29d631ba7dfe7f2c3a5323bfb414cb4da5b3321b
2024-08-21 15:20:18 -07:00
Alex Chau
9109b81a95 Reset mTopRowIdSet in applyLoadPlan
- All taskViewIds become obsolete after removing and re-adding, so we'll need to reset mTopRowIdSet when removing all taskViews
- OverviewActionsView.updateActionButtonsVisibility can be called before updateDimension (where mDp is set), so a null check is necessary
- Fixed TestStaibilityRule failing when running FallbackRecentsTest alone. FallbackRecentsTest runs with 3P Launcher, in that case launcherPackageName is our test activity, and launcherVersion can be null. This can only occur in a local run, thus return LOCAL in this case.

Fix: 355042336
Test: FallbackRecentsTest and manually testing dismiss
Flag: EXEMPT BUG_FIX
Change-Id: I9125ea38a567deb0d3028e7d7407397d1dc06ade
2024-08-21 12:37:14 +01:00
Alex Chau
1eebacf636 Merge "Clean-up debug logs" into main 2024-08-21 10:53:21 +00:00