Commit Graph

23356 Commits

Author SHA1 Message Date
Jordan Silva
3d348a0d27 Add focus border animation to IconAppChipView
Fix: 366177160
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB and navigate through the task menu.
Test: Manual using Mouse. Hover over the Chip and the Task Menu.
Change-Id: I785ad8723e5255186d744a20992ac0cd0968b380
2025-05-21 14:20:49 -07:00
Lucas Dupin
02c6fd6604 Add recents position callback to SystemUiProxy
Flag: com.android.systemui.enable_underlay
Test: atest AmbientCueRepositoryTest
Test: atest AmbientCueInteractorTest
Test: atest AmbientCueViewModelTest
Test: atest TaskbarNavButtonControllerTest
Bug: 415914274
Bug: 415914083
Change-Id: Ie6c7412d3bbc9cd64e4c9993db47821962e1b1fc
2025-05-21 14:04:18 -07:00
minch
ded5807543 Create the RemoteTargetGluer based on the GroupedTaskInfo
Determine whether a `RemoteTargetGluer` for desktop should be
created based on GroupedTaskInfo instead of
`RecentsAnimationTargets.hasDesktopTasks`. The latter one is
inaccurate to assume that a desk may only have FREEFORM tasks.

Bug: 400866688
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: I6f35f41204790ada59317e0b4bd0a8965c9718eb
2025-05-21 13:42:08 -07:00
Xiaoqian (Daisy) Dai
7e21181997 desktop-exploded-view: truncate the task header app title if it overflows
A long app title can cause the close button to be covered.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 413387821
Change-Id: Id66cabb271ac6f4772969335232e3e9638828571
2025-05-21 20:13:53 +00:00
Schneider Victor-Tulias
124b010ea9 Add recents animation start timeout handling to TaskAnimationManager
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.

Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
2025-05-21 15:55:44 -04:00
Sergey Pinkevich
d0fccf8773 Convert DesktopVisibilityControllerTest to multivalent
Bug: 397902030
Flag: NONE test fix, not actual code editing
Test: atest NexusLauncherTests:DesktopVisibilityControllerTest

Change-Id: Ie6ae4abb2a894d4f7403e77cf797cdce924fd9e3
2025-05-21 18:50:43 +00:00
Simon (Qiong) Sun
00063bcf2f Support multiple tasks per split screen via SplitRemoteTargetHandles
It enables support for assigning SplitRemoteTargetHandles to multiple tasks within a split-screen.

The changes include:

- Retrieving the list of split-screen tasks directly from `SplitBounds`.
- Iterating through the task list and setting the remoteTargetHandle for each individual task.
- General code refactoring to set the remoteTargetHandle.

Bug: 346295292
Bug: 360782849
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: manual test.
Video: Before: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/fnHVbaVwMWfvrOaez5eO6L
Video: After: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/dzv6tZMlAYG1bBBtYdsWxF

Change-Id: I1e8c8316947b0d4fd72c9cf36dff8ecd99d2f170
2025-05-21 17:51:09 +00:00
Schneider Victor-Tulias
6d532fe59d Fix broken state when tapping nav handle from running app.
When tapping the nav handle from running app, OtherActivityInputConsumer will start the recents window through TaskAnimationManager. The recents window would then typically be closed through the StateManager, however since the state isn't changing, then RecentsWindowManger never actually gets any signal to close the recents window. Added a new callback to fix this flow.

Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/post submit tests. tapped nev handle from a runnign app
Change-Id: If1fe7de195a9a8a98c72629c7904d469a5768d7f
2025-05-21 10:35:11 -07:00
Jordan Silva
e14014cc88 Merge "Fix task icons sometimes not appearing in recents view" into main 2025-05-21 10:09:00 -07:00
Treehugger Robot
57de0ebf21 Merge "Make sure RecentsWindowManager is created for TaskbarUIController" into main 2025-05-21 09:56:04 -07:00
Liran Binyamin
328bf4ab1c Fix bar state when overflow is selected initially
Fix the state of the bubble bar when the initial state received
from sysui has the overflow selected, which can happen after
unfolding. This ensures that the arrow position is set correctly,
and that when tapping on the overflow in this state the bar
collapses.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - have floating bubble and expand
       - selecte overflow
       - unfold
       - observe overflow is expanded and bubble bar arrow position
         is correct
       - tap on the overflow bubble
       - observe bar collapses
Change-Id: I4a3d217ce951c7c7f2d17da89b0cd5905faf0eff
2025-05-21 12:49:02 -04:00
Helen Cheuk
444161df77 Merge "[Action Corner] Make home action corner irreversible" into main 2025-05-21 09:13:31 -07:00
Treehugger Robot
10b72a252d Merge "Revert "Temporarily revert allowing recents view to reapply load state"" into main 2025-05-21 07:15:41 -07:00
Alex Chau
f29a8dd4e2 Make sure RecentsWindowManager is created for TaskbarUIController
Bug: 418965555
Flag: EXEMPT bugfix
Test: local + presubmit

Change-Id: Ib45df9c0f04534cd88a1b2ae1ff4ab49f8999dff
2025-05-21 14:13:20 +00:00
Treehugger Robot
2cc2843f03 Merge "Dismiss task on default display if it is moved to external" into main 2025-05-21 06:45:24 -07:00
helen cheuk
9598e4c78c [Action Corner] Make home action corner irreversible
The go home action for action corner should be irreversible for now.
When home action corner is triggered at homepage, it should just stay at homepage and would not go back to previous task.
Add flag for the reversible behavior for non-desktop mode home action corner. It is to be completed with dekstop mode in later release.

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.launcher3.enable_reversible_home_action_corner
Change-Id: Ib36581d0d3d81d4a7ff8f8d6265d8d5d5f5872fd
2025-05-21 14:26:01 +01:00
Jordan Silva
ea25b86ce1 Fix task icons sometimes not appearing in recents view
- Call setTaskIconVisible(true) at the end of the gesture regardless of `setCurrentTask`.
- Resets the icon visibility when RecentsView resets to make sure the bad state won't get stuck.

Fix: 332744660
Flag: EXEMPT bug fix
Test: Manual test on device
Change-Id: Ie8b86efa4892298f0071ad304a8c77698c306d6a
2025-05-21 04:57:22 -07:00
Sebastián Franco
e010d8f654 Merge "launcher: Remove allow rotation setting from indexable settings" into main 2025-05-20 17:04:02 -07:00
Treehugger Robot
737a52ce07 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-05-20 16:11:42 -07:00
Pierre Barbier de Reuille
4ad6e804ec Merge "Create a flag to enable the desktop menu entry on Overview when ready" into main 2025-05-20 15:28:02 -07:00
Treehugger Robot
27312fa26d Merge "Prevent adding duplicate TaskAnimationManager launcher destroyed callbacks" into main 2025-05-20 15:22:24 -07:00
Treehugger Robot
ab9921a5d5 Merge "Only update All Apps scrim (panel) when blur state changes." into main 2025-05-20 14:17:39 -07:00
Will Osborn
33f9e2c356 Dismiss task on default display if it is moved to external
https://photos.app.goo.gl/AdvkEkTvQdP2dXA26

Bug: 417451469
Flag: EXEMPT bugfix
Test: Local + presubmit
Change-Id: I2955aaee2b59bffb072330e5ebbfcf6d3d83dc3c
2025-05-20 20:34:15 +00:00
Saumya Prakash
4d4fd45f02 Merge "Modify Gesture nav edu to new UX specs" into main 2025-05-20 11:58:06 -07:00
Sam Cackett
10276b2d76 Merge "Add logs for split screen RemoteAnimationTargets" into main 2025-05-20 09:03:59 -07:00
Pierre Barbier de Reuille
933c5324d0 Create a flag to enable the desktop menu entry on Overview when ready
Bug: 418822736
Flag: com.android.launcher3.enable_desktop_menu_on_secondary_display_bugfix
Test: atest DesktopSystemShortcutTest
Change-Id: I55b6493165f5307d3c247bb604441b093d5e8e9d
2025-05-20 15:55:41 +01:00
Alex Chau
cb05c49ff0 Revert "Temporarily revert allowing recents view to reapply load state"
This reverts commit cea90d45a6.

Reason for revert: b/417535264 reland

Bug: 417535264
Change-Id: I8611ec59c9574021a0d925d35ee6523faebd6d18
2025-05-20 07:39:07 -07:00
Cosmin Băieș
cba51f4023 Merge "Remove canImeRenderGesturalNavButtons and sysprop" into main 2025-05-20 03:41:58 -07:00
Treehugger Robot
9977ef7c2a Merge "Update Empty State to support Blur background" into main 2025-05-20 02:17:40 -07:00
Sam Cackett
544b511aa5 Add logs for split screen RemoteAnimationTargets
Crash happened because the split config taskId couldn't be found in the
list of remote targets, however I can't reproduce this, so adding
additional logging in case it happens again

Fix: 411897545
Flag: EXEMPT. Bugfix
Test: N/A. Logs
Change-Id: Id6ad6f5dc94aa904e1ea89f3ec59cdcd4114ec73
2025-05-20 09:53:23 +01:00
Treehugger Robot
fe134675be Merge "desktop-exploded-view: Fix the hierarchy with the header" into main 2025-05-19 19:39:05 -07:00
Andy Wickham
dc681e83e7 Only update All Apps scrim (panel) when blur state changes.
Previously we updated many other things, such as the buttons and RV
decorators, but the latest UX guidance is to use the same colors
when blurs are enabled or disabled, other than the panel color.

Note: When Overview blur is enabled, the activity is recreated and
this change is redundant. So this is only done if that flag is off.

Demo with home and taskbar all apps (toggling blur with adb):
https://drive.google.com/file/d/1HzveExKpAERxMVdu7JXQSYeGRwaBNR4_/view?usp=sharing&resourcekey=0-l-dGWOS6aCQjj2KStvwySA

Fix: 413229346
Flag: com.android.launcher3.all_apps_blur
Test: Manual with battery saver and `adb shell wm disable-blur 1` / 0
Change-Id: I55c9b46f0999c574c29a6ac7ae557b1e30d91d15
2025-05-19 19:20:34 -07:00
Saumya Prakash
0c6c1d7309 Modify Gesture nav edu to new UX specs
This change adapts the "Done" button in the gesture navigation tutorial
according to new UX specs. Specifically, the button is wider and may
have a different font according to theme.

Fix: 416144733
Test: Run the gesture navigation tutorial and observe the done button
Flag: EXEMPT bugfix
Change-Id: I4732a21c76e5a0e95433a211cd747cb36aaeaa4d
2025-05-19 23:33:32 +00:00
Andy Wickham
982b08ede0 Merge "Fix All Apps interpolators and blur." into main 2025-05-19 15:11:00 -07:00
Bill Yi
2f0de7f663 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie1ca16291c4c1b3624d6d30a66f7d1a5ae2f674b
2025-05-19 19:24:54 +00:00
Adnan Begovic
07a95ff14d launcher3: Ensure workspace visibility after scaling animation is done
- Using setFloat instead of setViewAlpha for animation. The difference between setViewAlpha
and setFloat is that the latter will flip the view visibility as a short circuit of its
implementation. Moving to setFloat ensures that we only mutate the alpha values themselves.

Bug: 414949943
Flag: EXEMPT Bug fix
Tested: Manually, simulated
Change-Id: Id0152ac4780568dd31224df8dcea5c7ad9d309d8
2025-05-19 10:28:00 -07:00
Treehugger Robot
496de611cd Merge "Change "Close" menu shortcut label to "Clear" in Overview" into main 2025-05-19 09:18:43 -07:00
vinayjoglekar
c66cc78eca Update Empty State to support Blur background
Updated icon and text font as well as scrim values to make the text and
icon visible in both themes and different wallpapers.

Fix: 408437743
Test: Go to overview in empty state(no tasks)
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Ic76d25f4a70bffa402950fc4c3c3fade32c66c2b
2025-05-19 15:48:24 +01:00
Alex Chau
13d1b07304 Merge "Reland "Recreate Launcher activity when blur enabled changes"" into main 2025-05-19 07:03:27 -07:00
Treehugger Robot
34b37ff825 Merge "Revert "Add temp logging to select task"" into main 2025-05-19 05:59:54 -07:00
Treehugger Robot
096352d567 Merge "Improve app to home animation blur" into main 2025-05-19 05:42:24 -07:00
Treehugger Robot
5ae4fb14f4 Merge "Wait for all springs to finish before running end snapping and relayout." into main 2025-05-19 03:47:48 -07:00
Alex Chau
64d347259f Revert "Add temp logging to select task"
Revert submission 33469527-b/407815700

Reason for revert: logs no longer needed
Reverted changes: /q/submissionid:33469527-b/407815700
Bug; 407815700

Change-Id: Ic48e54e8247a672f763bb3b3bbe4c16aef9b6322
2025-05-19 03:26:29 -07:00
Sam Cackett
5bf67401f6 Change "Close" menu shortcut label to "Clear" in Overview
Fix: 413764920
Flag: EXEMPT. Bugfix
Test: Manual. Open recents, tap menu, "Close" should now be "Clear"
Change-Id: Ic727ae7dedf23af65a382e0c7bfe455653865819
2025-05-19 09:23:41 +01:00
Andy Wickham
15ce89129d Improve app to home animation blur
- Add a blur layer to the Scaling Workspace Reveal to have a smooth
  blur transition during animation
    - As part of this, disable blur from DepthController (but still
      use it for depth to match workspace scale)
    - This mirrors the approach in LauncherBackAnimationController
- Use a snappier interpolator for the blur portion (666ms, emphasized)
- Reduce the alpha of floating view during animation, to reduce the
  blur effect during the morph
- Increase the cross fade duration of the App Widget to App reveal

Demo video with various widgets and apps:
https://drive.google.com/file/d/1fYJc-TPAEltqParM957NMYbRe2Gn5OgJ/view?usp=sharing&resourcekey=0-AGiL7sqLNXDcNsY-qOzzYQ

Note: this is sort of a different approach to ag/33537973 without the
underlying refactor necessary.

Bug: 417269110
Test: Manual (see video)
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I2bb6c0114d42af7ed802fbcae03655befe19aa7e
2025-05-18 16:51:46 -07:00
Sebastian Franco
52c77ba8c2 launcher: Remove allow rotation setting from indexable settings
Fix: 407675825
Flag: com.android.launcher3.one_grid_specs
Test: SettingsIndexablePreferenceKeysTest
Change-Id: I5ba3df68c375cf00a604e3b30a47f28acc91165d
2025-05-18 11:08:05 -07:00
Mykola Podolian
9e4b44afcd Merge changes from topic "remove_ipc" into main
* changes:
  [5/5] Removed unused IPC call.
  [4/5] Cover DragToBubbleController with tests.
  [3/5] Implement DragToBubbleController.
  [2/5] Hook up DragToBubbleController and prepare launcher to use it.
  [1/5] Added DragToBubbleController
2025-05-16 16:01:03 -07:00
Mykola Podolian
bbd1e2e6ad Merge "Fixed issue with expanded view incorrect position." into main 2025-05-16 15:33:33 -07:00
Xiaoqian Dai
bc84ada5e3 desktop-exploded-view: Fix the hierarchy with the header
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 417776150

Change-Id: Ia9272801f2bb5a8e67b2bc69d5df8c4227f7a11a
2025-05-16 21:44:26 +00:00
Vadim Tryshev
a3e63d1e20 Merge "Skip all tests after a test times out" into main 2025-05-16 14:06:56 -07:00