Commit Graph

828 Commits

Author SHA1 Message Date
Schneider Victor-Tulias
924c181fcd Fix missing TAPL test state checks
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I2315e0af7b0567368ddc194a2d5ec7b3e563175f
2025-03-31 16:15:42 -07:00
Wen-chien Wang
edf603cf95 Merge "pin-shortcut: Make single recent task pinnable from taskbar" into main 2025-03-31 14:12:43 -07:00
Will Osborn
5c00b41505 Merge "Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library" into main 2025-03-28 14:05:39 -07:00
Will Osborn
ec8d20d0ed Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library
Test: locally tested on Tangor
Bug: 399371607
Flag: EXEMPT refactor

Change-Id: Ie52f53a2d5dee757a8dc3b19248736bc15e5e0c6
2025-03-28 12:08:36 +00:00
Treehugger Robot
530ccf25a5 Merge "Forcefully finish recents animations when launcher is detroyed" into main 2025-03-28 01:55:03 -07:00
Schneider Victor-Tulias
8d72503263 Forcefully finish recents animations when launcher is detroyed
If launcher is destroyed while the recents animation start is pending, then the taskanimationmanager and absswipeuphandler states are not properly cleaned up. Adding a new cleanup flow to handle this case.

Flag: EXEMPT bug fix
Fixes: 405642423
Test: adb shell cmd uimode night yes/no while TaskAnimationManager.mRecentsAnimationStartPending == true
Change-Id: I7bf1fc4fc07859f92d7aec6cd78deafa1214dd17
2025-03-27 23:03:40 -04:00
Treehugger Robot
d81b43802a Merge "Add showPinningView to TaskbarPinningControllerTest." into main 2025-03-27 14:45:20 -07:00
Treehugger Robot
b3a5b7c8e4 Merge "Revert^2 "Simplifying model testing rules"" into main 2025-03-27 10:11:38 -07:00
Treehugger Robot
749927c88e Merge "Move querying focus display to TIS" into main 2025-03-27 04:14:02 -07:00
Sunny Goyal
3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Treehugger Robot
b932dea54e Merge "Implement spring animations for running state changes." into main 2025-03-26 21:06:14 -07:00
Jon Miranda
e6d41c9b2f Add showPinningView to TaskbarPinningControllerTest.
Simple test that checks long pressing on the divider icon shows the
pinning view.

Bug: 402671805
Bug: 346394250
Test: TaskbarPinningControllerTest
Flag: TEST_ONLY
Change-Id: I435be4d7a12b0a92432cba49e57b6cef46e9679d
2025-03-26 19:05:03 -07:00
Sunny Goyal
6e12b811a0 Merge "Revert "Simplifying model testing rules"" into main 2025-03-26 16:37:45 -07:00
Priyanka Advani (xWF)
35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Treehugger Robot
0219df0770 Merge "Simplifying model testing rules" into main 2025-03-26 15:10:44 -07:00
Min Chen
12fafb2469 Merge changes from topic "empty-desk" into main
* changes:
  Remove wallpaper task and tasks below from `getCachedTopTask`
  Handling for an empty desk
2025-03-26 13:02:49 -07:00
Sunny Goyal
cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Jagrut Desai
7a6b2a39f6 Merge "Fix Taskbar Flicker with Recents or Running Apps Present" into main 2025-03-26 08:59:05 -07:00
Shamali Patwa
a8455409f6 Merge changes from topic "dwb-refactor-data" into main
* changes:
  Add a useCase to get the remaining app time rounded down to minutes
  Add a repository to fetch the remaining time for DWB
2025-03-26 06:02:52 -07:00
Ajinkya Chalke
28b50a21a5 Move querying focus display to TIS
- Move the logic to query for focused displayId from
  OverviewCommandHelper to TouchInteractionService.
- This way the OverviewCommandHelper code always uses command.displayId
  in its code.

Bug: 404757863
Test: manual run CUJ
Flag: com.android.launcher3.enable_alt_tab_kqs_on_connected_displays
Change-Id: Ia9b05e64b549895f029bc5204169cf84474af125
2025-03-26 09:43:56 +00:00
Wen-Chien Wang
0f0df91430 pin-shortcut: Make single recent task pinnable from taskbar
With this change, we can now using long-press menu to pin a single
task to the taskbar.

Note that some of the code in this cl is filtered by the flag.

Bug: 375648361
Test: Adding in the next cl
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: Id0f2a9dce03a6c94da2cf8bd0deffd4c48656a7a
2025-03-26 00:49:27 +00:00
Shamali P
258d1297fe Add a useCase to get the remaining app time rounded down to minutes
The flag will be applied at the code using this use case.

Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
2025-03-25 23:50:20 +00:00
Shamali P
24ba38b393 Add a repository to fetch the remaining time for DWB
The usage of this chain will be flagged

Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
2025-03-25 23:41:46 +00:00
Treehugger Robot
be8869060d Merge "Use up-to-date hover tooltip text for recents." into main 2025-03-25 14:28:16 -07:00
Jagrut Desai
64d448a8db Fix Taskbar Flicker with Recents or Running Apps Present
Test: Manual, Presubmit
Bug: 404772481
Flag: EXEMPT bugfix
Change-Id: If3b87474e6e85fabf24a42ac2a3e4ac6a19a4358
2025-03-25 14:16:12 -07:00
minch
1b3daa918e Handling for an empty desk
Bug: 401582344
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I60960277f22196050491b152ea7e9476f4f70bb9
2025-03-24 20:17:44 +00:00
minch
956a9e0abb Pass displayId to CachedTaskInfo when needed
Bug: 401582344
Flag: EXEMPT refactor
Test: m
Change-Id: Id930db727dd0072ab5be04ae4272dc68c8b6dcb3
2025-03-24 16:18:09 +00:00
minch
fba9726258 Introduce TopTaskTracker.getPlaceholderGroupedTaskInfo
This CL just introduces an API inside TopTaskTracker to return
a GroupedTaskInfo, no existing logic being migrated to it yet.

It will be used to replace `getPlaceholderTasks` and
`getSplitPlaceholderTasks` in the follow-up cls.

Bug: 401582344
Flag: EXEMPT, introduce a new API without usage
Test: m
Change-Id: Ic12003833605582d191c4abfd4a0878c266dd30f
2025-03-22 05:22:05 +00:00
Alex Chau
df6dc455a7 Merge changes from topic "revert_task_content_view" into main
* changes:
  Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
  Revert "Remove redundant FrameLayout from task_header_view.xml"
2025-03-21 04:14:36 -07:00
Treehugger Robot
00310cd372 Merge "Get top task per display from TopTaskTracker" into main 2025-03-20 12:19:06 -07:00
Schneider Victor-tulias
f30a5e3cce Merge changes Id10bb2ac,Ie8edd55b into main
* changes:
  Have Taskbar listen for RecentsState as well
  Fix TaskarUIController being wrong with Overview-in-Window enabled
2025-03-20 10:09:18 -07:00
Will Osborn
7e3c0c2249 Get top task per display from TopTaskTracker
Test: locally tested on tablet
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402362465
Change-Id: I0eb66c5c931fe30ce954657ee1b0eb2d87e58943
2025-03-20 16:40:28 +00:00
Uwais Ashraf
bbe63db85c Merge changes from topic "cleanup-existing-update-disabled-flags" into main
* changes:
  Remove existing superceded calls to updateDisableFlags
  Change actions view disabling logic
2025-03-20 07:00:19 -07:00
Alex Chau
77ddc254cc Revert "Add TaskContentView parent to TaskThumbnailViewHeader and TTV"
This reverts commit e0cc96df62.

Reason for revert: b/403826044, b/402277471

Flag: EXEMPT revert

Change-Id: I0c6e507753bf47be4f74b6056de75d981f0c2848
2025-03-20 04:45:52 -07:00
Alex Chau
7034889756 Revert "Remove redundant FrameLayout from task_header_view.xml"
Revert submission 32215257-b/401469907-remove-redundant-headerview-layout

Reason for revert: b/403826044, b/402277471

Reverted changes: /q/submissionid:32215257-b/401469907-remove-redundant-headerview-layout

Change-Id: I5c619179c849f8b65484937ed0c37623612316f8
2025-03-20 11:11:00 +00:00
Tony Wickham
81469da43b Have Taskbar listen for RecentsState as well
Also update parallel animation to GestureEndState instead of
assuming it's always a LauncherState.

Fixes: 401382426
Test: manual/existing automated tests
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Id10bb2ac5601462a3885d24d6484889ddfeb59d6
2025-03-19 11:59:54 -07:00
Brian Isganitis
c0a8f7ea99 Implement spring animations for running state changes.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 402683858
Test: go/testedequals
Change-Id: Icc4a3a61b6c0997564a4dcdd8eb7768459d5f2ef
2025-03-19 14:34:13 -04:00
Brian Isganitis
e8b7cd7b2e Use up-to-date hover tooltip text for recents.
Flag: EXEMPT bugfix
Fix: 402776493
Test: go/testedequals
Change-Id: I6f438ce8b3cd51beaece0cf6734876f21719bf3d
2025-03-19 14:26:25 -04:00
Uwais Ashraf
7fd33ebde5 Change actions view disabling logic
1. Introduces "central task" - the task relating to the actions view
2. Decouple the overlay and actions view
3. Undo filter of taskViewType == SINGLE for overlay as it can be enabled for split tasks as well

Bug: 402351284
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: OverviewImageTest (attached abtd run)
Test: OverviewMenuImageTest (attached abtd run)
Change-Id: Id7bc5c9c6620183d91e99d9dc5d2980eb8e3ec36
2025-03-19 18:03:52 +00:00
Uwais Ashraf
376885f8ba Merge "Remove BubbleBarViewAnimatorTest from deviceless suite." into main 2025-03-19 09:26:30 -07:00
Uwais Ashraf
6aa9820532 Remove BubbleBarViewAnimatorTest from deviceless suite.
This test is the leading cause of flakiness for the entire suite.

Bug: 404773413
Flag: EXEMPT test-only
Test: BubbleBarViewAnimatorTest
Change-Id: I7c5658ad55aa0e959e068e5979325d1c41d18310
2025-03-19 12:41:19 +00:00
Tony Wickham
1588bb1a57 Merge changes I1b67d065,Ib2e7f859 into main
* changes:
  Don't show hover tooltip while an app popup is open
  Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
2025-03-18 11:38:05 -07:00
Treehugger Robot
e5cebbd9ca Merge "Do not notify desk mode changes on visible desk tasks count changes" into main 2025-03-17 18:29:02 -07:00
Tony Wickham
88a9e18f7c Don't show hover tooltip while an app popup is open
Flag: EXEMPT bugfix
Test: TaskbarHoverToolTipControllerTest
Fixes: 397243128
Change-Id: I1b67d065e9e79e13a5a341a5d133da700ef5f40c
2025-03-17 22:36:27 +00:00
Tony Wickham
131c68b11b Migrate TaskbarHoverToolTipControllerTest to use TaskbarUnitTestRule
This means we are now testing real objects instead of mocks

Test: TaskbarHoverToolTipControllerTest
Fixes: 346394827
Flag: EXEMPT bugfix
Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
2025-03-17 22:34:32 +00:00
Shamali Patwa
fedb2319af Merge "Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call" into main 2025-03-17 11:19:13 -07:00
Shamali P
56dd87a584 Use new PreviewPositionHelper for each GetThumbnailPositionUseCase call
It is now injected via a factory so a new instance is used each time.

Bug: 399641570
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: Iee703f0c954c95599c07ceb788edabb0d808abb2
2025-03-17 14:41:53 +00:00
Treehugger Robot
dee6dd8bb7 Merge "Make OverviewCommandHelper commands and OverviewCommandHelperTest display-aware" into main 2025-03-14 13:18:28 -07:00
Will Osborn
69a9346b07 Make OverviewCommandHelper commands and OverviewCommandHelperTest display-aware
Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 397942185
Change-Id: Ib2c3b2662413d15926215c18421168e93ce2b117
2025-03-14 17:55:20 +00:00
minch
c48f662c7d Do not notify desk mode changes on visible desk tasks count changes
1. Trigger `notifyIsInDesktopModeChanged` on
   `visibleDesktopTasksCount` changes only when the multi-desks
   flags are disabled.
2. Make `DesktopVisibilityController.isInDesktopMode` variable
   private and legacy, which should only be used when the multi-desks
   feature is disabled. All the call sites should go to check
   `DesktopVisibilityController.isInDesktopMode(displayId)`, which
    works both with and without the multi-desks feature enabled.

Bug: 402222877
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I291e2be6d99e81b0c918ae7f39c17a8cd4ea0918
2025-03-14 15:21:19 +00:00