Commit Graph

6908 Commits

Author SHA1 Message Date
Vinit Nayak
f4e7e5aaf4 Add overview taskbar split support for 3P launcher
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers

Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
2023-02-15 11:26:06 -08:00
Nicolò Mazzucato
5147b1d509 Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev 2023-02-11 09:24:42 +00:00
Nicolo' Mazzucato
8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Schneider Victor-tulias
301433c11a Merge "Reorganize ActiveGestureLogs for ease-of-use" into tm-qpr-dev 2023-02-10 22:01:57 +00:00
Ats Jenk
90d0019447 Merge "Add icon to desktop tile in overview" into tm-qpr-dev 2023-02-10 21:47:31 +00:00
Lucas Silva
bc333343ec Merge "Allow QuickstepTransitionManager to be overridden" into tm-qpr-dev 2023-02-10 20:47:27 +00:00
Ats Jenk
78b614f555 Add icon to desktop tile in overview
Copied over icon from caption desktop button in WMShell. Temporary icon
for now.
Refactored some logic in TaskView to better support for custom
orientation handling in subclasses. Subclasses can override setting
orientation for icon or thumbnail.

Bug: 267326722
Test: manual, enable desktop windowing proto 2 and go to overview
Change-Id: Id66d48fa52a418a07b954a384b2c3ea22f091b1f
2023-02-10 10:16:31 -08:00
Sunny Goyal
c424941565 Merge "Updating Drawables as per GraphicsUtils changes" into tm-qpr-dev 2023-02-10 16:46:19 +00:00
Lucas Silva
099341fa97 Allow QuickstepTransitionManager to be overridden
This allows for custom animations in classes inheriting from
QuickstepLauncher

Bug: 260637266
Test: flashed device and verified animation
Change-Id: I21fa112851e9ce43037151fc4c2fd21e90056712
2023-02-10 10:41:39 -05:00
Luca Zuccarini
527679d258 Merge "Disable splash icon when launching a search result." into tm-qpr-dev 2023-02-10 12:20:53 +00:00
Sunny Goyal
799e12077b Updating Drawables as per GraphicsUtils changes
Bug: 266661614
Test: Presubmit
Change-Id: Ia3d0e0bc7a2b019d234e3bca71e893d5c4c54ca8
2023-02-09 16:14:04 -08:00
Ats Jenk
05abfa49c8 Merge "Fix invoking transient taskbar in desktop windowing prototypes" into tm-qpr-dev 2023-02-09 21:09:43 +00:00
TreeHugger Robot
f5f3a80959 Merge "Refresh thumbnail splash when task icon changes." into tm-qpr-dev 2023-02-09 16:29:50 +00:00
Brandon Dayauon
f4437f742e Merge "Implement diff haptics going into all apps" into tm-qpr-dev 2023-02-09 00:45:24 +00:00
Ats Jenk
d9f6d4e31c Fix invoking transient taskbar in desktop windowing prototypes
When transient taskbar is invoked, it starts the recents animation.
Recents animation triggers the launch of launcher activity. We need to
ensure that after recents animation is cancelled (since the gesture was
only for taskbar), we bring the desktop tasks back to front.

When the transient taskbar gesture finishes, we need to ensure that
launcher state is restored to normal. With fullscreen tasks, launcher
activity in stopped after gesture finishes as a fullscreen task is on
top. This stop triggers the launcher state to return to normal.
When freeform tasks are visible on top of launcher, launcher activity is
not stopped. This means we have to manually move launcher to normal
state after transient taskbar gesture finishes.

Bug: 267364407
Test: enable proto 1, switch to desktop mode and open some tasks, swipe
  up for transient taskbar, swipe up to recents view
Test: enable proto 2, move a task to desktop, swipe up for transient
  taskbar, swipe up to recents view
Change-Id: I712bc5086407c26779638d824f34674f7db1ff51
2023-02-08 15:16:43 -08:00
Saumya Prakash
a184e0def7 Merge "Migrate from using CardViews to Views in gesture nav tutorial layouts." into tm-qpr-dev 2023-02-08 23:02:04 +00:00
Schneider Victor-tulias
0a184a9981 Reorganize ActiveGestureLogs for ease-of-use
Fixes: 268382209
Test: completed several gestures and checked the logs
Change-Id: Ic08bfc553a39bda7401f6565ce5553933dbc0689
2023-02-08 13:37:49 -08:00
Saumya Prakash
c65f37e7c6 Migrate from using CardViews to Views in gesture nav tutorial layouts.
Use Views in layouts for the gesture navigation tutorial instead of CardViews. We only migrate the classes that will end up being used in the redesigned gesture tutorial.

Fix: 268259319
Test: Manual
Change-Id: I510c8b3f840d0267dd6dfca573cc69c4996d525c
2023-02-08 19:28:05 +00:00
Pat Manning
97ef7f0052 Refresh thumbnail splash when task icon changes.
This is usually a result of TaskIconCache updating in the background.

Fix: 267744363
Test: manual.
Change-Id: I83620f3774def7ffb07906a6d45b64e9aad6de71
2023-02-08 16:41:17 +00:00
Jerry Chang
ab314be1e4 Merge "Support entering split screen with a shortcut and an intent" into tm-qpr-dev 2023-02-08 07:46:50 +00:00
Jerry Chang
7c59ccac02 Support entering split screen with a shortcut and an intent
Starting a split pair by indicating (shortcut|shortcut) or
(shortcut|intent) was not properly supported, update to leverage
startIntens flow to handle shortcut info when starting a split pair.

Fix: 265919000
Test: repro steps of the bug
Change-Id: I9afcd6f3cdfb5530c1b440a9c0ade8c9952a5fff
2023-02-08 03:27:41 +00:00
TreeHugger Robot
96328e98d1 Merge "Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag." into tm-qpr-dev 2023-02-07 21:03:18 +00:00
TreeHugger Robot
71a7a13f06 Merge "Rotate back button drawable when IME present." into tm-qpr-dev 2023-02-07 20:32:31 +00:00
Brandon Dayauon
12c193e6c5 Implement diff haptics going into all apps
Notes:
* the reason why 0.6 -> 1 never happened was because of AllAppsSwipeController where
it had a clampToProgress. By changing lowerbound to 0 the progress actually shows fully 0->1

- composed the haptics in the constructor
- added new listener class in AATransitionController

Added featureflag

bug: 233751149
test: Manually - presubmit, ran “make -j7 Launcher3” from master branch  photo: https://screenshot.googleplex.com/8r5FZh6buzkQMjk
Change-Id: I5e1a24170fdbfdd35b8d8f24af0ec5e8586641a2
2023-02-07 11:36:42 -08:00
Pat Manning
e68ae41196 Rotate back button drawable when IME present.
Currently rotation for IME rotates the whole view, including the background.

Fix: 266874111
Test: manual.
Change-Id: Iea310c99d0714d98ce534a0170316a0fb351f57d
2023-02-07 17:55:59 +00:00
Jon Miranda
24bd17f23d Remove ENABLE_TASKBAR_REVISED_THRESHOLDS feature flag.
Test: manual
Fixes: 268056334
Change-Id: Iab0eb1ca76b49f0acb96f50274cb2c81d9f213a5
2023-02-07 09:09:52 -08:00
Vinit Nayak
678abecaa0 Merge "Set StateManager to BackgroundAppState if end gesture is NEW_TASK" into tm-qpr-dev 2023-02-06 22:07:36 +00:00
Ats Jenk
b759d55a50 Merge "Pin desktop tile to the right in overview" into tm-qpr-dev 2023-02-06 20:01:24 +00:00
Vinit Nayak
05dbd1aab8 Merge "Rename LauncherState QUICK_SWITCH to QUICK_SWITCH_FROM_HOME" into tm-qpr-dev 2023-02-06 18:59:47 +00:00
Ats Jenk
a9a99a4748 Merge "Remove desktop tile from proto 1 of desktop windowing" into tm-qpr-dev 2023-02-06 17:59:32 +00:00
Jeremy Sim
507c3edef6 Merge "Refactor getIndexOfTask() to getTaskAttributesById()" into tm-qpr-dev 2023-02-06 03:16:24 +00:00
Jon Miranda
ea134a109d Merge "Crop taskbar icons during stash/unstash animation." into tm-qpr-dev 2023-02-04 04:05:27 +00:00
Hongwei Wang
bfcdd23597 Merge "Implement app icon overlay for entering PiP" into tm-qpr-dev 2023-02-04 03:11:00 +00:00
Ats Jenk
6f50ca34c4 Pin desktop tile to the right in overview
When desktop windowing prototype is enabled, pin desktop tile to the
right of the focused tile.
Also making desktop tile persistent so it will always show up,
regardless whether there are tasks added to the desktop or not.
Fixing some nullpointer issues that stem from that.

Bug: 261234155
Test: no recent tasks, go to overview, shows empty view
Test: only desktop tasks, go to overview from home, desktop tile focused
Test: only desktop tasks, desktop open, go to overview, desktop tile
  focused
Test: 1 fullscreen task and some desktop tasks, go to overview from home
  screen, fullscreen tile focused
Test: fullscreen task open and no desktop tasks, go to overview,
  fullscreen task focused and empty desktop tile on the right
Test: fullscreen task open and some desktop tasks in background, go to
  overview, fullscreen tile focused, desktop tile on the right
Test: some desktop tasks focused, some fullscreen tasks in background,
  go to overview, desktop tile focused, fullscreen tasks on the left

Change-Id: Ib28185b40f639d36b82b6d0e3c61026ec84e245c
2023-02-03 17:29:43 -08:00
Brian Isganitis
d98de99af8 Merge "Support persistent/transient asset variants in EDU tooltip." into tm-qpr-dev 2023-02-03 23:24:58 +00:00
Jon Miranda
11b47c542e Crop taskbar icons during stash/unstash animation.
When we stash, we crop the taskbar icons to the height of the
stashed handle.

In a follow up CL we will translate the icons so that at the
end of the stash animation, the icons will overlap with the
stashed handle for a more seamless handoff.

This will be good to get in first so that we can see if there is
any performance regression by running multiple outline
animations at the same time.

Test: stash/unstash observe cropping
Bug: 267806083
Change-Id: I19b05647a669c11376ac1d3267fd600131246be8
2023-02-03 15:14:42 -08:00
Vinit Nayak
4b76e9123f Set StateManager to BackgroundAppState if end gesture is NEW_TASK
* QUICK_SWITCH_FROM_HOME was incorrectly used as that LauncherState
is only meant for quickswitching for the most recent task from
workspace

Bug: 265734073
Test: Tested quickswitch with fullscreen and splitscreen tasks
Change-Id: Ia81152927f57203cf6adb90254675bcf82a2e836
2023-02-03 14:16:09 -08:00
Vinit Nayak
82b8aa561a Rename LauncherState QUICK_SWITCH to QUICK_SWITCH_FROM_HOME
Test: compiles
Bug: 265734073
Change-Id: I38e23c62b1eeae6a26db9c388655a8ffceb025b6
2023-02-03 10:38:21 -08:00
Winson Chung
537c380bcb Merge "Revert "Include SysUI state in stashing check"" into tm-qpr-dev 2023-02-03 18:02:17 +00:00
Tony Wickham
632e9a84c4 Merge "Don't applyState if taskbar is already destroyed" into tm-qpr-dev 2023-02-03 17:55:30 +00:00
Pat Manning
cbedc7ed08 Merge "Move overview actions to task menu when no focused task." into tm-qpr-dev 2023-02-03 13:51:54 +00:00
Luca Zuccarini
3be7449605 Disable splash icon when launching a search result.
Bug: 262751986
Test: manual, see videos in bug
Change-Id: I58888ee58f3e02541bcdf6b3e775a2dc077a30b7
2023-02-03 11:49:11 +00:00
Vinit Nayak
6fa1ab9441 Merge "Unify split options into single option" into tm-qpr-dev 2023-02-03 06:07:41 +00:00
Vinit Nayak
c1799a8221 Merge "Set StateManager to BackgroundAppState if end gesture is LAST_TASK" into tm-qpr-dev 2023-02-03 06:05:22 +00:00
Jon Miranda
554c431d40 Merge "Iterative improvement to the taskbar stash animation." into tm-qpr-dev 2023-02-03 02:39:10 +00:00
Jon Miranda
5903751ee3 Merge "Update notification dot renderer when we update the taskbar icon size." into tm-qpr-dev 2023-02-03 01:34:05 +00:00
Tony Wickham
9fb8883017 Don't applyState if taskbar is already destroyed
Test: Open overview while unfolded, then fold; ensure hotseat remains
visible
Fixes: 260135164

Change-Id: I788a9a682a7d5fabbea7c478231fc7abe92e95b9
2023-02-03 01:00:21 +00:00
Stefan Andonian
6a4e9a34ab Merge "Migrate "isRotationAllowed" setting to LauncherPrefs." into tm-qpr-dev 2023-02-03 00:27:14 +00:00
Jon Miranda
b1e85e9b70 Iterative improvement to the taskbar stash animation.
Test: manual
Bug: 246632728
Change-Id: I4e4051faaf699a462c90acf87afcee11a0b4165b
2023-02-02 23:52:23 +00:00
Winson Chung
0499f31aa5 Revert "Include SysUI state in stashing check"
This reverts commit 62c74f9633.

Reason for revert: b/267543857

Change-Id: Ifc2fc3abfc07c92acef560fd3eef7d799f3e28bf
2023-02-02 23:33:15 +00:00