Commit Graph

10392 Commits

Author SHA1 Message Date
Tracy Zhou
f3e5382042 Do not set isImmersive in TaskbarDelegate
allow_gesture and immersive_mode are opposite of each other, and currently we set one or another, check one or another in different places. We should consolidate the two. Hence, we are removing all references of immersive_mode (allow_gesture has more usages).

Bug: 313033827
Test: N/A
Change-Id: I52d86c37cb39ef0bc04a04a0fa78d2b051a0e56e
2023-12-10 21:18:22 -08:00
Jeremy Sim
d761f5c3bd Merge "App Pairs: Implement Taskbar functionality" into main 2023-12-09 02:20:45 +00:00
Vadim Tryshev
151751c014 Merge "Fixing non-sending wallpaper animation finish event" into main 2023-12-08 23:33:53 +00:00
Jeremy Sim
2987d95ba4 App Pairs: Implement Taskbar functionality
[App Pairs 8/?]

This CL adds taskbar functionality for app pairs:
- Ability to drag an app pair icon to Taskbar
- App pair launch from Home Taskbar
- App pair launch from Overview Taskbar
- App pair launch from in-app Taskbar

KNOWN ISSUES:
- Bug (b/315190686): if user is inside a running split pair and attempts to launch the same pair from an app pair icon on taskbar, Overview tiles get temporarily messed up (recoverable by leaving Overview)
- User can attempt to split with an app pair icon on the Taskbar. This should result in a "can't split with this" bounce animation on the SplitInstructionsView (to be implemented). Currently does nothing.

Bug: 274835596
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Test: Manual
Change-Id: I5256547af236fc2deeb192d60bfe1f2b7ddc5647
2023-12-08 15:07:45 -08:00
Saumya Prakash
55fdc45ecc Merge "Ensure Taskbar stashes when launching an app from folder" into main 2023-12-08 22:59:45 +00:00
Vinit Nayak
fe22e7fa4d Merge "Only launch from split taskView if it's visible to user" into main 2023-12-08 22:34:33 +00:00
Vadim Tryshev
3277cbdb17 Fixing non-sending wallpaper animation finish event
Wallpaper animation may be interrupted with an animation to go to Normal state.
Then the animation won't succeed, but it will still end.

Bug: 315074923
Flag: N/A
Test: presubmit
Change-Id: I15a106de78030f6935978539d333cc85ee95b4e7
2023-12-08 14:11:55 -08:00
Saumya Prakash
86285d477d Ensure Taskbar stashes when launching an app from folder
We use the folder closing callback to trigger a call to stash the
taskbar if an app was launched. We can check whether an app was launched
from a folder based on whether a folder's view is open when
an app is launched. This ensures that the taskbar only stashes after the
folder is done animating.

Flag: NA
Fix: 295296529
Test: Launched an app in a folder on taskbar. Also ensured that other
taskbar behavior remains unchanged.

Change-Id: Ib5a797186978ee960e44b6b62c833eead03bccd0
2023-12-08 20:16:15 +00:00
Vinit Nayak
14f3a795e1 Only launch from split taskView if it's visible to user
* Same logic that fullscreen tasks use to launch.
* If not on-screen it will use default fade in animation

Test: Repro-steps don't produce crash
Fixes: 313911097
Flag: None
Change-Id: I4ada7137bffc7c567e4f8184bdd65bdf9bad481e
2023-12-07 15:04:16 -08:00
William Leshner
5836cec7ec Merge "Show Launcher's widget picker in an activity." into main 2023-12-07 19:23:58 +00:00
Jagrut Desai
a473968d24 Merge "Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action" into main 2023-12-07 19:11:51 +00:00
Tony Wickham
1482ec384c Merge "Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support" into main 2023-12-07 19:11:07 +00:00
Greg Kaiser
d806c0abd1 Merge "Revert^3 "Refactor/clean up Overview Actions buttons"" into main 2023-12-07 14:06:19 +00:00
Greg Kaiser
e8b1d45485 Revert^3 "Refactor/clean up Overview Actions buttons"
6b99fe1a00

Change-Id: I8f4054335b7bdee898ce3943f4a3798ba51c6fbc
2023-12-07 13:54:39 +00:00
Andy Wickham
fa1b3bd05b Merge "Improve touch finished logging" into main 2023-12-06 23:01:19 +00:00
Tony Wickham
18551f29fe Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support
Flag: NA
Test: manual, TaplTestsTaskbar, TaplTestsPersistent, TaplTestsTransient
Fixes: 270395798
Change-Id: I4ecf5ddcd1206e846538175c684043c5e065fd5d
2023-12-06 22:13:10 +00:00
Vinit Nayak
5aac28a031 Merge "Revert^2 "Refactor/clean up Overview Actions buttons"" into main 2023-12-06 18:49:27 +00:00
Tony Wickham
5a26b1ce0f Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-06 18:06:44 +00:00
Sunny Goyal
0d152a5bf6 Merge "Revert "Revert "Removing unnecessary iconFactory class when gene..."" into main 2023-12-06 16:11:43 +00:00
Andreas Agvard
cad2f1ed9c Improve touch finished logging
Test: Manual
Bug: 314993218
Flag: N/A
Change-Id: I1cf827ed3125071b722c617c384350b53e57fac5
2023-12-06 15:52:57 +01:00
Vadim Tryshev
42476cc355 Merge "Waiting for wallpaper animation completion when configuring new widget" into main 2023-12-06 01:43:07 +00:00
Vinit Nayak
7b7dca38cb Merge "Pass through both the widget's pendingIntent and remoteView intent" into main 2023-12-06 01:24:05 +00:00
Jagrut Desai
66283595b9 Fixing/Adding Support for "Move to top/left" and "Move to bottom/right" Talkback Menu Item Action
Test: Manual
Bug: 307878012
Flag: NONE
Change-Id: I9d80c3c976193bfea911e1531ed180f4ee4aa8f5
2023-12-05 13:55:49 -08:00
Vadim Tryshev
61434924f0 Waiting for wallpaper animation completion when configuring new widget
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ice7ae8a2517d68c53d135a34cc33e11f3203f788
2023-12-05 13:32:41 -08:00
Will Leshner
9dce65e05a Show Launcher's widget picker in an activity.
Bug: 307306823
Test: atest Launcher3Tests
Flag: NA

Change-Id: I28ef731abcdf1bd44c66366d42a135912dbcc5be
2023-12-05 13:12:05 -08:00
Tony Wickham
d546564f3e Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ie7b8fcedb94e33742b7bf18cb829dab55af74b7d
2023-12-05 20:38:41 +00:00
Sunny Goyal
1aaa3aa795 Merge "Revert^3 "Changing SystemUiProxy to kotlin"" into main 2023-12-05 17:23:24 +00:00
Tracy Zhou
d4235f504b Merge "Do not apply rounded corner background to task bar when it's in phone mode" into main 2023-12-05 16:55:26 +00:00
Andreas Agvard
52b5113e8d Merge "Adds supportsCommitHaptic" into main 2023-12-05 12:48:15 +00:00
Johannes Gallmann
e8575dfbe9 Merge "Fix delayed taskbar animation for predictive back" into main 2023-12-05 12:37:30 +00:00
Jeremy Sim
6b99fe1a00 Revert^2 "Refactor/clean up Overview Actions buttons"
Second attempt after ag/25292769 was reverted (fixed the screenshot test failure)

Bug: 274835596
Test: atest OverviewImageTest#testOverview
Flag: NA
Change-Id: I3e442264e946b3a0979ca3e401b9ffd30671a291
2023-12-05 11:36:01 +00:00
Satish Yalla
b85266aef2 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-12-05 10:21:18 +00:00
Sunny Goyal
f002d014cd Revert^3 "Changing SystemUiProxy to kotlin"
b1e430bcb9

Change-Id: I67ed9f357da99119686f935252c8ab88416b56bd
2023-12-05 07:28:46 +00:00
Satish Yalla
de82f8f44f Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: I51e78699f588a8fe8506c96398de921448e0ab6a
2023-12-05 06:48:25 +00:00
Tracy Zhou
ec26a138d5 Do not apply rounded corner background to task bar when it's in phone mode
Fixes: 311428370
Test: Make sure nav bar in landscape phone mode doesn't have weird clips
Change-Id: I0c402dd10a3bd39afd5692d21ef8adaad04646db
2023-12-04 22:07:04 -08:00
Schneider Victor-tulias
dc4b61be59 Merge "Fix Keyboard quick switch screenshots and spliscreen launch" into main 2023-12-05 04:10:13 +00:00
Tony Wickham
2f334e9ca7 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-05 02:40:02 +00:00
Vadim Tryshev
dc7de0d9fb Merge "Waiting for Launcher activity to stop when starting an overview task" into main 2023-12-04 21:47:09 +00:00
Sunny Goyal
3de59f24a0 Revert "Revert "Removing unnecessary iconFactory class when gene..."
Revert submission 25518508-revert-25483550-themed-badge-GJNKEECDMN

Reason for revert: Fixed badging bug

Reverted changes: /q/submissionid:25518508-revert-25483550-themed-badge-GJNKEECDMN

Change-Id: I0f378eaabcb7bdea855b80a33bdec007c9b11436
2023-12-04 18:53:50 +00:00
Sunny Goyal
b1e430bcb9 Revert^2 "Changing SystemUiProxy to kotlin"
49997a7cf9

Change-Id: Ieed3f7ad7c9d36ee1c2fc53e0c03df34698c256d
2023-12-04 17:21:22 +00:00
Andreas Agvard
973c049fe0 Adds supportsCommitHaptic
Test: Manual
Bug: 314408519
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Change-Id: Ia8f90489c2b8d82f6c63b4b363f9be5de6b2598b
2023-12-02 11:04:51 +01:00
Vadim Tryshev
caf5958e57 Waiting for Launcher activity to stop when starting an overview task
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ie72853a9d289b2688fdfbdf5220ce86808ac2da1
2023-12-01 16:15:45 -08:00
Andreas Agvard
23de925836 Increase slider for haptic hint iterations
The haptic hint can now be made up to 200 itertions long (2.4 seconds)

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Change-Id: I9c92d3cb24fabfa3b0d318a77d312423501737a6
2023-12-01 21:16:14 +01:00
Andreas Agvard
ffa44902d4 Merge "Adds support for shrinking nav handle on press" into main 2023-12-01 20:14:03 +00:00
Vinit Nayak
717c4f51ff Merge "Remove unused animation of splitInstructionsView text" into main 2023-12-01 20:00:27 +00:00
Andreas Agvard
1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Pat Manning
bf6905c069 Merge "Navigate grid overview via arrows and tab properly." into main 2023-12-01 12:23:21 +00:00
Serdar Kocdemir
063858b510 Merge "Revert "Changing SystemUiProxy to kotlin"" into main 2023-12-01 12:04:59 +00:00
Pat Manning
e683c4c549 Navigate grid overview via arrows and tab properly.
Fix: 311646336
Fix: 281021558
Test: TaskGridNavHelperTest
Flag: N/A
Change-Id: Iad5a2eec22f8fa4519a6a1f7bcde097e00d6b142
2023-12-01 11:06:41 +00:00
Surajit Chandra
49997a7cf9 Revert "Changing SystemUiProxy to kotlin"
Revert submission 25509210-proxy-kotlin

Reason for revert: test revert b/314219394
Reverted changes: /q/submissionid:25509210-proxy-kotlin

Change-Id: I3ada33461886ba2428b6b768cacc0d5454d543a3
2023-12-01 08:27:16 +00:00