Commit Graph

560 Commits

Author SHA1 Message Date
vadimt
bfac8730fe Improving TAPL messaging
Test: presubmit
Bug: 187761685
Change-Id: I83eb0eef2f9c8c33cc9d1b42cb52fb670a5bf427
2021-05-20 15:48:29 -07:00
vadimt
e2801bcb77 Removing pss checks in memory tests
Test: presubmit
Bug: 185181057
Change-Id: I4f504f9540b80c62cd3f1024ff1d1b57102f2ed6
2021-05-12 18:57:55 -07:00
TreeHugger Robot
39228d0325 Merge "Improving TAPL error messages" into sc-dev 2021-05-12 19:10:34 +00:00
Winson Chung
d193f65878 Merge "Use testapi to trigger gc in system and sysui" into sc-dev 2021-05-11 05:02:37 +00:00
vadimt
a6cb751715 Improving TAPL error messages
Test: forrest
Bug: 187761685
Change-Id: I822f3f28e7153028fb5746e037066153478ec86d
2021-05-10 17:50:41 -07:00
vadimt
eefc2e1de1 Diagnosing only system health problems happened during the test
Test: presubmit
Bug: 187761685
Change-Id: I3feba12e2228fe6dda3b0d65d904b0b839da2108
2021-05-11 00:31:24 +00:00
Winson Chung
b09a41d86c Use testapi to trigger gc in system and sysui
- Do this prior to gc'ing launcher to ensure that temporary binder
  refs on the system side a released

Bug: 186268407
Test: Presubmit

Change-Id: I7878e1042b07ded5491af6153cff9b0772c557db
2021-05-10 13:00:37 -07:00
TreeHugger Robot
60f6662fa3 Merge "Temporary wait to check that waiting after swiping from context menu is a way to the real fix." into sc-dev 2021-05-04 03:18:07 +00:00
vadimt
e9ce95bed8 Temporary wait to check that waiting after swiping from context menu is a way to the real fix.
Test: presubmit
Bug: 187080582
Change-Id: Ief09857c267e8786bb6f67203db26b47f27060ea
2021-05-03 19:05:35 -07:00
Alina Zaidi
2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
TreeHugger Robot
0d51bc3caa Merge "Better diags when Launcher is manipulated on the locked phone" into sc-dev 2021-04-22 13:22:05 +00:00
vadimt
4c6722ede5 Better diags when Launcher is manipulated on the locked phone
Test: presubmit
Bug: 185395995
Change-Id: I9a7e0bda47851ce186adc15838f9ace9a2c8195a
2021-04-20 19:38:46 -07:00
Steven Ng
8c8d99f966 Fix flaky widget tapl tests
Potential issues:
1. Widgets floating tips view is being shown
2. Header visible height is too small to be considered as a scroll
   gesture

Test: Run AddConfigWidgetTest, AddWidgetTest, BindWidgetTest &
      RequestPinItemTest
Bug: 185733371
Change-Id: Ic3e9188724dd920349ce8d8e8d98392b94b40642
2021-04-20 23:01:19 +01:00
vadimt
6a562d8cbe Waiting for NexusLauncher to go away after swiping up from menu
Swiping up can temporarily bring Nexus Launcher if the
current launcher is a Launcher3 one. Wait for the
current launcher to reappear.

Test: presubmit
Bug: 183615088
Change-Id: Iff6eaf3bf27f7ddca445fab86780f8cf82f97352
2021-04-13 11:22:03 -07:00
Zak Cohen
b391ebf798 TAPL Increase size of Background to Overview swipe gesture
The instrumentation is using the swipe height, not width, for when in
landscape. Ideally this should be plumbed through but it isn't yet so fix
with a bigger gesture.

Test: TaplTestNexus#testBackground
Bug: 184059820
Change-Id: Id19f65f51468af707baea0a1b31569bb84f7fcb8
2021-03-31 15:10:21 -07:00
Steven Ng
26a9df6046 Fix AddWidgetTest & AddWidgetConfigTest
Simplify the scrolling by a scroll down a smaller fixed distance. This
way we don't need to scroll back-n-forth in order to handle the
overlapping of the search bar and the targeted widget.

Test: run AddWidgetTest & AddWidgetConfigTest

Bug: 183616605
Change-Id: Icc72f4ba6c61bdb95ab5eaf22600407d59d14eba
2021-03-25 20:57:13 +00:00
Steven Ng
6c5e02ac27 Fix scrolling in widgets picker tapl tests
If the search bar and the target widget item intersect, scroll up to
make the target widget item clickable.

Test: run AddWidgetTest, AddConfigWidgetTest

Bug: 183403949
Change-Id: I847cc34757cb02b1a12e18e511fda749873ad5da
2021-03-24 00:01:53 +00:00
Steven Ng
682af23651 Merge "Renders widget recommendations" into sc-dev 2021-03-19 23:18:22 +00:00
Steven Ng
4235fc129c Renders widget recommendations
Update the tapl test logic to scroll a smaller distance to avoid the
search bar blocking the target touch area.

Test: Open full widgets sheet and observe the widget recommendations
      shown at the top.
      Run AddConfigWidgetTest

Bug: 179797520

Change-Id: I6d53bbb46e2cb928ed7d015aaac604be17d33178
2021-03-19 21:11:32 +00:00
TreeHugger Robot
bab908bfca Merge "Disable waiting for animation from event injection" into sc-dev 2021-03-19 20:24:54 +00:00
Sunny Goyal
c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Vadim Tryshev
f4cacd720c Merge "Fixing Launcher3 tests" into sc-dev 2021-03-15 17:47:05 +00:00
vadimt
730b9d60a4 Fixing Launcher3 tests
Adding an atest config.
Correctly calculating display height.
Allowing scrolling from a partially visible bottom row in AllApps

Test: presubmit
Bug: 182006150
Change-Id: I5f3b976ac05ed1c2e1ffbb67cc6db0c0ee13ae6c
2021-03-12 15:11:34 -08:00
vadimt
288960b5ba Disable waiting for animation from event injection
This will avoid taking locks from it,
and stop TAPL from introducing jank under lock contention.

Bug: 173469230
Test: presubmit
Change-Id: Ifeba2dc7528b573ffaba2aa94dfdae6b8a14a7b3
2021-03-11 19:11:19 -08:00
vadimt
368dc79f55 Increase wait times in TAPL
This helps to avoid misleading errors when
the system has performance problems.

Test: presubmit
Bug: 179392551
Change-Id: I4de3c543f32f41af64bd6107885df82b03973d35
2021-03-10 12:19:12 -08:00
TreeHugger Robot
d3b82a2471 Merge "Log a bit more data in switchToAllApps()" into sc-dev 2021-02-27 03:15:24 +00:00
Tony Wickham
4faa87c478 Log a bit more data in switchToAllApps()
Test: TaplTestsQuickstep.testWorkspaceSwitchToAllApps
Bug: 181122114
Change-Id: Ice5515f5b3ac87c42af42d946036505879deb235
2021-02-26 16:25:35 -08:00
Vadim Tryshev
e1ea6cf754 Merge "Waiting for the state of views to settle after orientation change" into sc-dev 2021-02-26 19:37:06 +00:00
TreeHugger Robot
47603e4e69 Merge "Diagnosing expected selector in app-start" into sc-dev 2021-02-26 19:28:44 +00:00
vadimt
6e2a8e86df Diagnosing expected selector in app-start
Test: manual
Bug: 179392551
Change-Id: I4c7173e784caaa6435927f94eef6b269884d0ce9
2021-02-25 19:32:41 -08:00
vadimt
5f21f104f0 Waiting for the state of views to settle after orientation change
Presumably, we currently have flakes when immediately
after orientation change, we check for the presence of certain
views, and they are still not present.

Test: presubmit
Bug: 181057446
Change-Id: I6dbcb757a47c19728d4096283da6710f6dd5aa02
2021-02-25 18:50:49 -08:00
Steven Ng
e8d92342fa Replace horizontal ScrollViews with tables in the full widgets picker
Test: Run gnl test, AddWidgetTest
      Run Robolectric tests for widgets
      Manual test video: https://drive.google.com/file/d/1uwCtVNIlC9150kv5eEfILfP5r5M7ARYm/view?usp=sharing

Bug: 179797520
Change-Id: I2f4cdf84338a91b63967879d0c9268c312ace19b
2021-02-24 19:49:15 +00:00
Steven Ng
391404fcb7 Add personal / work tabs for work profile widgets
Video: https://drive.google.com/file/d/1TORRNcvVM7fIvNd_WZaajLbI7D9z4VFA/view?usp=sharing


Test: Main profile only: run AddConfigWidgetTest.
      With work profile: manually launch the full widgets sheet.
      Go to the personal tab: only personal widgets are shown.
      Go to the work tab: only work widgets are shown
      Successfully add personal / work widgets from the full widgets
      sheet.

Bug: 179797520

Change-Id: Iad8b90c2af35e0580319d7a05510ec88e4f8b86c
2021-02-22 16:10:09 +00:00
Steven Ng
e92bc55d12 Make all widgets collapsed in the full widget picker by default
Changes:
1. Add a WidgetListHeader view for showing icon, app name and a subtitle.
2. Only WidgetListHeaders are always visible to users in the full widget
   picker.
3. Only one widgets list from an app is visible in the full widget picker
   at any one time.

Test: Auto: run add robolectric tests under widget/picker
      Manual: Open full widgets picker. Then, expand and collapse apps.
      Video: https://drive.google.com/file/d/1gzfeEm5IOAu0qHsO77OTS2eMfU7CHJiL/view?usp=sharing

Bug: 179797520
Change-Id: Idac58be23dfeafcb79b3c61b4972d3addb462de1
2021-02-15 17:46:38 +00:00
vadimt
ed86cb19bc Adding debug tracing for Device.wait
I suspect it may wait for a period of time less than
the specified one, causing flakes.

Test: presubmit
Bug: 177318681
Change-Id: I0be8790c6ee9a5831767fe83c36054ed5a84f8d7
2021-01-15 13:58:03 -08:00
Sunny Goyal
9b1e77377b Removing shelf from 2-button gesture mode
Test: Manual
Bug: 175137718
Change-Id: Ifb64b4dcac53252aefa8ee0bd6434f90f1d868b7
2021-01-05 19:07:21 +00:00
Ice Chang
feb22118bf Merge "Add swipes left method in Background.java" 2020-12-12 16:33:16 +00:00
icechang
212cff1dec Add swipes left method in Background.java
Bug: 153276032
Test: TF_GLOBAL_CONFIG=/google/src/cloud/<ldap>/<workspace>/google3/wireless/android/test_tools/forrest/configs/local-host-config.xml \
pts-tradefed run commandAndExit cuj/<testname> \
--primary-abi-only \
--log-level verbose --log-level-display verbose \
--wifi-network GoogleGuest

Test:

Change-Id: Ib1cbc609f47a547f173e8170f00af9e8bdfa77bb
2020-12-01 21:34:26 +08:00
vadimt
daa731f1fe Removing binder call from the gesture injection
This causes jank under lock contention stress.

Test: local
Bug: 173072373
Change-Id: I3a44e510254f6d651cedb91f72e1789ae97d9b67
2020-11-19 22:12:09 +00:00
vadimt
0ebbc18803 Removing tracing for a gone flake
Bug: 156044202
Change-Id: Ice142bb941fee7b731f46c2073fab17d83bbc871
2020-10-06 14:52:27 -07:00
Vadim Tryshev
c77a225faf Merge "Revert "Speed up tests by injecting input events asynchronously"" into ub-launcher3-master 2020-09-17 17:57:33 +00:00
Vadim Tryshev
7729447716 Revert "Speed up tests by injecting input events asynchronously"
This reverts commit 4c80053950.

Reason for revert: Broke tests

Change-Id: I3bd556b3127c0936b18a3fec8202b492d2ecb099
2020-09-17 17:15:08 +00:00
TreeHugger Robot
7144004c56 Merge "Speed up tests by injecting input events asynchronously" into ub-launcher3-master 2020-09-17 01:22:07 +00:00
Sreyas
46aba2a46e Adding content push button behind flag to OAV.
Tested: TaplTestsNexus:testOverviewActions()
Change-Id: I83bc6e5033e2292776c927fba363214f347e01ce
2020-09-10 12:59:55 -07:00
Tony Wickham
d844fe758c Remove ENABLE_OVERVIEW_ACTIONS flag, defaulting to true
We no longer support the "peeking" model where the shelf would
peek on motion pause from an app and overview would peek on motion
pause from home. Thus, removed/inlined the following:
- FlingAndHoldTouchController (merged into its sole subclass
  NoButtonNavbarToOverviewTouchController)
- ShelfPeekAnim
- OverviewPeekState

Change-Id: I066a3ad2636fde4786089c922b896bf1e03361fd
2020-08-14 15:58:29 -07:00
Adam Bookatz
2104d72b28 LauncherInstrumentation enables even when non-system user
Attempting to run a tapl test while the device is in a secondary user
currently fails because the test app doesn't get enabled for
this secondary user. We fix that (at least one issue with it) in this cl.

Test: make PlatformScenarioTests; adb root && adb install -r -g ${ANDROID_PRODUCT_OUT}/testcases/PlatformScenarioTests/$(get_build_var TARGET_ARCH)/PlatformScenarioTests.apk
adb shell am instrument -w -r -e class android.platform.test.scenario.chrome.OpenApp android.platform.test.scenario/androidx.test.runner.AndroidJUnitRunner
(Do this while the current user is SYSTEM as well as Guest)

Bug: 162454040
Change-Id: If6d8e545b41eb20e3fed2935c39069ce97d8b6cd
2020-08-07 22:51:38 +00:00
Raman Tenneti
ab98166c36 AOSP/Launcher3 - Update language to comply with Android's inclusive language guidance.
See https://source.android.com/setup/contribute/respectful-code for reference

BUG=161896447

Test: make and Presubmit verify.

Change-Id: I44e903046dd4cd9c7c07872fc56a8d552eb09522
2020-08-04 00:35:03 +00:00
TreeHugger Robot
707727b6ae Merge "Creating UI tests for overview action buttons." into ub-launcher3-rvc-qpr-dev am: bf84725855 am: 8c10f6801f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12242419

Change-Id: I3cd8c26f5e774c5d54683c21006060d2d19fdf19
2020-07-31 21:54:17 +00:00
Sreyas
bf103f16b1 Creating UI tests for overview action buttons.
Change-Id: Ie6298064a068dc978ca33fb64e1856c3ba2a8cb1
2020-07-31 13:20:08 -07:00
vadimt
e873a171f7 Expecting TYPE_WINDOW_STATE_CHANGED in quick switch
Bug: 142654442
Change-Id: I48c8d929952872e444d1a3f7a40721d8edcd8942
2020-07-30 15:08:34 -07:00