Commit Graph

813 Commits

Author SHA1 Message Date
Steven Ng
f375e8bebc Fix ripple effect shown when tapping an app row in widgets picker
Test: Open the full widgets and tap an app. Ripple effect is applied
      to the entire row rather than just on the arrow.
Bug: 188873069
Change-Id: Id77b2055f6bc31c12bb19e695ea44aeaff36c4a6
2021-05-24 16:32:56 +01:00
Sunny Goyal
d5500548dc Revert^2 "Moving taskbar lifecycle to TouchInteractionService"
430465a3d5
Bug: 187353581
Change-Id: I7b2280d16adfafd3e85ffc1d22e32d0c00d12b67
2021-05-21 07:05:02 +00:00
Steven Ng
b46428fcd9 Merge "Remove work profile badge from widget previews" into sc-dev 2021-05-20 23:42:50 +00:00
Kholoud Mohamed
430465a3d5 Revert "Moving taskbar lifecycle to TouchInteractionService"
This reverts commit e215fb730b.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/tests/view?invocationId=I13700009003387451&testResultId=TR89423459137251402, bug https://buganizer.corp.google.com/issues/188755902

Bug: 188755902
Change-Id: I4650136975b60f311499ee6ff5b27ab9a32d23d6
2021-05-20 13:32:05 +01:00
Steven Ng
f735c738ea Remove work profile badge from widget previews
Test: Check work profile badge no longer shown on work widget in the
      full and bottom widgets pickers.
Bug: 177675123
Change-Id: I0e5e32e18df832c1919749404094d68805c30556
2021-05-19 21:45:10 +01:00
Samuel Fufa
76b33404b5 [Search] Update all apps header protection
- Introduce spacing between header protection and search box
- introduce vertical padding for "personal | work" tab
- animate tab header protection color change when docking

Test: Manual
preview: https://drive.google.com/file/d/1eS4B7hcLExxCdjSp1IzBcziKm-9w87UR/view?usp=sharing&resourcekey=0--mtY6bCC9GJpFSUC8I5d6w
Bug: 184946772
Change-Id: I840af27c7557f1dffd7a15874aa09833514b4bb1
2021-05-18 17:14:14 -05:00
Samuel Fufa
b605d1d73c Merge "Fix header protection interactions" into sc-dev 2021-05-18 19:00:37 +00:00
Sunny Goyal
5bb515b6cc Merge "Moving taskbar lifecycle to TouchInteractionService" into sc-dev 2021-05-18 17:17:27 +00:00
Samuel Fufa
0a709374ae Fix header protection interactions
Bug: 184711608
Bug: 187790639
Preview: https://drive.google.com/file/d/1MDh71t8DQn0SxTQY3-GZTfIlGECQs_Kn/view?usp=sharing&resourcekey=0-ep9C3q9Meo8cQShVJqnKEw
Test: Manual
Change-Id: I9c939a894adc3e9cd1ed1beb7c11f9c2dd673824
2021-05-18 16:28:55 +00:00
Sunny Goyal
e215fb730b Moving taskbar lifecycle to TouchInteractionService
> Inflating taskbar views with a non-launcher window context
> Removing separate taskbar view in Launcher
> Handling taskbar icon clicks directly instead of going via launcher
> Fixing some relayouts during show/hide animation

Bug: 187353581
Test: Manual
Change-Id: Ia7d44acbb770bf0345922234b3daa5cc040a5843
2021-05-17 21:47:08 -07:00
TreeHugger Robot
162dca963c Merge "Fix all apps & widgets picker tabs ripple effect" into sc-dev 2021-05-18 03:07:01 +00:00
Steven Ng
33a328370b Fix all apps & widgets picker tabs ripple effect
Test: Switch between tabs in all apps & widgets picker
Bug: 188091348
Change-Id: I9d8aae33ffe11a0c19f166517be881e06cf6d6b0
2021-05-17 23:19:16 +01:00
Steven Ng
c47d8a027d Merge "Add a scrim underneath the top section of search & recommendation UI" into sc-dev 2021-05-17 17:51:41 +00:00
Alina Zaidi
f0e11cbbc3 Merge "Modify pin widget dialog open-close animation." into sc-dev 2021-05-17 16:51:50 +00:00
Alina Zaidi
d80cec62b4 Modify pin widget dialog open-close animation.
Pin widget sheet should open from bottom up and close on drag down.
Behaviour with navigation bar is similar to that of widgets bottom sheet.

Add a drag layer and reuse AbstractSlideInView for open-close
animation.

Test: Tested manually- opening, closing through dragging/ cancel button/
back button. Adding widget to screen by dragging/ add to home screen
button.
Bug: 186124244

Change-Id: I4b77d5bdd4ed1689b651847dfed69d19cafa7456
2021-05-14 17:59:50 +01:00
Steven Ng
3503e6fa25 Add a scrim underneath the top section of search & recommendation UI
Test: In the full widgets picker, scroll up. Recommended widgets are
      not visible behind the search bar when they overlap.
Bug: 188021019
Change-Id: I13144ad534c74393bb1b12c651e734bb8bee0bc2
2021-05-14 17:03:01 +01:00
Stevie Kideckel
5fc74c7f8f Add start to widget app name layout gravity
This fixes the alignment issue in RTL. Seems like the default is start
if layout_gravity isn't set, but if you set layout_gravity to
center_vertical, you need to explicitly set start or it will go to the
left.

Bug: 188147009
Test: validated locally and in AS layout preview
Change-Id: Ic4b4d7e6dfe03e1e6dd3ead5c3821e77261b4bb5
2021-05-14 12:37:44 +00:00
Alina Zaidi
3237236f26 Merge "Prevent cropping of personal/work tabs in full screen widget picker." into sc-dev 2021-05-12 17:13:50 +00:00
Hyunyoung Song
15df06d05e Merge "Fix white text on light accent color issue for all apps and widgets drawer" into sc-dev 2021-05-12 16:42:09 +00:00
Jonathan Miranda
d95aa5a5d7 Merge "Remove color extraction from popup arrow, add shadows." into sc-dev 2021-05-12 15:47:43 +00:00
Alina Zaidi
071665c89b Prevent cropping of personal/work tabs in full screen widget picker.
Bug: 187632869
Test: Tested manually
Change-Id: I39a43ed1efae5802ffdd5d79ad3cb1a50af38d62
2021-05-12 14:57:42 +01:00
Hyunyoung Song
3af62c1e25 Fix white text on light accent color issue for all apps and widgets drawer
Bug: 187857897
Bug: 185211063

Test: manual, see screenshot on the bug
Change-Id: Ie7461ce4724c15dafda35a5c533d9539a34d68ab
2021-05-12 00:42:11 -07:00
Jon Miranda
35c5477d5c Remove color extraction from popup arrow, add shadows.
Bug: 175329686
Bug: 187014675
Test: manual

Change-Id: I84a3f23b7a9ceef004a2b1b66e5f8a10585bd113
2021-05-11 17:35:01 -07:00
Alina Zaidi
042249ff59 Update colors in pin widget dialog, to be similar to widget bottom sheet.
Bug: 187374499
Test: Visually tested. Also tested using accessibility scanner.
Change-Id: I3be84dc394d312d03b97fe66b7e8214c4d8bef71
2021-05-11 17:47:48 +01:00
Samuel Fufa
f94540b28a Merge "[WorkProfile] Update work/personal tab to pills" into sc-dev 2021-05-06 23:33:06 +00:00
Steven Ng
57347bd6b7 Only show collapse handle when the bottom widgets picker is scrollable
Test: Go to contact bottom widgets picker. No collapse handle is
      shown because the content isn't scrollable. Go to Google calendar
      bottom widget picker. Collapse handle is hown because the content
      is scrollable.
Bug: 185134663
Change-Id: Ic6109c055a072aa1cf3521f829833fd5f4cece0f
2021-05-06 17:39:49 +01:00
Steven Ng
edfec2fc0b Fix scrolling issue in the full widgets picker
Before this change, the widgets recommendation table handles all the
touch events. The table doesn't distinguish a touch event from a scroll
event. This change forwards the motion event to the active recycler view.
If the recycler view doesn't handle the event, it will then forward the
event back to the view hierarchy.

Test: Open the full widgets picker, then start scrolling on the
      recommended widgets UI. The full widgets picker scrolls perfectly.
      Drag-n-drop a recommended widget
Bug: 186567644
Change-Id: I89d473179796c516d2394332dd75f8e9a1d8b388
2021-05-05 23:19:09 +01:00
Samuel Fufa
db9b483c02 [WorkProfile] Update work/personal tab to pills
Bug: 186857875
Test: Manual
Screenshot: https://screenshot.googleplex.com/89jD32tHqNkBUWb
Change-Id: Ia4bb91372896d8a53017e3eadbe985878ce7f0ec
2021-05-03 10:53:33 -05:00
TreeHugger Robot
51991a7333 Merge "Fix few A11y/ UI bugs for widget pickers" into sc-dev 2021-04-30 19:09:53 +00:00
TreeHugger Robot
ed40c7735e Merge "Correct "cropping" of widget picker's search bar" into sc-dev 2021-04-30 15:00:32 +00:00
Pierre Barbier de Reuille
0e092292fb Correct "cropping" of widget picker's search bar
To corrent, I added 1dp of bottom margin. Not doing this, the framework
ignores the dropped shadow due to the elevation when some text is
entered in the box, leading to the observed cropping.

Fix: 186722040
Test: Manually
Change-Id: I746a8f014197552416ed9c40e9736baf22794c5f
2021-04-30 14:30:37 +01:00
Alina Zaidi
c16c281305 Fix few A11y/ UI bugs for widget pickers
- Add a subtext in pin widget dialog informing users how to add widget
manually. This is not important for accessibility, as drag and drop is through an
action item for visually impaired users.
- Update search bar text hint color so that it passes accessibility test.

Bug: 182994384
Bug: 182993604
Test: Manually Tested using accessibility scanner app and talkback
Change-Id: I5a49d0bc3e5973b76c41b2a178af509e96a3cdd7
2021-04-30 13:30:03 +01:00
Alina Zaidi
b42513fbc5 Merge "Fix some bugs in widget pickers." into sc-dev 2021-04-30 09:19:07 +00:00
Alina Zaidi
2b5124ec41 Fix some bugs in widget pickers.
- Update color of Educational tip view contents. Background colorAccentSecondary
in NexusLauncher above S, colorAccent otherwise (b/185834169)
- Update widget picker search bar color and its text font and color. (b/186423026)
- Update button padding and text in pin widget picker. (b/182994384, b/183601584)

Bug: 185834169
Bug: 186423026
Bug: 182994384
Bug: 183601584
Test: Manually tested
Change-Id: I36cd3ed2285677d0c164db8f57f6c90a5f247982
2021-04-30 07:52:23 +01:00
Steven Ng
1777a1be4f Use widget picker color surface for WidgetsBottomSheet
Test: Launch widgets bottom sheet, search popup to confirm the expected
      background color is applied.
Bug: 183601302
Change-Id: I300a364605e00a0d8046a907a40f4cb797ec161e
2021-04-29 12:44:31 +01:00
TreeHugger Robot
222b4757f5 Merge "Allow Workspace Scrim to be colored per state" into sc-dev 2021-04-28 00:10:26 +00:00
Zak Cohen
4d35ac3020 Allow Workspace Scrim to be colored per state
Make it possible to set the color of workspace scrim to a different color
per state. Motivated by making Overview Scrim and All Apps scrims different
colors.

Bug: 186253733
Test: Local build and flash
Change-Id: Id7c38ce3c9173308eedfcb7592ececa7bd6bf220
2021-04-27 14:04:46 -07:00
Steven Ng
f4bd91f0ab Merge "Add a11y action for expand / collapse items in WidgetsFullSheet" into sc-dev 2021-04-27 16:28:11 +00:00
Steven Ng
fd68f757c8 Add a11y action for expand / collapse items in WidgetsFullSheet
Test: Enable talkback. When focusing on a collapsed item, it announces
      Collapsed "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Expand.
      Widgets are expanded.
      When focusing on an expanded item, it announces
      Expanded "App Name" "n widgets/shortcuts". Action available. Use
      tap with 3 fingers to view. 3 fingers tap > Action > Collapse.
      Widgets are collapsed.
Bug: 183120145
Change-Id: Ibbb6025b929c141aa9e2fd2c72dce314e8be837e
2021-04-27 16:28:00 +00:00
Cyrus Boadway
5f35ff021d Merge changes I65d2b1bc,I35bf9cb4 into sc-dev
* changes:
  Animate App Widget activity launch from Quickstep launchers
  Add a mechanism to temporarily defer App Widget updates
2021-04-27 10:17:00 +00:00
Cyrus Boadway
61110601f6 Animate App Widget activity launch from Quickstep launchers
Following the general pattern on icon launch animations, define a
'floating widget view' to represent the appearance of the app widget
through the launch animation.

The floating widget view separates the foreground and background
components of the LauncherAppWidgetHostView, which can be positioned
and animated separately.

The background (or placeholder if no background can be identified)
moves and grows from its original position and size to the launched
app's position and size.

The widget's foreground scales and moves to match, fading out to be
replaced with the app window.

Bug: 169042867
Test: manual
Change-Id: I65d2b1bc80275f9df460790720e13d1650093347
2021-04-27 08:31:49 +00:00
Steven Ng
c7d7410178 Include recommended widgets table vertical padding in the height estimation
Test: run AddWidgetTest, AddConfigWidgetTest
Bug: 186450511
Change-Id: If306b569058edb3edb3c741199e9c0d96a88f412
2021-04-26 22:19:58 +01:00
Alina Zaidi
b7f5ab04ad Fix few UI bugs in widget picker.
- Update colors for widget picker (b/184236316)
- Adjust padding according to mocks (b/184236316)
- Make sure view holders refresh corners in search mode. (b/185099541)
- Fix search bar shadow being cropped (b/183602001)

Bug: 184236316
Bug: 185099541
Bug: 183602001
Test: Manually tested
Change-Id: Ifa33e090cdf31c95db9c1145e623ef55c42dd52e
2021-04-26 16:48:14 +01:00
Alina Zaidi
df9582e559 Merge "Fix UI bugs for widget picker search." into sc-dev 2021-04-13 15:42:34 +00:00
Alina Zaidi
1ccd7efaf0 Fix UI bugs for widget picker search.
- Mirror search icon in RTL (b/184162989)
- Fix spacing between edit text and cancel button, to make it consistent
with space between search icon and edit text. (b/183602001)
- Scroll to top on every search result. (b/183602001)
- Fix keyboard overlap on orientation change. This is fixed by clearing
text on edit text differently (b/184048899)

Test: Manually tested
Bug: 184162989
Bug: 183602001
Bug: 184048899
Change-Id: I72ed51e1968a55a3105bd8b389d1bbd74d50d8af
2021-04-13 10:41:18 +01:00
Steven Ng
3691179041 Set width & height of app icons in all widgets tray to 48dp
Bug: 184877669
Test: Change the grid size and observe app icons in all widgets
      tray stay the same.
Change-Id: I856d5fada579474fffb6296d641fb686623ca2cc
2021-04-09 11:15:50 +01:00
Steven Ng
1b5e45acae Merge "Use a separate personal/work tabs layout for the widget picker" into sc-dev 2021-04-08 18:48:52 +00:00
Steven Ng
fd604ee7ae Use a separate personal/work tabs layout for the widget picker
1. Apps are feminine while widgets are masculine in some languages.
   We should use a different set of strings to ensure strings are
   translated with the right context.
2. We will be using a different theme for widget tabs. Let's keep
   the layout separate.

Bug: 184613311
Test: manual
Change-Id: I88df8ca6091e4b6ddf81f34f180a6ce2cada16e3
2021-04-08 11:14:24 +00:00
TreeHugger Robot
63c169561c Merge "Some cleanup in RecentsView" into sc-dev 2021-04-07 21:06:55 +00:00
Pierre Barbier de Reuille
ad41a56166 Stop trying to draw a view not attached to the view tree
The behavior of the framework when we try to do so is undefined. In our
case, it almost work, but no clipping is applied, which is a problem for
Android S (before that, widget couldn't use clipping in the first
place).

Instead of drawing the view through a drawable, this really add the view
and adds also a badge ImageView for badges instead of drawing them
indirectly.

Note that, temporarily, we have to re-allow drawing the view after it
has been attached, but the underlying framework bug being fixed, this
should be fine (I tested it and it really seems to be).

Bug: 183609936
Test: Using hand designed app (see bug)
Change-Id: I929ef8fc81c98c49406f2d940cd5efc28319886d
2021-04-07 15:51:43 +01:00