Commit Graph

350 Commits

Author SHA1 Message Date
Jagrut Desai
a26500b145 Remove Change Navigation Mode option for Taskbar Divider Popup Menu
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Merged-In: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
2023-08-18 16:57:08 +00:00
Jagrut Desai
579188aee0 Refactor taskbar divider view to IconButtonView
- Breakout CL part 1
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist refactoring of Taskbar Divider Line to be using IconButtonView.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I6719dd568986dce7cf9cdf0f287c3f079fd35ba6
2023-08-16 13:11:14 -07:00
Andy Wickham
bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Ivan Tkachenko
2de68329fd Merge "Bubble bar dismiss interaction" into udc-qpr-dev 2023-07-31 17:54:43 +00:00
Ivan Tkachenko
90a769d1d3 Bubble bar dismiss interaction
A single bubble and the bubble stack dismiss functionality is implemented using `BubbleDragController`. It attaches a touch listener to the corresponding views and handles gesture interactions.
* When the view is long clicked the dragging to dismiss interaction starts. It scales up the dragged view and presents the dismiss view in the bottom of the window.
* When the bubble or the bubble stack is dragged close to the dismiss target area, it gets pulled towards it and sticks to it. The `MagnetizedObject` and `MagneticTarget` classes are used for it.
* When the dragged view is released outside of the dismiss area, it moves back to the initial position with animation.
* When the dragged bubble is released inside of the dismiss area, it will dismiss the bubble with animation and remove it from the stack.
* When the dragged bubble bar stack is released inside the dismiss area, all the bubbles will get dismissed and the bubble bar will dissapear.

Bug: 271466616
Test: manual, TBD
Flag: WM_BUBBLE_BAR
Change-Id: I83393898be61ec522db92688ac2e111ef7d72fe6
2023-07-28 18:17:09 +00:00
Andy Wickham
be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Schneider Victor-tulias
d33fc05022 Merge "Fix broken gesture nav edu on tablets in portrait." into udc-qpr-dev 2023-07-25 17:01:37 +00:00
Greg Kaiser
f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Andy Wickham
f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Vinit Nayak
306c6e843f Merge "Change split toast exit asset to "X"" into udc-qpr-dev 2023-07-20 22:58:17 +00:00
Schneider Victor-tulias
41f7e169c3 Fix broken gesture nav edu on tablets in portrait.
Launching the gesture nav tutorial in portrait mode on tablets causes fragments with the wrong layout file to be inflated (uses the default phone layout).

Reinflating fragments whenever they need to be switched. Added a new rotation prompt fragment

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 291062054
Test: Launched the tutorial in portrait mode and landscape mode, then rotated the screen several times. tried with the flag disabled as well.
Change-Id: I0215d7589285007d04ef81d3a63e404c2cda3895
2023-07-20 15:28:49 -07:00
helencheuk
27f23c7a35 Re-land "Add hover state border to overview task item"
Fix: 249859410
Test: b/291266459
Change-Id: I5ac1e9e77439e587f11c994d22fdc72d20d8502d
2023-07-20 18:35:22 +01:00
Vinit Nayak
78207fd80b Change split toast exit asset to "X"
* TODO: Probably need to change tint based on theme

Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Shows up as expected
Change-Id: I28a2eefa115cb15aab560d750103c7946639c18b
2023-07-17 20:19:16 -07:00
Vinit Nayak
5f09091583 Show split select instructions toast when starting split on workspace
* Used same animation properties that RecentsView uses to
show the instructions view unfolding
* TODOs:
  * UI polish (correct asset, animation timings, etc)
  * Hook into existing animations (if possible)
  * Migrate recentsView splitInstructionsView to use same/similar code path;
    remove RecentsView#safeRemoveDragLayerView

Bug: 276361926
Test: Create split w/ and w/o flag, works as expected
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I7a51b71c358902399ad73b650287cdbf1dad07c6
2023-07-14 17:49:42 -07:00
Liran Binyamin
c06c7ff6fa Update the bubble bar offset on Home
This is an initial change that positions the bubble bar aligning it
with the center of the hotseat icons. We still need to center it
with the taskbar when in overview.

This change also fixes the touch issues where sometimes the hotseat
icons don't respond to taps. The fix is twofold:

1. Make sure that taskbar insets are always updated when
   BubbleStashController#setBubblesShowingOnHome is called.
2. Update the touchable region in TaskbarInsetsController to account
   for the Y translation of the bubble bar bounds when the bubble
   bar is visible.

Demo: https://screenshot.googleplex.com/6NRyu2CR7Bjs32x

Bug: 286247080
Test: Manual on a physical device
Change-Id: I00daff8341e4d8f5d141b5e0220726f6c03b437c
2023-07-05 17:29:52 -04:00
Schneider Victor-tulias
ae62216f15 Inset the contents of AllSetActivity
Insetting the contents of AllSetActivity to prevent overlapping with the gesture nav handle

Flag: not needed
Fixes: 275018092
Test: launched AllSetActivity in landscape with largest font and display size
Change-Id: Ia82a007e8a69c637a30c56e079d9c77d73885d9f
2023-06-28 10:02:05 -07:00
Schneider Victor-tulias
3b9c654669 Merge "Polish redesgined tutorial home and overview animations" into udc-qpr-dev 2023-06-13 13:47:21 +00:00
Saumya Prakash
07ed097042 Merge "Scale the gesture tutorial animation to work on smaller devices" into udc-dev am: cb5e2cfd3e am: 83301267f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23632910

Change-Id: I1f12a7dddfa9fd9efbd762fad142e87a2e5842e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:49:43 +00:00
Schneider Victor-tulias
1c2c5a58a2 Polish redesgined tutorial home and overview animations
- Added a 6th hotseat icon to the tablet and unfolded foldable
- not animating the previous task view when animating to hotseat from the home step
- updating the first hotseat icon's color and visibility at the correct times
- cross fading the animating task view and hotseat icon's color

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 283967613
Test: ran the tutorial on handheld, tablet and foldable with ENABLE_NEW_GESTURE_NAV_TUTORIAL true and false
Change-Id: I7a76646ca71502e924f45bba76d72be17d31249d
2023-06-12 21:03:30 +00:00
Saumya Prakash
08a2708739 Scale the gesture tutorial animation to work on smaller devices
The lottie animations in the gesture navigation tutorial would get cut
off due to having to crop them to smaller devices. This change uses a
matrix to correctly scale the animation such that the aspect ratio is
maintained.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 283969417
Test: Went through the tutorial on devices of different sizes and aspect
ratios and ensured that the lottie animation isn't cut off.

Change-Id: I4b4cc9e11a68daef29fa31d6a89a1c9006041937
2023-06-12 17:55:00 +00:00
Saumya Prakash
7a69792b26 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev am: 372de4f521 am: 4522e5d2ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23493333

Change-Id: I0efd0da5bea9f4490b2688aaf295a320947eceea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-11 23:56:40 +00:00
Saumya Prakash
372de4f521 Merge "Enforce the correct orientation for the gesture navigation tutorial" into udc-dev 2023-06-11 22:24:13 +00:00
Saumya Prakash
e2711c254a Enforce the correct orientation for the gesture navigation tutorial
The lottie animations used for the gesture navigation tutorial are
designed for specific orientations depending on the device. This change
ensures that users are in the correct orientation for their device. For large screen users in portrait mode, we display a prompt to rotate the screen.

Flag: ENABLE_NEW_GESTURE_TUTORIAL
Fix: 277781713
Bug: 276515961
Test: Manually went through the tutorial starting from both
orientations on handheld, foldable, and tablet to ensure that the prompt
was shown and hidden correctly. Also ensured that gestures cannot be
completed in the background while the prompt is being shown.

Change-Id: I86ae566721f240264177ad4ec7fc12e58d1b95cd
2023-06-09 21:41:07 +00:00
Schneider Victor-tulias
1c7f97916e Merge "Fix layout issues in suw all set page" into udc-dev am: 8ee4ad6604 am: 32a14e59bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23502666

Change-Id: I0896653b0faaf647c850be3a8af9bb34b80ddb5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 19:50:37 +00:00
Schneider Victor-tulias
b5c7086323 Fix layout issues in suw all set page
putting contents of the suw all set page in a scroll view to fix layout issues in large display/font sizes

Flag: not needed
Fixes: 275018092
Test: launched all set page on smallest and largest display/font sizes on handheld, tablet and foldable
Change-Id: I921b1becfc0627e9b77e467efe309613aa3ca9d0
2023-06-06 09:42:36 -07:00
Brian Isganitis
7a5809e47b Add initial support for search session in Taskbar All Apps.
A search session is represented as a stub ResourceBasedOverride that can
be extended for controlling a search session.

Test: Manual (including aosp Quickstep)
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9cf4b5f84feec5215840d456b601c6a9f7c4c211
2023-06-02 15:55:46 +00:00
Schneider Victor-tulias
2f3ad0bc36 Merge "Update gesture nav edu motion and colors" into udc-dev am: b4e91b14bd am: 2256dfcec1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23389667

Change-Id: Ibd7edffcc8e3492497ca06008f4ce5e8bc94c183
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26 19:57:55 +00:00
Schneider Victor-tulias
b4e91b14bd Merge "Update gesture nav edu motion and colors" into udc-dev 2023-05-26 16:12:06 +00:00
Ikram Gabiyev
5b914fb5ce Merge "Remove contentDescription attribute in filter icon" into udc-dev am: 749a2d2a6a am: 786046540d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23418186

Change-Id: Ica90e655735160e315e915dbf6b10b3b00c46173
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-25 20:34:57 +00:00
Ikram Gabiyev
45b33a1a55 Remove contentDescription attribute in filter icon
Remove contentDescription attribute for multi-instance
filter icon ImageView since importantForAccessibility="no"
to avoid talkback noting it instead of the task name itself.

Bug: 280908761
Test: manually reproduce the steps in the bug
Change-Id: Ifdc884537222565fc2e52d5a17272f19a4446f62
2023-05-24 14:01:04 -07:00
Schneider Victor-tulias
9a7de100f4 Update gesture nav edu motion and colors
- Updated gesture nav edu overview step post-success motion and colors
- Updated gesture nav edu menu done button color and legacy action button color
- Switching light/dark mode when a step is complete started the demonstration animation. fixed this jank

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281764891
Fixes: 283964958
Bug: 279823249
Test: ran full tutorial with ENABLE_NEW_GESTURE_NAV_TUTORIAL enabled and disabled
Change-Id: I9adc05947267ec038b6f374b2a29a5499468883b
2023-05-24 18:36:39 +00:00
Schneider Victor-tulias
28821554ac Merge "Fix redesigned gesture nav jank" into udc-dev am: bd0188abd1 am: 3a32a4d20b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23267694

Change-Id: I19b409a952d0e88f19846ed87951921fa50c117a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:23:56 +00:00
Schneider Victor-tulias
bd0188abd1 Merge "Fix redesigned gesture nav jank" into udc-dev 2023-05-22 19:01:35 +00:00
Randy Pfohl
faf1abbe96 Merge "Updating overview colors to utilize new tokens" into udc-dev am: f6b74f1521 am: 075191743a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23269307

Change-Id: Id046be9b8792b092a58b448dbda898fd961bbf54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:38:06 +00:00
Saumya Prakash
ae2aab9217 Merge changes If2c82082,I03532b80 into udc-dev am: 66e7ec721b am: 1b12262d07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23159151

Change-Id: I31b599f7b1e3cd4a3ed6dc659ba9b3f5b258334b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 23:13:58 +00:00
Randy Pfohl
f6b74f1521 Merge "Updating overview colors to utilize new tokens" into udc-dev 2023-05-18 22:43:30 +00:00
Schneider Victor-tulias
9caa0f9559 Fix redesigned gesture nav jank
- Removed the fake animated taskbar view from the redesigned tutorial flow
- Fixed the hotseat and home icon colors from the overview step

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Fixes: 281121701
Fixes: 283310758
Test: swiped up from home/overview step
Change-Id: Ie659495994f0c935c5b6c6bf1ae534ec51521726
2023-05-18 14:36:28 -07:00
randypfohl
b8e47fe329 Updating overview colors to utilize new tokens
Test: built locally and verified colors
Flag: none
bug:275709319
Change-Id: I1abcf608e0279a70e975190ea66128563f996f3e
2023-05-18 11:15:07 -07:00
Schneider Victor-tulias
474f3c4e90 Update gesture tutorial colors
- Updated all redesigned gesture nav menu and tutorial colors to dynamic color spec

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 281764891
Bug: 279823249
Test: launched tutorial menu and tutorial steps
Change-Id: I03532b80c6e14867c1374bbdf9f984c1cece9809
2023-05-18 10:47:33 -07:00
Ats Jenk
9f11519936 Show a persistent toast when selecting desktop apps on home screen
When desktop stashed state changes, show a persistent popup on home
screen to select an app that will be launched on desktop.

Flag: persist.wm.debug.desktop_mode_2
Bug: 261234402
Test: launch an app on desktop, swipe home, observe the popup, launch an
  app, observe app is launched on desktop and popup is hidden
Test: stash desktop apps by going home while on desktop, press on the
  "exit desktop" button in the popup, observe popup is hidden, launch an
  app, observe it is launched in fullscreen

Change-Id: I66fe0ab977fa7b2059f149d7d0ab0cf92192c967
2023-05-18 09:31:27 -07:00
TreeHugger Robot
b9f04842b5 Merge "Add a no recent tasks message to the keyboard quick switch view" into udc-dev 2023-05-16 06:49:52 +00:00
Schneider Victor-tulias
b29355c192 Add a no recent tasks message to the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 280652620
Test: launched the keyboard quick switch with 0, <=6 and >6 tasks launched
Change-Id: I560707645b83b79ba2203460e62e4c540f5da421
2023-05-15 16:49:45 -07:00
Schneider Victor-tulias
b6407699ae Update keyboard quick switch view ordering and add icons
- Updated the keyboard quick switch view ordering to left-to-right (vice versa in RTL)
- Added app icons to keyboard quick switch taskviews

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Fixes: 275629107
Test: launched keyboard quick switch view and changed focus back and forth
Change-Id: Ie2f0a1c08c7065c53075f6fa015000a2d6184491
2023-05-15 12:06:19 -07:00
Schneider Victor-tulias
458971616d Merge "Fix tutorial menu layout issues" into udc-dev 2023-05-09 20:18:07 +00:00
Schneider Victor-tulias
c50f870625 Fix tutorial menu layout issues
- Fixed back button image padding (and updated all other images to prevent hidden padding)
- fixed done button size
- padding top and bottom insets for status bar and nav bar

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fixes: 281121442
Fixes: 281121138
Test: launched the tutorial menu on handheld, foldable and tablet, compared before/after pictures
Change-Id: I61bce2fc4a8d3824048229e0d48f9a429c80a204
2023-05-08 15:43:39 -07:00
Mady Mellor
c37bf46381 Adds BubbleControllers to TaskbarControllers
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
Brian Isganitis
58f079b134 Better handle large display and text scaling on EDU tooltip.
For large scaling configurations, the tooltip height can exceed the
available space, which can truncate important content such as the "Done"
button. To mitigate this issue, we should attempt to increase the width
of the tooltip to hopefully free up some height due to the text taking
up fewer lines.

To support dynamic width, each EDU column gets an equal weight in the
ConstraintLayout, but the lottie animations are still constrained to
their original dimensions. If they fill the width, their aspect ratio
will be maintained and we will still have height issues.

Demo: https://screenshot.googleplex.com/6jV6geJFzCYtQ6v.png

Test: Manual (transient and persistent)
Fix: 278761297
Change-Id: I8cc0c4260caef747378954225d8635b2fb8eef52
2023-05-03 18:46:47 +00:00
Saumya Prakash
773c5c1760 Merge "Update the mock hotseat for the Gesture Navigation tutorial" into udc-dev 2023-04-25 20:14:32 +00:00
Saumya Prakash
2f3d412b24 Update the mock hotseat for the Gesture Navigation tutorial
The redesigned gesture navigation tutorial was using older files for the
mock hotseat when swiping up to home. This adds in the correct files to
align with the design and be consistent with the mobile version of the
tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 278790706
Test: Went through the gesture tutorial on small screen and large screen devices.
Change-Id: Ib3cffd1b8b62220ff0b1458e32b3825396cdb6a0
2023-04-21 22:31:03 +00:00
Jagrut Desai
64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00