Commit Graph

13799 Commits

Author SHA1 Message Date
Jagrut Desai
f26460f852 Merge "Support launching minimized task into desktop" into main 2025-03-04 12:51:18 -08:00
Brian Isganitis
14a7b56b5e Merge changes I34983821,I175e4282 into main
* changes:
  Initial overflow compatibility with layout transition.
  Migrate layout transition flag to DesktopModeFlag version.
2025-03-04 12:06:18 -08:00
Brian Isganitis
75d443ffdb Initial overflow compatibility with layout transition.
Also implements RTL support for overflow.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I34983821a2a1a80793dc6d811d42cfeafe274ef4
2025-03-04 12:05:58 -08:00
Mykola Podolian
7781be068a Merge "Taskbar app icon drag interruption fix." into main 2025-03-04 11:57:24 -08:00
Treehugger Robot
13669ecb2a Merge "Add Two stages related flags to bug report's flag dump logs." into main 2025-03-04 11:15:27 -08:00
Saumya Prakash
f979f6518b Merge "Remove the step indicator for the gesture tutorial" into main 2025-03-04 09:32:41 -08:00
Randy Pfohl
4743e508e9 Merge "Enabling secondary deviceprofile creation in windowcontext" into main 2025-03-04 09:17:16 -08:00
Sunny Goyal
372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Brian Isganitis
42c58e39fd Migrate layout transition flag to DesktopModeFlag version.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I175e428240bc52689efe0f6e4457620ac2efdbb5
2025-03-04 11:30:23 -05:00
Treehugger Robot
cfa59a3c26 Merge "Refactor OverviewComponentObserver for connected displays" into main 2025-03-04 07:22:38 -08:00
Will Osborn
2a19d636d7 Refactor OverviewComponentObserver for connected displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: Icb619f59ef3acd9781eee1bf1f7cfd056a26c55f
2025-03-04 12:51:04 +00:00
Alex Chau
12d5e6aed8 Merge "Update gridTranslation of live tile when gestures ends" into main 2025-03-04 02:42:13 -08:00
Jon Miranda
f792db712a Merge "Add enable_taskbar_behind_shade to DesktopModeFlags." into main 2025-03-03 18:14:25 -08:00
mpodolian
a977d6b4ef Taskbar app icon drag interruption fix.
When there are no bubbles and the taskbar is not present on the screen,
the bubble bar drop target needs to be shown for the dragged taskbar
icon. To show the drop target, the view is added to the bubble bar's
parent layout. When the drop target should be hidden, the view is
removed.

The issue was caused by an incorrect parent container being passed to
the BubbleBarPinController. Instead of the bubble bar container, the
entire drag layer was used. Removing the view from the drag layer
interrupted the drag gesture.

Adding/removing the drop target view directly to the bubble bar
container does not affect the drag.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Be on the overview screen with no bubbles present. Drag
the taskbar over the bubble drop zone and then back. Observe that the
drag is not interrupted.

Change-Id: I116883117b3da39528a4586a2436a10838625600
2025-03-03 18:14:05 -08:00
Wen-chien Wang
8444f38c92 Merge "pin-shortcut: Tracks hotseat states and adds unpin option for taskbar" into main 2025-03-03 16:50:48 -08:00
Treehugger Robot
51a3a87b14 Merge "Arrows to scroll recent tasks in KQS" into main 2025-03-03 16:44:25 -08:00
Brian Isganitis
06d2e58105 Merge "Exclude All Apps divider in desktop mode." into main 2025-03-03 15:58:41 -08:00
Uwais Ashraf
994bc6dfcf Merge "Use Recents CoroutineScope with cancellable Jobs per TaskView." into main 2025-03-03 15:37:36 -08:00
Treehugger Robot
85ec44bcf9 Merge "Revert "Add debug logs to AbsSwipeUpHandler.calculateEndTarget"" into main 2025-03-03 15:14:01 -08:00
Saumya Prakash
6a32cf392b Remove the step indicator for the gesture tutorial
This change removes the pill indicator for the legacy gesture navigation
tutorial. It causes accessibility issues and is not needed for the current version
of the gesture tutorial.

Fix: 378415116
Bug: 400485351
Test: Run tutorial and observe no more indicator for the steps
Flag: EXEMPT bugfix
Change-Id: I33c3d7131752c2118ef03bf7d76389e855b836f4
2025-03-03 23:10:29 +00:00
Jagrut Desai
b46953da5b Support launching minimized task into desktop
Test: Manual, Presubmit
Bug: 396615095
Flag: EXEMPT bugfix
Change-Id: I6489257df18aca2e696434aafee2c1d910b627da
2025-03-03 14:44:06 -08:00
Anushree Ganjam
17c6f2c4a1 Add Two stages related flags to bug report's flag dump logs.
Bug: 400141268
Test: Manual
Flag: EXEMPT legacy DeviceConfig ENABLE_LPNH_TWO_STAGES ENABLED
Change-Id: I264aef5256096df2ab5860d7d78fb890656bf7f0
2025-03-03 14:41:17 -08:00
Treehugger Robot
5fcd02dff6 Merge "Fix NPE from navbar touch cancel without down." into main 2025-03-03 13:05:39 -08:00
Jagrut Desai
47b0246c26 Merge "Fix SystemNav and Taskbar related Memory Leaks" into main 2025-03-03 12:24:47 -08:00
Schneider Victor-tulias
55c543622c Revert "Add debug logs to AbsSwipeUpHandler.calculateEndTarget"
This reverts commit f9c1e29766.

Reason for revert: debug logs no longer needed. issue found

Change-Id: I633d5d6a7386349f19b64ed12aecbc163b5c1c21
2025-03-03 11:46:57 -08:00
Brian Isganitis
8127148e02 Exclude All Apps divider in desktop mode.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 315354060
Test: go/testedequals
Change-Id: Ic9cf42ad9a81357fe7452ed576663bedb54fbcf7
2025-03-03 14:42:16 -05:00
Mykola Podolian
c095f8b318 Merge "Added accessibility action to move taskbar icon to the bubble bar" into main 2025-03-03 10:31:03 -08:00
Sunny Goyal
5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Treehugger Robot
34d1359072 Merge "Disallow scroll to the AddDesktopButton" into main 2025-03-03 09:55:16 -08:00
Jon Miranda
04e9972f05 Add enable_taskbar_behind_shade to DesktopModeFlags.
Bug: 343194358
Test: n/a no code, just adding flag
Flag: com.android.launcher3.enable_taskbar_behind_shade
Change-Id: Ide8574580afbfd1c1038c34d4b5699a0681fa239
2025-03-03 09:47:02 -08:00
Uwais Ashraf
7a797477ea Use Recents CoroutineScope with cancellable Jobs per TaskView.
This saves time on first usage which can happen during a CUJ on main.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Perfetto trace comparison
Change-Id: I496a00e3002f29830adbd8bb10857e78b16c68c8
2025-03-03 17:39:54 +00:00
Jagrut Desai
39dd498074 Fix SystemNav and Taskbar related Memory Leaks
Test: Presubmit
Bug: 398908322
Bug: 399884290
Flag: EXEMPT bugfix
Change-Id: Idf1ed3ff154e64de523b477aa34b67cbcd3cf8b4
2025-03-03 09:29:39 -08:00
Treehugger Robot
12934bc891 Merge "Skip TaskView settledProgress and fullscreenProgress updates for same progress value" into main 2025-03-03 08:52:00 -08:00
minch
5cb890579e Disallow scroll to the AddDesktopButton
Bug: 389209338
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: Ib9e5bc3ff73aed9facd1bad17d34722bd7a24652
2025-03-03 15:37:11 +00:00
Jordan Silva
266de900d5 Skip TaskView settledProgress and fullscreenProgress updates for same progress value
This prevents calling settledProgress with the same value multiple times during the onFullscreenProgress animation. It was causing a performance issue when the icon visibility was switching between VISIBILE and INVISIBLE each frame of the animation. More information in the comments of b/398318613.

Bug: 398318613
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Test: systemui-thermal-throttling-3-suite
Change-Id: Ib24bfd7541bb177d7141718fa36d2349f7ec9d46
2025-03-03 12:07:47 +00:00
Alex Chau
8619197e6a Merge "desktop-exploded-view: Calculate an accurate crop rect for desktop tasks" into main 2025-03-03 02:12:35 -08:00
Treehugger Robot
6e8347912c Merge changes I6846a3dd,I45356fd7 into main
* changes:
  Update ActiveGestureLogs to print gestures' display IDs
  Update TIS to use one input monitor per display
2025-03-02 18:07:04 -08:00
Schneider Victor-Tulias
841c6a98d2 Update ActiveGestureLogs to print gestures' display IDs
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: connected an external display and checked logs
Change-Id: I6846a3dda77fc4afbbd83855aacca726eeb8eace
2025-03-02 16:03:32 -08:00
Schneider Victor-Tulias
21dba415e9 Update TIS to use one input monitor per display
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Bug: 398881237
Test: connected an external display and attempted touch gestures. checked logs to ensure motion events are separated by display id
Change-Id: I45356fd7f1926685093833990d39c85a4a074c58
2025-03-02 16:03:08 -08:00
Treehugger Robot
eb808032f1 Merge "Propagate the display id with SysUIState changes to launcher" into main 2025-02-28 22:14:13 -08:00
Mykola Podolian
b0fe82378a Merge changes from topic "bubblebar_drop_target" into main
* changes:
  Removed fly-back animation after a taskbar item drop on the bubble bar
  Added BubbleBarLocation drop target.
2025-02-28 18:02:48 -08:00
Treehugger Robot
55dd78123c Merge "Taskbar on home should open all apps that support drag to workspace" into main 2025-02-28 17:04:20 -08:00
Toni Barzic
26ad16592a Taskbar on home should open all apps that support drag to workspace
If taskbar is shown on home screen, have the taskbar all apps button
toggle the launcher activity version of all apps UI. This makes the
behavior consistent with how all apps system action (keyboard shortcut)
works, and addresses a gap in functionality where users are unable to
drag apps from the taskbar all apps UI to the workspace.

Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: On desktop device, toggle all apps from taskbar on home screen,
      drag and app from all apps to workspace.
Change-Id: Ida0f230bf38c6e1e35041556f33de1be85daf785
2025-02-28 21:31:46 +00:00
Toni Barzic
8ca3eaa345 Arrows to scroll recent tasks in KQS
Bug: 397878339
Bug: 397975686
Flag: com.android.launcher3.taskbar_overflow
Test: Enter taskbar overflow, and open the overflow view.
    Verify that arrow buttons are present; tapping them scrolls in the
    correct direction; when fully scrolled in a direction, the
    associated arrow button is disabled; verify arrow buttons have hover
    effects.
    Open Alt+Tab view, verify no buttons are present if the view cannot
    be scrolled (and present if the view can be scrolled).

Change-Id: Id1c37a2967a629aeb4b3cc2dc5ff7efb21c90cbe
2025-02-28 19:49:50 +00:00
Daniel Andersson
7250db2fee desktop-exploded-view: Calculate an accurate crop rect for desktop tasks
This change fixes crop rects on desktop tasks when exploded view is
enabled. The crop rect calculation now takes the current task rect
transform into account (which is used to position windows when exploded
view is enabled).

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392
Change-Id: I2b296a5065a5bc74c8ba884f2329081546b40ad0
2025-02-28 11:17:38 -08:00
Alex Chau
59e8c59ec6 Update gridTranslation of live tile when gestures ends
- Instead of updating in updateGridProperties, which will be re-run after dismiss and potentially apply wrong translations to live tile.
- Also set gridTranslationX of live tile to 0, as recentsScroll already takes care of horizontally task offest
- Guaded assigning RemoteTargetHandle to DesktopTaskView with enableDrawingLiveTile, so going to Home won't continue to mananages the TaskViewSimulator

Fix: 398231631
Fix: 394316748
Test: App to Overview with live tile on different location in the grid
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I2e0f83a55421279581f3632c16c1e4c41d1fdae6
2025-02-28 18:48:40 +00:00
Randy Pfohl
42405b2fa3 Enabling secondary deviceprofile creation in windowcontext
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window
      com.android.launcher3.enable_launcher_overview_in_window

Change-Id: Iafb75840c4acadb35eb9e89810e9de61bbeda326
2025-02-28 18:14:02 +00:00
mpodolian
672a32a18b Removed fly-back animation after a taskbar item drop on the bubble bar
Added logic to track whether the drop target handled the app icon drop,
in order to prevent the fly-back animation in those cases.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Drop a taskbar icon onto the bubble bar. Observe that no
fly-back animation is performed for the dropped icon.

Change-Id: If439d7280fe9f713c181531ac899ac8ad37ed481
2025-02-28 10:01:13 -08:00
Orhan Uysal
a7cd4f21d3 Merge "Change the misused logic" into main 2025-02-28 09:37:20 -08:00
Orhan Uysal
5e99882d75 Change the misused logic
Refactor from ag/31915496 was wrong. We should skip the transparent
activity tiles when there is a visible task already found not when
visible tasks are not found.

Bug: 397190111
Test: Enter any app, trigger circle to search, see only one tile
produced.
Flag: EXEMPT Bug fix

Change-Id: Ic19710a7d1f5be78e96aa5ac25553358732acf3b
2025-02-28 15:42:37 +00:00